test(startup): isolate logger caller validation (#37)

- Issue #37: compare the Windows renderer startup path with the logging read command's caller extraction removed.\n- Keep the renderer logger IPC call and native startup otherwise unchanged.

scripts/smoke-packaged-app.js

@@ -23,21 +23,16 @@ const stabilityMsValue = Number.parseInt(argValue('--stability-ms') || '5000', 1
 const stabilityMs = Number.isFinite(stabilityMsValue) && stabilityMsValue >= 0
   ? Math.min(stabilityMsValue, MAX_STABILITY_MS)
   : 5000;
-const childEnv = {
-  ...process.env,
-  FIRELINK_SMOKE_TEST: '1',
-  FIRELINK_DISABLE_ARIA2_POLLER: '1',
-  WEBKIT_DISABLE_COMPOSITING_MODE: '1',
-  GDK_BACKEND: 'x11',
-};
-if (process.argv.includes('--disable-aria2-poller')) {
-  childEnv.FIRELINK_DISABLE_ARIA2_POLLER = '1';
-}
 const READY_PORT_TIMEOUT_MS = 500;
 const child = spawn(executable, [], {
   cwd: process.env.RUNNER_TEMP || process.env.TMPDIR || process.cwd(),
   detached: process.platform !== 'win32',
-  env: childEnv,
+  env: {
+    ...process.env,
+    FIRELINK_SMOKE_TEST: '1',
+    WEBKIT_DISABLE_COMPOSITING_MODE: '1',
+    GDK_BACKEND: 'x11',
+  },
   stdio: ['ignore', 'pipe', 'pipe'],
 });
 

src-tauri/src/lib.rs

@@ -18200,9 +18200,8 @@ fn toggle_log_pause(caller: tauri::WebviewWindow, pause: bool) -> Result<(), Str
 }
 
 #[tauri::command]
-fn is_log_paused(caller: tauri::WebviewWindow) -> bool {
-    properties_window::ensure_main_window(&caller).is_ok()
-        && LOG_PAUSED.load(std::sync::atomic::Ordering::Relaxed)
+fn is_log_paused() -> bool {
+    LOG_PAUSED.load(std::sync::atomic::Ordering::Relaxed)
 }
 
 #[tauri::command]
@@ -19007,9 +19006,6 @@ pub fn run() {
             let poll_secret = aria2_secret.clone();
             let poll_mgr = Arc::clone(&queue_manager_poll);
             tauri::async_runtime::spawn(async move {
-                if std::env::var_os("FIRELINK_DISABLE_ARIA2_POLLER").is_some() {
-                    return;
-                }
                 let mut interval = tokio::time::interval(std::time::Duration::from_millis(1000));
                 let mut observations: HashMap<String, Aria2ConnectionObservation> = HashMap::new();
                 let mut missing_gid_recovery_at: HashMap<String, Instant> = HashMap::new();

src/main.tsx

@@ -1,128 +1,8 @@
-import { StrictMode, type ComponentType } from "react";
-import { createRoot } from "react-dom/client";
-import "@fontsource-variable/inter/wght.css";
-import "@fontsource-variable/noto-sans-hebrew/wght.css";
-import "@fontsource-variable/noto-sans-sc/wght.css";
-import "@fontsource-variable/outfit/wght.css";
-import "@fontsource-variable/roboto/wght.css";
-import "@fontsource-variable/vazirmatn/wght.css";
-import "./index.css";
-import { i18nReady } from "./i18n";
-import { ErrorBoundary } from "./components/ErrorBoundary";
-import { ToastProvider } from "./contexts/ToastContext";
-import { error as logError, warn as logWarn, initLogger } from "./utils/logger";
-import { getCurrentWindow } from '@tauri-apps/api/window';
-import { invokeCommand as invoke } from './ipc';
-
-const isPropertiesWindow = getCurrentWindow().label.startsWith('properties-');
+import { initLogger } from "./utils/logger";
 
 void initLogger();
 
-const serializeConsoleArguments = (values: unknown[]) => values.map(value => {
-  if (value instanceof Error) return `${value.name}: ${value.message}\n${value.stack || ''}`;
-  if (typeof value === 'string') return value;
-  try {
-    return JSON.stringify(value);
-  } catch {
-    return String(value);
-  }
-}).join(' ');
-
-const redactConsoleMessage = (message: string) => message
-  .replace(/(authorization|cookie|password|token|secret)\s*[:=]\s*([^\s,;]+)/gi, '$1=[redacted]')
-  .replace(/(https?:\/\/[^\s?]+)\?[^\s]+/g, '$1?[redacted]');
-
-const originalConsoleError = console.error.bind(console);
-const originalConsoleWarn = console.warn.bind(console);
-console.error = (...values: unknown[]) => {
-  originalConsoleError(...values);
-  void logError(redactConsoleMessage(serializeConsoleArguments(values))).catch(() => undefined);
-};
-console.warn = (...values: unknown[]) => {
-  originalConsoleWarn(...values);
-  void logWarn(redactConsoleMessage(serializeConsoleArguments(values))).catch(() => undefined);
-};
-
 const rootElement = document.getElementById("root");
-const renderRoot = (RootComponent: ComponentType) => {
-  if (!rootElement) return;
-
-  createRoot(rootElement).render(
-    <StrictMode>
-      <ErrorBoundary>
-        <ToastProvider>
-          <RootComponent />
-        </ToastProvider>
-      </ErrorBoundary>
-    </StrictMode>,
-  );
-};
-
-const PropertiesStartupFailure = () => (
-  <main className="properties-window-shell flex h-screen min-h-0 flex-col items-center justify-center gap-4 bg-main-bg p-6 text-text-primary">
-    <p role="alert">Download Properties could not be loaded.</p>
-    <button
-      type="button"
-      className="app-button app-button-primary px-3 text-xs"
-      onClick={() => {
-        void getCurrentWindow().close().catch(error => {
-          console.error('[PropertiesStartupFailure] close failed', error);
-        });
-      }}
-    >
-      Close
-    </button>
-  </main>
-);
-
-const renderMainApp = async () => {
-  if (!rootElement) return;
-
-  // Keep the child entrypoint isolated from the main application module. App
-  // imports the persistent Zustand stores, whose module initialization issues
-  // main-window-only IPC commands. Loading it in a Properties child creates a
-  // second persistence owner and can race the bridge handshake.
-  const RootComponent = (await import('./App')).default;
-  renderRoot(RootComponent);
-};
-
-const renderPropertiesApp = async () => {
-  if (!rootElement) return;
-
-  try {
-    // Properties starts with the synchronous English catalog and changes locale
-    // after its first paint. Waiting for a lazy locale chunk here delays the
-    // loading shell and makes native window startup visible to the user.
-    const RootComponent = (await import('./components/PropertiesWindowApp')).PropertiesWindowApp;
-    renderRoot(RootComponent);
-  } catch (error) {
-    // A failed lazy chunk must not leave the native window hidden forever. Show
-    // a styled, closable failure state and use the same caller-validated native
-    // reveal command as the normal child path.
-    console.error('Failed to initialize the Properties window:', error);
-    renderRoot(PropertiesStartupFailure);
-    const fallbackSessionId = crypto.randomUUID();
-    void invoke('properties_window_send_ready', { sessionId: fallbackSessionId })
-      .then(() => invoke('properties_window_reveal', { sessionId: fallbackSessionId }))
-      .catch(revealError => {
-        console.error('Failed to reveal the Properties startup error:', revealError);
-      });
-  }
-};
-
-if (isPropertiesWindow) {
-  void renderPropertiesApp();
-} else {
-  void i18nReady.then(renderMainApp).catch(error => {
-    console.error('Failed to initialize localization:', error);
-    void renderMainApp();
-  });
+if (rootElement) {
+  rootElement.textContent = "Firelink startup control";
 }
-
-// Prevent the webview's default context menu ("Reload", etc.) on right-click.
-// Individual components that provide custom context menus call preventDefault()
-// in their own onContextMenu handlers, which fires before this document-level
-// listener and is unaffected.
-document.addEventListener('contextmenu', (e) => {
-  e.preventDefault();
-});