gsadmin/Firelink
1
0
Fork 0
mirror of https://github.com/nimbold/Firelink.git synced 2026-08-16 14:28:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(release): allow non-publishing branch audits

Browse Source
This commit is contained in:
NimBold
2026-08-09 05:10:25 +03:30
parent 807e16a1fe
commit 6a9b2bc099
3 changed files with 31 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files
.github/workflows/release.yml
+5 -1
View File
@@ -45,8 +45,12 @@ jobs:
with:
node-version: 22
cache: npm
- name: Verify release version
- name: Verify tagged release version
if: github.event_name == 'push' || inputs.publish_release
run: node scripts/verify-release-version.js
- name: Verify non-publishing package version
if: github.event_name == 'workflow_dispatch' && !inputs.publish_release
run: node scripts/verify-release-version.js --allow-untagged
- name: Verify Companion release identity
run: node scripts/verify-companion-release.js
- uses: dtolnay/rust-toolchain@stable
scripts/verify-release-version.js
+18 -13
View File
@@ -42,23 +42,11 @@ function versionFromRef(ref) {
return version;
}
const tag = argValue('--tag') || process.env.GITHUB_REF_NAME;
const expected = versionFromRef(tag);
const versions = {
'package.json': readPackageVersion(repositoryRoot),
'src-tauri/Cargo.toml': readCargoVersion(repositoryRoot),
'src-tauri/tauri.conf.json': readTauriVersion(repositoryRoot),
};
const mismatches = Object.entries(versions)
.filter(([, version]) => version !== expected)
.map(([file, version]) => `${file}=${version}`);
if (mismatches.length > 0) {
console.error(`Release tag ${tag} does not match the application manifests (expected ${expected}).`);
for (const mismatch of mismatches) console.error(` ${mismatch}`);
process.exit(1);
}
const uniqueVersions = new Set(Object.values(versions));
if (uniqueVersions.size !== 1) {
console.error('Application version manifests do not agree:');
@@ -66,4 +54,21 @@ if (uniqueVersions.size !== 1) {
process.exit(1);
}
console.log(`Release version ${expected} matches ${Object.keys(versions).length} manifests.`);
const allowUntagged = process.argv.includes('--allow-untagged');
const tag = argValue('--tag') || process.env.GITHUB_REF_NAME;
const expected = allowUntagged ? Object.values(versions)[0] : versionFromRef(tag);
const mismatches = Object.entries(versions)
.filter(([, version]) => version !== expected)
.map(([file, version]) => `${file}=${version}`);
if (!allowUntagged && mismatches.length > 0) {
console.error(`Release tag ${tag} does not match the application manifests (expected ${expected}).`);
for (const mismatch of mismatches) console.error(` ${mismatch}`);
process.exit(1);
}
console.log(
allowUntagged
? `Non-publishing package version ${expected} matches ${Object.keys(versions).length} manifests.`
: `Release version ${expected} matches ${Object.keys(versions).length} manifests.`
);
scripts/verify-release-version.node-test.js
+8 -2
View File
@@ -11,8 +11,8 @@ const currentVersion = JSON.parse(
fs.readFileSync(path.join(repositoryRoot, 'package.json'), 'utf8')
).version;
function runVerifier(tag) {
return spawnSync(process.execPath, [verifier, '--tag', tag], {
function runVerifier(tag, ...extraArguments) {
return spawnSync(process.execPath, [verifier, '--tag', tag, ...extraArguments], {
cwd: repositoryRoot,
encoding: 'utf8',
});
@@ -35,3 +35,9 @@ test('release version verifier rejects non-semver tag names', () => {
assert.equal(result.status, 1);
assert.match(result.stderr, /semantic version tag/);
});
test('release version verifier accepts an untagged non-publishing package audit', () => {
const result = runVerifier('main', '--allow-untagged');
assert.equal(result.status, 0, result.stderr);
assert.match(result.stdout, new RegExp(`Non-publishing package version ${currentVersion} matches`));
});