mirror of
https://github.com/okieselbach/AutopilotMonitor.git
synced 2026-10-26 05:29:43 +00:00
Compare commits
31 Commits
| Author | SHA1 | Date | |
|---|---|---|---|
| 6b92e4e28c | |||
| f392819b97 | |||
| 672570df04 | |||
| 6f7ececa1f | |||
| af7e9d3650 | |||
| b3b122a23c | |||
| 064b670c75 | |||
| e5eb6dc4fb | |||
| 9f46adcdfa | |||
| cd1319a486 | |||
| ca10f36624 | |||
| e537a4b074 | |||
| 762fef4e24 | |||
| bca492ba05 | |||
| e7dd962133 | |||
| 14a67ef5af | |||
| 2371855b77 | |||
| 3a50de83ef | |||
| 24dfd247e9 | |||
| a640039518 | |||
| c3e9011905 | |||
| 8f6926a945 | |||
| 01323fdf6d | |||
| c566ed818b | |||
| 3a40361bb6 | |||
| 1b988d2943 | |||
| e88a0e455c | |||
| 0695f7943c | |||
| 6f8e7d48b2 | |||
| 0248d14738 | |||
| dc59fea6e5 |
+1
-1
Submodule .claude/commands updated: d48bf40136...d05399a386
@@ -11,6 +11,7 @@
|
||||
Identity comes from whatever `az login` established: the federated GitHub OIDC principal
|
||||
in CI (azure/login, subject repo:okieselbach/AutopilotMonitor:ref:refs/heads/main), the
|
||||
operator's own account for the local build. No secret is read, stored or passed around.
|
||||
Under GitHub Actions the token is masked in the run log before it is returned.
|
||||
|
||||
x-ms-version is MANDATORY here, not decoration: Entra-authorized requests are rejected
|
||||
below 2017-11-09, and Table requests without a SAS must carry the header at all. 2021-08-06
|
||||
@@ -45,6 +46,15 @@ if ($LASTEXITCODE -ne 0 -or [string]::IsNullOrWhiteSpace($token)) {
|
||||
'on the table -- a missing role shows up later as HTTP 403 AuthorizationPermissionMismatch.')
|
||||
}
|
||||
|
||||
# GitHub masks only secrets.* on its own; a token minted at run time is clear text in the
|
||||
# (public) run log the moment anything prints it -- an uncaptured call of this script, or
|
||||
# Get-Error / Format-List on a failed request, whose TargetObject carries this header.
|
||||
# Write-Host, never Write-Output: the output stream is this script's return value. Only
|
||||
# under Actions -- anywhere else the line would print the token instead of hiding it.
|
||||
if ($env:GITHUB_ACTIONS -eq 'true') {
|
||||
Write-Host "::add-mask::$token"
|
||||
}
|
||||
|
||||
return @{
|
||||
'Authorization' = "Bearer $token"
|
||||
'x-ms-version' = '2021-08-06'
|
||||
|
||||
@@ -108,6 +108,8 @@ jobs:
|
||||
NEXT_PUBLIC_ENTRA_REDIRECT_URI: ${{ vars.NEXT_PUBLIC_ENTRA_REDIRECT_URI }}
|
||||
NEXT_PUBLIC_ENTRA_POST_LOGOUT_REDIRECT_URI: ${{ vars.NEXT_PUBLIC_ENTRA_POST_LOGOUT_REDIRECT_URI }}
|
||||
NEXT_PUBLIC_API_BASE_URL: ${{ vars.NEXT_PUBLIC_API_BASE_URL }}
|
||||
# Browsers load the live stats through it, and the build reads it once to bake the
|
||||
# numbers of this moment into the landing page's static HTML (lib/platformStats.ts).
|
||||
NEXT_PUBLIC_PLATFORM_STATS_MANIFEST_URL: ${{ vars.NEXT_PUBLIC_PLATFORM_STATS_MANIFEST_URL }}
|
||||
NEXT_PUBLIC_APPINSIGHTS_CONNECTION_STRING: ${{ secrets.NEXT_PUBLIC_APPINSIGHTS_CONNECTION_STRING }}
|
||||
# Build stamp for public/version.json (scripts/generate-version.js in prebuild);
|
||||
@@ -121,6 +123,9 @@ jobs:
|
||||
npm run build
|
||||
test -f out/version.json || { echo "out/version.json missing - export did not run"; exit 1; }
|
||||
test -f out/whats-new.json || { echo "out/whats-new.json missing - whats-new prebuild did not run"; exit 1; }
|
||||
# Fail-soft like the star count: browsers still load the stats live; only crawlers and
|
||||
# LLM fetchers, which run no JS, see no numbers until the next deploy.
|
||||
grep -q 'data-stats-snapshot=' out/index.html || echo "::warning::Platform stats were not baked into the landing page (reason in the build log) - crawlers and LLM fetchers see no numbers until the next deploy"
|
||||
|
||||
# One archive of the exact bytes that get uploaded, so the attestation has a single subject.
|
||||
- name: Package export
|
||||
|
||||
+1
-1
Submodule internal updated: d73e9478c3...fd299a3c0d
+16
@@ -140,6 +140,22 @@ namespace AutopilotMonitor.Agent.V2.Core.Tests.Monitoring.Ime
|
||||
Assert.Equal(1, fired); // the persisted flag suppressed the second emission
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void Registry_reconciliation_counters_survive_a_restart()
|
||||
{
|
||||
using var h = new Harness();
|
||||
h.Tracker.ScriptRuns.CountVerified();
|
||||
h.Tracker.ScriptRuns.CountVerified();
|
||||
h.Tracker.ScriptRuns.CountCorrected();
|
||||
h.Tracker.SaveStateForTest();
|
||||
|
||||
h.Restart();
|
||||
|
||||
var health = h.Tracker.GetHealthSnapshot();
|
||||
Assert.Equal(2, health.PlatformOutputVerified);
|
||||
Assert.Equal(1, health.PlatformOutputCorrected);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public async Task Handler_time_does_not_count_against_the_line_budget()
|
||||
{
|
||||
|
||||
+368
@@ -0,0 +1,368 @@
|
||||
using System;
|
||||
using System.Collections.Generic;
|
||||
using System.Linq;
|
||||
using System.Threading.Tasks;
|
||||
using AutopilotMonitor.Agent.V2.Core.Monitoring.Enrollment.Ime;
|
||||
using Xunit;
|
||||
|
||||
namespace AutopilotMonitor.Agent.V2.Core.Tests.Monitoring.Ime
|
||||
{
|
||||
/// <summary>
|
||||
/// Session 756970cf: IME launched a Win32 detection executor and a platform-script executor 15 ms apart, and both
|
||||
/// opened AgentExecutor.log at the same end-of-file offset. The platform executor's shorter start block overwrote
|
||||
/// the detection executor's, whose identity line the tracker never saw; the detection's end block (exit 1 and its
|
||||
/// stdout), written at its own position behind its own start block, then sat behind the PLATFORM start block, and
|
||||
/// "the nearest preceding marker owns the line" handed another script's output and exit code to the platform
|
||||
/// script. These tests pin the writer boundary: an entry that is not exactly one CMTrace record is where one
|
||||
/// writer's bytes end and another's begin, and nothing behind it belongs to the invocation in front of it.
|
||||
/// </summary>
|
||||
public sealed partial class ImeLogTrackerOverwriteRewindTests
|
||||
{
|
||||
private const string RaceUserId = "00000000-0000-0000-0000-000000000000";
|
||||
private const string RacePlatformId = "1d6f0a52-3c4e-4b7a-9e21-5f8c7d2b9a10";
|
||||
private const string RaceDetectionAppId = "8b2e4c71-6a9d-4f03-b5e8-2c7a1d9f4e36";
|
||||
private const string RaceFillerAppId = "5e1c2b7d-0a4f-4c8e-9d36-7b2f1e8a4c50";
|
||||
private const string ImeDir = @"C:\Program Files (x86)\Microsoft Intune Management Extension";
|
||||
private const string DetectionStdout = "VERBOSE: === Sample Suite Detection Started ===\r\nWARNING: === DETECTION FAILED: Sample Suite is not installed ===";
|
||||
private const string PlatformStdout = "=== bootstrap loader started ===\r\nInstaller finished (exit code 0).";
|
||||
|
||||
private static string EntryAt(string time, string message)
|
||||
=> $"<![LOG[{message}]LOG]!><time=\"{time}\" date=\"9-10-2026\" component=\"AgentExecutor\" context=\"\" type=\"1\" thread=\"1\" file=\"\">\r\n";
|
||||
|
||||
/// <summary>The four lines every AgentExecutor invocation starts with — identical length for every executor.</summary>
|
||||
private static string ExecutorBanner(string time)
|
||||
=> EntryAt(time, "ExecutorLog AgentExecutor gets invoked")
|
||||
+ EntryAt(time, "Creating command line parser, name delimiter is - and value separator is .")
|
||||
+ EntryAt(time, "Getting Ordered Parameters")
|
||||
+ EntryAt(time, "Parsing Ordered Parameters.");
|
||||
|
||||
private static string ExecutorLaunch(string time, string scriptPath, string pid)
|
||||
=> EntryAt(time, "Prepare to run Powershell Script ..")
|
||||
+ EntryAt(time, $"cmd line for running powershell is -NoProfile -executionPolicy bypass -file \"{scriptPath}\" ")
|
||||
+ EntryAt(time, "runAs32BitOn64 = False, so Disable Wow64FsRedirection")
|
||||
+ EntryAt(time, @"PowerShell path is C:\Windows\System32\WindowsPowerShell\v1.0\powershell.exe")
|
||||
+ EntryAt(time, $"[Executor] created powershell with process id {pid}");
|
||||
|
||||
private static string PlatformStartBlock(string time, string policyId, string pid)
|
||||
{
|
||||
var path = $@"{ImeDir}\Policies\Scripts\{RaceUserId}_{policyId}.ps1";
|
||||
var results = $@"{ImeDir}\Policies\Results\{RaceUserId}_{policyId}";
|
||||
return ExecutorBanner(time)
|
||||
+ EntryAt(time, $"Adding argument powershell with value {path} to the named argument list.")
|
||||
+ EntryAt(time, "Powershell option gets invoked")
|
||||
+ EntryAt(time, path)
|
||||
+ EntryAt(time, results + ".output")
|
||||
+ EntryAt(time, results + ".error")
|
||||
+ EntryAt(time, results + ".timeout")
|
||||
+ ExecutorLaunch(time, path, pid);
|
||||
}
|
||||
|
||||
private static string DetectionStartBlock(string time, string appId, string pid)
|
||||
{
|
||||
var path = $@"{ImeDir}\Content\DetectionScripts\{appId}_2.ps1";
|
||||
return ExecutorBanner(time)
|
||||
+ EntryAt(time, $"Adding argument powershellDetection with value {path} to the named argument list.")
|
||||
+ EntryAt(time, "PowershellDetection option gets invoked")
|
||||
+ EntryAt(time, path)
|
||||
+ EntryAt(time, path + "quotedResultFilePath.txt")
|
||||
+ EntryAt(time, path + "quotedErrorFilePath.txt")
|
||||
+ EntryAt(time, path + "quotedTimeoutFilePath.txt")
|
||||
+ EntryAt(time, path + "quotedExitCodeFilePath.txt")
|
||||
+ ExecutorLaunch(time, path, pid);
|
||||
}
|
||||
|
||||
private static string ExecutorEndBlock(string time, int exitCode, string stdout)
|
||||
=> EntryAt(time, $"Powershell exit code is {exitCode}")
|
||||
+ EntryAt(time, $"length of out={stdout.Length}")
|
||||
+ EntryAt(time, "length of error=0")
|
||||
+ EntryAt(time, "error from script =")
|
||||
+ EntryAt(time, exitCode == 0 ? "Powershell script is successfully executed." : "Powershell script is failed to execute")
|
||||
+ EntryAt(time, $"write output done. output = {stdout}, error = ")
|
||||
+ EntryAt(time, "Revert Wow64FsRedirection")
|
||||
+ EntryAt(time, "Agent executor completed.");
|
||||
|
||||
private static string PlatformResultLine(string policyId)
|
||||
=> $"[PowerShell] User Id = {RaceUserId}, Policy id = {policyId}, policy result = Success";
|
||||
|
||||
/// <summary>The file offsets at which the entries of an ASCII <paramref name="block"/> start when it is written at <paramref name="at"/>.</summary>
|
||||
private static HashSet<long> EntryStarts(string block, long at)
|
||||
{
|
||||
Assert.True(block.All(c => c < 128), "offset arithmetic assumes ASCII test content");
|
||||
var starts = new HashSet<long>();
|
||||
for (var i = block.IndexOf("<![LOG[", StringComparison.Ordinal); i >= 0; i = block.IndexOf("<![LOG[", i + 1, StringComparison.Ordinal))
|
||||
starts.Add(at + i);
|
||||
return starts;
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public async Task Executor_that_opened_at_the_same_offset_never_lends_its_end_block_to_the_platform_script()
|
||||
{
|
||||
using var h = new Harness("AgentExecutor.log", ScriptPatterns());
|
||||
|
||||
// An earlier, finished detection run: the race starts mid-file like in the field log.
|
||||
h.Append(DetectionStartBlock("12:00:00.0000000", RaceFillerAppId, "1548") + ExecutorEndBlock("12:00:00.5000000", 0, "detected"));
|
||||
await h.Pass();
|
||||
var x = h.Length;
|
||||
|
||||
// Detection executor C and platform executor D open the file at the same end x. C writes first; the tracker
|
||||
// reads C's banner, then D writes its own start block over C's.
|
||||
var cStart = DetectionStartBlock("12:00:01.0000000", RaceDetectionAppId, "6416");
|
||||
var dStart = PlatformStartBlock("12:00:01.2000000", RacePlatformId, "2524");
|
||||
var cHead = cStart.Substring(0, cStart.IndexOf("<![LOG[Getting Ordered Parameters", StringComparison.Ordinal));
|
||||
h.Append(cHead);
|
||||
h.Now = h.Now.AddMilliseconds(100);
|
||||
await h.Pass();
|
||||
h.Append(cStart.Substring(cHead.Length));
|
||||
h.Overwrite(x, dStart);
|
||||
|
||||
// The field geometry: D's start block is shorter and ends inside one of C's lines, so the tail of that line
|
||||
// sits between D's start block and C's remaining bytes.
|
||||
Assert.True(dStart.Length < cStart.Length);
|
||||
Assert.DoesNotContain(x + dStart.Length, EntryStarts(cStart, x));
|
||||
h.Now = h.Now.AddMilliseconds(150);
|
||||
await h.Pass();
|
||||
Assert.True(h.Health.OverwriteRewinds >= 1);
|
||||
|
||||
// C ends: its end block lands at its own position, right behind its own (overwritten) start block.
|
||||
Assert.Equal(x + cStart.Length, h.Length);
|
||||
var cEnd = ExecutorEndBlock("12:00:07.0000000", 1, DetectionStdout);
|
||||
h.Append(cEnd);
|
||||
h.Now = h.Now.AddSeconds(6);
|
||||
await h.Pass();
|
||||
|
||||
// IME's result for D reaches the tracker before D's own end block: the completion must wait for it.
|
||||
h.Tracker.ProcessLogMessageForTest(PlatformResultLine(RacePlatformId), sourceFileName: "IntuneManagementExtension.log");
|
||||
Assert.Empty(h.Completed);
|
||||
|
||||
// D ends: its end block lands at ITS position, over the fragment and C's bytes; C's last line survives.
|
||||
var dEnd = ExecutorEndBlock("12:00:09.5000000", 0, PlatformStdout);
|
||||
Assert.True(dEnd.Length < cStart.Length - dStart.Length + cEnd.Length);
|
||||
h.Overwrite(x + dStart.Length, dEnd);
|
||||
h.Now = h.Now.AddMilliseconds(130);
|
||||
await h.Pass();
|
||||
h.Tracker.FlushPendingPlatformScriptResults(h.Now);
|
||||
|
||||
var script = Assert.Single(h.Completed);
|
||||
Assert.Equal(RacePlatformId, script.PolicyId);
|
||||
Assert.Equal("Success", script.Result);
|
||||
Assert.Equal(0, script.ExitCode);
|
||||
Assert.Equal(PlatformStdout.Replace("\r\n", "\n"), script.Stdout);
|
||||
Assert.DoesNotContain(h.Completed, s => (s.Stdout ?? string.Empty).Contains("Detection"));
|
||||
|
||||
// The run is known to the registry reconciliation under the user id of its own lines (D-316).
|
||||
Assert.Equal(RaceUserId, script.UserId);
|
||||
Assert.False(string.IsNullOrEmpty(script.RunId));
|
||||
h.Tracker.ScriptRuns.NotePassCompleted(DateTime.MaxValue.AddDays(-1));
|
||||
Assert.Equal(PlatformRunClaim.Claimed, h.Tracker.ScriptRuns.TryClaim(RaceUserId, RacePlatformId, h.Now, out var run));
|
||||
Assert.Equal(script.RunId, run!.RunId);
|
||||
}
|
||||
|
||||
/// <summary>
|
||||
/// The mirror image: a foreign executor whose stream position lies inside the platform start block (it opened
|
||||
/// at the same end with a shorter start block) writes its end block there. Its first line merges with the head of
|
||||
/// a platform line — cut inside the message or inside the trailer, which the parser would otherwise read up to
|
||||
/// the foreign trailer — and its output line follows without any marker in between.
|
||||
/// </summary>
|
||||
[Theory]
|
||||
[InlineData(15)]
|
||||
[InlineData(-30)]
|
||||
public async Task Foreign_end_block_merged_into_the_platform_start_block_never_reaches_the_platform_script(int cut)
|
||||
{
|
||||
using var h = new Harness("AgentExecutor.log", ScriptPatterns());
|
||||
h.Append(DetectionStartBlock("12:00:00.0000000", RaceFillerAppId, "1548") + ExecutorEndBlock("12:00:00.5000000", 0, "detected"));
|
||||
await h.Pass();
|
||||
var x = h.Length;
|
||||
|
||||
var dStart = PlatformStartBlock("12:00:01.0000000", RacePlatformId, "2524");
|
||||
h.Append(dStart);
|
||||
await h.Pass();
|
||||
|
||||
// The foreign end block starts inside the line after D's argument line.
|
||||
var lineAfterArgument = x + dStart.IndexOf("<![LOG[Powershell option gets invoked", StringComparison.Ordinal);
|
||||
var lineLength = EntryAt("12:00:01.0000000", "Powershell option gets invoked").Length;
|
||||
var at = lineAfterArgument + (cut > 0 ? cut : lineLength + cut);
|
||||
var foreignEnd = ExecutorEndBlock("12:00:03.0000000", 1, "foreign output");
|
||||
Assert.True(at + foreignEnd.Length < x + dStart.Length, "the foreign block must end inside D's start block");
|
||||
h.Overwrite(at, foreignEnd);
|
||||
h.Tracker.RequestOverwriteCheckForTest();
|
||||
h.Now = h.Now.AddMilliseconds(100);
|
||||
await h.Pass();
|
||||
|
||||
h.Tracker.ProcessLogMessageForTest(PlatformResultLine(RacePlatformId), sourceFileName: "IntuneManagementExtension.log");
|
||||
h.Now = h.Now.Add(ImeLogTracker.PlatformScriptEndBlockGrace);
|
||||
h.Tracker.FlushPendingPlatformScriptResults(h.Now);
|
||||
|
||||
// No owner is provable behind the cut: the completion goes out without end-block data, never with the foreign one.
|
||||
var script = Assert.Single(h.Completed);
|
||||
Assert.Equal("Success", script.Result);
|
||||
Assert.Null(script.ExitCode);
|
||||
Assert.Null(script.Stdout);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public async Task Entry_read_unchanged_after_a_rewind_keeps_its_platform_marker()
|
||||
{
|
||||
const string platformId = "2b7d9e41-8c3a-4f60-a5d2-9e1b7c4f3a08";
|
||||
using var h = new Harness("AgentExecutor.log", ScriptPatterns());
|
||||
|
||||
// Detection W waits for its script; detection X runs completely behind it; platform F starts behind X.
|
||||
var wStart = DetectionStartBlock("12:00:00.0000000", RaceFillerAppId, "1111");
|
||||
var xRun = DetectionStartBlock("12:00:00.2000000", RaceDetectionAppId, "2222") + ExecutorEndBlock("12:00:00.4000000", 0, "x detected");
|
||||
h.Append(wStart + xRun + PlatformStartBlock("12:00:01.0000000", platformId, "3333"));
|
||||
await h.Pass();
|
||||
|
||||
// W ends at its own position, over the head of X's run; F's start block keeps its bytes and offset.
|
||||
var wEnd = ExecutorEndBlock("12:00:02.0000000", 0, "w detected");
|
||||
Assert.True(wEnd.Length < xRun.Length);
|
||||
h.Overwrite(wStart.Length, wEnd);
|
||||
h.Tracker.RequestOverwriteCheckForTest();
|
||||
h.Now = h.Now.AddMilliseconds(100);
|
||||
await h.Pass();
|
||||
Assert.Equal(1, h.Health.OverwriteRewinds);
|
||||
|
||||
// F's end block lands behind its start block: still F's, because F's marker survived with its bytes.
|
||||
h.Append(ExecutorEndBlock("12:00:05.0000000", 7, "Hello from F"));
|
||||
h.Now = h.Now.AddMilliseconds(100);
|
||||
await h.Pass();
|
||||
h.Tracker.ProcessLogMessageForTest(PlatformResultLine(platformId), sourceFileName: "IntuneManagementExtension.log");
|
||||
|
||||
var script = Assert.Single(h.Completed);
|
||||
Assert.Equal(platformId, script.PolicyId);
|
||||
Assert.Equal(7, script.ExitCode);
|
||||
Assert.Equal("Hello from F", script.Stdout);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public async Task Writer_boundary_read_unchanged_after_a_rewind_still_closes_the_platform_invocation()
|
||||
{
|
||||
using var h = new Harness("AgentExecutor.log", ScriptPatterns());
|
||||
|
||||
// Detection Q waits for its script while detection R runs completely behind it.
|
||||
var qStart = DetectionStartBlock("12:00:00.0000000", RaceFillerAppId, "1111");
|
||||
var rRun = DetectionStartBlock("12:00:00.2000000", "6c3f8a20-1d5e-4b97-8f4a-0e2d6b9c7a13", "2222") + ExecutorEndBlock("12:00:00.4000000", 0, "r detected");
|
||||
h.Append(qStart + rRun);
|
||||
await h.Pass();
|
||||
var x = h.Length;
|
||||
|
||||
// The race of the field case behind them: the boundary closes D.
|
||||
var cStart = DetectionStartBlock("12:00:01.0000000", RaceDetectionAppId, "6416");
|
||||
var dStart = PlatformStartBlock("12:00:01.2000000", RacePlatformId, "2524");
|
||||
h.Append(cStart);
|
||||
h.Overwrite(x, dStart);
|
||||
h.Now = h.Now.AddMilliseconds(100);
|
||||
await h.Pass();
|
||||
|
||||
// Q ends at its own position, over R's run: the rewind starts in front of the race, whose bytes read unchanged.
|
||||
var qEnd = ExecutorEndBlock("12:00:02.0000000", 0, "q detected");
|
||||
Assert.True(qEnd.Length < rRun.Length);
|
||||
h.Overwrite(qStart.Length, qEnd);
|
||||
h.Tracker.RequestOverwriteCheckForTest();
|
||||
h.Now = h.Now.AddMilliseconds(100);
|
||||
await h.Pass();
|
||||
|
||||
// C's end block behind the boundary stays unowned; D's own end block completes D.
|
||||
var cEnd = ExecutorEndBlock("12:00:07.0000000", 1, DetectionStdout);
|
||||
h.Append(cEnd);
|
||||
h.Now = h.Now.AddMilliseconds(100);
|
||||
await h.Pass();
|
||||
h.Tracker.ProcessLogMessageForTest(PlatformResultLine(RacePlatformId), sourceFileName: "IntuneManagementExtension.log");
|
||||
Assert.Empty(h.Completed);
|
||||
|
||||
h.Overwrite(x + dStart.Length, ExecutorEndBlock("12:00:09.5000000", 0, PlatformStdout));
|
||||
h.Now = h.Now.AddMilliseconds(130);
|
||||
await h.Pass();
|
||||
h.Tracker.FlushPendingPlatformScriptResults(h.Now);
|
||||
|
||||
var script = Assert.Single(h.Completed);
|
||||
Assert.Equal(0, script.ExitCode);
|
||||
Assert.Equal(PlatformStdout.Replace("\r\n", "\n"), script.Stdout);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public async Task Raw_text_in_the_executor_log_is_never_matched_and_closes_the_platform_invocation()
|
||||
{
|
||||
using var h = new Harness("AgentExecutor.log", ScriptPatterns());
|
||||
h.Append(PlatformStartBlock("12:00:00.0000000", RacePlatformId, "2524"));
|
||||
await h.Pass();
|
||||
|
||||
// The tail of a cut line that happens to read like an exit line, then a foreign end block.
|
||||
h.Append("Powershell exit code is 5\r\n" + ExecutorEndBlock("12:00:02.0000000", 6, "foreign output"));
|
||||
// A fragment right at the bookmark stops the first pass for a check; the second one reads it.
|
||||
h.Now = h.Now.AddMilliseconds(100);
|
||||
await h.Pass();
|
||||
h.Now = h.Now.AddMilliseconds(100);
|
||||
await h.Pass();
|
||||
|
||||
h.Tracker.ProcessLogMessageForTest(PlatformResultLine(RacePlatformId), sourceFileName: "IntuneManagementExtension.log");
|
||||
h.Now = h.Now.Add(ImeLogTracker.PlatformScriptEndBlockGrace);
|
||||
h.Tracker.FlushPendingPlatformScriptResults(h.Now);
|
||||
|
||||
var script = Assert.Single(h.Completed);
|
||||
Assert.Null(script.ExitCode);
|
||||
Assert.Null(script.Stdout);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public async Task Fragment_in_the_ime_log_does_not_close_the_platform_run_context()
|
||||
{
|
||||
using var h = new Harness("IntuneManagementExtension.log", ScriptPatterns());
|
||||
// In the IME log the service writes the platform marker and the context line itself; the fragment in
|
||||
// between is the tail of an executor's telemetry line and separates nothing.
|
||||
h.Append(Entry(@"Script file C:\Program Files (x86)\Microsoft Intune Management Extension\Policies\Scripts\" + RaceUserId + "_" + RacePlatformId + ".ps1 is generated.", "17")
|
||||
+ "ing mananger...]LOG]!><time=\"12:00:00.0000000\" date=\"9-10-2026\" component=\"AgentExecutor\" context=\"\" type=\"1\" thread=\"1\" file=\"\">\r\n"
|
||||
+ Entry("Launch powershell executor in user session", "17"));
|
||||
await h.Pass();
|
||||
|
||||
h.Tracker.ProcessLogMessageForTest(PlatformResultLine(RacePlatformId));
|
||||
h.Now = h.Now.Add(ImeLogTracker.PlatformScriptEndBlockGrace);
|
||||
h.Tracker.FlushPendingPlatformScriptResults(h.Now);
|
||||
|
||||
var script = Assert.Single(h.Completed);
|
||||
Assert.Equal("User", script.RunContext);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public async Task Cut_multi_line_output_adds_one_boundary_not_one_per_line()
|
||||
{
|
||||
using var h = new Harness("AgentExecutor.log", ScriptPatterns());
|
||||
h.Append(PlatformStartBlock("12:00:00.0000000", RacePlatformId, "2524"));
|
||||
await h.Pass();
|
||||
var markersBefore = h.Tracker.InvocationMarkerCountForTest("AgentExecutor.log");
|
||||
|
||||
var lines = string.Concat(Enumerable.Range(1, 600).Select(i => $"orphaned output line {i}\r\n"));
|
||||
h.Append(lines);
|
||||
h.Now = h.Now.AddMilliseconds(100);
|
||||
await h.Pass();
|
||||
h.Now = h.Now.AddMilliseconds(100);
|
||||
await h.Pass();
|
||||
|
||||
Assert.Equal(markersBefore + 1, h.Tracker.InvocationMarkerCountForTest("AgentExecutor.log"));
|
||||
}
|
||||
|
||||
[Theory]
|
||||
[InlineData("<![LOG[Powershell exit code is 0]LOG]!><time=\"12:00:00.0000000\" date=\"9-10-2026\" component=\"AgentExecutor\" context=\"\" type=\"1\" thread=\"1\" file=\"\">", true)]
|
||||
[InlineData("<![LOG[write output done. output = line one\nline two, error = ]LOG]!><time=\"12:00:00.0000000\" date=\"9-10-2026\" component=\"AgentExecutor\" context=\"\" type=\"1\" thread=\"1\" file=\"\">", true)]
|
||||
[InlineData("\uFEFF<![LOG[ExecutorLog AgentExecutor gets invoked]LOG]!><time=\"12:00:00.0000000\" date=\"9-10-2026\" component=\"AgentExecutor\" context=\"\" type=\"1\" thread=\"1\" file=\"\">", true)]
|
||||
[InlineData("t code is 3]LOG]!><time=\"12:00:00.0000000\" date=\"9-10-2026\" component=\"AgentExecutor\" context=\"\" type=\"1\" thread=\"1\" file=\"\">", false)]
|
||||
[InlineData("", false)]
|
||||
[InlineData("<![LOG[Powe<![LOG[Powershell exit code is 1]LOG]!><time=\"12:00:00.0000000\" date=\"9-10-2026\" component=\"AgentExecutor\" context=\"\" type=\"1\" thread=\"1\" file=\"\">", false)]
|
||||
[InlineData("<![LOG[Powershell option gets invoked]LOG]!><time=\"12:00:00.0000000\" da<![LOG[Powershell exit code is 1]LOG]!><time=\"12:00:01.0000000\" date=\"9-10-2026\" component=\"AgentExecutor\" context=\"\" type=\"1\" thread=\"1\" file=\"\">", false)]
|
||||
[InlineData("<![LOG[write output done. output = line one\nline<![LOG[Agent executor completed.]LOG]!><time=\"12:00:00.0000000\" date=\"9-10-2026\" component=\"AgentExecutor\" context=\"\" type=\"1\" thread=\"1\" file=\"\">", false)]
|
||||
public void Single_cmtrace_record_is_told_apart_from_the_cut_of_two_writers(string text, bool expected)
|
||||
{
|
||||
Assert.Equal(expected, ImeLogTracker.IsSingleCmTraceRecord(text));
|
||||
}
|
||||
|
||||
[Theory]
|
||||
[InlineData("AgentExecutor.log", true)]
|
||||
[InlineData("AgentExecutor-20261003-233348.log", true)]
|
||||
[InlineData("IntuneManagementExtension.log", false)]
|
||||
[InlineData("IntuneManagementExtension-20261003-233348.log", false)]
|
||||
[InlineData("HealthScripts.log", false)]
|
||||
[InlineData("AppWorkload.log", false)]
|
||||
public void Writer_boundaries_apply_to_the_executor_log_live_and_rotated(string fileName, bool expected)
|
||||
{
|
||||
Assert.Equal(expected, ImeLogTracker.IsWriterBoundaryLogFile(fileName));
|
||||
}
|
||||
}
|
||||
}
|
||||
+2
-2
@@ -25,7 +25,7 @@ namespace AutopilotMonitor.Agent.V2.Core.Tests.Monitoring.Ime
|
||||
/// contract: unchanged bytes never rewind, changed bytes are processed exactly once, and the
|
||||
/// executor lines a rewind uncovers belong to the invocation that owns their file position.
|
||||
/// </summary>
|
||||
public sealed class ImeLogTrackerOverwriteRewindTests
|
||||
public sealed partial class ImeLogTrackerOverwriteRewindTests
|
||||
{
|
||||
private static readonly DateTime T0 = new DateTime(2026, 9, 10, 19, 30, 0, DateTimeKind.Utc);
|
||||
|
||||
@@ -42,7 +42,7 @@ namespace AutopilotMonitor.Agent.V2.Core.Tests.Monitoring.Ime
|
||||
private static readonly string[] ScriptPatternIds =
|
||||
{
|
||||
"PS-AGENT-INVOCATION", "PS-AGENT-ARG", "PS-AGENT-SCRIPT-START", "PS-AGENT-EXITCODE",
|
||||
"PS-AGENT-OUTPUT", "PS-AGENT-COMPLETED", "PS-SCRIPT-GENERATED", "PS-SCRIPT-CONTEXT", "PS-SCRIPT-RESULT",
|
||||
"PS-AGENT-OUTPUT", "PS-AGENT-ERROR", "PS-AGENT-COMPLETED", "PS-SCRIPT-GENERATED", "PS-SCRIPT-CONTEXT", "PS-SCRIPT-RESULT",
|
||||
};
|
||||
|
||||
/// <summary>The shipped pattern JSON — the same source combine.js embeds — so the contract is the real one.</summary>
|
||||
|
||||
+143
-2
@@ -1,6 +1,7 @@
|
||||
#nullable enable
|
||||
using System;
|
||||
using System.Collections.Generic;
|
||||
using System.IO;
|
||||
using System.Linq;
|
||||
using AutopilotMonitor.Agent.V2.Core.Logging;
|
||||
using AutopilotMonitor.Agent.V2.Core.Monitoring.Enrollment.SystemSignals;
|
||||
@@ -10,6 +11,7 @@ using AutopilotMonitor.Agent.V2.Core.Tests.Orchestration;
|
||||
using AutopilotMonitor.DecisionCore.Engine;
|
||||
using AutopilotMonitor.DecisionCore.Signals;
|
||||
using AutopilotMonitor.Shared;
|
||||
using Newtonsoft.Json;
|
||||
using Xunit;
|
||||
|
||||
namespace AutopilotMonitor.Agent.V2.Core.Tests.Monitoring
|
||||
@@ -36,18 +38,31 @@ namespace AutopilotMonitor.Agent.V2.Core.Tests.Monitoring
|
||||
private const string CspGateTrue =
|
||||
"CloudExperienceHost Web App Event 2. Name: 'ExpeditedUpdate_isNDUPAllowedByCSPSucceeded', Value: 'true'.";
|
||||
|
||||
// A French Windows labels the same fields "Résultat", "Nom" and "valeur" and quotes them
|
||||
// in guillemets; the event properties carry the values unchanged in every language.
|
||||
private const string FrenchNdupStarted = "Activité d’application web CloudExperienceHost démarrée. CXID : « OobeNDUP ».";
|
||||
private const string FrenchPageStopped = "Activité d’application web CloudExperienceHost arrêtée. Résultat : « success ».";
|
||||
private const string FrenchCspGate =
|
||||
"Événement d’application web CloudExperienceHost 2. Nom : « ExpeditedUpdate_isNDUPAllowedByCSPSucceeded », valeur : « true ».";
|
||||
|
||||
private readonly TempDirectory _tmp = new TempDirectory();
|
||||
private readonly FakeSignalIngressSink _sink = new FakeSignalIngressSink();
|
||||
private IReadOnlyList<OobeUpdateRegistrySnapshot.KeyState> _registry = Array.Empty<OobeUpdateRegistrySnapshot.KeyState>();
|
||||
|
||||
public void Dispose() => _tmp.Dispose();
|
||||
|
||||
private ShellCoreTracker Build() =>
|
||||
private ShellCoreTracker Build(string? stateDirectory = null) =>
|
||||
new ShellCoreTracker("S1", "T1",
|
||||
new InformationalEventPost(_sink, new VirtualClock(At)),
|
||||
new AgentLogger(_tmp.Path, AgentLogLevel.Info),
|
||||
helloTracker: null,
|
||||
oobeUpdateRegistryReader: () => _registry);
|
||||
oobeUpdateRegistryReader: () => _registry,
|
||||
stateDirectory: stateDirectory);
|
||||
|
||||
private string StateDirectory => Path.Combine(_tmp.Path, "state");
|
||||
|
||||
private static void Live(ShellCoreTracker tracker, int eventId, string description, DateTime at, long recordId) =>
|
||||
tracker.ProcessEvent(eventId, description, at, "Microsoft-Windows-Shell-Core", isBackfill: false, recordId: recordId);
|
||||
|
||||
private IReadOnlyList<FakeSignalIngressSink.PostedSignal> ByType(string eventType) =>
|
||||
_sink.Posted.Where(p =>
|
||||
@@ -274,6 +289,132 @@ namespace AutopilotMonitor.Agent.V2.Core.Tests.Monitoring
|
||||
Assert.Equal(3, _sink.Posted.Count);
|
||||
}
|
||||
|
||||
// ------------------------------------------------------------ localization ----
|
||||
|
||||
[Fact]
|
||||
public void LocalizedRecords_AreReadFromTheirProperties()
|
||||
{
|
||||
using var tracker = Build();
|
||||
|
||||
tracker.ProcessEvent(ShellCoreTracker.EventId_ShellCore_WebAppStarted, FrenchNdupStarted, At, "Microsoft-Windows-Shell-Core",
|
||||
isBackfill: false, properties: new[] { "OobeNDUP" });
|
||||
tracker.ProcessEvent(ShellCoreTracker.EventId_ShellCore_WebAppEvent, FrenchCspGate, At.AddSeconds(5), "Microsoft-Windows-Shell-Core",
|
||||
isBackfill: false, properties: new[] { "ExpeditedUpdate_isNDUPAllowedByCSPSucceeded", "true" });
|
||||
tracker.ProcessEvent(ShellCoreTracker.EventId_ShellCore_WebAppStopped, FrenchPageStopped, At.AddMinutes(1), "Microsoft-Windows-Shell-Core",
|
||||
isBackfill: false, properties: new[] { "success" });
|
||||
|
||||
var pages = ByType(Constants.EventTypes.OobeUpdatePage).Select(Data).ToList();
|
||||
Assert.Equal(new object[] { "page_started", "event_name", "page_stopped" }, pages.Select(d => d["cxhEvent"]).ToArray());
|
||||
Assert.Equal("OobeNDUP", pages[0]["page"]);
|
||||
Assert.Equal("ExpeditedUpdate_isNDUPAllowedByCSPSucceeded", pages[1]["name"]);
|
||||
Assert.Equal("true", pages[1]["value"]);
|
||||
Assert.Equal("OobeNDUP", pages[2]["page"]);
|
||||
Assert.Equal("success", pages[2]["result"]);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void LocalizedMessage_WithoutProperties_DoesNotYieldItsLabelledFields()
|
||||
{
|
||||
// Why the properties are read: the French labels are not the manifest's.
|
||||
Assert.Null(ShellCoreTracker.ReadCxhFields(ShellCoreTracker.EventId_ShellCore_WebAppStopped, FrenchPageStopped, properties: null).Primary);
|
||||
Assert.Null(ShellCoreTracker.ReadCxhFields(ShellCoreTracker.EventId_ShellCore_WebAppEvent, FrenchCspGate, properties: null).Primary);
|
||||
|
||||
Assert.Equal("success",
|
||||
ShellCoreTracker.ReadCxhFields(ShellCoreTracker.EventId_ShellCore_WebAppStopped, FrenchPageStopped, new[] { "success" }).Primary);
|
||||
}
|
||||
|
||||
[Theory]
|
||||
[InlineData("CloudExperienceHost Web App Event 2. Name: 'ExpeditedUpdate_x', Value: 'true'.")]
|
||||
[InlineData("CloudExperienceHost Web App Event 2. Name : « ExpeditedUpdate_x », Value : « true ».")]
|
||||
[InlineData("CloudExperienceHost Web App Event 2. Name\u00A0: «\u202FExpeditedUpdate_x\u202F», Value\u00A0: «\u00A0true\u00A0».")]
|
||||
public void MessageFallback_AcceptsQuotesAndGuillemets(string description)
|
||||
{
|
||||
var fields = ShellCoreTracker.ReadCxhFields(ShellCoreTracker.EventId_ShellCore_WebAppEvent, description, properties: null);
|
||||
|
||||
Assert.Equal("ExpeditedUpdate_x", fields.Primary);
|
||||
Assert.Equal("true", fields.Value);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void PropertyValue_LeavesTheTrackerOnlyInASafeForm()
|
||||
{
|
||||
var fields = ShellCoreTracker.ReadCxhFields(ShellCoreTracker.EventId_ShellCore_WebAppEvent, "",
|
||||
new[] { "ExpeditedUpdate_commitExpeditionDownloadInstallAsyncSucceeded", "{\"url\":\"https://login.microsoftonline.com/x\"}" });
|
||||
|
||||
var record = ShellCoreTracker.ParseUpdatePageRecord(ShellCoreTracker.EventId_ShellCore_WebAppEvent, fields, lastPage: null);
|
||||
Assert.Equal("ExpeditedUpdate_commitExpeditionDownloadInstallAsyncSucceeded", record!.Name);
|
||||
Assert.Null(record.Value);
|
||||
Assert.DoesNotContain("microsoftonline",
|
||||
ShellCoreTracker.FormatCxhBreadcrumb(ShellCoreTracker.EventId_ShellCore_WebAppEvent, fields, lastPage: null));
|
||||
}
|
||||
|
||||
// ------------------------------------------------------- restart watermark ----
|
||||
|
||||
[Fact]
|
||||
public void RestartBackfill_SkipsUpdatePageRecords_AnEarlierRunReported()
|
||||
{
|
||||
using (var first = Build(StateDirectory))
|
||||
{
|
||||
Live(first, ShellCoreTracker.EventId_ShellCore_WebAppStarted, NdupStarted, At, recordId: 500);
|
||||
Live(first, ShellCoreTracker.EventId_ShellCore_WebAppEventName, ScanStartedName, At.AddMinutes(1), recordId: 501);
|
||||
}
|
||||
|
||||
// The restart reads the minutes before it again — plus the stop the first run missed.
|
||||
using var second = Build(StateDirectory);
|
||||
second.LoadPageWatermark();
|
||||
second.ReplayBackfillRecords(new[]
|
||||
{
|
||||
new ShellCoreRecord(ShellCoreTracker.EventId_ShellCore_WebAppStarted, NdupStarted, At, recordId: 500),
|
||||
new ShellCoreRecord(ShellCoreTracker.EventId_ShellCore_WebAppEventName, ScanStartedName, At.AddMinutes(1), recordId: 501),
|
||||
new ShellCoreRecord(ShellCoreTracker.EventId_ShellCore_WebAppStopped, PageStopped, At.AddMinutes(2), recordId: 502),
|
||||
});
|
||||
|
||||
var pages = ByType(Constants.EventTypes.OobeUpdatePage).Select(Data).ToList();
|
||||
Assert.Equal(new object[] { "page_started", "event_name", "page_stopped" }, pages.Select(d => d["cxhEvent"]).ToArray());
|
||||
Assert.Equal(new object[] { false, false, true }, pages.Select(d => d["backfill"]).ToArray());
|
||||
// The skipped start still names the page the stop belongs to.
|
||||
Assert.Equal("OobeNDUP", pages[2]["page"]);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void SameRecord_FromTheLiveWatcherAndTheBackfill_IsReportedOnce()
|
||||
{
|
||||
// The live watcher is armed before the backfill runs, so both can deliver a record.
|
||||
using var tracker = Build(StateDirectory);
|
||||
Live(tracker, ShellCoreTracker.EventId_ShellCore_WebAppStarted, NdupStarted, At, recordId: 700);
|
||||
tracker.ReplayBackfillRecords(new[]
|
||||
{
|
||||
new ShellCoreRecord(ShellCoreTracker.EventId_ShellCore_WebAppStarted, NdupStarted, At, recordId: 700),
|
||||
});
|
||||
|
||||
Assert.Single(ByType(Constants.EventTypes.OobeUpdatePage));
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void Watermark_FollowsReportedRecordsOnly()
|
||||
{
|
||||
using var tracker = Build(StateDirectory);
|
||||
for (var i = 0; i <= OobeUpdateTelemetry.MaxPageEventsPerKey; i++)
|
||||
Live(tracker, ShellCoreTracker.EventId_ShellCore_WebAppEventName, ScanStartedName, At.AddSeconds(i), recordId: 800 + i);
|
||||
|
||||
// The repeat over the per-name cap is claimed for this run, not written down.
|
||||
Assert.Equal(OobeUpdateTelemetry.MaxPageEventsPerKey, ByType(Constants.EventTypes.OobeUpdatePage).Count);
|
||||
var state = JsonConvert.DeserializeObject<EventRecordWatermark.WatermarkState>(
|
||||
File.ReadAllText(Path.Combine(StateDirectory, ShellCoreTracker.PageWatermarkStateFileName)));
|
||||
Assert.Equal(800 + OobeUpdateTelemetry.MaxPageEventsPerKey - 1, state!.LastRecordId);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void RecordsWithoutARecordId_AreNotDeduplicated()
|
||||
{
|
||||
using var tracker = Build(StateDirectory);
|
||||
Live(tracker, ShellCoreTracker.EventId_ShellCore_WebAppStarted, NdupStarted, At, recordId: -1);
|
||||
Live(tracker, ShellCoreTracker.EventId_ShellCore_WebAppStarted, NdupStarted, At.AddMinutes(5), recordId: -1);
|
||||
|
||||
Assert.Equal(2, ByType(Constants.EventTypes.OobeUpdatePage).Count);
|
||||
Assert.False(File.Exists(Path.Combine(StateDirectory, ShellCoreTracker.PageWatermarkStateFileName)));
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void AgentStartAndStop_ReportTheRegistryState_StopOnce()
|
||||
{
|
||||
|
||||
+49
@@ -84,6 +84,55 @@ namespace AutopilotMonitor.Agent.V2.Core.Tests.Monitoring
|
||||
Assert.False(raised);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void ProcessEvent_62404_NGC_in_a_localized_message_is_read_from_the_cxid_property()
|
||||
{
|
||||
// A French Windows quotes the CXID in guillemets — the "'NGC'" substring never matched.
|
||||
using var tmp = new TempDirectory();
|
||||
using var tracker = MakeTracker(tmp, new VirtualClock(ClockNow));
|
||||
var raised = 0;
|
||||
tracker.HelloWizardStarted += (_, _) => raised++;
|
||||
|
||||
tracker.ProcessEvent(
|
||||
eventId: ShellCoreTracker.EventId_ShellCore_WebAppStarted,
|
||||
description: "Activité d’application web CloudExperienceHost démarrée. CXID : « NGC ».",
|
||||
timestamp: ClockNow,
|
||||
providerName: "Microsoft-Windows-Shell-Core",
|
||||
isBackfill: false,
|
||||
properties: new[] { "NGC" });
|
||||
|
||||
Assert.Equal(1, raised);
|
||||
}
|
||||
|
||||
[Theory]
|
||||
[InlineData("AADHello", true)]
|
||||
[InlineData("NGC", true)]
|
||||
[InlineData("NGCPin", false)]
|
||||
[InlineData("OobeNDUP", false)]
|
||||
public void HelloWizardStart_is_decided_by_the_cxid(string cxid, bool expected)
|
||||
{
|
||||
Assert.Equal(expected, ShellCoreTracker.IsHelloWizardStart(cxid, description: "CXID: 'AADHello'"));
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void Backfill_62404_reads_the_cxid_property()
|
||||
{
|
||||
using var tmp = new TempDirectory();
|
||||
using var tracker = MakeTracker(tmp, new VirtualClock(ClockNow));
|
||||
var captured = new List<HelloWizardStartedEventArgs>();
|
||||
tracker.HelloWizardStarted += (_, args) => captured.Add(args);
|
||||
|
||||
var historical = ClockNow.AddMinutes(-3);
|
||||
tracker.ReplayBackfillRecords(new[]
|
||||
{
|
||||
new ShellCoreRecord(ShellCoreTracker.EventId_ShellCore_WebAppStarted,
|
||||
"Activité d’application web CloudExperienceHost démarrée. CXID : « NGC ».", historical,
|
||||
recordId: 42, properties: new[] { "NGC" }),
|
||||
});
|
||||
|
||||
Assert.Equal(historical, Assert.Single(captured).OccurredAtUtc);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void Backfill_62404_raises_once_with_historical_timestamp()
|
||||
{
|
||||
|
||||
+411
@@ -0,0 +1,411 @@
|
||||
#nullable enable
|
||||
using System;
|
||||
using System.Collections.Generic;
|
||||
using System.Linq;
|
||||
using AutopilotMonitor.Agent.V2.Core.Monitoring.Enrollment.Ime;
|
||||
using AutopilotMonitor.Agent.V2.Core.Monitoring.Enrollment.SystemSignals;
|
||||
using AutopilotMonitor.Agent.V2.Core.Orchestration;
|
||||
using AutopilotMonitor.Agent.V2.Core.Tests.Harness;
|
||||
using AutopilotMonitor.Agent.V2.Core.Tests.Orchestration;
|
||||
using AutopilotMonitor.DecisionCore.Engine;
|
||||
using Xunit;
|
||||
using SharedEventTypes = AutopilotMonitor.Shared.Constants.EventTypes;
|
||||
|
||||
namespace AutopilotMonitor.Agent.V2.Core.Tests.Monitoring.SystemSignals
|
||||
{
|
||||
/// <summary>
|
||||
/// D-316: IME saves every platform script's result under Policies\<user>\<policy> after reporting the
|
||||
/// batch; the observer checks the tracker's emitted run against it. The field case (session 756970cf): the run
|
||||
/// had been given a Win32 detection script's end block — exit 1 and "Detection Started" output — while IME saved
|
||||
/// the bootstrap output of the platform script itself.
|
||||
/// </summary>
|
||||
public sealed class ImeRegistryScriptResultObserverTests
|
||||
{
|
||||
private const string DeviceUser = "00000000-0000-0000-0000-000000000000";
|
||||
private const string PolicyA = "1d6f0a52-3c4e-4b7a-9e21-5f8c7d2b9a10";
|
||||
private const string PolicyB = "2b7d9e41-8c3a-4f60-a5d2-9e1b7c4f3a08";
|
||||
private const string OwnStdout = "=== bootstrap loader started ===\nInstaller finished (exit code 0).";
|
||||
private const string ForeignStdout = "VERBOSE: === Sample Suite Detection Started ===\nWARNING: === DETECTION FAILED ===";
|
||||
private static readonly DateTime T0 = new DateTime(2026, 10, 3, 20, 59, 0, DateTimeKind.Utc);
|
||||
|
||||
// ── PlatformOutputJudge ─────────────────────────────────────────────────
|
||||
|
||||
private static PlatformScriptRun Run(string? stdout, string? stderr = null, int? exitCode = 0, string result = "Success", string resultSource = "ime_policy_result")
|
||||
=> new PlatformScriptRun { PolicyId = PolicyA, UserId = DeviceUser, RunId = "run-1", Emitted = true, Result = result, ResultSource = resultSource, ExitCode = exitCode, Stdout = stdout, Stderr = stderr };
|
||||
|
||||
private static string Details(string executionMessage)
|
||||
=> "{\"Version\":1,\"SigningCode\":15,\"EncryptionCode\":19,\"ExecutionMsg\":" + System.Text.Json.JsonSerializer.Serialize(executionMessage) + "}";
|
||||
|
||||
private static SavedScriptResult Saved(string? executionMessage, string result = "Success", int errorCode = 0, string user = DeviceUser, string policy = PolicyA, string stamp = "10/3/2026 9:00:00 PM")
|
||||
=> new SavedScriptResult
|
||||
{
|
||||
UserId = user,
|
||||
PolicyId = policy,
|
||||
Result = result,
|
||||
ErrorCode = errorCode,
|
||||
ResultDetails = executionMessage == null ? null : Details(executionMessage),
|
||||
LastUpdatedTimeUtc = stamp,
|
||||
};
|
||||
|
||||
[Fact]
|
||||
public void Field_case_detection_output_on_the_platform_run_is_foreign_and_the_saved_stdout_replaces_it()
|
||||
{
|
||||
var judgement = PlatformOutputJudge.Judge(Run(ForeignStdout, string.Empty, exitCode: 1), Saved(OwnStdout.Replace("\n", "\r\n")));
|
||||
Assert.Equal(PlatformOutputVerdict.Foreign, judgement.Verdict);
|
||||
Assert.Equal("stdout_differs", judgement.Reason);
|
||||
Assert.Equal(OwnStdout, judgement.Stdout);
|
||||
Assert.Equal(string.Empty, judgement.Stderr);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void Matching_output_is_verified_across_line_ending_and_trim_differences()
|
||||
{
|
||||
var judgement = PlatformOutputJudge.Judge(Run(OwnStdout, string.Empty), Saved(" " + OwnStdout.Replace("\n", "\r\n") + "\r\n"));
|
||||
Assert.Equal(PlatformOutputVerdict.Verified, judgement.Verdict);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void Output_cut_by_the_tracker_is_verified_against_the_longer_saved_text()
|
||||
{
|
||||
var full = string.Concat(Enumerable.Repeat("line of output\n", 1000)).TrimEnd();
|
||||
var emitted = ImeLogTracker.TruncateOutput(full);
|
||||
Assert.EndsWith(ImeLogTracker.OutputTruncationMarker, emitted);
|
||||
Assert.Equal(PlatformOutputVerdict.Verified, PlatformOutputJudge.Judge(Run(emitted), Saved(full)).Verdict);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void Both_empty_is_verified_but_stderr_on_a_success_is_another_executors()
|
||||
{
|
||||
Assert.Equal(PlatformOutputVerdict.Verified, PlatformOutputJudge.Judge(Run(string.Empty), Saved(string.Empty)).Verdict);
|
||||
var judgement = PlatformOutputJudge.Judge(Run(string.Empty, "Get-Item : not found"), Saved(string.Empty));
|
||||
Assert.Equal(PlatformOutputVerdict.Foreign, judgement.Verdict);
|
||||
Assert.Equal("stderr_on_success", judgement.Reason);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void Explicitly_empty_emitted_output_against_saved_text_is_foreign()
|
||||
{
|
||||
Assert.Equal(PlatformOutputVerdict.Foreign, PlatformOutputJudge.Judge(Run(string.Empty), Saved(OwnStdout)).Verdict);
|
||||
Assert.Equal(PlatformOutputVerdict.Foreign, PlatformOutputJudge.Judge(Run(OwnStdout), Saved(string.Empty)).Verdict);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void Output_never_read_is_completed_from_the_saved_text_and_the_exit_code_stands()
|
||||
{
|
||||
var judgement = PlatformOutputJudge.Judge(Run(null), Saved(OwnStdout));
|
||||
Assert.Equal(PlatformOutputVerdict.Repaired, judgement.Verdict);
|
||||
Assert.Equal("stdout_missing", judgement.Reason);
|
||||
Assert.Equal(OwnStdout, judgement.Stdout);
|
||||
Assert.Equal(PlatformOutputVerdict.NotComparable, PlatformOutputJudge.Judge(Run(null), Saved(string.Empty)).Verdict);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void Stdout_containing_the_output_error_separator_is_repaired_not_foreign()
|
||||
{
|
||||
// "write output done. output = X, error = " with X = "Copying files, error = 0 errors\nDone": the
|
||||
// lazy split leaves "Copying files" as stdout and the rest as stderr.
|
||||
var judgement = PlatformOutputJudge.Judge(
|
||||
Run("Copying files", "0 errors\nDone, error ="),
|
||||
Saved("Copying files, error = 0 errors\r\nDone"));
|
||||
Assert.Equal(PlatformOutputVerdict.Repaired, judgement.Verdict);
|
||||
Assert.Equal("stdout_split", judgement.Reason);
|
||||
Assert.Equal("Copying files, error = 0 errors\nDone", judgement.Stdout);
|
||||
Assert.Equal(string.Empty, judgement.Stderr);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void A_prefix_without_the_split_explanation_is_foreign()
|
||||
{
|
||||
Assert.Equal(PlatformOutputVerdict.Foreign, PlatformOutputJudge.Judge(Run("Detected"), Saved("Detected and repaired")).Verdict);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void Failed_with_stderr_is_judged_on_stderr()
|
||||
{
|
||||
Assert.Equal(PlatformOutputVerdict.Verified,
|
||||
PlatformOutputJudge.Judge(Run("partial", "Access denied", 1, "Failed"), Saved("Access denied\r\n", "Failed", 99)).Verdict);
|
||||
|
||||
var missing = PlatformOutputJudge.Judge(Run(null, null, 1, "Failed"), Saved("Access denied", "Failed", 99));
|
||||
Assert.Equal(PlatformOutputVerdict.Repaired, missing.Verdict);
|
||||
Assert.Null(missing.Stdout);
|
||||
Assert.Equal("Access denied", missing.Stderr);
|
||||
|
||||
var foreign = PlatformOutputJudge.Judge(Run("Detected", string.Empty, 0, "Failed"), Saved("Access denied", "Failed", 99));
|
||||
Assert.Equal(PlatformOutputVerdict.Foreign, foreign.Verdict);
|
||||
Assert.Equal(string.Empty, foreign.Stdout);
|
||||
Assert.Equal("Access denied", foreign.Stderr);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void Results_without_saved_output_or_from_another_run_are_not_compared()
|
||||
{
|
||||
Assert.Equal("no_saved_output", PlatformOutputJudge.Judge(Run(OwnStdout, null, 1, "Failed"), Saved("1", "Failed", 1)).Reason);
|
||||
var hashMismatch = new SavedScriptResult { UserId = DeviceUser, PolicyId = PolicyA, Result = "Failed", ErrorCode = 2, ResultDetails = "Hash mismatch" };
|
||||
Assert.Equal("no_execution_message", PlatformOutputJudge.Judge(Run(OwnStdout, null, 1, "Failed"), hashMismatch).Reason);
|
||||
Assert.Equal("result_differs", PlatformOutputJudge.Judge(Run(OwnStdout), Saved("Access denied", "Failed", 99)).Reason);
|
||||
// A result derived from the exit code (fallback) is not IME's — the saved one is.
|
||||
Assert.Equal(PlatformOutputVerdict.Verified,
|
||||
PlatformOutputJudge.Judge(Run(OwnStdout, null, 1, "Failed", "agentexecutor_fallback"), Saved(OwnStdout)).Verdict);
|
||||
}
|
||||
|
||||
// ── PlatformScriptRunRegister ───────────────────────────────────────────
|
||||
|
||||
private static ScriptExecutionState Emitted(string policyId, string? stdout, int? exitCode = 0, string? userId = DeviceUser, string runId = "run-1")
|
||||
=> new ScriptExecutionState { PolicyId = policyId, ScriptType = "platform", UserId = userId, RunId = runId, Result = "Success", ResultSource = "ime_policy_result", ExitCode = exitCode, Stdout = stdout };
|
||||
|
||||
[Fact]
|
||||
public void A_save_is_paired_only_after_the_tracker_read_past_it_and_the_run_was_emitted()
|
||||
{
|
||||
var runs = new PlatformScriptRunRegister();
|
||||
runs.NoteStarted(DeviceUser, PolicyA, T0);
|
||||
var seen = T0.AddSeconds(30);
|
||||
|
||||
Assert.Equal(PlatformRunClaim.Wait, runs.TryClaim(DeviceUser, PolicyA, seen, out _));
|
||||
runs.NotePassCompleted(seen.AddSeconds(1));
|
||||
Assert.Equal(PlatformRunClaim.Wait, runs.TryClaim(DeviceUser, PolicyA, seen, out _)); // pass started too early
|
||||
runs.NotePassCompleted(seen + PlatformScriptRunRegister.TrackerCatchUp);
|
||||
Assert.Equal(PlatformRunClaim.Wait, runs.TryClaim(DeviceUser, PolicyA, seen, out _)); // run not emitted yet
|
||||
|
||||
runs.NoteEmitted(Emitted(PolicyA, OwnStdout), T0.AddSeconds(40));
|
||||
Assert.Equal(PlatformRunClaim.Claimed, runs.TryClaim(DeviceUser, PolicyA, seen, out var run));
|
||||
Assert.Equal("run-1", run!.RunId);
|
||||
Assert.Equal(OwnStdout, run.Stdout);
|
||||
Assert.Equal(PlatformRunClaim.None, runs.TryClaim(DeviceUser, PolicyA, seen, out _)); // never twice
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void A_new_start_replaces_the_latest_run_of_its_key_and_other_users_stay_apart()
|
||||
{
|
||||
var runs = new PlatformScriptRunRegister();
|
||||
runs.NoteStarted(DeviceUser, PolicyA, T0);
|
||||
runs.NoteEmitted(Emitted(PolicyA, "first run"), T0.AddSeconds(5));
|
||||
runs.NoteStarted(DeviceUser, PolicyA, T0.AddMinutes(30));
|
||||
runs.NoteEmitted(Emitted(PolicyA, "second run", runId: "run-2"), T0.AddMinutes(30).AddSeconds(5));
|
||||
const string user = "6c3f8a20-1d5e-4b97-8f4a-0e2d6b9c7a13";
|
||||
runs.NoteStarted(user, PolicyA, T0.AddMinutes(31));
|
||||
runs.NotePassCompleted(T0.AddHours(1));
|
||||
|
||||
Assert.Equal(PlatformRunClaim.Claimed, runs.TryClaim(DeviceUser, PolicyA, T0.AddMinutes(31), out var run));
|
||||
Assert.Equal("second run", run!.Stdout);
|
||||
Assert.Equal(PlatformRunClaim.Wait, runs.TryClaim(user, PolicyA, T0.AddMinutes(32), out _));
|
||||
Assert.Equal(PlatformRunClaim.None, runs.TryClaim(DeviceUser, PolicyB, T0.AddMinutes(32), out _));
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void A_run_without_a_readable_user_id_is_claimed_by_its_policy()
|
||||
{
|
||||
var runs = new PlatformScriptRunRegister();
|
||||
runs.NoteStarted(null, PolicyA, T0);
|
||||
runs.NoteEmitted(Emitted(PolicyA, OwnStdout, userId: null), T0.AddSeconds(5));
|
||||
runs.NotePassCompleted(T0.AddMinutes(5));
|
||||
Assert.Equal(PlatformRunClaim.Claimed, runs.TryClaim(DeviceUser, PolicyA, T0.AddMinutes(1), out _));
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void Register_keeps_the_newest_runs_and_its_counters_report_each_change_once()
|
||||
{
|
||||
var runs = new PlatformScriptRunRegister();
|
||||
for (var i = 0; i <= PlatformScriptRunRegister.MaxRuns; i++)
|
||||
runs.NoteStarted(DeviceUser, Guid.NewGuid().ToString("D"), T0.AddSeconds(i));
|
||||
runs.NoteStarted(DeviceUser, PolicyA, T0.AddHours(1));
|
||||
runs.NoteEmitted(Emitted(PolicyA, OwnStdout), T0.AddHours(1));
|
||||
runs.NotePassCompleted(T0.AddHours(2));
|
||||
Assert.Equal(PlatformRunClaim.Claimed, runs.TryClaim(DeviceUser, PolicyA, T0.AddHours(1), out _));
|
||||
|
||||
Assert.False(runs.ConsumeCountersChanged());
|
||||
runs.CountVerified();
|
||||
runs.CountCorrected();
|
||||
Assert.True(runs.ConsumeCountersChanged());
|
||||
Assert.False(runs.ConsumeCountersChanged());
|
||||
Assert.Equal(1, runs.Verified);
|
||||
runs.RestoreCounters(7, 3);
|
||||
Assert.Equal(7, runs.Verified);
|
||||
Assert.Equal(3, runs.Corrected);
|
||||
}
|
||||
|
||||
// ── observer flow ───────────────────────────────────────────────────────
|
||||
|
||||
private sealed class Fixture
|
||||
{
|
||||
public readonly FakeSignalIngressSink Sink = new FakeSignalIngressSink();
|
||||
public readonly VirtualClock Clock = new VirtualClock(T0);
|
||||
public readonly PlatformScriptRunRegister Runs = new PlatformScriptRunRegister();
|
||||
public Dictionary<string, SavedScriptResult> Registry = new Dictionary<string, SavedScriptResult>(StringComparer.OrdinalIgnoreCase);
|
||||
public readonly ImeRegistryScriptResultObserver Observer;
|
||||
|
||||
public Fixture()
|
||||
{
|
||||
Observer = new ImeRegistryScriptResultObserver(Runs, new InformationalEventPost(Sink, Clock), null, Clock,
|
||||
() => new Dictionary<string, SavedScriptResult>(Registry, StringComparer.OrdinalIgnoreCase));
|
||||
}
|
||||
|
||||
public void Save(SavedScriptResult saved) => Registry[ImeRegistryScriptResultObserver.KeyOf(saved.UserId, saved.PolicyId)] = saved;
|
||||
|
||||
/// <summary>The tracker emitted a run, then kept polling past the save.</summary>
|
||||
public void EmitRun(string policyId, string? stdout, int? exitCode, string runId)
|
||||
{
|
||||
Runs.NoteStarted(DeviceUser, policyId, Clock.UtcNow);
|
||||
Runs.NoteEmitted(Emitted(policyId, stdout, exitCode, runId: runId), Clock.UtcNow);
|
||||
}
|
||||
|
||||
public void TrackerCaughtUp() => Runs.NotePassCompleted(Clock.UtcNow);
|
||||
|
||||
public IReadOnlyList<FakeSignalIngressSink.PostedSignal> Corrections()
|
||||
=> Sink.Posted.Where(p => p.Payload != null
|
||||
&& p.Payload.TryGetValue(SignalPayloadKeys.EventType, out var et)
|
||||
&& et == SharedEventTypes.ScriptOutputReconciliation).ToList();
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void Field_case_end_to_end_the_save_corrects_the_run_with_a_warning_naming_it()
|
||||
{
|
||||
var f = new Fixture();
|
||||
f.Save(Saved("an older run of another policy", policy: PolicyB, stamp: "10/2/2026 8:00:00 AM"));
|
||||
f.Observer.Tick("baseline");
|
||||
|
||||
f.EmitRun(PolicyA, ForeignStdout, 1, "run-a");
|
||||
f.Save(Saved(OwnStdout));
|
||||
f.Clock.Advance(TimeSpan.FromSeconds(1));
|
||||
f.Observer.Tick("registry_change");
|
||||
Assert.Empty(f.Corrections()); // the tracker has not read past the save yet
|
||||
|
||||
f.Clock.Advance(PlatformScriptRunRegister.TrackerCatchUp);
|
||||
f.TrackerCaughtUp();
|
||||
f.Observer.Tick("periodic");
|
||||
|
||||
var correction = Assert.Single(f.Corrections());
|
||||
var data = correction.Payload!;
|
||||
Assert.Equal(PolicyA, data["policyId"]);
|
||||
Assert.Equal("platform", data["scriptType"]);
|
||||
Assert.Equal("run-a", data["runId"]);
|
||||
Assert.Equal("foreign", data["outcome"]);
|
||||
Assert.Equal("stdout_differs", data["reason"]);
|
||||
Assert.Equal("Success", data["result"]);
|
||||
Assert.Equal(OwnStdout, data["stdout"]);
|
||||
Assert.Equal(string.Empty, data["stderr"]);
|
||||
Assert.Equal("1", data["previousExitCode"]);
|
||||
Assert.Equal("0", data["registryErrorCode"]);
|
||||
Assert.Equal("Warning", data[SignalPayloadKeys.Severity]);
|
||||
Assert.Equal("true", data[SignalPayloadKeys.ImmediateUpload]);
|
||||
Assert.DoesNotContain("exitCode", data.Keys);
|
||||
Assert.Equal(1, f.Runs.Corrected);
|
||||
Assert.Equal(0, f.Runs.Verified);
|
||||
|
||||
// The same save read again changes nothing.
|
||||
f.Clock.Advance(TimeSpan.FromMinutes(1));
|
||||
f.TrackerCaughtUp();
|
||||
f.Observer.Tick("periodic");
|
||||
Assert.Single(f.Corrections());
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void Confirmed_output_is_counted_and_emits_nothing()
|
||||
{
|
||||
var f = new Fixture();
|
||||
f.Observer.Tick("baseline");
|
||||
f.EmitRun(PolicyA, OwnStdout, 0, "run-a");
|
||||
f.Save(Saved(OwnStdout));
|
||||
f.Clock.Advance(TimeSpan.FromSeconds(1));
|
||||
f.Observer.Tick("registry_change");
|
||||
f.Clock.Advance(TimeSpan.FromSeconds(3));
|
||||
f.TrackerCaughtUp();
|
||||
f.Observer.Tick("periodic");
|
||||
|
||||
Assert.Empty(f.Corrections());
|
||||
Assert.Equal(1, f.Runs.Verified);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void Completed_output_is_an_info_event_that_keeps_the_exit_code()
|
||||
{
|
||||
var f = new Fixture();
|
||||
f.Observer.Tick("baseline");
|
||||
f.EmitRun(PolicyA, null, 0, "run-a");
|
||||
f.Save(Saved(OwnStdout));
|
||||
f.Clock.Advance(TimeSpan.FromSeconds(1));
|
||||
f.Observer.Tick("registry_change");
|
||||
f.Clock.Advance(TimeSpan.FromSeconds(3));
|
||||
f.TrackerCaughtUp();
|
||||
f.Observer.Tick("periodic");
|
||||
|
||||
var data = Assert.Single(f.Corrections()).Payload!;
|
||||
Assert.Equal("repaired", data["outcome"]);
|
||||
Assert.Equal("Info", data[SignalPayloadKeys.Severity]);
|
||||
Assert.DoesNotContain("previousExitCode", data.Keys);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void A_save_seen_before_its_run_was_emitted_waits_for_the_emit()
|
||||
{
|
||||
var f = new Fixture();
|
||||
f.Observer.Tick("baseline");
|
||||
f.Runs.NoteStarted(DeviceUser, PolicyA, f.Clock.UtcNow); // result held for its end block
|
||||
f.Save(Saved(OwnStdout));
|
||||
f.Observer.Tick("registry_change");
|
||||
f.Clock.Advance(TimeSpan.FromSeconds(3));
|
||||
f.TrackerCaughtUp();
|
||||
f.Observer.Tick("periodic");
|
||||
Assert.Equal(0, f.Runs.Verified + f.Runs.Corrected);
|
||||
|
||||
f.Runs.NoteEmitted(Emitted(PolicyA, ForeignStdout, 1, runId: "run-a"), f.Clock.UtcNow);
|
||||
f.Clock.Advance(TimeSpan.FromSeconds(60));
|
||||
f.Observer.Tick("periodic");
|
||||
Assert.Equal("foreign", Assert.Single(f.Corrections()).Payload!["outcome"]);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void A_save_no_run_claims_within_the_expiry_is_dropped()
|
||||
{
|
||||
var f = new Fixture();
|
||||
f.Observer.Tick("baseline");
|
||||
f.Save(Saved(OwnStdout));
|
||||
f.Observer.Tick("registry_change");
|
||||
f.Clock.Advance(ImeRegistryScriptResultObserver.PendingExpiry);
|
||||
f.TrackerCaughtUp();
|
||||
f.Runs.NoteStarted(DeviceUser, PolicyA, f.Clock.UtcNow);
|
||||
f.Observer.Tick("periodic"); // waits for the emit — and expires
|
||||
|
||||
f.Runs.NoteEmitted(Emitted(PolicyA, ForeignStdout, 1, runId: "run-a"), f.Clock.UtcNow);
|
||||
f.Clock.Advance(TimeSpan.FromSeconds(60));
|
||||
f.TrackerCaughtUp();
|
||||
f.Observer.Tick("periodic");
|
||||
Assert.Empty(f.Corrections());
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void Saves_from_before_the_agent_started_are_the_silent_baseline()
|
||||
{
|
||||
var f = new Fixture();
|
||||
f.EmitRun(PolicyA, ForeignStdout, 1, "run-a");
|
||||
f.Save(Saved(OwnStdout));
|
||||
f.TrackerCaughtUp();
|
||||
f.Observer.Tick("baseline");
|
||||
f.Clock.Advance(TimeSpan.FromMinutes(1));
|
||||
f.TrackerCaughtUp();
|
||||
f.Observer.Tick("periodic");
|
||||
|
||||
Assert.Empty(f.Corrections());
|
||||
Assert.Equal(0, f.Runs.Verified + f.Runs.Corrected);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void Corrections_beyond_the_cap_are_counted_but_not_emitted()
|
||||
{
|
||||
var f = new Fixture();
|
||||
f.Observer.Tick("baseline");
|
||||
var policies = Enumerable.Range(0, ImeRegistryScriptResultObserver.MaxCorrectionsPerSession + 3).Select(_ => Guid.NewGuid().ToString("D")).ToList();
|
||||
foreach (var policy in policies)
|
||||
{
|
||||
f.EmitRun(policy, ForeignStdout, 1, "run-" + policy);
|
||||
f.Save(Saved(OwnStdout, policy: policy));
|
||||
}
|
||||
f.Observer.Tick("registry_change");
|
||||
f.Clock.Advance(TimeSpan.FromSeconds(3));
|
||||
f.TrackerCaughtUp();
|
||||
f.Observer.Tick("periodic");
|
||||
|
||||
Assert.Equal(ImeRegistryScriptResultObserver.MaxCorrectionsPerSession, f.Corrections().Count);
|
||||
Assert.Equal(policies.Count, f.Runs.Corrected);
|
||||
}
|
||||
}
|
||||
}
|
||||
+31
@@ -112,6 +112,37 @@ namespace AutopilotMonitor.Agent.V2.Core.Tests.Monitoring.SystemSignals
|
||||
Assert.Equal(OobeUpdateTelemetry.MaxPageEventsPerRun, ByType(Constants.EventTypes.OobeUpdatePage).Count);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void PageStartAndStop_AreReported_AfterTheNameBudgetIsSpent()
|
||||
{
|
||||
// The time attribution reads the update's span from the page start and stop.
|
||||
var telemetry = Build();
|
||||
for (var i = 0; i < OobeUpdateTelemetry.MaxPageEventsPerRun; i++)
|
||||
{
|
||||
Assert.True(telemetry.ReportPage(new OobeUpdatePageRecord(OobeUpdatePageRecord.EventName, 62406, name: $"ExpeditedUpdate_step{i}"), At, isBackfill: false));
|
||||
}
|
||||
|
||||
Assert.False(telemetry.ReportPage(new OobeUpdatePageRecord(OobeUpdatePageRecord.EventName, 62406, name: "ExpeditedUpdate_late"), At, isBackfill: false));
|
||||
Assert.True(telemetry.ReportPage(new OobeUpdatePageRecord(OobeUpdatePageRecord.PageStarted, 62404, page: "RebootNDUP"), At.AddMinutes(1), isBackfill: false));
|
||||
Assert.True(telemetry.ReportPage(new OobeUpdatePageRecord(OobeUpdatePageRecord.PageStopped, 62405, page: "RebootNDUP", result: "success"), At.AddMinutes(2), isBackfill: false));
|
||||
|
||||
var pages = ByType(Constants.EventTypes.OobeUpdatePage);
|
||||
Assert.Equal(OobeUpdateTelemetry.MaxPageEventsPerRun + 2, pages.Count);
|
||||
Assert.Equal(new object[] { "page_started", "page_stopped" },
|
||||
pages.Skip(OobeUpdateTelemetry.MaxPageEventsPerRun).Select(p => Data(p)["cxhEvent"]).ToArray());
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void SamePageStart_IsReportedAtMostThreeTimes()
|
||||
{
|
||||
// Outside the run budget, but a page that restarts in a loop still cannot flood.
|
||||
var telemetry = Build();
|
||||
var reported = Enumerable.Range(0, 10)
|
||||
.Count(i => telemetry.ReportPage(new OobeUpdatePageRecord(OobeUpdatePageRecord.PageStarted, 62404, page: "OobeNDUP"), At.AddMinutes(i), isBackfill: false));
|
||||
|
||||
Assert.Equal(OobeUpdateTelemetry.MaxPageEventsPerKey, reported);
|
||||
}
|
||||
|
||||
// ------------------------------------------------------------ oobe_update_state ----
|
||||
|
||||
[Fact]
|
||||
|
||||
+54
@@ -0,0 +1,54 @@
|
||||
using System;
|
||||
using AutopilotMonitor.Agent.V2.Core.Monitoring.Enrollment.Ime;
|
||||
using AutopilotMonitor.Agent.V2.Core.SignalAdapters;
|
||||
using AutopilotMonitor.Agent.V2.Core.Tests.Harness;
|
||||
using SharedEventTypes = AutopilotMonitor.Shared.Constants.EventTypes;
|
||||
using Xunit;
|
||||
|
||||
namespace AutopilotMonitor.Agent.V2.Core.Tests.SignalAdapters
|
||||
{
|
||||
/// <summary>
|
||||
/// D-316: every emitted platform-script completion carries a run id, and the tracker's run register holds what
|
||||
/// was emitted for it under the IME user id — what the registry reconciliation pairs IME's saved result with.
|
||||
/// </summary>
|
||||
public sealed class ImeLogTrackerAdapterPlatformRunTests
|
||||
{
|
||||
private static readonly DateTime ClockNow = new DateTime(2026, 10, 3, 21, 0, 0, DateTimeKind.Utc);
|
||||
private const string DeviceUser = "00000000-0000-0000-0000-000000000000";
|
||||
private const string PolicyId = "1d6f0a52-3c4e-4b7a-9e21-5f8c7d2b9a10";
|
||||
|
||||
[Fact]
|
||||
public void Platform_completion_carries_its_run_id_and_the_register_holds_the_emitted_run()
|
||||
{
|
||||
using var f = new ImeLogTrackerAdapterFixture(ClockNow);
|
||||
using var adapter = new ImeLogTrackerAdapter(f.Tracker, f.Ingress, f.Clock);
|
||||
|
||||
f.Tracker.LastMatchedLogTimestamp = ClockNow.AddSeconds(-10);
|
||||
f.Tracker.HandlePlatformScriptStarted(PolicyId, "ime", DeviceUser);
|
||||
f.Tracker.RecordPlatformScriptExitCodeForTesting(PolicyId, 0, ClockNow.AddSeconds(-1));
|
||||
f.Tracker.LastMatchedLogTimestamp = ClockNow;
|
||||
f.Tracker.CompletePlatformScriptFromImeResultForTesting(PolicyId, "Success", ClockNow);
|
||||
|
||||
var info = f.InfoEvent(SharedEventTypes.ScriptCompleted);
|
||||
Assert.True(Guid.TryParse(info.Payload!["runId"], out _));
|
||||
|
||||
f.Tracker.ScriptRuns.NotePassCompleted(ClockNow.AddMinutes(1));
|
||||
Assert.Equal(PlatformRunClaim.Claimed, f.Tracker.ScriptRuns.TryClaim(DeviceUser, PolicyId, ClockNow.AddSeconds(5), out var run));
|
||||
Assert.Equal(info.Payload["runId"], run!.RunId);
|
||||
Assert.Equal(0, run.ExitCode);
|
||||
Assert.Equal("Success", run.Result);
|
||||
}
|
||||
|
||||
[Theory]
|
||||
[InlineData("[PowerShell] User Id = 00000000-0000-0000-0000-000000000000, Policy id = d94468af-6ebe-4e94-9901-2a62d33ea6c1, policy result = Success", "00000000-0000-0000-0000-000000000000")]
|
||||
[InlineData(@"Adding argument powershell with value C:\Program Files (x86)\Microsoft Intune Management Extension\Policies\Scripts\6C3F8A20-1D5E-4B97-8F4A-0E2D6B9C7A13_d94468af-6ebe-4e94-9901-2a62d33ea6c1.ps1", "6c3f8a20-1d5e-4b97-8f4a-0e2d6b9c7a13")]
|
||||
[InlineData(@"Script file C:\Program Files (x86)\Microsoft Intune Management Extension\Policies\Scripts\00000000-0000-0000-0000-000000000000_d94468af-6ebe-4e94-9901-2a62d33ea6c1.ps1 is generated", "00000000-0000-0000-0000-000000000000")]
|
||||
[InlineData(@"Adding argument powershellDetection with value C:\Program Files (x86)\Microsoft Intune Management Extension\Content\DetectionScripts\8b2e4c71-6a9d-4f03-b5e8-2c7a1d9f4e36_2.ps1", null)]
|
||||
[InlineData("[PowerShell] User Id = not-a-guid, Policy id = d94468af", null)]
|
||||
[InlineData("", null)]
|
||||
public void Ime_user_id_is_read_from_the_result_line_and_the_script_path(string text, string? expected)
|
||||
{
|
||||
Assert.Equal(expected, ImeLogTracker.ImeUserIdFrom(text));
|
||||
}
|
||||
}
|
||||
}
|
||||
+46
-8
@@ -271,14 +271,38 @@ namespace AutopilotMonitor.Agent.V2.Core.Monitoring.Enrollment.Ime
|
||||
}
|
||||
else
|
||||
{
|
||||
HandlePlatformScriptStarted(id, source);
|
||||
HandlePlatformScriptStarted(id, source, ImeUserIdFrom(match.Value));
|
||||
}
|
||||
}
|
||||
|
||||
/// <summary>
|
||||
/// The IME user id on a platform-script line — <c>User Id = {id}</c> on the result line,
|
||||
/// <c>…\Policies\Scripts\{id}_{policy}.ps1</c> on the start lines — or null. Read from the
|
||||
/// matched text, not from a capture group, so it works with every pattern pack the agent may
|
||||
/// be served.
|
||||
/// </summary>
|
||||
internal static string ImeUserIdFrom(string text)
|
||||
{
|
||||
if (string.IsNullOrEmpty(text)) return null;
|
||||
const string resultTag = "User Id = ";
|
||||
const string pathTag = @"\Policies\Scripts\";
|
||||
var i = text.IndexOf(resultTag, StringComparison.OrdinalIgnoreCase);
|
||||
if (i >= 0) return GuidAt(text, i + resultTag.Length);
|
||||
i = text.IndexOf(pathTag, StringComparison.OrdinalIgnoreCase);
|
||||
return i >= 0 ? GuidAt(text, i + pathTag.Length) : null;
|
||||
}
|
||||
|
||||
private static string GuidAt(string text, int start)
|
||||
{
|
||||
if (start + 36 > text.Length) return null;
|
||||
var candidate = text.Substring(start, 36);
|
||||
return Guid.TryParse(candidate, out _) ? candidate.ToLowerInvariant() : null;
|
||||
}
|
||||
|
||||
// Platform script: AgentExecutor.log entries create/enrich, IME log entries also create.
|
||||
// Internal so the stale-slot hardening is directly testable (the public path arrives via
|
||||
// a regex Match).
|
||||
internal void HandlePlatformScriptStarted(string id, string source = null)
|
||||
internal void HandlePlatformScriptStarted(string id, string source = null, string userId = null)
|
||||
{
|
||||
var currentStartTs = LastMatchedLogTimestamp ?? UtcNowProvider();
|
||||
var currentStartProvenance = CaptureLastMatchedProvenance();
|
||||
@@ -327,6 +351,7 @@ namespace AutopilotMonitor.Agent.V2.Core.Monitoring.Enrollment.Ime
|
||||
pendingSlot.StartedAtProvenance = currentStartProvenance;
|
||||
_stateDirty = true;
|
||||
}
|
||||
if (pendingSlot.UserId == null && userId != null) pendingSlot.UserId = userId;
|
||||
}
|
||||
if (!_pendingPlatformScripts.ContainsKey(id))
|
||||
{
|
||||
@@ -340,6 +365,7 @@ namespace AutopilotMonitor.Agent.V2.Core.Monitoring.Enrollment.Ime
|
||||
{
|
||||
PolicyId = id,
|
||||
ScriptType = "platform",
|
||||
UserId = userId,
|
||||
// Prefer the source CMTrace timestamp so a script that started before the
|
||||
// agent launched (replayed log content) is dated to its real start, not now.
|
||||
// Set only at slot creation: the start line fires twice (agentexecutor + ime
|
||||
@@ -347,6 +373,7 @@ namespace AutopilotMonitor.Agent.V2.Core.Monitoring.Enrollment.Ime
|
||||
StartedAtUtc = currentStartTs,
|
||||
StartedAtProvenance = currentStartProvenance,
|
||||
};
|
||||
ScriptRuns.NoteStarted(userId, id, UtcNowProvider());
|
||||
// Live "running" indicator — same signal health scripts emit. Gated on slot
|
||||
// creation so the duplicate start line (agentexecutor + ime source) doesn't
|
||||
// double-emit for the same execution.
|
||||
@@ -439,6 +466,8 @@ namespace AutopilotMonitor.Agent.V2.Core.Monitoring.Enrollment.Ime
|
||||
ApplyExitCode(script, exitCode, LastMatchedLogTimestamp ?? UtcNowProvider(), CaptureLastMatchedProvenance());
|
||||
else if (ownerPolicyId != null)
|
||||
_logger.Debug($"ImeLogTracker: exit code {exitCode} belongs to platform script {ownerPolicyId}, whose completion was already emitted — dropped");
|
||||
else
|
||||
LogLineBehindWriterBoundary($"exit code {exitCode}");
|
||||
// An exit code means the executor just wrote its end block and IME is about to
|
||||
// write the result — both land at a stale stream position when another process
|
||||
// appended meanwhile. Check the ledgers on the next pass.
|
||||
@@ -465,7 +494,11 @@ namespace AutopilotMonitor.Agent.V2.Core.Monitoring.Enrollment.Ime
|
||||
{
|
||||
var outputType = parameters != null && parameters.TryGetValue("outputType", out var ot) ? ot : null;
|
||||
var script = GetCurrentScriptForLineUpdate(parameters);
|
||||
if (script == null) return;
|
||||
if (script == null)
|
||||
{
|
||||
LogLineBehindWriterBoundary($"script output ({outputType ?? "combined"})");
|
||||
return;
|
||||
}
|
||||
|
||||
// PS-AGENT-OUTPUT captures both stdout and stderr in one pattern
|
||||
var output = match.Groups["output"]?.Value;
|
||||
@@ -507,7 +540,7 @@ namespace AutopilotMonitor.Agent.V2.Core.Monitoring.Enrollment.Ime
|
||||
|
||||
if (string.IsNullOrEmpty(id)) return;
|
||||
|
||||
CompletePlatformScriptFromImeResult(id, result, LastMatchedLogTimestamp, LastMatchedPatternId, CaptureLastMatchedProvenance());
|
||||
CompletePlatformScriptFromImeResult(id, result, LastMatchedLogTimestamp, LastMatchedPatternId, CaptureLastMatchedProvenance(), ImeUserIdFrom(match.Value));
|
||||
}
|
||||
|
||||
/// <summary>
|
||||
@@ -521,7 +554,7 @@ namespace AutopilotMonitor.Agent.V2.Core.Monitoring.Enrollment.Ime
|
||||
/// line reopened the slot, produced a fallback duplicate (session e7f3c910).
|
||||
/// <see cref="FlushPendingPlatformScriptResults"/> emits the held completion.
|
||||
/// </summary>
|
||||
internal void CompletePlatformScriptFromImeResult(string policyId, string result, DateTime? resultLineTimestampUtc, string patternId, CmTraceLineProvenance resultProvenance)
|
||||
internal void CompletePlatformScriptFromImeResult(string policyId, string result, DateTime? resultLineTimestampUtc, string patternId, CmTraceLineProvenance resultProvenance, string userId = null)
|
||||
{
|
||||
// Dedup: the deadline-based fallback (FlushPendingPlatformScriptResults) may already have
|
||||
// emitted this script from its AgentExecutor exit code because IME's authoritative
|
||||
@@ -558,11 +591,14 @@ namespace AutopilotMonitor.Agent.V2.Core.Monitoring.Enrollment.Ime
|
||||
script = new ScriptExecutionState
|
||||
{
|
||||
PolicyId = policyId,
|
||||
ScriptType = "platform"
|
||||
ScriptType = "platform",
|
||||
UserId = userId,
|
||||
};
|
||||
_pendingPlatformScripts[policyId] = script;
|
||||
ScriptRuns.NoteStarted(userId, policyId, UtcNowProvider());
|
||||
}
|
||||
|
||||
if (script.UserId == null && userId != null) script.UserId = userId;
|
||||
script.Result = result;
|
||||
script.ResultSource = "ime_policy_result";
|
||||
script.ResultObservedAtUtc = resultLineTimestampUtc ?? UtcNowProvider();
|
||||
@@ -591,7 +627,9 @@ namespace AutopilotMonitor.Agent.V2.Core.Monitoring.Enrollment.Ime
|
||||
private void EmitPlatformScriptResult(ScriptExecutionState script, string note = null)
|
||||
{
|
||||
_logger.Info($"ImeLogTracker: platform script completed: {script.PolicyId}, result={script.Result}, exit={script.ExitCode}{(note != null ? $" ({note})" : string.Empty)}");
|
||||
if (string.IsNullOrEmpty(script.RunId)) script.RunId = Guid.NewGuid().ToString("D");
|
||||
EmitScriptEvent(script);
|
||||
ScriptRuns.NoteEmitted(script, UtcNowProvider());
|
||||
// The run's source stamp, capped at the clock: a result line cannot be read before it
|
||||
// was written, so a stamp ahead of the clock is a wrong zone assumption on that line
|
||||
// (a rewound result resolved in the reader's zone, session 4377911b: +1 h). Left
|
||||
@@ -1163,11 +1201,11 @@ namespace AutopilotMonitor.Agent.V2.Core.Monitoring.Enrollment.Ime
|
||||
internal static readonly TimeSpan HeldScriptStartGrace = TimeSpan.FromMinutes(30);
|
||||
internal static readonly TimeSpan HeldScriptStartShutdownGrace = TimeSpan.FromMinutes(5);
|
||||
|
||||
private static string TruncateOutput(string output)
|
||||
internal static string TruncateOutput(string output)
|
||||
{
|
||||
if (string.IsNullOrEmpty(output) || output.Length <= MaxScriptOutputLength)
|
||||
return output;
|
||||
return output.Substring(0, MaxScriptOutputLength) + "...[truncated]";
|
||||
return output.Substring(0, MaxScriptOutputLength) + OutputTruncationMarker;
|
||||
}
|
||||
|
||||
// -----------------------------------------------------------------------
|
||||
|
||||
+22
-8
@@ -123,16 +123,18 @@ namespace AutopilotMonitor.Agent.V2.Core.Monitoring.Enrollment.Ime
|
||||
var ledger = IsMultiWriterLogFile(fileName) ? GetLedger(fileName) : null;
|
||||
|
||||
// Set by a rewind: entries that still read unchanged behind the old bookmark are
|
||||
// skipped, and nothing below the old bookmark is fresh or a calibration anchor.
|
||||
HashSet<LedgerEntry> rewoundEntries = null;
|
||||
// skipped (their invocation markers are given back), and nothing below the old
|
||||
// bookmark is fresh or a calibration anchor.
|
||||
RewindState rewind = null;
|
||||
long oldBookmark = -1;
|
||||
var writerBoundaries = IsWriterBoundaryLogFile(fileName);
|
||||
|
||||
if (ledger != null)
|
||||
{
|
||||
var rewindTo = await PrepareLedgerAsync(filePath, fileName, ledger, startPos, passNowUtc, token);
|
||||
if (rewindTo >= 0)
|
||||
{
|
||||
rewoundEntries = ApplyRewind(filePath, fileName, ledger, rewindTo, startPos);
|
||||
rewind = ApplyRewind(filePath, fileName, ledger, rewindTo, startPos);
|
||||
oldBookmark = startPos;
|
||||
startPos = rewindTo;
|
||||
}
|
||||
@@ -164,7 +166,7 @@ namespace AutopilotMonitor.Agent.V2.Core.Monitoring.Enrollment.Ime
|
||||
{
|
||||
// Guard zone: the file grew and is open anyway — re-check the entries just behind
|
||||
// the bookmark, where a stale writer's block lands when it is short.
|
||||
if (ledger != null && rewoundEntries == null && ledger.Entries.Count > 0)
|
||||
if (ledger != null && rewind == null && ledger.Entries.Count > 0)
|
||||
{
|
||||
var guardFrom = ledger.OffsetOfEntryAtOrAfter(startPos - OverwriteGuardBytes);
|
||||
if (guardFrom >= 0 && guardFrom < startPos)
|
||||
@@ -178,7 +180,7 @@ namespace AutopilotMonitor.Agent.V2.Core.Monitoring.Enrollment.Ime
|
||||
_verifiedBytes += startPos - ledger.StartOffset;
|
||||
_verifyPasses++;
|
||||
if (earliest >= 0) divergence = earliest;
|
||||
rewoundEntries = ApplyRewind(filePath, fileName, ledger, divergence, startPos);
|
||||
rewind = ApplyRewind(filePath, fileName, ledger, divergence, startPos);
|
||||
oldBookmark = startPos;
|
||||
startPos = divergence;
|
||||
}
|
||||
@@ -259,7 +261,7 @@ namespace AutopilotMonitor.Agent.V2.Core.Monitoring.Enrollment.Ime
|
||||
// A fragment right at the bookmark of a multi-writer file (the previous
|
||||
// entry ended exactly here, this one does not open an entry) is the tail of
|
||||
// a block a stale writer laid over already-read bytes: verify before reading on.
|
||||
if (ledger != null && rewoundEntries == null && entry.Offset == ledger.EndOffset
|
||||
if (ledger != null && rewind == null && entry.Offset == ledger.EndOffset
|
||||
&& ledger.LastFragmentOffset != entry.Offset && !entry.Text.StartsWith("<![LOG["))
|
||||
{
|
||||
ledger.VerifyRequested = true;
|
||||
@@ -270,8 +272,20 @@ namespace AutopilotMonitor.Agent.V2.Core.Monitoring.Enrollment.Ime
|
||||
}
|
||||
|
||||
if (ledger != null) ledger.Record(entry);
|
||||
if (rewoundEntries != null && rewoundEntries.Contains(new LedgerEntry { Offset = entry.Offset, Hash = entry.Hash }))
|
||||
continue; // unchanged behind the old bookmark — processed before the rewind
|
||||
var unchanged = rewind != null && rewind.IsUnchanged(entry);
|
||||
if (unchanged) RestoreInvocationMarkers(rewind, entry.Offset);
|
||||
|
||||
// Writer boundary (see ImeLogTracker.Overwrite.cs): an AgentExecutor.log entry that is
|
||||
// not exactly one CMTrace record ends the bytes of the executor in front of it. Never
|
||||
// matched — its text is the cut of two writers. Evaluated for unchanged entries too:
|
||||
// what owns the position in front of them may have changed with the rewind.
|
||||
if (writerBoundaries && !IsSingleCmTraceRecord(entry.Text))
|
||||
{
|
||||
CloseAtWriterBoundary(fileName, entry.Offset, entry.Text);
|
||||
continue;
|
||||
}
|
||||
|
||||
if (unchanged) continue; // unchanged behind the old bookmark — processed before the rewind
|
||||
|
||||
_currentPassLinesAreFresh = passLinesAreFresh && entry.Offset >= oldBookmark;
|
||||
|
||||
|
||||
+174
-31
@@ -293,13 +293,40 @@ namespace AutopilotMonitor.Agent.V2.Core.Monitoring.Enrollment.Ime
|
||||
}
|
||||
}
|
||||
|
||||
/// <summary>Moves the bookmark back to the first changed entry; returns the entries to skip if they still read unchanged behind it.</summary>
|
||||
private HashSet<LedgerEntry> ApplyRewind(string filePath, string fileName, FileLedger ledger, long rewindTo, long bookmark)
|
||||
/// <summary>
|
||||
/// What one rewind pass carries: the entries to skip if they still read unchanged behind the rewind point, and
|
||||
/// the invocation markers set aside there until their entries prove unchanged. Pass-local by design — whatever
|
||||
/// is not given back dies with the pass on every exit path.
|
||||
/// </summary>
|
||||
private sealed class RewindState
|
||||
{
|
||||
public RewindState(string fileName, HashSet<LedgerEntry> unchanged, List<InvocationMarker> markers, InvocationMarker lastPlatformMarker)
|
||||
{
|
||||
FileName = fileName;
|
||||
Unchanged = unchanged;
|
||||
Markers = markers;
|
||||
LastPlatformMarker = lastPlatformMarker;
|
||||
}
|
||||
|
||||
public string FileName { get; }
|
||||
public HashSet<LedgerEntry> Unchanged { get; }
|
||||
/// <summary>Set aside at the rewind, ascending by offset.</summary>
|
||||
public List<InvocationMarker> Markers { get; }
|
||||
/// <summary>The tracker-wide last platform marker, when it was among the set-aside ones.</summary>
|
||||
public InvocationMarker LastPlatformMarker { get; }
|
||||
public int Next { get; set; }
|
||||
|
||||
public bool IsUnchanged(AssembledEntry entry) => Unchanged.Contains(new LedgerEntry { Offset = entry.Offset, Hash = entry.Hash });
|
||||
}
|
||||
|
||||
/// <summary>Moves the bookmark back to the first changed entry; returns what the re-read needs to skip and to give back.</summary>
|
||||
private RewindState ApplyRewind(string filePath, string fileName, FileLedger ledger, long rewindTo, long bookmark)
|
||||
{
|
||||
var removed = ledger.TruncateFrom(rewindTo);
|
||||
_positionTracker.SetPosition(filePath, rewindTo);
|
||||
_heldTails.Remove(filePath);
|
||||
InvalidateInvocationMarkersFrom(fileName, rewindTo);
|
||||
var lastPlatformMarker = _lastPlatformMarker;
|
||||
var markers = TakeInvocationMarkersFrom(fileName, rewindTo, out var tookLastPlatformMarker);
|
||||
_overwriteRewinds++;
|
||||
_overwriteBytesReprocessed += bookmark - rewindTo;
|
||||
|
||||
@@ -314,7 +341,7 @@ namespace AutopilotMonitor.Agent.V2.Core.Monitoring.Enrollment.Ime
|
||||
{
|
||||
_logger.Debug(message);
|
||||
}
|
||||
return removed;
|
||||
return new RewindState(fileName, removed, markers, tookLastPlatformMarker ? lastPlatformMarker : null);
|
||||
}
|
||||
|
||||
private long RetentionFloor(string fileName, long bookmark)
|
||||
@@ -331,20 +358,35 @@ namespace AutopilotMonitor.Agent.V2.Core.Monitoring.Enrollment.Ime
|
||||
// -----------------------------------------------------------------------
|
||||
//
|
||||
// AgentExecutor.log carries "Powershell exit code is N" / "write output done" without a
|
||||
// policy id. Their owner is decided by FILE POSITION, not by the order lines were read:
|
||||
// an executor writes its end block at its own stream position, i.e. directly after its
|
||||
// own start block in the final bytes, so the nearest preceding invocation marker names
|
||||
// it — and stays right after a rewind re-reads that region. A marker is a platform start
|
||||
// (policy id), some other invocation (detection, remediation, requirement: null) or a
|
||||
// close ("gets invoked" banner, "Agent executor completed").
|
||||
// policy id. Their owner is decided by FILE POSITION: the nearest preceding marker — a
|
||||
// platform start (policy id), some other invocation (detection, remediation, requirement:
|
||||
// null), a close ("gets invoked" banner, "Agent executor completed") or a writer boundary.
|
||||
//
|
||||
// Every executor writes its lines contiguously from its own stream position, so its end
|
||||
// block follows its own start block — but that start block may be gone. Two executors that
|
||||
// open the file at the same end write their start blocks over each other, and the end block
|
||||
// of the one that lost then sits behind the OTHER executor's start block (session 756970cf:
|
||||
// a detection script's exit code and output on a platform script). Where one writer's bytes
|
||||
// meet another's, the cut leaves an entry that is not exactly one CMTrace record — a
|
||||
// fragment, a merged line or an empty line — unless the line boundaries of both writers
|
||||
// coincide byte-exactly. That writer boundary closes the platform invocation in front of it.
|
||||
// AgentExecutor.log only: in the IME log the service writes the markers and the lines they
|
||||
// own itself, and its fragments are executor telemetry lines.
|
||||
//
|
||||
// A marker lives exactly as long as the bytes of its entry: a rewind sets the markers from
|
||||
// the rewind point on aside, and an entry that reads unchanged gets its markers back.
|
||||
|
||||
private sealed class InvocationMarker
|
||||
{
|
||||
public long Offset;
|
||||
public string PolicyId;
|
||||
public bool IsClose;
|
||||
/// <summary>Set on a writer boundary: the platform invocation it closed.</summary>
|
||||
public string ClosedPolicyId;
|
||||
}
|
||||
|
||||
private const string ExecutorLogFileName = "AgentExecutor.log";
|
||||
|
||||
private readonly Dictionary<string, List<InvocationMarker>> _invocationMarkers =
|
||||
new Dictionary<string, List<InvocationMarker>>(StringComparer.OrdinalIgnoreCase);
|
||||
private InvocationMarker _lastPlatformMarker;
|
||||
@@ -354,22 +396,59 @@ namespace AutopilotMonitor.Agent.V2.Core.Monitoring.Enrollment.Ime
|
||||
private readonly HashSet<string> _platformMarkerFiles = new HashSet<string>(StringComparer.OrdinalIgnoreCase);
|
||||
private long _testEntryOrdinal;
|
||||
|
||||
private void RecordInvocationMarker(string policyId, bool isClose)
|
||||
/// <summary>
|
||||
/// The executor log, live or rotated (<c>AgentExecutor-yyyyMMdd-HHmmss.log</c>): its invocations are one process
|
||||
/// each, so a writer boundary ends an invocation — in the final bytes of a rotation as much as in the live file.
|
||||
/// </summary>
|
||||
internal static bool IsWriterBoundaryLogFile(string fileName)
|
||||
=> string.Equals(fileName, ExecutorLogFileName, StringComparison.OrdinalIgnoreCase)
|
||||
|| (fileName != null
|
||||
&& fileName.StartsWith("AgentExecutor-", StringComparison.OrdinalIgnoreCase)
|
||||
&& fileName.EndsWith(".log", StringComparison.OrdinalIgnoreCase));
|
||||
|
||||
/// <summary>
|
||||
/// True when the entry is exactly one CMTrace record: it opens with <c><![LOG[</c> (culture-sensitive like
|
||||
/// <c>CmTraceLogParser.TryParseLine</c>, so a BOM is ignorable) and holds no second one — the parser takes the
|
||||
/// message up to the LAST trailer, so a line cut anywhere, its trailer included, would swallow the record
|
||||
/// written over it. An empty entry is the terminator of a cut line. A script whose own output contains the
|
||||
/// open tag loses that output line: the bytes cannot tell it from a merged line.
|
||||
/// </summary>
|
||||
internal static bool IsSingleCmTraceRecord(string text)
|
||||
{
|
||||
if (string.IsNullOrEmpty(text) || !text.StartsWith(LogOpenTag)) return false;
|
||||
var first = text.IndexOf(LogOpenTag, StringComparison.Ordinal);
|
||||
return first >= 0 && text.IndexOf(LogOpenTag, first + LogOpenTag.Length, StringComparison.Ordinal) < 0;
|
||||
}
|
||||
|
||||
private List<InvocationMarker> GetOrCreateMarkerList(string file)
|
||||
{
|
||||
if (_currentEntryOffset < 0) return;
|
||||
var file = _currentSourceFileName ?? TestSourceFileName;
|
||||
List<InvocationMarker> list;
|
||||
if (!_invocationMarkers.TryGetValue(file, out list))
|
||||
{
|
||||
list = new List<InvocationMarker>();
|
||||
_invocationMarkers[file] = list;
|
||||
}
|
||||
return list;
|
||||
}
|
||||
|
||||
private static void AppendInvocationMarker(List<InvocationMarker> list, InvocationMarker marker)
|
||||
{
|
||||
if (list.Count >= MaxInvocationMarkersPerFile) list.RemoveAt(0);
|
||||
list.Add(marker);
|
||||
}
|
||||
|
||||
private void RecordInvocationMarker(string policyId, bool isClose)
|
||||
{
|
||||
if (_currentEntryOffset < 0) return;
|
||||
var file = _currentSourceFileName ?? TestSourceFileName;
|
||||
var list = GetOrCreateMarkerList(file);
|
||||
|
||||
if (list.Count > 0 && list[list.Count - 1].Offset == _currentEntryOffset)
|
||||
{
|
||||
// Two patterns on one line: the platform start outranks the generic argument line.
|
||||
// A writer boundary is never upgraded.
|
||||
var last = list[list.Count - 1];
|
||||
if (!isClose && policyId != null)
|
||||
if (!isClose && policyId != null && last.ClosedPolicyId == null)
|
||||
{
|
||||
last.PolicyId = policyId;
|
||||
last.IsClose = false;
|
||||
@@ -379,9 +458,8 @@ namespace AutopilotMonitor.Agent.V2.Core.Monitoring.Enrollment.Ime
|
||||
return;
|
||||
}
|
||||
|
||||
if (list.Count >= MaxInvocationMarkersPerFile) list.RemoveAt(0);
|
||||
var marker = new InvocationMarker { Offset = _currentEntryOffset, PolicyId = policyId, IsClose = isClose };
|
||||
list.Add(marker);
|
||||
AppendInvocationMarker(list, marker);
|
||||
if (!isClose && policyId != null)
|
||||
{
|
||||
_lastPlatformMarker = marker;
|
||||
@@ -390,21 +468,34 @@ namespace AutopilotMonitor.Agent.V2.Core.Monitoring.Enrollment.Ime
|
||||
}
|
||||
|
||||
/// <summary>
|
||||
/// The pending platform script that owns the entry being processed, or null.
|
||||
/// <paramref name="ownerPolicyId"/> names the owning platform script even when its slot is
|
||||
/// gone (completion already emitted); null when no platform invocation owns the entry.
|
||||
/// An entry of <paramref name="fileName"/> at <paramref name="offset"/> that is not exactly one CMTrace record:
|
||||
/// the bytes behind it were written by another process than the bytes in front of it. Closes the platform
|
||||
/// invocation that owns the position; records nothing when none is open there (a cut multi-line output yields
|
||||
/// one fragment per line). Idempotent at the same offset.
|
||||
/// </summary>
|
||||
private ScriptExecutionState ResolvePlatformScriptForCurrentEntry(out string ownerPolicyId)
|
||||
private void CloseAtWriterBoundary(string fileName, long offset, string text)
|
||||
{
|
||||
var owner = FindOwningMarker(fileName, offset);
|
||||
if (owner == null || owner.IsClose || owner.PolicyId == null) return;
|
||||
|
||||
var list = GetOrCreateMarkerList(fileName);
|
||||
if (list.Count > 0 && list[list.Count - 1].Offset >= offset) return;
|
||||
AppendInvocationMarker(list, new InvocationMarker { Offset = offset, IsClose = true, ClosedPolicyId = owner.PolicyId });
|
||||
|
||||
var kind = string.IsNullOrEmpty(text) ? "empty line" : text.StartsWith(LogOpenTag) ? "merged line" : "fragment";
|
||||
_logger.Debug($"ImeLogTracker: writer boundary in {fileName} at offset {offset} ({kind}, {text?.Length ?? 0} chars) closes platform script {owner.PolicyId} (opened at {owner.Offset}) — the bytes behind it belong to another executor");
|
||||
}
|
||||
|
||||
/// <summary>The marker that owns <paramref name="offset"/> in <paramref name="file"/>, or null.</summary>
|
||||
private InvocationMarker FindOwningMarker(string file, long offset)
|
||||
{
|
||||
ownerPolicyId = null;
|
||||
var file = _currentSourceFileName ?? TestSourceFileName;
|
||||
InvocationMarker marker = null;
|
||||
List<InvocationMarker> list = null;
|
||||
if (_currentEntryOffset >= 0 && _invocationMarkers.TryGetValue(file, out list))
|
||||
if (offset >= 0 && _invocationMarkers.TryGetValue(file, out list))
|
||||
{
|
||||
for (var i = list.Count - 1; i >= 0; i--)
|
||||
{
|
||||
if (list[i].Offset <= _currentEntryOffset)
|
||||
if (list[i].Offset <= offset)
|
||||
{
|
||||
marker = list[i];
|
||||
break;
|
||||
@@ -420,6 +511,18 @@ namespace AutopilotMonitor.Agent.V2.Core.Monitoring.Enrollment.Ime
|
||||
// (session 24dc69d1: the health-script worker's exit line pre-filled a platform slot's
|
||||
// exit code, its launch line the slot's context).
|
||||
if (marker == null && (list == null || list.Count == 0) && _platformMarkerFiles.Contains(file)) marker = _lastPlatformMarker;
|
||||
return marker;
|
||||
}
|
||||
|
||||
/// <summary>
|
||||
/// The pending platform script that owns the entry being processed, or null.
|
||||
/// <paramref name="ownerPolicyId"/> names the owning platform script even when its slot is
|
||||
/// gone (completion already emitted); null when no platform invocation owns the entry.
|
||||
/// </summary>
|
||||
private ScriptExecutionState ResolvePlatformScriptForCurrentEntry(out string ownerPolicyId)
|
||||
{
|
||||
ownerPolicyId = null;
|
||||
var marker = FindOwningMarker(_currentSourceFileName ?? TestSourceFileName, _currentEntryOffset);
|
||||
if (marker == null || marker.IsClose || marker.PolicyId == null) return null;
|
||||
|
||||
ownerPolicyId = marker.PolicyId;
|
||||
@@ -427,17 +530,32 @@ namespace AutopilotMonitor.Agent.V2.Core.Monitoring.Enrollment.Ime
|
||||
return _pendingPlatformScripts.TryGetValue(marker.PolicyId, out state) ? state : null;
|
||||
}
|
||||
|
||||
private void InvalidateInvocationMarkersFrom(string fileName, long offset)
|
||||
/// <summary>Debug trace for an executor line that a writer boundary kept away from a platform script.</summary>
|
||||
private void LogLineBehindWriterBoundary(string what)
|
||||
{
|
||||
var marker = FindOwningMarker(_currentSourceFileName ?? TestSourceFileName, _currentEntryOffset);
|
||||
if (marker?.ClosedPolicyId == null) return;
|
||||
_logger.Debug($"ImeLogTracker: {what} at offset {_currentEntryOffset} lies behind the writer boundary at {marker.Offset} that closed platform script {marker.ClosedPolicyId} — another executor's end block, not attributed");
|
||||
}
|
||||
|
||||
/// <summary>Removes the markers from <paramref name="offset"/> on and returns them in offset order.</summary>
|
||||
private List<InvocationMarker> TakeInvocationMarkersFrom(string fileName, long offset, out bool tookLastPlatformMarker)
|
||||
{
|
||||
tookLastPlatformMarker = false;
|
||||
var taken = new List<InvocationMarker>();
|
||||
List<InvocationMarker> list;
|
||||
if (!_invocationMarkers.TryGetValue(fileName, out list) || list.Count == 0) return;
|
||||
var removedLast = false;
|
||||
for (var i = list.Count - 1; i >= 0 && list[i].Offset >= offset; i--)
|
||||
if (!_invocationMarkers.TryGetValue(fileName, out list) || list.Count == 0) return taken;
|
||||
|
||||
var from = list.Count;
|
||||
while (from > 0 && list[from - 1].Offset >= offset) from--;
|
||||
for (var i = from; i < list.Count; i++)
|
||||
{
|
||||
if (ReferenceEquals(list[i], _lastPlatformMarker)) removedLast = true;
|
||||
list.RemoveAt(i);
|
||||
if (ReferenceEquals(list[i], _lastPlatformMarker)) tookLastPlatformMarker = true;
|
||||
taken.Add(list[i]);
|
||||
}
|
||||
if (removedLast)
|
||||
list.RemoveRange(from, list.Count - from);
|
||||
|
||||
if (tookLastPlatformMarker)
|
||||
{
|
||||
_lastPlatformMarker = null;
|
||||
for (var i = list.Count - 1; i >= 0; i--)
|
||||
@@ -449,6 +567,28 @@ namespace AutopilotMonitor.Agent.V2.Core.Monitoring.Enrollment.Ime
|
||||
}
|
||||
}
|
||||
}
|
||||
return taken;
|
||||
}
|
||||
|
||||
private void InvalidateInvocationMarkersFrom(string fileName, long offset) => TakeInvocationMarkersFrom(fileName, offset, out _);
|
||||
|
||||
/// <summary>
|
||||
/// An entry that reads unchanged after a rewind keeps its markers: gives back the set-aside markers at exactly
|
||||
/// <paramref name="entryOffset"/>. Set-aside markers in front of it belonged to entries that changed and stay
|
||||
/// gone with their bytes.
|
||||
/// </summary>
|
||||
private void RestoreInvocationMarkers(RewindState rewind, long entryOffset)
|
||||
{
|
||||
var markers = rewind.Markers;
|
||||
while (rewind.Next < markers.Count && markers[rewind.Next].Offset < entryOffset) rewind.Next++;
|
||||
while (rewind.Next < markers.Count && markers[rewind.Next].Offset == entryOffset)
|
||||
{
|
||||
var marker = markers[rewind.Next++];
|
||||
var list = GetOrCreateMarkerList(rewind.FileName);
|
||||
if (list.Count > 0 && list[list.Count - 1].Offset >= marker.Offset) continue;
|
||||
AppendInvocationMarker(list, marker);
|
||||
if (ReferenceEquals(marker, rewind.LastPlatformMarker)) _lastPlatformMarker = marker;
|
||||
}
|
||||
}
|
||||
|
||||
private long OldestPendingScriptMarkerOffset(string fileName)
|
||||
@@ -474,6 +614,9 @@ namespace AutopilotMonitor.Agent.V2.Core.Monitoring.Enrollment.Ime
|
||||
/// <summary>What a rollover of the file does to its invocation markers.</summary>
|
||||
internal void ClearInvocationMarkersForTest(string fileName) => InvalidateInvocationMarkersFrom(fileName, 0);
|
||||
|
||||
internal int InvocationMarkerCountForTest(string fileName)
|
||||
=> _invocationMarkers.TryGetValue(fileName, out var list) ? list.Count : 0;
|
||||
|
||||
internal int LedgerEntryCountForTest(string fileName)
|
||||
{
|
||||
FileLedger ledger;
|
||||
|
||||
+20
-1
@@ -182,6 +182,12 @@ namespace AutopilotMonitor.Agent.V2.Core.Monitoring.Enrollment.Ime
|
||||
private readonly Dictionary<string, ScriptExecutionState> _pendingPlatformScripts =
|
||||
new Dictionary<string, ScriptExecutionState>(StringComparer.OrdinalIgnoreCase);
|
||||
|
||||
/// <summary>
|
||||
/// The platform runs this tracker started and emitted, for the registry reconciliation that
|
||||
/// checks them against IME's saved results (D-316). Shared with the registry host's thread.
|
||||
/// </summary>
|
||||
internal PlatformScriptRunRegister ScriptRuns { get; } = new PlatformScriptRunRegister();
|
||||
|
||||
// Health-script (remediation) line-by-line accumulator — single slot because IME
|
||||
// executes health scripts SEQUENTIALLY within a session (verified across multiple
|
||||
// diagnostic captures: ProcessScript → context → exit → stdout → stderr → compliance,
|
||||
@@ -240,7 +246,8 @@ namespace AutopilotMonitor.Agent.V2.Core.Monitoring.Enrollment.Ime
|
||||
// the 32K-char Table Storage property limit that bounds the event downstream. Growth
|
||||
// driver is the number of log lines the bootstrap chain writes, so re-measure before
|
||||
// adding a chatty step rather than raising this again.
|
||||
private const int MaxScriptOutputLength = 8192;
|
||||
internal const int MaxScriptOutputLength = 8192;
|
||||
internal const string OutputTruncationMarker = "...[truncated]";
|
||||
private const int MaxMultiLineBufferLines = 100;
|
||||
// Size cap for ONE entry — a single physical line (enforced by BoundedLineReader before
|
||||
// the line is materialized) and an assembled multiline entry alike. Any process able to
|
||||
@@ -389,6 +396,8 @@ namespace AutopilotMonitor.Agent.V2.Core.Monitoring.Enrollment.Ime
|
||||
VerifiedBytes = _verifiedBytes,
|
||||
PassMaxMs = _passMaxMs,
|
||||
PassGapMaxMs = _passGapMaxMs,
|
||||
PlatformOutputVerified = ScriptRuns.Verified,
|
||||
PlatformOutputCorrected = ScriptRuns.Corrected,
|
||||
PatternHits = new Dictionary<string, int>(_patternHits, StringComparer.OrdinalIgnoreCase),
|
||||
};
|
||||
}
|
||||
@@ -1034,6 +1043,7 @@ namespace AutopilotMonitor.Agent.V2.Core.Monitoring.Enrollment.Ime
|
||||
internal async Task RunPollPassAsync(CancellationToken token)
|
||||
{
|
||||
var startMs = MonotonicMillisProvider();
|
||||
var passStartedUtc = UtcNowProvider();
|
||||
if (_lastPassEndMs >= 0 && startMs - _lastPassEndMs > _passGapMaxMs)
|
||||
{
|
||||
_passGapMaxMs = startMs - _lastPassEndMs;
|
||||
@@ -1045,6 +1055,12 @@ namespace AutopilotMonitor.Agent.V2.Core.Monitoring.Enrollment.Ime
|
||||
FlushRecurringScripts(UtcNowProvider(), shuttingDown: false);
|
||||
CheckPendingTokenFailure(UtcNowProvider());
|
||||
|
||||
// The lines written before this pass started are read now — a held tail or a fragment
|
||||
// awaiting its check follows a pass or two later, which TrackerCatchUp covers. The
|
||||
// registry reconciliation waits for such a pass before it pairs an IME save with a run.
|
||||
if (!token.IsCancellationRequested) ScriptRuns.NotePassCompleted(passStartedUtc);
|
||||
if (ScriptRuns.ConsumeCountersChanged()) _stateDirty = true;
|
||||
|
||||
var endMs = MonotonicMillisProvider();
|
||||
if (endMs - startMs > _passMaxMs)
|
||||
{
|
||||
@@ -1207,6 +1223,7 @@ namespace AutopilotMonitor.Agent.V2.Core.Monitoring.Enrollment.Ime
|
||||
_verifiedBytes = state.Health.VerifiedBytes;
|
||||
_passMaxMs = state.Health.PassMaxMs;
|
||||
_passGapMaxMs = state.Health.PassGapMaxMs;
|
||||
ScriptRuns.RestoreCounters(state.Health.PlatformOutputVerified, state.Health.PlatformOutputCorrected);
|
||||
}
|
||||
if (state.PatternHits != null)
|
||||
{
|
||||
@@ -1283,6 +1300,8 @@ namespace AutopilotMonitor.Agent.V2.Core.Monitoring.Enrollment.Ime
|
||||
VerifiedBytes = _verifiedBytes,
|
||||
PassMaxMs = _passMaxMs,
|
||||
PassGapMaxMs = _passGapMaxMs,
|
||||
PlatformOutputVerified = ScriptRuns.Verified,
|
||||
PlatformOutputCorrected = ScriptRuns.Corrected,
|
||||
};
|
||||
state.PatternHits = new Dictionary<string, int>(_patternHits, StringComparer.OrdinalIgnoreCase);
|
||||
}
|
||||
|
||||
+10
@@ -81,6 +81,16 @@ namespace AutopilotMonitor.Agent.V2.Core.Monitoring.Enrollment.Ime
|
||||
/// </summary>
|
||||
public long PassGapMaxMs { get; set; }
|
||||
|
||||
/// <summary>
|
||||
/// Platform-script runs whose emitted output IME's saved result (registry, after the batch
|
||||
/// report) confirmed — the exit code of the same end block with it. Together with
|
||||
/// <see cref="PlatformOutputCorrected"/> the field measure of the registry reconciliation (D-316).
|
||||
/// </summary>
|
||||
public long PlatformOutputVerified { get; set; }
|
||||
|
||||
/// <summary>Platform-script runs whose emitted output IME's saved result corrected (script_output_reconciliation).</summary>
|
||||
public long PlatformOutputCorrected { get; set; }
|
||||
|
||||
/// <summary>Match count per enabled pattern ID — every enabled pattern is present, zeros included.</summary>
|
||||
public IReadOnlyDictionary<string, int> PatternHits { get; set; }
|
||||
|
||||
|
||||
+3
@@ -185,6 +185,9 @@ namespace AutopilotMonitor.Agent.V2.Core.Monitoring.Enrollment.Ime
|
||||
// Poll-loop timing maxima (null-defaulting on older state files).
|
||||
public long PassMaxMs { get; set; }
|
||||
public long PassGapMaxMs { get; set; }
|
||||
// Registry reconciliation of platform-script output (null-defaulting on older state files).
|
||||
public long PlatformOutputVerified { get; set; }
|
||||
public long PlatformOutputCorrected { get; set; }
|
||||
}
|
||||
|
||||
public class PackageStateData
|
||||
|
||||
+193
@@ -0,0 +1,193 @@
|
||||
using System;
|
||||
using System.Collections.Generic;
|
||||
|
||||
namespace AutopilotMonitor.Agent.V2.Core.Monitoring.Enrollment.Ime
|
||||
{
|
||||
/// <summary>What the registry reconciliation may do with a saved IME result right now.</summary>
|
||||
internal enum PlatformRunClaim
|
||||
{
|
||||
/// <summary>The run is handed out for reconciliation; it is never handed out again.</summary>
|
||||
Claimed,
|
||||
/// <summary>Not decidable yet: the tracker has not read past the save, or the run is not emitted yet.</summary>
|
||||
Wait,
|
||||
/// <summary>No run of this agent owns the save (none seen, or already reconciled).</summary>
|
||||
None,
|
||||
}
|
||||
|
||||
/// <summary>One platform-script run as the tracker emitted it; the register hands out copies.</summary>
|
||||
internal sealed class PlatformScriptRun
|
||||
{
|
||||
public string PolicyId;
|
||||
public string UserId;
|
||||
public string RunId;
|
||||
public DateTime StartSeenUtc;
|
||||
public bool Emitted;
|
||||
public bool Claimed;
|
||||
public string Result;
|
||||
public string ResultSource;
|
||||
public int? ExitCode;
|
||||
/// <summary>As emitted: null when no output line of the run was read, empty when it said so.</summary>
|
||||
public string Stdout;
|
||||
public string Stderr;
|
||||
|
||||
public PlatformScriptRun Clone() => (PlatformScriptRun)MemberwiseClone();
|
||||
}
|
||||
|
||||
/// <summary>
|
||||
/// The platform-script runs the tracker has seen, the latest per (IME user id, policy id), for the
|
||||
/// registry reconciliation (D-316). IME saves a run's output under
|
||||
/// <c>Policies\<UserId>\<PolicyId></c> only after it reported the whole script batch, so the
|
||||
/// observer reading it must know which run a changed key belongs to and what was emitted for it.
|
||||
/// Written on the tracker's poll thread, claimed on the registry host's timer thread: every member
|
||||
/// locks, and nothing calls out while holding the lock.
|
||||
/// <para>
|
||||
/// A save belongs to the latest run of its key: IME runs a policy once per batch and saves the
|
||||
/// batch after its last script, so the next run of the same key starts minutes later at the
|
||||
/// earliest. A save is paired only after the tracker completed a pass that started
|
||||
/// <see cref="TrackerCatchUp"/> after the save was seen — every line written before the save, the
|
||||
/// run's start among them, has been read by then, a stalled poll loop included.
|
||||
/// </para>
|
||||
/// </summary>
|
||||
internal sealed class PlatformScriptRunRegister
|
||||
{
|
||||
/// <summary>
|
||||
/// How far behind a seen save the tracker must have started a completed pass before the save
|
||||
/// is paired; covers the ledger's verify cadence (1 s) for a start line hidden by an overwrite.
|
||||
/// </summary>
|
||||
internal static readonly TimeSpan TrackerCatchUp = TimeSpan.FromSeconds(2);
|
||||
|
||||
internal const int MaxRuns = 256;
|
||||
|
||||
private readonly object _sync = new object();
|
||||
private readonly Dictionary<string, PlatformScriptRun> _latest =
|
||||
new Dictionary<string, PlatformScriptRun>(StringComparer.OrdinalIgnoreCase);
|
||||
private DateTime _lastCompletedPassStartUtc = DateTime.MinValue;
|
||||
private long _verified;
|
||||
private long _corrected;
|
||||
private bool _countersChanged;
|
||||
|
||||
private static string KeyOf(string userId, string policyId) => (userId ?? string.Empty) + "|" + policyId;
|
||||
|
||||
/// <summary>A platform run began: its start line, or its result when no start line was seen.</summary>
|
||||
public void NoteStarted(string userId, string policyId, DateTime seenUtc)
|
||||
{
|
||||
if (string.IsNullOrEmpty(policyId)) return;
|
||||
lock (_sync)
|
||||
{
|
||||
_latest[KeyOf(userId, policyId)] = new PlatformScriptRun { PolicyId = policyId, UserId = userId, StartSeenUtc = seenUtc };
|
||||
TrimLocked();
|
||||
}
|
||||
}
|
||||
|
||||
/// <summary>The tracker emitted the run with these end-block values.</summary>
|
||||
public void NoteEmitted(ScriptExecutionState script, DateTime emittedUtc)
|
||||
{
|
||||
if (script == null || string.IsNullOrEmpty(script.PolicyId)) return;
|
||||
lock (_sync)
|
||||
{
|
||||
var key = KeyOf(script.UserId, script.PolicyId);
|
||||
if (!_latest.TryGetValue(key, out var run) || run.Emitted)
|
||||
{
|
||||
run = new PlatformScriptRun { PolicyId = script.PolicyId, UserId = script.UserId, StartSeenUtc = emittedUtc };
|
||||
_latest[key] = run;
|
||||
}
|
||||
run.Emitted = true;
|
||||
run.RunId = script.RunId;
|
||||
run.Result = script.Result;
|
||||
run.ResultSource = script.ResultSource;
|
||||
run.ExitCode = script.ExitCode;
|
||||
run.Stdout = script.Stdout;
|
||||
run.Stderr = script.Stderr;
|
||||
TrimLocked();
|
||||
}
|
||||
}
|
||||
|
||||
/// <summary>The tracker finished a poll pass that started at <paramref name="passStartedUtc"/>.</summary>
|
||||
public void NotePassCompleted(DateTime passStartedUtc)
|
||||
{
|
||||
lock (_sync)
|
||||
{
|
||||
if (passStartedUtc > _lastCompletedPassStartUtc) _lastCompletedPassStartUtc = passStartedUtc;
|
||||
}
|
||||
}
|
||||
|
||||
/// <summary>
|
||||
/// Hands out the run a save of (<paramref name="userId"/>, <paramref name="policyId"/>) seen at
|
||||
/// <paramref name="savedSeenUtc"/> belongs to — once. A run whose user id the tracker could not
|
||||
/// read is keyed without one.
|
||||
/// </summary>
|
||||
public PlatformRunClaim TryClaim(string userId, string policyId, DateTime savedSeenUtc, out PlatformScriptRun run)
|
||||
{
|
||||
run = null;
|
||||
lock (_sync)
|
||||
{
|
||||
if (_lastCompletedPassStartUtc < savedSeenUtc + TrackerCatchUp) return PlatformRunClaim.Wait;
|
||||
|
||||
if (!_latest.TryGetValue(KeyOf(userId, policyId), out var latest)
|
||||
&& !_latest.TryGetValue(KeyOf(null, policyId), out latest))
|
||||
return PlatformRunClaim.None;
|
||||
if (latest.Claimed) return PlatformRunClaim.None;
|
||||
if (!latest.Emitted) return PlatformRunClaim.Wait;
|
||||
|
||||
latest.Claimed = true;
|
||||
run = latest.Clone();
|
||||
return PlatformRunClaim.Claimed;
|
||||
}
|
||||
}
|
||||
|
||||
public void CountVerified()
|
||||
{
|
||||
lock (_sync) { _verified++; _countersChanged = true; }
|
||||
}
|
||||
|
||||
public void CountCorrected()
|
||||
{
|
||||
lock (_sync) { _corrected++; _countersChanged = true; }
|
||||
}
|
||||
|
||||
/// <summary>Runs whose emitted output IME's saved result confirmed (restart-safe, session-cumulative).</summary>
|
||||
public long Verified { get { lock (_sync) return _verified; } }
|
||||
|
||||
/// <summary>Runs whose emitted output IME's saved result corrected (restart-safe, session-cumulative).</summary>
|
||||
public long Corrected { get { lock (_sync) return _corrected; } }
|
||||
|
||||
public void RestoreCounters(long verified, long corrected)
|
||||
{
|
||||
lock (_sync)
|
||||
{
|
||||
_verified = verified;
|
||||
_corrected = corrected;
|
||||
}
|
||||
}
|
||||
|
||||
/// <summary>True once after a counter moved — the tracker then persists its state.</summary>
|
||||
public bool ConsumeCountersChanged()
|
||||
{
|
||||
lock (_sync)
|
||||
{
|
||||
var changed = _countersChanged;
|
||||
_countersChanged = false;
|
||||
return changed;
|
||||
}
|
||||
}
|
||||
|
||||
private void TrimLocked()
|
||||
{
|
||||
while (_latest.Count > MaxRuns)
|
||||
{
|
||||
string oldestKey = null;
|
||||
var oldest = DateTime.MaxValue;
|
||||
foreach (var kv in _latest)
|
||||
{
|
||||
if (kv.Value.StartSeenUtc < oldest)
|
||||
{
|
||||
oldest = kv.Value.StartSeenUtc;
|
||||
oldestKey = kv.Key;
|
||||
}
|
||||
}
|
||||
if (oldestKey == null) return;
|
||||
_latest.Remove(oldestKey);
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
+13
@@ -15,6 +15,19 @@ public class ScriptExecutionState
|
||||
/// <summary>"platform" or "remediation".</summary>
|
||||
public string ScriptType { get; set; }
|
||||
|
||||
/// <summary>
|
||||
/// IME user id a platform script ran for (the all-zero GUID in device context), read from its
|
||||
/// script path or its result line. Keys IME's saved result
|
||||
/// (<c>Policies\<UserId>\<PolicyId></c>) that the registry reconciliation compares against.
|
||||
/// </summary>
|
||||
public string UserId { get; set; }
|
||||
|
||||
/// <summary>
|
||||
/// Identity of one emitted platform-script run, surfaced as <c>runId</c> on the event: what a
|
||||
/// later <c>script_output_reconciliation</c> names when it corrects that run.
|
||||
/// </summary>
|
||||
public string RunId { get; set; }
|
||||
|
||||
/// <summary>
|
||||
/// UTC timestamp of the script's first observed start line, taken from the source CMTrace log
|
||||
/// timestamp (so it dates correctly even when the agent replays historic IME log content that
|
||||
|
||||
+2
-1
@@ -413,7 +413,8 @@ namespace AutopilotMonitor.Agent.V2.Core.Monitoring.Enrollment.SystemSignals
|
||||
_tenantId,
|
||||
_post,
|
||||
_logger,
|
||||
_helloTracker);
|
||||
_helloTracker,
|
||||
stateDirectory: _stateDirectory);
|
||||
_shellCoreTracker.FinalizingSetupPhaseTriggered += OnFinalizingSetupPhaseTriggered;
|
||||
_shellCoreTracker.WhiteGloveCompleted += OnWhiteGloveCompleted;
|
||||
_shellCoreTracker.EspFailureDetected += OnShellCoreEspFailureDetected;
|
||||
|
||||
+401
@@ -0,0 +1,401 @@
|
||||
#nullable enable
|
||||
using System;
|
||||
using System.Collections.Generic;
|
||||
using System.Globalization;
|
||||
using System.Linq;
|
||||
using System.Text.Json;
|
||||
using AutopilotMonitor.Agent.V2.Core.Logging;
|
||||
using AutopilotMonitor.Agent.V2.Core.Monitoring.Enrollment.Ime;
|
||||
using AutopilotMonitor.Agent.V2.Core.Orchestration;
|
||||
using AutopilotMonitor.DecisionCore.Engine;
|
||||
using AutopilotMonitor.Shared.Models;
|
||||
using Microsoft.Win32;
|
||||
using SharedEventTypes = AutopilotMonitor.Shared.Constants.EventTypes;
|
||||
|
||||
namespace AutopilotMonitor.Agent.V2.Core.Monitoring.Enrollment.SystemSignals
|
||||
{
|
||||
/// <summary>
|
||||
/// Registry second pillar for platform scripts (D-316). After IME reported a script batch to
|
||||
/// Intune it saves every run of the batch under
|
||||
/// <c>HKLM\SOFTWARE\Microsoft\IntuneManagementExtension\Policies\<UserId>\<PolicyId></c>:
|
||||
/// <c>Result</c>, <c>ErrorCode</c> and <c>ResultDetails</c>, whose <c>ExecutionMsg</c> is what IME read
|
||||
/// from the result file of exactly that policy — the stdout when the run succeeded (IME's Success
|
||||
/// means an empty stderr file, whatever the exit code), the stderr when it failed with ErrorCode 99.
|
||||
/// The log tracker assigns a run's exit code and output by file position in AgentExecutor.log, where
|
||||
/// no policy id anchors them; this observer checks what was emitted against the keyed value and
|
||||
/// emits <c>script_output_reconciliation</c> when they disagree.
|
||||
/// <para>
|
||||
/// Snapshot-and-diff like <see cref="ImeRegistryAppStateObserver"/>, ticked by the same host: the
|
||||
/// first tick is the silent baseline, a later save is paired with its run through
|
||||
/// <see cref="PlatformScriptRunRegister"/>. No exit code lives in the registry: a run whose output
|
||||
/// matches proves the exit code of the same end block; a contradicted run loses its exit code.
|
||||
/// </para>
|
||||
/// </summary>
|
||||
internal sealed class ImeRegistryScriptResultObserver
|
||||
{
|
||||
public const string SourceLabel = "RegistryScriptResult";
|
||||
|
||||
internal const string PoliciesKeyPath = ImeRegistryAppStateObserver.ImeRootKeyPath + @"\Policies";
|
||||
|
||||
/// <summary>A save whose run never became claimable is dropped after this long (send failure of a later batch, agent restart).</summary>
|
||||
internal static readonly TimeSpan PendingExpiry = TimeSpan.FromMinutes(10);
|
||||
|
||||
/// <summary>Safety cap on correction events per agent run; corrections beyond it are counted only.</summary>
|
||||
internal const int MaxCorrectionsPerSession = 100;
|
||||
|
||||
private readonly PlatformScriptRunRegister _runs;
|
||||
private readonly Func<IReadOnlyDictionary<string, SavedScriptResult>> _snapshotSource;
|
||||
private readonly InformationalEventPost _post;
|
||||
private readonly AgentLogger? _logger;
|
||||
private readonly IClock _clock;
|
||||
private readonly object _sync = new object();
|
||||
|
||||
private IReadOnlyDictionary<string, SavedScriptResult>? _last;
|
||||
private readonly Dictionary<string, (SavedScriptResult Saved, DateTime SeenUtc)> _pending =
|
||||
new Dictionary<string, (SavedScriptResult, DateTime)>(StringComparer.OrdinalIgnoreCase);
|
||||
private int _correctionsEmitted;
|
||||
|
||||
/// <param name="snapshotSource">Replaces the live registry walk in tests; per instance, so parallel test classes never share it.</param>
|
||||
public ImeRegistryScriptResultObserver(
|
||||
PlatformScriptRunRegister runs,
|
||||
InformationalEventPost post,
|
||||
AgentLogger? logger,
|
||||
IClock clock,
|
||||
Func<IReadOnlyDictionary<string, SavedScriptResult>>? snapshotSource = null)
|
||||
{
|
||||
_runs = runs ?? throw new ArgumentNullException(nameof(runs));
|
||||
_post = post ?? throw new ArgumentNullException(nameof(post));
|
||||
_clock = clock ?? throw new ArgumentNullException(nameof(clock));
|
||||
_logger = logger;
|
||||
_snapshotSource = snapshotSource ?? ReadSnapshot;
|
||||
}
|
||||
|
||||
/// <summary>One observation pass: snapshot → new saves → pair → judge → correct. Fail-soft: never throws.</summary>
|
||||
public void Tick(string reason)
|
||||
{
|
||||
try
|
||||
{
|
||||
lock (_sync)
|
||||
{
|
||||
var snapshot = _snapshotSource();
|
||||
var nowUtc = _clock.UtcNow;
|
||||
|
||||
if (_last == null)
|
||||
{
|
||||
// Saves that predate this agent run belong to runs it never emitted.
|
||||
_last = snapshot;
|
||||
_logger?.Info($"RegistryScriptResult: baseline captured ({snapshot.Count} saved platform-script results, trigger={reason})");
|
||||
return;
|
||||
}
|
||||
|
||||
foreach (var kv in snapshot)
|
||||
{
|
||||
if (_last.TryGetValue(kv.Key, out var previous) && previous.SameSaveAs(kv.Value)) continue;
|
||||
_pending[kv.Key] = (kv.Value, nowUtc); // a newer save of the key replaces a waiting one
|
||||
}
|
||||
_last = snapshot;
|
||||
|
||||
ProcessPending(nowUtc);
|
||||
}
|
||||
}
|
||||
catch (Exception ex)
|
||||
{
|
||||
_logger?.Debug($"RegistryScriptResult: tick failed (fail-soft): {ex.Message}");
|
||||
}
|
||||
}
|
||||
|
||||
private void ProcessPending(DateTime nowUtc)
|
||||
{
|
||||
foreach (var key in _pending.Keys.ToList())
|
||||
{
|
||||
var (saved, seenUtc) = _pending[key];
|
||||
var claim = _runs.TryClaim(saved.UserId, saved.PolicyId, seenUtc, out var run);
|
||||
if (claim == PlatformRunClaim.Wait)
|
||||
{
|
||||
if (nowUtc - seenUtc >= PendingExpiry) _pending.Remove(key);
|
||||
continue;
|
||||
}
|
||||
|
||||
_pending.Remove(key);
|
||||
if (claim == PlatformRunClaim.Claimed && run != null) Reconcile(run, saved, nowUtc);
|
||||
}
|
||||
}
|
||||
|
||||
private void Reconcile(PlatformScriptRun run, SavedScriptResult saved, DateTime nowUtc)
|
||||
{
|
||||
var judgement = PlatformOutputJudge.Judge(run, saved);
|
||||
switch (judgement.Verdict)
|
||||
{
|
||||
case PlatformOutputVerdict.Verified:
|
||||
_runs.CountVerified();
|
||||
_logger?.Debug($"RegistryScriptResult: platform script {run.PolicyId} output confirmed by IME's saved result");
|
||||
return;
|
||||
case PlatformOutputVerdict.NotComparable:
|
||||
_logger?.Debug($"RegistryScriptResult: platform script {run.PolicyId} not comparable ({judgement.Reason})");
|
||||
return;
|
||||
}
|
||||
|
||||
_runs.CountCorrected();
|
||||
if (_correctionsEmitted >= MaxCorrectionsPerSession)
|
||||
{
|
||||
_logger?.Warning($"RegistryScriptResult: correction for {run.PolicyId} not emitted — cap of {MaxCorrectionsPerSession} per agent run reached");
|
||||
return;
|
||||
}
|
||||
_correctionsEmitted++;
|
||||
|
||||
var foreign = judgement.Verdict == PlatformOutputVerdict.Foreign;
|
||||
var culture = CultureInfo.InvariantCulture;
|
||||
var data = new Dictionary<string, string>(StringComparer.Ordinal)
|
||||
{
|
||||
["policyId"] = run.PolicyId,
|
||||
["scriptType"] = "platform",
|
||||
["outcome"] = foreign ? "foreign" : "repaired",
|
||||
["reason"] = judgement.Reason,
|
||||
};
|
||||
if (!string.IsNullOrEmpty(run.RunId)) data["runId"] = run.RunId!;
|
||||
if (!string.IsNullOrEmpty(saved.Result)) data["result"] = saved.Result!;
|
||||
if (saved.ErrorCode.HasValue) data["registryErrorCode"] = saved.ErrorCode.Value.ToString(culture);
|
||||
// A present key replaces the emitted value, an empty one clears it; an absent key keeps it.
|
||||
if (judgement.Stdout != null) data["stdout"] = judgement.Stdout;
|
||||
if (judgement.Stderr != null) data["stderr"] = judgement.Stderr;
|
||||
if (foreign && run.ExitCode.HasValue) data["previousExitCode"] = run.ExitCode.Value.ToString(culture);
|
||||
|
||||
var shortId = run.PolicyId.Length > 8 ? run.PolicyId.Substring(0, 8) : run.PolicyId;
|
||||
var message = foreign
|
||||
? $"Platform script {shortId}: output corrected from IME's saved result; the log had attributed another script's output, exit code unverified"
|
||||
: $"Platform script {shortId}: output completed from IME's saved result";
|
||||
|
||||
_post.Emit(
|
||||
eventType: SharedEventTypes.ScriptOutputReconciliation,
|
||||
source: SourceLabel,
|
||||
message: message,
|
||||
severity: foreign ? EventSeverity.Warning : EventSeverity.Info,
|
||||
immediateUpload: foreign,
|
||||
data: data,
|
||||
occurredAtUtc: nowUtc);
|
||||
|
||||
if (foreign)
|
||||
_logger?.Warning($"RegistryScriptResult: platform script {run.PolicyId} run {run.RunId} carried another script's end block ({judgement.Reason}) — corrected from IME's saved result");
|
||||
else
|
||||
_logger?.Info($"RegistryScriptResult: platform script {run.PolicyId} run {run.RunId} output completed from IME's saved result ({judgement.Reason})");
|
||||
}
|
||||
|
||||
// ── snapshot ────────────────────────────────────────────────────────────
|
||||
|
||||
internal static string KeyOf(string userId, string policyId) => userId + "|" + policyId;
|
||||
|
||||
internal static IReadOnlyDictionary<string, SavedScriptResult> ReadSnapshot()
|
||||
{
|
||||
var snapshot = new Dictionary<string, SavedScriptResult>(StringComparer.OrdinalIgnoreCase);
|
||||
using var baseKey = RegistryKey.OpenBaseKey(RegistryHive.LocalMachine, RegistryView.Registry64);
|
||||
using var policies = baseKey.OpenSubKey(PoliciesKeyPath);
|
||||
if (policies == null) return snapshot;
|
||||
|
||||
foreach (var userId in policies.GetSubKeyNames())
|
||||
{
|
||||
if (!Guid.TryParse(userId, out _)) continue;
|
||||
using var userKey = policies.OpenSubKey(userId);
|
||||
if (userKey == null) continue;
|
||||
|
||||
foreach (var policyId in userKey.GetSubKeyNames())
|
||||
{
|
||||
if (!Guid.TryParse(policyId, out _)) continue;
|
||||
using var policyKey = userKey.OpenSubKey(policyId);
|
||||
if (policyKey == null) continue;
|
||||
|
||||
snapshot[KeyOf(userId, policyId)] = new SavedScriptResult
|
||||
{
|
||||
UserId = userId,
|
||||
PolicyId = policyId,
|
||||
Result = policyKey.GetValue("Result") as string,
|
||||
ErrorCode = TryReadInt(policyKey.GetValue("ErrorCode")),
|
||||
ResultDetails = policyKey.GetValue("ResultDetails") as string,
|
||||
LastUpdatedTimeUtc = policyKey.GetValue("LastUpdatedTimeUtc") as string,
|
||||
};
|
||||
}
|
||||
}
|
||||
return snapshot;
|
||||
}
|
||||
|
||||
private static int? TryReadInt(object? value)
|
||||
{
|
||||
switch (value)
|
||||
{
|
||||
case int i: return i;
|
||||
case long l when l >= int.MinValue && l <= int.MaxValue: return (int)l;
|
||||
case string s when int.TryParse(s, NumberStyles.Integer, CultureInfo.InvariantCulture, out var parsed): return parsed;
|
||||
default: return null;
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
/// <summary>One platform-script result as IME saved it under <c>Policies\<UserId>\<PolicyId></c>.</summary>
|
||||
internal sealed class SavedScriptResult
|
||||
{
|
||||
public string UserId { get; set; } = string.Empty;
|
||||
public string PolicyId { get; set; } = string.Empty;
|
||||
public string? Result { get; set; }
|
||||
public int? ErrorCode { get; set; }
|
||||
public string? ResultDetails { get; set; }
|
||||
public string? LastUpdatedTimeUtc { get; set; }
|
||||
|
||||
/// <summary>The same save: IME stamps every save with a new <c>LastUpdatedTimeUtc</c>.</summary>
|
||||
public bool SameSaveAs(SavedScriptResult other)
|
||||
=> string.Equals(LastUpdatedTimeUtc, other.LastUpdatedTimeUtc, StringComparison.Ordinal)
|
||||
&& string.Equals(Result, other.Result, StringComparison.Ordinal)
|
||||
&& ErrorCode == other.ErrorCode
|
||||
&& string.Equals(ResultDetails, other.ResultDetails, StringComparison.Ordinal);
|
||||
|
||||
/// <summary>
|
||||
/// <c>ExecutionMsg</c> of the CryptoResult JSON in <c>ResultDetails</c> (IME 1.73 and later), or null
|
||||
/// when the value is not that JSON ("Hash mismatch", a launch failure).
|
||||
/// </summary>
|
||||
public string? ExecutionMessage()
|
||||
{
|
||||
if (string.IsNullOrWhiteSpace(ResultDetails)) return null;
|
||||
try
|
||||
{
|
||||
using var doc = JsonDocument.Parse(ResultDetails!);
|
||||
if (doc.RootElement.ValueKind != JsonValueKind.Object) return null;
|
||||
return doc.RootElement.TryGetProperty("ExecutionMsg", out var msg) && msg.ValueKind == JsonValueKind.String
|
||||
? msg.GetString()
|
||||
: null;
|
||||
}
|
||||
catch (JsonException)
|
||||
{
|
||||
return null;
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
internal enum PlatformOutputVerdict
|
||||
{
|
||||
/// <summary>IME's saved result cannot confirm or contradict the run (no output saved, other failure kind).</summary>
|
||||
NotComparable,
|
||||
/// <summary>The emitted output is what IME saved: the end block, its exit code included, is the run's own.</summary>
|
||||
Verified,
|
||||
/// <summary>The log delivered the run's output incomplete; IME's saved text completes it, the exit code stands.</summary>
|
||||
Repaired,
|
||||
/// <summary>The emitted output contradicts IME's saved result: the end block was another executor's.</summary>
|
||||
Foreign,
|
||||
}
|
||||
|
||||
internal sealed class PlatformOutputJudgement
|
||||
{
|
||||
public PlatformOutputVerdict Verdict { get; set; }
|
||||
public string Reason { get; set; } = string.Empty;
|
||||
/// <summary>Value to publish (Repaired/Foreign): null keeps the emitted stdout, empty clears it.</summary>
|
||||
public string? Stdout { get; set; }
|
||||
/// <summary>Value to publish (Repaired/Foreign): null keeps the emitted stderr, empty clears it.</summary>
|
||||
public string? Stderr { get; set; }
|
||||
}
|
||||
|
||||
/// <summary>
|
||||
/// Compares a platform-script run as the tracker emitted it with IME's saved result. Comparable are
|
||||
/// a Success (ExecutionMsg = stdout; IME's Success means the stderr file was empty) and a Failed with
|
||||
/// ErrorCode 99 (ExecutionMsg = stderr). Both texts are compared after CR/LF normalisation and Trim;
|
||||
/// the tracker's own 8192-character cut is a prefix of the saved text.
|
||||
/// </summary>
|
||||
internal static class PlatformOutputJudge
|
||||
{
|
||||
internal const int ImeStderrErrorCode = 99;
|
||||
private const string OutputErrorSeparator = ", error =";
|
||||
|
||||
public static PlatformOutputJudgement Judge(PlatformScriptRun run, SavedScriptResult saved)
|
||||
{
|
||||
var executionMessage = saved.ExecutionMessage();
|
||||
if (executionMessage == null) return NotComparable("no_execution_message");
|
||||
|
||||
// The run's IME result line and the save come from the same IME run.
|
||||
if (string.Equals(run.ResultSource, "ime_policy_result", StringComparison.Ordinal)
|
||||
&& !string.Equals(run.Result, saved.Result, StringComparison.OrdinalIgnoreCase))
|
||||
return NotComparable("result_differs");
|
||||
|
||||
if (string.Equals(saved.Result, "Success", StringComparison.OrdinalIgnoreCase))
|
||||
return JudgeSuccess(run, Normalize(executionMessage)!);
|
||||
if (string.Equals(saved.Result, "Failed", StringComparison.OrdinalIgnoreCase) && saved.ErrorCode == ImeStderrErrorCode)
|
||||
return JudgeStderrFailure(run, Normalize(executionMessage)!);
|
||||
return NotComparable("no_saved_output");
|
||||
}
|
||||
|
||||
private static PlatformOutputJudgement JudgeSuccess(PlatformScriptRun run, string savedStdout)
|
||||
{
|
||||
var stdout = NormalizeEmitted(run.Stdout, out var stdoutCut);
|
||||
var stderr = Normalize(run.Stderr);
|
||||
var stderrClean = string.IsNullOrEmpty(stderr);
|
||||
|
||||
if (!string.IsNullOrEmpty(stdout) && Agrees(stdout!, stdoutCut, savedStdout))
|
||||
return stderrClean ? Verified() : Correct(PlatformOutputVerdict.Repaired, "stderr_cleared", savedStdout, string.Empty);
|
||||
|
||||
if (stdout != null && stdout.Length == 0 && savedStdout.Length == 0)
|
||||
return stderrClean ? Verified() : Correct(PlatformOutputVerdict.Foreign, "stderr_on_success", string.Empty, string.Empty);
|
||||
|
||||
if (stdout == null)
|
||||
{
|
||||
if (!stderrClean) return Correct(PlatformOutputVerdict.Foreign, "stderr_on_success", savedStdout, string.Empty);
|
||||
return savedStdout.Length > 0
|
||||
? Correct(PlatformOutputVerdict.Repaired, "stdout_missing", savedStdout, string.Empty)
|
||||
: NotComparable("nothing_read");
|
||||
}
|
||||
|
||||
// "write output done. output = X, error = Y" splits at the first ", error =" — a stdout that
|
||||
// contains the separator ends up partly in stderr. The saved text shows the cut right there.
|
||||
if (stdout.Length > 0 && !stdoutCut && !stderrClean
|
||||
&& savedStdout.StartsWith(stdout, StringComparison.Ordinal)
|
||||
&& savedStdout.Substring(stdout.Length).TrimStart().StartsWith(OutputErrorSeparator, StringComparison.Ordinal))
|
||||
return Correct(PlatformOutputVerdict.Repaired, "stdout_split", savedStdout, string.Empty);
|
||||
|
||||
return Correct(PlatformOutputVerdict.Foreign, "stdout_differs", savedStdout, string.Empty);
|
||||
}
|
||||
|
||||
private static PlatformOutputJudgement JudgeStderrFailure(PlatformScriptRun run, string savedStderr)
|
||||
{
|
||||
var stderr = NormalizeEmitted(run.Stderr, out var stderrCut);
|
||||
if (!string.IsNullOrEmpty(stderr) && Agrees(stderr!, stderrCut, savedStderr)) return Verified();
|
||||
|
||||
// Nothing of the end block read: complete the stderr, the run's stdout stays as emitted.
|
||||
if (run.Stderr == null && run.Stdout == null)
|
||||
return Correct(PlatformOutputVerdict.Repaired, "stderr_missing", null, savedStderr);
|
||||
|
||||
// The end block read said something else — an empty stderr included: IME read stderr from this
|
||||
// run's error file. The block's stdout is the other executor's as well.
|
||||
return Correct(PlatformOutputVerdict.Foreign, "stderr_differs", string.Empty, savedStderr);
|
||||
}
|
||||
|
||||
private static bool Agrees(string emitted, bool emittedCut, string saved)
|
||||
=> string.Equals(emitted, saved, StringComparison.Ordinal)
|
||||
|| (emittedCut && saved.StartsWith(emitted, StringComparison.Ordinal));
|
||||
|
||||
/// <summary>CR LF and lone CR to LF, then Trim — what the tracker's line reader and handlers make of a text.</summary>
|
||||
internal static string? Normalize(string? text)
|
||||
=> text?.Replace("\r\n", "\n").Replace('\r', '\n').Trim();
|
||||
|
||||
private static string? NormalizeEmitted(string? text, out bool cut)
|
||||
{
|
||||
cut = false;
|
||||
if (text == null) return null;
|
||||
if (text.EndsWith(ImeLogTracker.OutputTruncationMarker, StringComparison.Ordinal))
|
||||
{
|
||||
cut = true;
|
||||
text = text.Substring(0, text.Length - ImeLogTracker.OutputTruncationMarker.Length);
|
||||
}
|
||||
return Normalize(text);
|
||||
}
|
||||
|
||||
private static PlatformOutputJudgement Verified()
|
||||
=> new PlatformOutputJudgement { Verdict = PlatformOutputVerdict.Verified, Reason = "match" };
|
||||
|
||||
private static PlatformOutputJudgement NotComparable(string reason)
|
||||
=> new PlatformOutputJudgement { Verdict = PlatformOutputVerdict.NotComparable, Reason = reason };
|
||||
|
||||
private static PlatformOutputJudgement Correct(PlatformOutputVerdict verdict, string reason, string? stdout, string? stderr)
|
||||
=> new PlatformOutputJudgement
|
||||
{
|
||||
Verdict = verdict,
|
||||
Reason = reason,
|
||||
// The tracker's own output cap: a corrected value is never longer than an emitted one.
|
||||
Stdout = stdout == null ? null : ImeLogTracker.TruncateOutput(stdout),
|
||||
Stderr = stderr == null ? null : ImeLogTracker.TruncateOutput(stderr),
|
||||
};
|
||||
}
|
||||
}
|
||||
+15
-10
@@ -53,7 +53,7 @@ namespace AutopilotMonitor.Agent.V2.Core.Monitoring.Enrollment.SystemSignals
|
||||
/// </summary>
|
||||
internal sealed class OobeUpdateTelemetry
|
||||
{
|
||||
internal const int MaxPageEventsPerRun = 50;
|
||||
internal const int MaxPageEventsPerRun = 150;
|
||||
internal const int MaxPageEventsPerKey = 3;
|
||||
internal const int MaxStateEventsPerRun = 6;
|
||||
internal const int MaxStateLineLength = 1000;
|
||||
@@ -98,31 +98,34 @@ namespace AutopilotMonitor.Agent.V2.Core.Monitoring.Enrollment.SystemSignals
|
||||
|
||||
/// <summary>
|
||||
/// One <c>oobe_update_page</c> per update-page record, at most
|
||||
/// <see cref="MaxPageEventsPerKey"/> per page/name and <see cref="MaxPageEventsPerRun"/>
|
||||
/// per run — a page that logs the same name in a loop cannot flood the session.
|
||||
/// <see cref="MaxPageEventsPerKey"/> per page/name — a page that logs the same name in a
|
||||
/// loop cannot flood the session. Event names also share <see cref="MaxPageEventsPerRun"/>
|
||||
/// per run; a page start or stop is outside that budget, because the time attribution
|
||||
/// reads the update's span from them. True when the record was reported.
|
||||
/// </summary>
|
||||
public void ReportPage(OobeUpdatePageRecord record, DateTime occurredAtUtc, bool isBackfill)
|
||||
public bool ReportPage(OobeUpdatePageRecord record, DateTime occurredAtUtc, bool isBackfill)
|
||||
{
|
||||
if (record == null) return;
|
||||
if (record == null) return false;
|
||||
|
||||
var isEventName = record.CxhEvent == OobeUpdatePageRecord.EventName;
|
||||
var key = $"{record.CxhEvent}:{record.Page ?? record.Name}";
|
||||
int occurrence;
|
||||
lock (_lock)
|
||||
{
|
||||
if (_pageEvents >= MaxPageEventsPerRun)
|
||||
if (isEventName && _pageEvents >= MaxPageEventsPerRun)
|
||||
{
|
||||
if (!_pageCapLogged)
|
||||
{
|
||||
_pageCapLogged = true;
|
||||
_logger.Info($"OOBE update page telemetry: {MaxPageEventsPerRun} events reached, the rest of this run stays in agent.log");
|
||||
_logger.Info($"OOBE update page telemetry: {MaxPageEventsPerRun} event names reached, the rest of this run stays in agent.log");
|
||||
}
|
||||
return;
|
||||
return false;
|
||||
}
|
||||
_pageEventsPerKey.TryGetValue(key, out occurrence);
|
||||
if (occurrence >= MaxPageEventsPerKey) return;
|
||||
if (occurrence >= MaxPageEventsPerKey) return false;
|
||||
occurrence++;
|
||||
_pageEventsPerKey[key] = occurrence;
|
||||
_pageEvents++;
|
||||
if (isEventName) _pageEvents++;
|
||||
}
|
||||
|
||||
var data = new Dictionary<string, object>
|
||||
@@ -153,10 +156,12 @@ namespace AutopilotMonitor.Agent.V2.Core.Monitoring.Enrollment.SystemSignals
|
||||
Data = data,
|
||||
ImmediateUpload = false,
|
||||
});
|
||||
return true;
|
||||
}
|
||||
catch (Exception ex)
|
||||
{
|
||||
_logger.Debug($"OOBE update page telemetry failed: {ex.Message}");
|
||||
return false;
|
||||
}
|
||||
}
|
||||
|
||||
|
||||
+1
-1
@@ -280,7 +280,7 @@ namespace AutopilotMonitor.Agent.V2.Core.Monitoring.Enrollment.SystemSignals
|
||||
Timestamp = timeCreatedUtc ?? DateTime.UtcNow,
|
||||
EventType = Constants.EventTypes.WindowsUpdateServicing,
|
||||
Severity = severity,
|
||||
Source = "ServicingWatcher",
|
||||
Source = Constants.EventSources.ServicingWatcher,
|
||||
Phase = EnrollmentPhase.Unknown,
|
||||
Message = message,
|
||||
Data = data,
|
||||
|
||||
+199
-55
@@ -1,6 +1,7 @@
|
||||
using System;
|
||||
using System.Collections.Generic;
|
||||
using System.Diagnostics.Eventing.Reader;
|
||||
using System.Globalization;
|
||||
using System.Text.RegularExpressions;
|
||||
using System.Threading;
|
||||
using AutopilotMonitor.Agent.V2.Core.Logging;
|
||||
@@ -62,17 +63,20 @@ namespace AutopilotMonitor.Agent.V2.Core.Monitoring.Enrollment.SystemSignals
|
||||
@"OOBE_ESP.*Exiting", RegexOptions.IgnoreCase | RegexOptions.Compiled);
|
||||
|
||||
// Manifest templates: 62404 "... started. CXID: '%1'.", 62405 "... stopped. Result: '%1'.",
|
||||
// 62406 "... Event 1. Name: '%1'.", 62407 "... Event 2. Name: '%1', Value: '%2'.". A 62407
|
||||
// value can carry URLs with tenant ids — a value leaves the tracker only in a form that
|
||||
// cannot (SafeValuePattern: a boolean, an integer, an HRESULT).
|
||||
// 62406 "... Event 1. Name: '%1'.", 62407 "... Event 2. Name: '%1', Value: '%2'.". The
|
||||
// fields are read from the event PROPERTIES (%1/%2): the formatted message is localized
|
||||
// ("Ergebnis: '…'", "Nom : « … »"), so these patterns are only the fallback for a record
|
||||
// without properties and accept « » and a space before the colon. A 62407 value can carry
|
||||
// URLs with tenant ids — a value leaves the tracker only in a form that cannot
|
||||
// (SafeValuePattern: a boolean, an integer, an HRESULT).
|
||||
private static readonly Regex CxidPattern = new Regex(
|
||||
@"CXID:\s*'([^']*)'", RegexOptions.CultureInvariant | RegexOptions.Compiled, TimeSpan.FromMilliseconds(100));
|
||||
@"CXID\s*:\s*['\u00AB]\s*([^'\u00BB]*?)\s*['\u00BB]", RegexOptions.CultureInvariant | RegexOptions.Compiled, TimeSpan.FromMilliseconds(100));
|
||||
private static readonly Regex ResultPattern = new Regex(
|
||||
@"Result:\s*'([^']*)'", RegexOptions.CultureInvariant | RegexOptions.Compiled, TimeSpan.FromMilliseconds(100));
|
||||
@"Result\s*:\s*['\u00AB]\s*([^'\u00BB]*?)\s*['\u00BB]", RegexOptions.CultureInvariant | RegexOptions.Compiled, TimeSpan.FromMilliseconds(100));
|
||||
private static readonly Regex NamePattern = new Regex(
|
||||
@"Name:\s*'([^']*)'", RegexOptions.CultureInvariant | RegexOptions.Compiled, TimeSpan.FromMilliseconds(100));
|
||||
@"Name\s*:\s*['\u00AB]\s*([^'\u00BB]*?)\s*['\u00BB]", RegexOptions.CultureInvariant | RegexOptions.Compiled, TimeSpan.FromMilliseconds(100));
|
||||
private static readonly Regex ValuePattern = new Regex(
|
||||
@"Value:\s*'([^']*)'", RegexOptions.CultureInvariant | RegexOptions.Compiled, TimeSpan.FromMilliseconds(100));
|
||||
@"Value\s*:\s*['\u00AB]\s*([^'\u00BB]*?)\s*['\u00BB]", RegexOptions.CultureInvariant | RegexOptions.Compiled, TimeSpan.FromMilliseconds(100));
|
||||
private static readonly Regex SafeValuePattern = new Regex(
|
||||
@"^(?:true|false|-?[0-9]{1,10}|0x[0-9a-f]{1,8})$",
|
||||
RegexOptions.CultureInvariant | RegexOptions.IgnoreCase | RegexOptions.Compiled, TimeSpan.FromMilliseconds(100));
|
||||
@@ -84,6 +88,11 @@ namespace AutopilotMonitor.Agent.V2.Core.Monitoring.Enrollment.SystemSignals
|
||||
private readonly InformationalEventPost _post;
|
||||
private readonly HelloTracker _helloTracker;
|
||||
private readonly OobeUpdateTelemetry _oobeUpdate;
|
||||
// Shell-Core RecordIds of the update-page records already reported: the restart backfill
|
||||
// must not report a record an earlier run already sent (D-310 field data: the same 20
|
||||
// records came twice after a restart).
|
||||
private readonly EventRecordWatermark _pageWatermark;
|
||||
internal const string PageWatermarkStateFileName = "shellcore-page-watermark.json";
|
||||
|
||||
private EventLogWatcher _watcher;
|
||||
private int _started;
|
||||
@@ -131,7 +140,8 @@ namespace AutopilotMonitor.Agent.V2.Core.Monitoring.Enrollment.SystemSignals
|
||||
InformationalEventPost post,
|
||||
AgentLogger logger,
|
||||
HelloTracker helloTracker,
|
||||
Func<IReadOnlyList<OobeUpdateRegistrySnapshot.KeyState>> oobeUpdateRegistryReader = null)
|
||||
Func<IReadOnlyList<OobeUpdateRegistrySnapshot.KeyState>> oobeUpdateRegistryReader = null,
|
||||
string stateDirectory = null)
|
||||
{
|
||||
_sessionId = sessionId ?? throw new ArgumentNullException(nameof(sessionId));
|
||||
_tenantId = tenantId ?? throw new ArgumentNullException(nameof(tenantId));
|
||||
@@ -141,17 +151,24 @@ namespace AutopilotMonitor.Agent.V2.Core.Monitoring.Enrollment.SystemSignals
|
||||
// Test seam: a fake registry reader; production reads the real registry.
|
||||
_oobeUpdate = new OobeUpdateTelemetry(sessionId, tenantId, post, logger,
|
||||
oobeUpdateRegistryReader ?? OobeUpdateRegistrySnapshot.Read);
|
||||
_pageWatermark = new EventRecordWatermark(stateDirectory, PageWatermarkStateFileName, logger, "Shell-Core update page");
|
||||
}
|
||||
|
||||
internal bool IsEspExitedForTest { get { lock (_stateLock) { return _espExitDetected; } } }
|
||||
internal bool IsWhiteGloveDetectedForTest { get { lock (_stateLock) { return _whiteGloveDetected; } } }
|
||||
|
||||
/// <summary>Loads the update-page watermark as <see cref="Start"/> does, without arming the watcher.</summary>
|
||||
internal void LoadPageWatermark() => _pageWatermark.Load();
|
||||
|
||||
public void Start()
|
||||
{
|
||||
// The OOBE update registry state at every agent start — so also right after the
|
||||
// update's restart (D-310).
|
||||
if (Interlocked.Exchange(ref _started, 1) == 0)
|
||||
{
|
||||
_oobeUpdate.ReportState(OobeUpdateTelemetry.Moments.AgentStart);
|
||||
_pageWatermark.Load();
|
||||
}
|
||||
|
||||
try
|
||||
{
|
||||
@@ -185,7 +202,9 @@ namespace AutopilotMonitor.Agent.V2.Core.Monitoring.Enrollment.SystemSignals
|
||||
{
|
||||
// Stop runs again from Dispose — one snapshot, and only for a tracker that started.
|
||||
if (Volatile.Read(ref _started) == 1 && Interlocked.Exchange(ref _stopReported, 1) == 0)
|
||||
{
|
||||
_oobeUpdate.ReportState(OobeUpdateTelemetry.Moments.AgentStop);
|
||||
}
|
||||
|
||||
if (_watcher == null) return;
|
||||
try
|
||||
@@ -216,7 +235,8 @@ namespace AutopilotMonitor.Agent.V2.Core.Monitoring.Enrollment.SystemSignals
|
||||
var description = record.FormatDescription() ?? $"Event ID {record.Id}";
|
||||
var timestamp = (record.TimeCreated ?? DateTime.UtcNow).ToUniversalTime();
|
||||
|
||||
ProcessEvent(record.Id, description, timestamp, record.ProviderName ?? "", isBackfill: false);
|
||||
ProcessEvent(record.Id, description, timestamp, record.ProviderName ?? "", isBackfill: false,
|
||||
recordId: record.RecordId ?? -1, properties: ReadProperties(record));
|
||||
}
|
||||
catch (Exception ex)
|
||||
{
|
||||
@@ -228,9 +248,17 @@ namespace AutopilotMonitor.Agent.V2.Core.Monitoring.Enrollment.SystemSignals
|
||||
/// Core event-processing logic. Exposed as internal so tests can drive it without
|
||||
/// needing to synthesize an <see cref="EventRecord"/> (abstract + Windows-only).
|
||||
/// </summary>
|
||||
internal void ProcessEvent(int eventId, string description, DateTime timestamp, string providerName, bool isBackfill)
|
||||
internal void ProcessEvent(
|
||||
int eventId,
|
||||
string description,
|
||||
DateTime timestamp,
|
||||
string providerName,
|
||||
bool isBackfill,
|
||||
long recordId = -1,
|
||||
IReadOnlyList<string> properties = null)
|
||||
{
|
||||
ObserveCxhRecord(eventId, description, timestamp, isBackfill);
|
||||
var fields = ReadCxhFields(eventId, description, properties);
|
||||
ObserveCxhRecord(eventId, fields, timestamp, isBackfill, recordId);
|
||||
if (eventId == EventId_ShellCore_WebAppStopped || eventId == EventId_ShellCore_WebAppEventName) return;
|
||||
|
||||
string eventType;
|
||||
@@ -244,7 +272,7 @@ namespace AutopilotMonitor.Agent.V2.Core.Monitoring.Enrollment.SystemSignals
|
||||
switch (eventId)
|
||||
{
|
||||
case EventId_ShellCore_WebAppStarted: // 62404
|
||||
if (description.Contains("AADHello") || description.Contains("'NGC'"))
|
||||
if (IsHelloWizardStart(fields.Primary, description))
|
||||
{
|
||||
eventType = Constants.EventTypes.HelloWizardStarted;
|
||||
message = "Windows Hello wizard started (CloudExperienceHost)";
|
||||
@@ -437,7 +465,7 @@ namespace AutopilotMonitor.Agent.V2.Core.Monitoring.Enrollment.SystemSignals
|
||||
PathType.LogName,
|
||||
$"*[System[{WatchedEventIdsXPath} and TimeCreated[timediff(@SystemTime) <= {lookbackMs}]]]");
|
||||
|
||||
var records = new List<(int Id, string Description, DateTime OccurredAtUtc)>();
|
||||
var records = new List<ShellCoreRecord>();
|
||||
using (var reader = new EventLogReader(query))
|
||||
{
|
||||
for (EventRecord record = reader.ReadEvent(); record != null; record = reader.ReadEvent())
|
||||
@@ -449,7 +477,8 @@ namespace AutopilotMonitor.Agent.V2.Core.Monitoring.Enrollment.SystemSignals
|
||||
// (EspAndHelloTrackerAdapter) can stamp signals with the source time
|
||||
// rather than collapsing to wall-clock-now.
|
||||
var timestamp = (record.TimeCreated ?? DateTime.UtcNow).ToUniversalTime();
|
||||
records.Add((record.Id, description, timestamp));
|
||||
records.Add(new ShellCoreRecord(record.Id, description, timestamp,
|
||||
record.RecordId ?? -1, ReadProperties(record)));
|
||||
}
|
||||
}
|
||||
}
|
||||
@@ -502,6 +531,14 @@ namespace AutopilotMonitor.Agent.V2.Core.Monitoring.Enrollment.SystemSignals
|
||||
/// </summary>
|
||||
internal void ReplayBackfillRecords(
|
||||
IReadOnlyList<(int Id, string Description, DateTime OccurredAtUtc)> records)
|
||||
{
|
||||
if (records == null) return;
|
||||
var converted = new List<ShellCoreRecord>(records.Count);
|
||||
foreach (var r in records) converted.Add(new ShellCoreRecord(r.Id, r.Description, r.OccurredAtUtc));
|
||||
ReplayBackfillRecords(converted);
|
||||
}
|
||||
|
||||
internal void ReplayBackfillRecords(IReadOnlyList<ShellCoreRecord> records)
|
||||
{
|
||||
if (records == null || records.Count == 0) return;
|
||||
|
||||
@@ -513,11 +550,12 @@ namespace AutopilotMonitor.Agent.V2.Core.Monitoring.Enrollment.SystemSignals
|
||||
foreach (var record in records)
|
||||
{
|
||||
var description = record.Description ?? string.Empty;
|
||||
ObserveCxhRecord(record.Id, description, record.OccurredAtUtc, isBackfill: true);
|
||||
var fields = ReadCxhFields(record.Id, description, record.Properties);
|
||||
ObserveCxhRecord(record.Id, fields, record.OccurredAtUtc, isBackfill: true, recordId: record.RecordId);
|
||||
|
||||
if (record.Id == EventId_ShellCore_WebAppStarted)
|
||||
{
|
||||
HandleBackfillRecord(record.Id, description, record.OccurredAtUtc);
|
||||
HandleBackfillRecord(record.Id, description, record.OccurredAtUtc, fields.Primary);
|
||||
continue;
|
||||
}
|
||||
|
||||
@@ -586,7 +624,7 @@ namespace AutopilotMonitor.Agent.V2.Core.Monitoring.Enrollment.SystemSignals
|
||||
/// (<c>record.TimeCreated</c>); subscribers read it via
|
||||
/// <see cref="LastEventOccurredAtUtc"/> during their synchronous event handler.
|
||||
/// </summary>
|
||||
internal void HandleBackfillRecord(int eventId, string description, DateTime occurredAtUtc)
|
||||
internal void HandleBackfillRecord(int eventId, string description, DateTime occurredAtUtc, string cxid = null)
|
||||
{
|
||||
if (eventId == EventId_ShellCore_WebAppStarted)
|
||||
{
|
||||
@@ -594,7 +632,7 @@ namespace AutopilotMonitor.Agent.V2.Core.Monitoring.Enrollment.SystemSignals
|
||||
// are unrelated. Fire-once so a replayed log tail cannot re-raise (downstream is
|
||||
// idempotent anyway: HelloTracker once-guard, adapter dedup flag, engine
|
||||
// set-once fact — this guard just keeps the noise down).
|
||||
if (!description.Contains("AADHello") && !description.Contains("'NGC'")) return;
|
||||
if (!IsHelloWizardStart(cxid ?? ReadCxhFields(eventId, description, null).Primary, description)) return;
|
||||
|
||||
bool shouldRaiseWizard;
|
||||
lock (_stateLock)
|
||||
@@ -628,28 +666,36 @@ namespace AutopilotMonitor.Agent.V2.Core.Monitoring.Enrollment.SystemSignals
|
||||
/// Writes one agent.log line per CloudExperienceHost page start/stop and per update-page
|
||||
/// event name, so a diagnostics package shows the OOBE navigation. Records of the update
|
||||
/// page itself (<c>OobeNDUP</c>, <c>RebootNDUP</c> and its <c>ExpeditedUpdate_*</c> names)
|
||||
/// are also reported as <c>oobe_update_page</c>, and at the page's live start and stop the
|
||||
/// registry state behind it as <c>oobe_update_state</c>. No decision.
|
||||
/// are also reported as <c>oobe_update_page</c> — once across agent runs, by RecordId — and
|
||||
/// at the page's live start and stop the registry state behind it as
|
||||
/// <c>oobe_update_state</c>. No decision.
|
||||
/// </summary>
|
||||
private void ObserveCxhRecord(int eventId, string description, DateTime occurredAtUtc, bool isBackfill)
|
||||
private void ObserveCxhRecord(int eventId, CxhFields fields, DateTime occurredAtUtc, bool isBackfill, long recordId)
|
||||
{
|
||||
try
|
||||
{
|
||||
string page;
|
||||
lock (_stateLock)
|
||||
{
|
||||
if (eventId == EventId_ShellCore_WebAppStarted)
|
||||
_lastCxhPage = ExtractToken(CxidPattern, description) ?? _lastCxhPage;
|
||||
if (eventId == EventId_ShellCore_WebAppStarted && fields.Primary != null)
|
||||
_lastCxhPage = fields.Primary;
|
||||
page = _lastCxhPage;
|
||||
}
|
||||
|
||||
var crumb = FormatCxhBreadcrumb(eventId, description, page);
|
||||
var crumb = FormatCxhBreadcrumb(eventId, fields, page);
|
||||
if (crumb == null) return;
|
||||
_logger.Info(isBackfill ? $"{crumb} (backfill, at {occurredAtUtc:o})" : crumb);
|
||||
|
||||
var record = ParseUpdatePageRecord(eventId, description, page);
|
||||
var record = ParseUpdatePageRecord(eventId, fields, page);
|
||||
if (record == null) return;
|
||||
_oobeUpdate.ReportPage(record, occurredAtUtc, isBackfill);
|
||||
// A record an earlier run (or this one) already reported — the restart backfill
|
||||
// re-reads the minutes before the restart.
|
||||
if (!_pageWatermark.TryClaim(recordId)) return;
|
||||
|
||||
// Only a reported record moves the state file — at most the run budget plus the
|
||||
// page boundaries; one over the budget stays claimed for this run only.
|
||||
if (_oobeUpdate.ReportPage(record, occurredAtUtc, isBackfill))
|
||||
_pageWatermark.MarkEmitted(recordId);
|
||||
|
||||
// The registry is read now — only a live page boundary is the page's moment.
|
||||
if (!isBackfill && record.CxhEvent != OobeUpdatePageRecord.EventName)
|
||||
@@ -667,32 +713,74 @@ namespace AutopilotMonitor.Agent.V2.Core.Monitoring.Enrollment.SystemSignals
|
||||
}
|
||||
}
|
||||
|
||||
/// <summary>The own fields of a CloudExperienceHost record: CXID, result or name (%1) and the 62407 value (%2).</summary>
|
||||
internal readonly struct CxhFields
|
||||
{
|
||||
public CxhFields(string primary, string value)
|
||||
{
|
||||
Primary = primary;
|
||||
Value = value;
|
||||
}
|
||||
|
||||
/// <summary>62404: CXID; 62405: result; 62406/62407: event name. Null when not readable.</summary>
|
||||
public string Primary { get; }
|
||||
|
||||
/// <summary>62407: the raw value (never logged or sent unless it is of a safe form).</summary>
|
||||
public string Value { get; }
|
||||
}
|
||||
|
||||
/// <summary>
|
||||
/// The record's fields from its event properties, which carry them verbatim in every
|
||||
/// display language. Without properties (a test, a record that failed to render them) the
|
||||
/// formatted message is parsed — English punctuation and « » only, so a localized label
|
||||
/// ("Ergebnis", "Nom") yields null there.
|
||||
/// </summary>
|
||||
internal static CxhFields ReadCxhFields(int eventId, string description, IReadOnlyList<string> properties)
|
||||
{
|
||||
if (properties != null && properties.Count > 0)
|
||||
{
|
||||
return new CxhFields(
|
||||
Bound(properties[0]),
|
||||
eventId == EventId_ShellCore_WebAppEvent && properties.Count > 1 ? Bound(properties[1]) : null);
|
||||
}
|
||||
|
||||
switch (eventId)
|
||||
{
|
||||
case EventId_ShellCore_WebAppStarted:
|
||||
return new CxhFields(ExtractToken(CxidPattern, description), null);
|
||||
case EventId_ShellCore_WebAppStopped:
|
||||
return new CxhFields(ExtractToken(ResultPattern, description), null);
|
||||
case EventId_ShellCore_WebAppEventName:
|
||||
return new CxhFields(ExtractToken(NamePattern, description), null);
|
||||
case EventId_ShellCore_WebAppEvent:
|
||||
return new CxhFields(ExtractToken(NamePattern, description), ExtractToken(ValuePattern, description));
|
||||
default:
|
||||
return default;
|
||||
}
|
||||
}
|
||||
|
||||
/// <summary>
|
||||
/// The breadcrumb for one Shell-Core record, or null when it is not one: a page start
|
||||
/// (62404, its CXID), a page stop (62405, its result, attributed to the last started
|
||||
/// page), or an update-page event name (62406/62407 — a 62407 value only in a safe form).
|
||||
/// </summary>
|
||||
internal static string FormatCxhBreadcrumb(int eventId, string description, string lastPage)
|
||||
internal static string FormatCxhBreadcrumb(int eventId, string description, string lastPage) =>
|
||||
FormatCxhBreadcrumb(eventId, ReadCxhFields(eventId, description, null), lastPage);
|
||||
|
||||
internal static string FormatCxhBreadcrumb(int eventId, CxhFields fields, string lastPage)
|
||||
{
|
||||
switch (eventId)
|
||||
{
|
||||
case EventId_ShellCore_WebAppStarted:
|
||||
{
|
||||
var cxid = ExtractToken(CxidPattern, description);
|
||||
return cxid == null ? null : $"CXH page started: {cxid}";
|
||||
}
|
||||
return fields.Primary == null ? null : $"CXH page started: {fields.Primary}";
|
||||
case EventId_ShellCore_WebAppStopped:
|
||||
{
|
||||
var result = ExtractToken(ResultPattern, description) ?? "?";
|
||||
return $"CXH page stopped: {lastPage ?? "?"} (result={result})";
|
||||
}
|
||||
return $"CXH page stopped: {lastPage ?? "?"} (result={fields.Primary ?? "?"})";
|
||||
case EventId_ShellCore_WebAppEventName:
|
||||
case EventId_ShellCore_WebAppEvent:
|
||||
{
|
||||
var name = ExtractToken(NamePattern, description);
|
||||
if (!IsUpdatePageToken(name)) return null;
|
||||
var value = eventId == EventId_ShellCore_WebAppEvent ? ExtractSafeValue(description) : null;
|
||||
return value == null ? $"CXH event: {name}" : $"CXH event: {name} (value={value})";
|
||||
if (!IsUpdatePageToken(fields.Primary)) return null;
|
||||
var value = eventId == EventId_ShellCore_WebAppEvent ? SafeValue(fields.Value) : null;
|
||||
return value == null ? $"CXH event: {fields.Primary}" : $"CXH event: {fields.Primary} (value={value})";
|
||||
}
|
||||
default:
|
||||
return null;
|
||||
@@ -704,29 +792,28 @@ namespace AutopilotMonitor.Agent.V2.Core.Monitoring.Enrollment.SystemSignals
|
||||
/// the start of a page whose CXID names NDUP, the stop of such a page (62405, attributed
|
||||
/// to the last started page), or an update-page event name from 62406/62407.
|
||||
/// </summary>
|
||||
internal static OobeUpdatePageRecord ParseUpdatePageRecord(int eventId, string description, string lastPage)
|
||||
internal static OobeUpdatePageRecord ParseUpdatePageRecord(int eventId, string description, string lastPage) =>
|
||||
ParseUpdatePageRecord(eventId, ReadCxhFields(eventId, description, null), lastPage);
|
||||
|
||||
internal static OobeUpdatePageRecord ParseUpdatePageRecord(int eventId, CxhFields fields, string lastPage)
|
||||
{
|
||||
switch (eventId)
|
||||
{
|
||||
case EventId_ShellCore_WebAppStarted:
|
||||
{
|
||||
var cxid = ExtractToken(CxidPattern, description);
|
||||
return IsUpdatePageToken(cxid)
|
||||
? new OobeUpdatePageRecord(OobeUpdatePageRecord.PageStarted, eventId, page: cxid)
|
||||
return IsUpdatePageToken(fields.Primary)
|
||||
? new OobeUpdatePageRecord(OobeUpdatePageRecord.PageStarted, eventId, page: fields.Primary)
|
||||
: null;
|
||||
}
|
||||
case EventId_ShellCore_WebAppStopped:
|
||||
return IsUpdatePageToken(lastPage)
|
||||
? new OobeUpdatePageRecord(OobeUpdatePageRecord.PageStopped, eventId,
|
||||
page: lastPage, result: ExtractToken(ResultPattern, description) ?? "?")
|
||||
page: lastPage, result: fields.Primary ?? "?")
|
||||
: null;
|
||||
case EventId_ShellCore_WebAppEventName:
|
||||
case EventId_ShellCore_WebAppEvent:
|
||||
{
|
||||
var name = ExtractToken(NamePattern, description);
|
||||
if (!IsUpdatePageToken(name)) return null;
|
||||
var value = eventId == EventId_ShellCore_WebAppEvent ? ExtractSafeValue(description) : null;
|
||||
return new OobeUpdatePageRecord(OobeUpdatePageRecord.EventName, eventId, name: name, value: value);
|
||||
if (!IsUpdatePageToken(fields.Primary)) return null;
|
||||
var value = eventId == EventId_ShellCore_WebAppEvent ? SafeValue(fields.Value) : null;
|
||||
return new OobeUpdatePageRecord(OobeUpdatePageRecord.EventName, eventId, name: fields.Primary, value: value);
|
||||
}
|
||||
default:
|
||||
return null;
|
||||
@@ -738,14 +825,26 @@ namespace AutopilotMonitor.Agent.V2.Core.Monitoring.Enrollment.SystemSignals
|
||||
&& (token.IndexOf("NDUP", StringComparison.OrdinalIgnoreCase) >= 0
|
||||
|| token.IndexOf("ExpeditedUpdate", StringComparison.OrdinalIgnoreCase) >= 0);
|
||||
|
||||
/// <summary>
|
||||
/// The Hello wizard's CloudExperienceHost start: CXID <c>AADHello</c> or <c>NGC</c>. With
|
||||
/// no readable CXID the formatted message decides, as before (an English or German
|
||||
/// message quotes the CXID as <c>'NGC'</c>).
|
||||
/// </summary>
|
||||
internal static bool IsHelloWizardStart(string cxid, string description) =>
|
||||
cxid != null
|
||||
? cxid.Contains("AADHello") || string.Equals(cxid, "NGC", StringComparison.Ordinal)
|
||||
: description != null && (description.Contains("AADHello") || description.Contains("'NGC'"));
|
||||
|
||||
/// <summary>
|
||||
/// The 62407 value when it is a boolean, an integer of up to ten digits or an HRESULT —
|
||||
/// forms that cannot carry a URL or a tenant id (the CSP gate, error codes). Null for
|
||||
/// anything else.
|
||||
/// </summary>
|
||||
internal static string ExtractSafeValue(string description)
|
||||
internal static string ExtractSafeValue(string description) =>
|
||||
SafeValue(ReadCxhFields(EventId_ShellCore_WebAppEvent, description, null).Value);
|
||||
|
||||
internal static string SafeValue(string value)
|
||||
{
|
||||
var value = ExtractToken(ValuePattern, description);
|
||||
if (string.IsNullOrEmpty(value)) return null;
|
||||
try
|
||||
{
|
||||
@@ -763,9 +862,7 @@ namespace AutopilotMonitor.Agent.V2.Core.Monitoring.Enrollment.SystemSignals
|
||||
try
|
||||
{
|
||||
var match = pattern.Match(description);
|
||||
if (!match.Success) return null;
|
||||
var token = match.Groups[1].Value;
|
||||
return token.Length > MaxBreadcrumbTokenLength ? token.Substring(0, MaxBreadcrumbTokenLength) + "…" : token;
|
||||
return match.Success ? Bound(match.Groups[1].Value) : null;
|
||||
}
|
||||
catch (RegexMatchTimeoutException)
|
||||
{
|
||||
@@ -773,6 +870,30 @@ namespace AutopilotMonitor.Agent.V2.Core.Monitoring.Enrollment.SystemSignals
|
||||
}
|
||||
}
|
||||
|
||||
private static string Bound(string token)
|
||||
{
|
||||
if (string.IsNullOrEmpty(token)) return null;
|
||||
return token.Length > MaxBreadcrumbTokenLength ? token.Substring(0, MaxBreadcrumbTokenLength) + "…" : token;
|
||||
}
|
||||
|
||||
/// <summary>The event's property values as strings (the manifest's %1, %2, …); null when unreadable.</summary>
|
||||
private static IReadOnlyList<string> ReadProperties(EventRecord record)
|
||||
{
|
||||
try
|
||||
{
|
||||
var properties = record.Properties;
|
||||
if (properties == null || properties.Count == 0) return null;
|
||||
var values = new string[properties.Count];
|
||||
for (var i = 0; i < properties.Count; i++)
|
||||
values[i] = Convert.ToString(properties[i]?.Value, CultureInfo.InvariantCulture);
|
||||
return values;
|
||||
}
|
||||
catch (Exception)
|
||||
{
|
||||
return null;
|
||||
}
|
||||
}
|
||||
|
||||
// =====================================================================
|
||||
// Pattern helpers
|
||||
// =====================================================================
|
||||
@@ -812,4 +933,27 @@ namespace AutopilotMonitor.Agent.V2.Core.Monitoring.Enrollment.SystemSignals
|
||||
return "Unknown_ESP_Failure";
|
||||
}
|
||||
}
|
||||
|
||||
/// <summary>One Shell-Core record read by the restart backfill.</summary>
|
||||
internal readonly struct ShellCoreRecord
|
||||
{
|
||||
public ShellCoreRecord(int id, string description, DateTime occurredAtUtc, long recordId = -1, IReadOnlyList<string> properties = null)
|
||||
{
|
||||
Id = id;
|
||||
Description = description;
|
||||
OccurredAtUtc = occurredAtUtc;
|
||||
RecordId = recordId;
|
||||
Properties = properties;
|
||||
}
|
||||
|
||||
public int Id { get; }
|
||||
public string Description { get; }
|
||||
public DateTime OccurredAtUtc { get; }
|
||||
|
||||
/// <summary>The channel's RecordId; -1 when unknown (no cross-run dedup).</summary>
|
||||
public long RecordId { get; }
|
||||
|
||||
/// <summary>The event's property values (%1, %2, …); null when unknown.</summary>
|
||||
public IReadOnlyList<string> Properties { get; }
|
||||
}
|
||||
}
|
||||
|
||||
+2
-2
@@ -340,7 +340,7 @@ namespace AutopilotMonitor.Agent.V2.Core.Monitoring.Enrollment.SystemSignals
|
||||
Timestamp = timeCreatedUtc ?? DateTime.UtcNow,
|
||||
EventType = Constants.EventTypes.SystemClockChanged,
|
||||
Severity = isLargeStep ? EventSeverity.Warning : EventSeverity.Info,
|
||||
Source = "SystemTimelineWatcher",
|
||||
Source = Constants.EventSources.SystemTimelineWatcher,
|
||||
Phase = EnrollmentPhase.Unknown,
|
||||
Message = message,
|
||||
Data = data,
|
||||
@@ -467,7 +467,7 @@ namespace AutopilotMonitor.Agent.V2.Core.Monitoring.Enrollment.SystemSignals
|
||||
Timestamp = timeCreatedUtc ?? DateTime.UtcNow,
|
||||
EventType = Constants.EventTypes.SystemSleepEpisode,
|
||||
Severity = EventSeverity.Info,
|
||||
Source = "SystemTimelineWatcher",
|
||||
Source = Constants.EventSources.SystemTimelineWatcher,
|
||||
Phase = EnrollmentPhase.Unknown,
|
||||
Message = message,
|
||||
Data = data,
|
||||
|
||||
+2
-2
@@ -405,7 +405,7 @@ namespace AutopilotMonitor.Agent.V2.Core.Monitoring.Enrollment.SystemSignals
|
||||
Timestamp = timeCreatedUtc ?? DateTime.UtcNow,
|
||||
EventType = shape.EventType,
|
||||
Severity = shape.Severity,
|
||||
Source = "WindowsUpdateWatcher",
|
||||
Source = Constants.EventSources.WindowsUpdateWatcher,
|
||||
Phase = EnrollmentPhase.Unknown,
|
||||
Message = BuildMessage(eventId, title, updateCount, data),
|
||||
Data = data,
|
||||
@@ -707,7 +707,7 @@ namespace AutopilotMonitor.Agent.V2.Core.Monitoring.Enrollment.SystemSignals
|
||||
TenantId = _tenantId,
|
||||
EventType = Constants.EventTypes.WindowsUpdateChannelCensus,
|
||||
Severity = EventSeverity.Debug,
|
||||
Source = "WindowsUpdateWatcher",
|
||||
Source = Constants.EventSources.WindowsUpdateWatcher,
|
||||
Phase = EnrollmentPhase.Unknown,
|
||||
Message = "Windows Update channel census: OS build changed across restart but no targeted WU events were captured — EventID histogram attached",
|
||||
Data = data,
|
||||
|
||||
+2
@@ -215,6 +215,8 @@ namespace AutopilotMonitor.Agent.V2.Core.Monitoring.Telemetry.Periodic
|
||||
data["ime_verified_bytes"] = health.VerifiedBytes;
|
||||
data["ime_pass_max_ms"] = health.PassMaxMs;
|
||||
data["ime_pass_gap_max_ms"] = health.PassGapMaxMs;
|
||||
data["ime_platform_output_verified"] = health.PlatformOutputVerified;
|
||||
data["ime_platform_output_corrected"] = health.PlatformOutputCorrected;
|
||||
}
|
||||
}
|
||||
catch (Exception ex)
|
||||
|
||||
@@ -524,14 +524,17 @@ namespace AutopilotMonitor.Agent.V2.Core.Orchestration
|
||||
// EspTrackingWin32Apps, StatusServiceReports) via snapshot-and-diff. Emits
|
||||
// registry_app_state on real changes and app_state_reconciliation when the
|
||||
// registry outcome diverges from the IME-log-derived state (= built-in pattern-drift
|
||||
// alarm). Always-on observability host; the tracker probe is read-only.
|
||||
// alarm). Always-on observability host; the tracker probe is read-only. Under the same
|
||||
// root IME saves each platform script's result after reporting the batch: the script
|
||||
// observer checks the tracker's emitted runs against it (script_output_reconciliation).
|
||||
hosts.Add(new ImeRegistryAppStateHost(
|
||||
sessionId: sessionId,
|
||||
tenantId: tenantId,
|
||||
logger: logger,
|
||||
ingress: ingress,
|
||||
clock: clock,
|
||||
trackerStateProbe: () => imeLogHost.AllKnownPackageStates));
|
||||
trackerStateProbe: () => imeLogHost.AllKnownPackageStates,
|
||||
scriptRuns: imeLogHost.Tracker.ScriptRuns));
|
||||
|
||||
// Deterministic update corroboration — compares the persisted OS build (CurrentBuild.UBR)
|
||||
// across agent restarts and emits os_build_changed when it differs (session 7443317c:
|
||||
|
||||
+11
-4
@@ -15,9 +15,10 @@ namespace AutopilotMonitor.Agent.V2.Core.Orchestration
|
||||
{
|
||||
/// <summary>
|
||||
/// Hosts the <see cref="ImeRegistryAppStateObserver"/> (registry second pillar, audit
|
||||
/// 2026-08-17): one recursive <see cref="RegistryWatcher"/> on the IME root — all three
|
||||
/// observed surfaces (Win32Apps, EspTrackingWin32Apps, SideCarPolicies\StatusServiceReports)
|
||||
/// live under it — debounced into snapshot-and-diff ticks, plus a 60-s periodic fallback
|
||||
/// 2026-08-17) and the <see cref="ImeRegistryScriptResultObserver"/> (D-316): one recursive
|
||||
/// <see cref="RegistryWatcher"/> on the IME root — every observed surface (Win32Apps,
|
||||
/// EspTrackingWin32Apps, SideCarPolicies\StatusServiceReports, Policies) lives under it —
|
||||
/// debounced into snapshot-and-diff ticks, plus a 60-s periodic fallback
|
||||
/// tick. The fallback both evaluates the reconciliation settle-delay when the registry goes
|
||||
/// quiet AND keeps the pillar alive if the watcher fails to arm (poll-only degraded mode,
|
||||
/// announced once via <c>collector_degraded</c>). Always-on observability host, no config
|
||||
@@ -31,6 +32,8 @@ namespace AutopilotMonitor.Agent.V2.Core.Orchestration
|
||||
private static readonly TimeSpan PeriodicInterval = TimeSpan.FromSeconds(60);
|
||||
|
||||
private readonly ImeRegistryAppStateObserver _observer;
|
||||
// Platform-script results under the same root (D-316); null when no run register was supplied.
|
||||
private readonly ImeRegistryScriptResultObserver? _scriptObserver;
|
||||
private readonly InformationalEventPost _post;
|
||||
private readonly AgentLogger? _logger;
|
||||
private readonly string _sessionId;
|
||||
@@ -47,7 +50,8 @@ namespace AutopilotMonitor.Agent.V2.Core.Orchestration
|
||||
AgentLogger? logger,
|
||||
ISignalIngressSink ingress,
|
||||
IClock clock,
|
||||
Func<IReadOnlyList<AppPackageState>>? trackerStateProbe)
|
||||
Func<IReadOnlyList<AppPackageState>>? trackerStateProbe,
|
||||
PlatformScriptRunRegister? scriptRuns = null)
|
||||
{
|
||||
if (ingress == null) throw new ArgumentNullException(nameof(ingress));
|
||||
if (clock == null) throw new ArgumentNullException(nameof(clock));
|
||||
@@ -56,6 +60,7 @@ namespace AutopilotMonitor.Agent.V2.Core.Orchestration
|
||||
_logger = logger;
|
||||
_post = new InformationalEventPost(ingress, clock);
|
||||
_observer = new ImeRegistryAppStateObserver(_post, logger, clock, trackerStateProbe);
|
||||
if (scriptRuns != null) _scriptObserver = new ImeRegistryScriptResultObserver(scriptRuns, _post, logger, clock);
|
||||
}
|
||||
|
||||
public void Start()
|
||||
@@ -63,6 +68,7 @@ namespace AutopilotMonitor.Agent.V2.Core.Orchestration
|
||||
// Baseline immediately: pre-existing registry state must be captured silently
|
||||
// BEFORE the first change edge, or stale entries would replay as fresh events.
|
||||
_observer.Tick("baseline");
|
||||
_scriptObserver?.Tick("baseline");
|
||||
|
||||
try
|
||||
{
|
||||
@@ -120,6 +126,7 @@ namespace AutopilotMonitor.Agent.V2.Core.Orchestration
|
||||
try
|
||||
{
|
||||
_observer.Tick(reason);
|
||||
_scriptObserver?.Tick(reason);
|
||||
}
|
||||
catch (Exception ex)
|
||||
{
|
||||
|
||||
+2
-2
@@ -197,7 +197,7 @@ namespace AutopilotMonitor.Agent.V2.Core.Orchestration
|
||||
TenantId = _tenantId,
|
||||
EventType = SharedConstants.EventTypes.WindowsUpdateActivitySummary,
|
||||
Severity = EventSeverity.Debug,
|
||||
Source = "WindowsUpdateWatcher",
|
||||
Source = SharedConstants.EventSources.WindowsUpdateWatcher,
|
||||
Phase = EnrollmentPhase.Unknown,
|
||||
Message = $"Update activity counted instead of listed: {total} event(s) " +
|
||||
"(Store, Defender and other non-OS updates, repeated scan results, servicing of non-OS packages)",
|
||||
@@ -223,7 +223,7 @@ namespace AutopilotMonitor.Agent.V2.Core.Orchestration
|
||||
_ingress.Post(
|
||||
kind: DecisionSignalKind.OsUpdateActivity,
|
||||
occurredAtUtc: DateTime.SpecifyKind(occurredAtUtc, DateTimeKind.Utc),
|
||||
sourceOrigin: source == "servicing" ? "ServicingWatcher" : "WindowsUpdateWatcher",
|
||||
sourceOrigin: source == "servicing" ? SharedConstants.EventSources.ServicingWatcher : SharedConstants.EventSources.WindowsUpdateWatcher,
|
||||
evidence: new Evidence(
|
||||
kind: EvidenceKind.Raw,
|
||||
identifier: $"os-update-activity:{source}",
|
||||
|
||||
@@ -92,6 +92,9 @@ namespace AutopilotMonitor.Agent.V2.Core.Orchestration
|
||||
SharedConstants.EventTypes.ImePatternHits,
|
||||
// Bookkeeping of runs that were deliberately not reported as activity.
|
||||
SharedConstants.EventTypes.ScriptRecurrenceSummary,
|
||||
// A correction of an already reported script run from IME's saved result (D-316):
|
||||
// registry observation after the fact, not progress.
|
||||
SharedConstants.EventTypes.ScriptOutputReconciliation,
|
||||
// Same for the update watchers' tally of Store/Defender/other update events (D-310):
|
||||
// emitted on stop, never progress. Windows/.NET update steps stay activity.
|
||||
SharedConstants.EventTypes.WindowsUpdateActivitySummary,
|
||||
|
||||
@@ -1263,6 +1263,8 @@ namespace AutopilotMonitor.Agent.V2.Core.SignalAdapters
|
||||
// logged its result line before the deadline). Lets the UI/MCP flag fallback-grounded
|
||||
// platform-script completions. Platform scripts only — null for health scripts.
|
||||
if (!string.IsNullOrEmpty(script.ResultSource)) data["resultSource"] = script.ResultSource!;
|
||||
// The run a later script_output_reconciliation corrects names it by this id (platform only).
|
||||
if (!string.IsNullOrEmpty(script.RunId)) data["runId"] = script.RunId!;
|
||||
if (!string.IsNullOrEmpty(script.ComplianceResult)) data["complianceResult"] = script.ComplianceResult!;
|
||||
if (script.RemediationStatus.HasValue) data["remediationStatus"] = script.RemediationStatus.Value.ToString(culture);
|
||||
if (script.TargetType.HasValue) data["targetType"] = script.TargetType.Value.ToString(culture);
|
||||
|
||||
@@ -599,6 +599,8 @@ namespace AutopilotMonitor.Agent.V2.Core.Termination
|
||||
["verifiedBytes"] = health.VerifiedBytes,
|
||||
["passMaxMs"] = health.PassMaxMs,
|
||||
["passGapMaxMs"] = health.PassGapMaxMs,
|
||||
["platformOutputVerified"] = health.PlatformOutputVerified,
|
||||
["platformOutputCorrected"] = health.PlatformOutputCorrected,
|
||||
["agentVersion"] = _agentVersion ?? string.Empty,
|
||||
};
|
||||
if (!string.IsNullOrEmpty(health.ImeAgentVersion))
|
||||
|
||||
@@ -455,6 +455,25 @@ public class AuthFunctionTests
|
||||
Assert.Equal(Constants.TenantRoles.Operator, (string)body.role);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void AutoAdmin_NotTriggered_ForClaimDerivedViewer_WhenNoTableMembers()
|
||||
{
|
||||
// Same guard for the read-only claim role: an Entra app-role Viewer in a claim-only tenant
|
||||
// stays a Viewer and is never written into the table as Admin.
|
||||
var result = AuthFunction.BuildAuthResult(
|
||||
DefaultConfig(), isGlobalAdmin: false, isGlobalReader: false, isPreviewApproved: true,
|
||||
memberRole: ViewerRole(), // came from the "roles" claim
|
||||
mcpCheck: McpDenied(),
|
||||
hasTenantAdmins: false,
|
||||
TenantId, Upn, DisplayName, ObjectId);
|
||||
|
||||
Assert.True(result.IsSuccess);
|
||||
Assert.False(result.NeedsAutoAdmin);
|
||||
var body = ToDynamic(result.Body);
|
||||
Assert.False((bool)body.isTenantAdmin);
|
||||
Assert.Equal(Constants.TenantRoles.Viewer, (string)body.role);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void AutoAdmin_NotTriggered_WhenUserAlreadyAdmin()
|
||||
{
|
||||
|
||||
@@ -25,7 +25,37 @@ public class EntraAppRoleResolverTests
|
||||
[Fact]
|
||||
public void MapClaimRole_UnknownRole_ReturnsNull()
|
||||
{
|
||||
Assert.Null(EntraAppRoleResolver.MapClaimRole(new[] { "Viewer", "SomethingElse" }));
|
||||
// Neither a foreign value nor an application permission ever becomes a member role.
|
||||
Assert.Null(EntraAppRoleResolver.MapClaimRole(new[] { "SomethingElse", "access_as_application", "GlobalAdmin" }));
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void MapClaimRole_Viewer_IsReadOnlyWithoutBootstrapPermission()
|
||||
{
|
||||
var role = EntraAppRoleResolver.MapClaimRole(new[] { "SomethingElse", Constants.TenantRoles.Viewer });
|
||||
|
||||
Assert.NotNull(role);
|
||||
Assert.Equal(Constants.TenantRoles.Viewer, role!.Role);
|
||||
Assert.False(role.CanManageBootstrapTokens);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void MapClaimRole_OperatorOutranksViewer_WhenBothPresent()
|
||||
{
|
||||
var role = EntraAppRoleResolver.MapClaimRole(
|
||||
new[] { Constants.TenantRoles.Viewer, Constants.TenantRoles.Operator });
|
||||
|
||||
Assert.Equal(Constants.TenantRoles.Operator, role!.Role);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void MapClaimRole_AdminOutranksViewer_WhenBothPresent()
|
||||
{
|
||||
var role = EntraAppRoleResolver.MapClaimRole(
|
||||
new[] { Constants.TenantRoles.Viewer, Constants.TenantRoles.Admin });
|
||||
|
||||
Assert.Equal(Constants.TenantRoles.Admin, role!.Role);
|
||||
Assert.True(role.CanManageBootstrapTokens);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
@@ -63,6 +93,7 @@ public class EntraAppRoleResolverTests
|
||||
var role = EntraAppRoleResolver.MapClaimRole(new[] { "admin" });
|
||||
|
||||
Assert.Equal(Constants.TenantRoles.Admin, role!.Role);
|
||||
Assert.Equal(Constants.TenantRoles.Viewer, EntraAppRoleResolver.MapClaimRole(new[] { " viewer " })!.Role);
|
||||
}
|
||||
|
||||
// -------------------------------------------------------------------------
|
||||
@@ -106,14 +137,43 @@ public class EntraAppRoleResolverTests
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void Resolve_NoTableRow_IgnoresClaim_WhenTenantFlagDisabled()
|
||||
public void Resolve_NoTableRow_FallsBackToViewerClaim_WhenEnabled()
|
||||
{
|
||||
var result = EntraAppRoleResolver.Resolve(
|
||||
TableMemberState.NotPresent, null, new[] { Constants.TenantRoles.Admin }, appRolesEnabled: false);
|
||||
TableMemberState.NotPresent, null, new[] { Constants.TenantRoles.Viewer }, appRolesEnabled: true);
|
||||
|
||||
Assert.Equal(Constants.TenantRoles.Viewer, result!.Role);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void Resolve_DisabledTableRow_IgnoresViewerClaim()
|
||||
{
|
||||
var result = EntraAppRoleResolver.Resolve(
|
||||
TableMemberState.Disabled, null, new[] { Constants.TenantRoles.Viewer }, appRolesEnabled: true);
|
||||
|
||||
Assert.Null(result);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void Resolve_EnabledTableViewer_WinsOverHigherClaim()
|
||||
{
|
||||
var tableRole = new MemberRoleInfo { Role = Constants.TenantRoles.Viewer };
|
||||
|
||||
var result = EntraAppRoleResolver.Resolve(
|
||||
TableMemberState.Enabled, tableRole, new[] { Constants.TenantRoles.Admin }, appRolesEnabled: true);
|
||||
|
||||
Assert.Equal(Constants.TenantRoles.Viewer, result!.Role);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void Resolve_NoTableRow_IgnoresClaim_WhenTenantFlagDisabled()
|
||||
{
|
||||
Assert.Null(EntraAppRoleResolver.Resolve(
|
||||
TableMemberState.NotPresent, null, new[] { Constants.TenantRoles.Admin }, appRolesEnabled: false));
|
||||
Assert.Null(EntraAppRoleResolver.Resolve(
|
||||
TableMemberState.NotPresent, null, new[] { Constants.TenantRoles.Viewer }, appRolesEnabled: false));
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void Resolve_NoTableRow_NoClaim_ReturnsNull()
|
||||
{
|
||||
|
||||
@@ -0,0 +1,45 @@
|
||||
using System.Globalization;
|
||||
using AutopilotMonitor.Functions.Services;
|
||||
|
||||
namespace AutopilotMonitor.Functions.Tests;
|
||||
|
||||
/// <summary>
|
||||
/// The versioned platform-stats file is served immutable for a year, so every publish must write
|
||||
/// a new name. Maintenance publishes every 2 hours; the per-day name it used to write was rewritten
|
||||
/// up to 12 times a day, and caches kept the first copy of the day.
|
||||
/// </summary>
|
||||
public class PlatformStatsPublishTests
|
||||
{
|
||||
private static readonly DateTime Publish = new(2026, 10, 3, 6, 0, 4, DateTimeKind.Utc);
|
||||
|
||||
[Fact]
|
||||
public void Versioned_file_name_carries_the_publish_instant_to_the_second()
|
||||
{
|
||||
Assert.Equal("platform-stats.2026-10-03T060004Z.json", MaintenanceService.PlatformStatsVersionedFileName(Publish));
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void Two_publishes_of_one_day_get_different_names()
|
||||
{
|
||||
var early = MaintenanceService.PlatformStatsVersionedFileName(new DateTime(2026, 10, 3, 2, 0, 3, DateTimeKind.Utc));
|
||||
var later = MaintenanceService.PlatformStatsVersionedFileName(new DateTime(2026, 10, 3, 4, 0, 3, DateTimeKind.Utc));
|
||||
|
||||
Assert.NotEqual(early, later);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void Versioned_file_name_ignores_the_current_culture()
|
||||
{
|
||||
var previous = CultureInfo.CurrentCulture;
|
||||
try
|
||||
{
|
||||
// th-TH counts years in the Buddhist era (2569 for 2026).
|
||||
CultureInfo.CurrentCulture = new CultureInfo("th-TH");
|
||||
Assert.Equal("platform-stats.2026-10-03T060004Z.json", MaintenanceService.PlatformStatsVersionedFileName(Publish));
|
||||
}
|
||||
finally
|
||||
{
|
||||
CultureInfo.CurrentCulture = previous;
|
||||
}
|
||||
}
|
||||
}
|
||||
@@ -0,0 +1,142 @@
|
||||
using System.Net;
|
||||
using System.Text.Json;
|
||||
using AutopilotMonitor.Functions.Functions.Progress;
|
||||
using AutopilotMonitor.Functions.Security;
|
||||
using AutopilotMonitor.Functions.Services;
|
||||
using AutopilotMonitor.Shared.DataAccess;
|
||||
using AutopilotMonitor.Shared.Models;
|
||||
using Microsoft.Extensions.Caching.Memory;
|
||||
using Microsoft.Extensions.Logging;
|
||||
using Moq;
|
||||
using Xunit;
|
||||
|
||||
namespace AutopilotMonitor.Functions.Tests;
|
||||
|
||||
/// <summary>
|
||||
/// The Progress Portal's tenant status: when an organization reads as unused (no session, signed up
|
||||
/// longer than <see cref="ProgressTenantStatusFunction.UnusedAfter"/> ago), and that a failed read never
|
||||
/// does.
|
||||
/// </summary>
|
||||
public class ProgressTenantStatusFunctionTests
|
||||
{
|
||||
private const string TenantId = "11111111-1111-1111-1111-111111111111";
|
||||
private static readonly DateTime Now = new(2026, 10, 2, 12, 0, 0, DateTimeKind.Utc);
|
||||
|
||||
private static TenantConfiguration Config(DateTime? onboardedAt)
|
||||
=> new() { TenantId = TenantId, OnboardedAt = onboardedAt };
|
||||
|
||||
// ── Policy catalog ───────────────────────────────────────────────────────
|
||||
|
||||
[Fact]
|
||||
public void Route_is_AuthenticatedUser_scoped_to_the_JWT_tenant()
|
||||
{
|
||||
// Members without a role are the audience, so the tier must not require membership; the route
|
||||
// takes no tenant parameter, so no caller can ask about another organization.
|
||||
var entry = EndpointAccessPolicyCatalog.FindPolicy("GET", "progress/tenant-status");
|
||||
|
||||
Assert.NotNull(entry);
|
||||
Assert.Equal(EndpointPolicy.AuthenticatedUser, entry!.Policy);
|
||||
Assert.Equal(TenantScoping.Jwt, entry.TenantScoping);
|
||||
}
|
||||
|
||||
// ── Evaluate ─────────────────────────────────────────────────────────────
|
||||
|
||||
[Fact]
|
||||
public void No_session_and_signed_up_a_month_ago_is_unused()
|
||||
{
|
||||
var signedUp = Now.AddDays(-30);
|
||||
|
||||
var status = ProgressTenantStatusFunction.Evaluate(Config(signedUp), hasAnySession: false, Now);
|
||||
|
||||
Assert.True(status.Success);
|
||||
Assert.True(status.Unused);
|
||||
Assert.Equal(signedUp, status.SignedUpAt);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void Any_session_means_in_use()
|
||||
{
|
||||
var status = ProgressTenantStatusFunction.Evaluate(Config(Now.AddDays(-300)), hasAnySession: true, Now);
|
||||
|
||||
Assert.False(status.Unused);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void An_organization_still_being_set_up_is_not_unused()
|
||||
{
|
||||
var status = ProgressTenantStatusFunction.Evaluate(Config(Now.AddDays(-13)), hasAnySession: false, Now);
|
||||
|
||||
Assert.False(status.Unused);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void The_window_closes_after_exactly_fourteen_days()
|
||||
{
|
||||
var status = ProgressTenantStatusFunction.Evaluate(
|
||||
Config(Now - ProgressTenantStatusFunction.UnusedAfter), hasAnySession: false, Now);
|
||||
|
||||
Assert.True(status.Unused);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void A_row_without_a_signup_date_is_old_and_reports_no_date()
|
||||
{
|
||||
var status = ProgressTenantStatusFunction.Evaluate(Config(onboardedAt: null), hasAnySession: false, Now);
|
||||
|
||||
Assert.True(status.Unused);
|
||||
Assert.Null(status.SignedUpAt);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void Without_a_configuration_row_nothing_is_unused()
|
||||
{
|
||||
var status = ProgressTenantStatusFunction.Evaluate(config: null, hasAnySession: false, Now);
|
||||
|
||||
Assert.True(status.Success);
|
||||
Assert.False(status.Unused);
|
||||
Assert.Null(status.SignedUpAt);
|
||||
}
|
||||
|
||||
// ── HTTP ─────────────────────────────────────────────────────────────────
|
||||
|
||||
private static (ProgressTenantStatusFunction Sut, Mock<ISessionRepository> Sessions) Build(TenantConfiguration? row)
|
||||
{
|
||||
var configService = new Mock<TenantConfigurationService>(
|
||||
Mock.Of<IConfigRepository>(), Mock.Of<ILogger<TenantConfigurationService>>(), Mock.Of<IMemoryCache>())
|
||||
{ CallBase = false };
|
||||
configService.Setup(s => s.GetConfigurationIfExistsAsync(TenantId)).ReturnsAsync(row);
|
||||
|
||||
var sessions = new Mock<ISessionRepository>(MockBehavior.Strict);
|
||||
var sut = new ProgressTenantStatusFunction(
|
||||
Mock.Of<ILogger<ProgressTenantStatusFunction>>(), configService.Object, sessions.Object);
|
||||
return (sut, sessions);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public async Task Answers_for_the_callers_own_tenant()
|
||||
{
|
||||
var (sut, sessions) = Build(Config(DateTime.UtcNow.AddDays(-60)));
|
||||
sessions.Setup(s => s.HasAnySessionStrictAsync(TenantId)).ReturnsAsync(false);
|
||||
var (req, _) = EndpointHarness.Request(TenantId);
|
||||
|
||||
var response = await sut.GetTenantStatus(req);
|
||||
|
||||
Assert.Equal(HttpStatusCode.OK, response.StatusCode);
|
||||
response.Body.Position = 0;
|
||||
using var doc = JsonDocument.Parse(response.Body);
|
||||
Assert.True(doc.RootElement.GetProperty("unused").GetBoolean());
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public async Task A_failed_session_read_is_an_error_never_unused()
|
||||
{
|
||||
var (sut, sessions) = Build(Config(DateTime.UtcNow.AddDays(-60)));
|
||||
sessions.Setup(s => s.HasAnySessionStrictAsync(TenantId))
|
||||
.ThrowsAsync(new InvalidOperationException("storage unavailable"));
|
||||
var (req, _) = EndpointHarness.Request(TenantId);
|
||||
|
||||
var response = await sut.GetTenantStatus(req);
|
||||
|
||||
Assert.Equal(HttpStatusCode.InternalServerError, response.StatusCode);
|
||||
}
|
||||
}
|
||||
@@ -137,4 +137,27 @@ public class ProgressWireParityTests
|
||||
Events = events
|
||||
});
|
||||
}
|
||||
|
||||
// GET /api/progress/tenant-status — typed from the start; the anonymous side is the literal the
|
||||
// portal reads.
|
||||
[Fact]
|
||||
public void ProgressTenantStatus_unused_with_signup_date()
|
||||
{
|
||||
var signedUpAt = new DateTime(2026, 3, 12, 8, 30, 0, DateTimeKind.Utc);
|
||||
|
||||
ApiResponseWireParityTests.AssertWireIdentical(
|
||||
new { success = true, unused = true, signedUpAt = signedUpAt },
|
||||
new ProgressTenantStatusResponse { Success = true, Unused = true, SignedUpAt = signedUpAt });
|
||||
}
|
||||
|
||||
// An unknown signup date drops the key on both sides (WhenWritingNull).
|
||||
[Fact]
|
||||
public void ProgressTenantStatus_without_signup_date_omits_the_key()
|
||||
{
|
||||
DateTime? signedUpAt = null;
|
||||
|
||||
ApiResponseWireParityTests.AssertWireIdentical(
|
||||
new { success = true, unused = false, signedUpAt = signedUpAt },
|
||||
new ProgressTenantStatusResponse { Success = true, Unused = false, SignedUpAt = signedUpAt });
|
||||
}
|
||||
}
|
||||
|
||||
+52
@@ -0,0 +1,52 @@
|
||||
using System;
|
||||
using System.Collections.Generic;
|
||||
using AutopilotMonitor.Functions.Services;
|
||||
using AutopilotMonitor.Shared;
|
||||
using AutopilotMonitor.Shared.Models;
|
||||
using Xunit;
|
||||
|
||||
namespace AutopilotMonitor.Functions.Tests;
|
||||
|
||||
/// <summary>
|
||||
/// D-316: the agent corrects an already reported platform run from IME's saved result with a
|
||||
/// script_output_reconciliation. It is observation of an earlier run: it never heals a Stalled session and never
|
||||
/// counts as another script run.
|
||||
/// </summary>
|
||||
public class ScriptOutputReconciliationClassificationTests
|
||||
{
|
||||
private static readonly DateTime At = new(2026, 10, 3, 20, 59, 8, DateTimeKind.Utc);
|
||||
|
||||
[Fact]
|
||||
public void A_correction_alone_is_no_real_activity_and_no_script_run()
|
||||
{
|
||||
var classification = EventIngestProcessor.ClassifyEvents(new List<EnrollmentEvent>
|
||||
{
|
||||
Event(Constants.EventTypes.ScriptOutputReconciliation, new Dictionary<string, object> { ["scriptType"] = "platform", ["runId"] = "run-1", ["outcome"] = "foreign" }),
|
||||
});
|
||||
|
||||
Assert.False(classification.HasNonPeriodicRealEvent);
|
||||
Assert.Equal(0, classification.PlatformScriptCount);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void The_corrected_run_counts_once_as_a_platform_script()
|
||||
{
|
||||
var classification = EventIngestProcessor.ClassifyEvents(new List<EnrollmentEvent>
|
||||
{
|
||||
Event("script_failed", new Dictionary<string, object> { ["scriptType"] = "platform", ["runId"] = "run-1", ["exitCode"] = "1" }),
|
||||
Event(Constants.EventTypes.ScriptOutputReconciliation, new Dictionary<string, object> { ["scriptType"] = "platform", ["runId"] = "run-1", ["outcome"] = "foreign" }),
|
||||
});
|
||||
|
||||
Assert.True(classification.HasNonPeriodicRealEvent);
|
||||
Assert.Equal(1, classification.PlatformScriptCount);
|
||||
}
|
||||
|
||||
private static EnrollmentEvent Event(string eventType, Dictionary<string, object> data) => new()
|
||||
{
|
||||
EventId = Guid.NewGuid().ToString(),
|
||||
Timestamp = At,
|
||||
EventType = eventType,
|
||||
Source = "RegistryScriptResult",
|
||||
Data = data,
|
||||
};
|
||||
}
|
||||
@@ -0,0 +1,86 @@
|
||||
using System;
|
||||
using System.Collections.Generic;
|
||||
using AutopilotMonitor.Functions.Services;
|
||||
using AutopilotMonitor.Shared;
|
||||
using AutopilotMonitor.Shared.Models;
|
||||
using Xunit;
|
||||
|
||||
namespace AutopilotMonitor.Functions.Tests;
|
||||
|
||||
/// <summary>
|
||||
/// Backfilled environment observations never set the session start (D-315). Since agent 2.0.1473
|
||||
/// the update and servicing watchers deliver rows with their original event time up to 60 min
|
||||
/// before the agent started; anchoring on them stretched StartedAt by 22 min at the median
|
||||
/// (p90 57 min). Source strings are the persisted wire values, spelled out on purpose.
|
||||
/// </summary>
|
||||
public class SessionAnchorSourceTests
|
||||
{
|
||||
private static readonly DateTime AgentStart = new(2026, 10, 3, 9, 6, 46, DateTimeKind.Utc);
|
||||
|
||||
[Theory]
|
||||
[InlineData("SystemTimelineWatcher")]
|
||||
[InlineData("WindowsUpdateWatcher")]
|
||||
[InlineData("ServicingWatcher")]
|
||||
public void Backfill_sources_are_not_anchor_eligible(string source)
|
||||
{
|
||||
Assert.False(Constants.EventSources.IsSessionAnchorEligible(source));
|
||||
}
|
||||
|
||||
[Theory]
|
||||
[InlineData("ImeLogTracker")]
|
||||
[InlineData("Agent")]
|
||||
[InlineData("MdmRebootPolicyWatcher")]
|
||||
[InlineData("windowsupdatewatcher")] // ordinal: a differently cased source is not the watcher
|
||||
[InlineData(null)] // legacy row without a source
|
||||
public void Activity_sources_are_anchor_eligible(string? source)
|
||||
{
|
||||
Assert.True(Constants.EventSources.IsSessionAnchorEligible(source));
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void Ingest_batch_anchors_on_the_first_activity_not_on_backfilled_update_rows()
|
||||
{
|
||||
// Shape of session 0f1d1f58: update scans and CBS servicing backfilled from before the
|
||||
// IME replay, a clock step even earlier, then IME replay, agent start, a live update row.
|
||||
var firstImeLine = AgentStart.AddMinutes(-10);
|
||||
var liveUpdate = AgentStart.AddMinutes(25);
|
||||
var events = new List<EnrollmentEvent>
|
||||
{
|
||||
Event(AgentStart.AddMinutes(-16), "system_clock_changed", "SystemTimelineWatcher"),
|
||||
Event(AgentStart.AddMinutes(-15), "windows_update_started", "WindowsUpdateWatcher"),
|
||||
Event(AgentStart.AddMinutes(-14), "windows_update_servicing", "ServicingWatcher"),
|
||||
Event(firstImeLine, "ime_agent_version", "ImeLogTracker"),
|
||||
Event(AgentStart, "agent_started", "Agent"),
|
||||
Event(liveUpdate, "windows_update_started", "WindowsUpdateWatcher"),
|
||||
};
|
||||
|
||||
var classification = EventIngestProcessor.ClassifyEvents(events);
|
||||
|
||||
Assert.Equal(firstImeLine, classification.EarliestEventTimestamp);
|
||||
// The latest timestamp still counts every row: a live update row is a real agent report.
|
||||
Assert.Equal(liveUpdate, classification.LatestEventTimestamp);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void Ingest_batch_of_only_backfilled_rows_carries_no_anchor()
|
||||
{
|
||||
var events = new List<EnrollmentEvent>
|
||||
{
|
||||
Event(AgentStart.AddMinutes(-50), "windows_update_started", "WindowsUpdateWatcher"),
|
||||
Event(AgentStart.AddMinutes(-40), "windows_update_servicing", "ServicingWatcher"),
|
||||
};
|
||||
|
||||
var classification = EventIngestProcessor.ClassifyEvents(events);
|
||||
|
||||
Assert.Null(classification.EarliestEventTimestamp);
|
||||
Assert.Equal(AgentStart.AddMinutes(-40), classification.LatestEventTimestamp);
|
||||
}
|
||||
|
||||
private static EnrollmentEvent Event(DateTime timestamp, string eventType, string source) => new()
|
||||
{
|
||||
EventId = Guid.NewGuid().ToString(),
|
||||
Timestamp = timestamp,
|
||||
EventType = eventType,
|
||||
Source = source,
|
||||
};
|
||||
}
|
||||
+28
-1
@@ -104,10 +104,14 @@ public class SessionStartedAtBackwardShiftGuardTests
|
||||
// =========================== system-timeline rows are not session anchors ====
|
||||
|
||||
[Fact]
|
||||
public void IsSessionAnchorEligible_excludes_system_timeline_watcher_rows()
|
||||
public void IsSessionAnchorEligible_excludes_backfilled_environment_rows()
|
||||
{
|
||||
Assert.False(TableStorageService.IsSessionAnchorEligible(
|
||||
new TableEntity("p", "r") { ["Source"] = "SystemTimelineWatcher" }));
|
||||
Assert.False(TableStorageService.IsSessionAnchorEligible(
|
||||
new TableEntity("p", "r") { ["Source"] = "WindowsUpdateWatcher" }));
|
||||
Assert.False(TableStorageService.IsSessionAnchorEligible(
|
||||
new TableEntity("p", "r") { ["Source"] = "ServicingWatcher" }));
|
||||
Assert.True(TableStorageService.IsSessionAnchorEligible(
|
||||
new TableEntity("p", "r") { ["Source"] = "ImeLogTracker" }));
|
||||
Assert.True(TableStorageService.IsSessionAnchorEligible(
|
||||
@@ -140,6 +144,29 @@ public class SessionStartedAtBackwardShiftGuardTests
|
||||
Assert.Equal((int)(lastEvent - firstActivity).TotalSeconds, harness.Written!.GetInt32("DurationSeconds"));
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public async Task Pending_duration_skips_backfilled_update_rows_and_anchors_on_activity()
|
||||
{
|
||||
// D-315: update scans and CBS servicing backfilled with their event time up to 60 min
|
||||
// before the agent started were the partition's earliest rows and re-anchored StartedAt.
|
||||
var firstActivity = StartedAt.AddMinutes(-5);
|
||||
var lastEvent = StartedAt.AddMinutes(70);
|
||||
var harness = new Harness(SessionRow(), eventRows: new[]
|
||||
{
|
||||
EventRow(StartedAt.AddMinutes(-55), sequence: 27, source: "WindowsUpdateWatcher"),
|
||||
EventRow(StartedAt.AddMinutes(-50), sequence: 34, source: "ServicingWatcher"),
|
||||
EventRow(firstActivity, sequence: 2, source: "ImeLogTracker"),
|
||||
});
|
||||
|
||||
var ok = await harness.Sut.UpdateSessionStatusAsync(
|
||||
TenantId, SessionId, SessionStatus.Pending, VerdictPaths.AgentWhiteGlovePending,
|
||||
latestEventTimestamp: lastEvent);
|
||||
|
||||
Assert.True(ok);
|
||||
Assert.NotNull(harness.Written);
|
||||
Assert.Equal((int)(lastEvent - firstActivity).TotalSeconds, harness.Written!.GetInt32("DurationSeconds"));
|
||||
}
|
||||
|
||||
private static TableEntity EventRow(DateTime occurredUtc, int sequence, string source) =>
|
||||
new($"{TenantId}_{SessionId}", $"{occurredUtc:yyyyMMddHHmmssfff}_{sequence:D10}")
|
||||
{
|
||||
|
||||
@@ -90,6 +90,8 @@ public sealed class SharedManifestParityTests
|
||||
["annotationVerdicts"] = AnnotationVerdicts.All,
|
||||
// Install channels of the app rows (AppInstallSummary.Source and the per-app DTOs).
|
||||
["appInstallSources"] = AppInstallSources.All,
|
||||
// Event sources whose rows never set a session's start; the portal's session duration applies them.
|
||||
["sessionAnchorIneligibleSources"] = Constants.EventSources.SessionAnchorIneligible,
|
||||
// Community rule submissions: kinds, effective statuses (incl. the derived "published"),
|
||||
// attribution modes and reviewer decisions — the MCP tool schemas enumerate these.
|
||||
["ruleSubmissionKinds"] = RuleSubmissionKinds.All,
|
||||
|
||||
@@ -87,4 +87,15 @@ public class TenantMemberRoleResolverTests
|
||||
|
||||
Assert.Equal(Constants.TenantRoles.Operator, role?.Role);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public async Task NoRow_ViewerClaim_IsAReadOnlyMember_WhenTheTenantOptedIn()
|
||||
{
|
||||
AppRolesEnabled();
|
||||
|
||||
var role = await _sut.ResolveAsync(Tenant, Upn, new[] { Constants.TenantRoles.Viewer });
|
||||
|
||||
Assert.Equal(Constants.TenantRoles.Viewer, role?.Role);
|
||||
Assert.False(role!.CanManageBootstrapTokens);
|
||||
}
|
||||
}
|
||||
|
||||
@@ -0,0 +1,490 @@
|
||||
using AutopilotMonitor.Functions.Helpers;
|
||||
using AutopilotMonitor.Shared.Models;
|
||||
using Xunit;
|
||||
|
||||
namespace AutopilotMonitor.Functions.Tests;
|
||||
|
||||
/// <summary>
|
||||
/// Golden fixtures for the OOBE quality update in the time attribution (AttributionVersion 4,
|
||||
/// D-314): <c>os_update</c> from the update page start whose visit holds update evidence to the
|
||||
/// last update evidence before the user is back, then — after a restart — <c>awaiting_sign_in</c>
|
||||
/// until the user is back. Sequences follow the field sessions of 2026-10-02 (synthetic times, no
|
||||
/// customer data). EVERY fixture asserts the exact-partition invariant.
|
||||
/// </summary>
|
||||
public class TimeAttributionOsUpdateTests
|
||||
{
|
||||
private static readonly DateTime T0 = new(2026, 10, 2, 14, 0, 0, DateTimeKind.Utc);
|
||||
private const string Lcu = "Package_for_RollupFix~31bf3856ad364e35~amd64~~26100.6899.1.7";
|
||||
private const string LcuKb = "Package_for_KB5129195~31bf3856ad364e35~amd64~~26100.6899.1.7";
|
||||
|
||||
private static long _seq;
|
||||
|
||||
private static EnrollmentEvent Evt(
|
||||
DateTime ts, string eventType,
|
||||
EnrollmentPhase phase = EnrollmentPhase.Unknown,
|
||||
Dictionary<string, object>? data = null)
|
||||
=> new()
|
||||
{
|
||||
EventType = eventType,
|
||||
Timestamp = ts,
|
||||
Sequence = ++_seq,
|
||||
Phase = phase,
|
||||
Data = data ?? new Dictionary<string, object>(),
|
||||
};
|
||||
|
||||
private static EnrollmentEvent PageStart(DateTime ts, string page) =>
|
||||
Evt(ts, "oobe_update_page", data: new() { ["cxhEvent"] = "page_started", ["page"] = page });
|
||||
|
||||
private static EnrollmentEvent PageStop(DateTime ts, string page, string result) =>
|
||||
Evt(ts, "oobe_update_page", data: new() { ["cxhEvent"] = "page_stopped", ["page"] = page, ["result"] = result });
|
||||
|
||||
private static EnrollmentEvent PageName(DateTime ts, string name, string? value = null)
|
||||
{
|
||||
var data = new Dictionary<string, object> { ["cxhEvent"] = "event_name", ["name"] = name };
|
||||
if (value != null) data["value"] = value;
|
||||
return Evt(ts, "oobe_update_page", data: data);
|
||||
}
|
||||
|
||||
private static EnrollmentEvent Servicing(DateTime ts, string step, string package = LcuKb, string targetState = "Installed") =>
|
||||
Evt(ts, "windows_update_servicing", data: new()
|
||||
{
|
||||
["step"] = step,
|
||||
["package"] = package,
|
||||
["client"] = "UpdateAgentLCU",
|
||||
["targetState"] = targetState,
|
||||
});
|
||||
|
||||
/// <summary>A restart: the agent's next run detects it; the gap runs from the last event before the boot to the first after.</summary>
|
||||
private static EnrollmentEvent RebootDetected(DateTime detectedAt, DateTime lastBoot) =>
|
||||
Evt(detectedAt, "system_reboot_detected", data: new() { ["lastBootUtc"] = lastBoot.ToString("o") });
|
||||
|
||||
private static TimeAttributionInput Input(
|
||||
List<EnrollmentEvent> events, DateTime completedAt, int durationSeconds,
|
||||
string status = "Succeeded", bool wg = false, DateTime? resumedAt = null)
|
||||
=> new()
|
||||
{
|
||||
TenantId = "00000000-0000-0000-0000-0000000000t1",
|
||||
SessionId = "00000000-0000-0000-0000-0000000000s1",
|
||||
Status = status,
|
||||
StartedAt = T0,
|
||||
CompletedAt = completedAt,
|
||||
DurationSeconds = durationSeconds,
|
||||
IsPreProvisioned = wg,
|
||||
ResumedAt = resumedAt,
|
||||
Events = events,
|
||||
};
|
||||
|
||||
private static void AssertExactPartition(SessionTimeBreakdown b)
|
||||
{
|
||||
Assert.Equal(b.WallClockSeconds, b.Segments.Sum(s => s.Seconds) + b.UnattributedSeconds);
|
||||
Assert.True(b.UnattributedSeconds >= 0, "unattributed must never be negative");
|
||||
}
|
||||
|
||||
private static int Total(SessionTimeBreakdown b, string segment) =>
|
||||
b.GetSegmentTotals().TryGetValue(segment, out var seconds) ? seconds : 0;
|
||||
|
||||
private static DateTime At(int minutes, int seconds = 0) => T0.AddMinutes(minutes).AddSeconds(seconds);
|
||||
|
||||
// ── the device ESP and the update page, shared by the fixtures ──────────
|
||||
|
||||
private static List<EnrollmentEvent> DeviceEsp() => new()
|
||||
{
|
||||
Evt(T0, "agent_started", EnrollmentPhase.DeviceSetup),
|
||||
Evt(At(2), "esp_phase_changed", EnrollmentPhase.AppsDevice),
|
||||
Evt(At(20), "esp_exiting"),
|
||||
};
|
||||
|
||||
// ── golden: long update, three restarts, second page visit (field: 83 min) ──
|
||||
|
||||
private static List<EnrollmentEvent> LongUpdateWithSecondVisit()
|
||||
{
|
||||
var events = DeviceEsp();
|
||||
events.AddRange(new[]
|
||||
{
|
||||
PageStart(At(20, 5), "OobeNDUP"),
|
||||
PageName(At(20, 10), "ExpeditedUpdate_isNDUPAllowedByCSPSucceeded", "true"),
|
||||
// The agent declares AccountSetup while the page still runs — no evidence of the user.
|
||||
Evt(At(22, 36), "esp_phase_changed", EnrollmentPhase.AccountSetup),
|
||||
Servicing(At(43, 35), "initiating", targetState: "Staged"),
|
||||
Servicing(At(63), "state_reached", targetState: "Staged"),
|
||||
Servicing(At(63, 10), "initiating"),
|
||||
Servicing(At(86, 46), "reboot_required"),
|
||||
PageName(At(102, 39), "ExpeditedUpdate_downloadInstallFailureHelper"),
|
||||
PageStart(At(103, 11), "RebootNDUP"),
|
||||
RebootDetected(At(104, 43), lastBoot: At(104)),
|
||||
Evt(At(106), "agent_shutting_down"),
|
||||
RebootDetected(At(108), lastBoot: At(107)),
|
||||
Evt(At(110), "agent_shutting_down"),
|
||||
RebootDetected(At(112), lastBoot: At(111)),
|
||||
Servicing(At(119, 54), "state_reached"),
|
||||
PageStart(At(120, 6), "OobeNDUP"),
|
||||
PageStop(At(120, 36), "OobeNDUP", "success"),
|
||||
Evt(At(122, 8), "desktop_arrived"),
|
||||
Evt(At(125), "enrollment_complete"),
|
||||
});
|
||||
return events;
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void LongUpdate_IsOneUpdateSegment_FromThePageStartToTheSecondVisit_ThenTheWait()
|
||||
{
|
||||
var b = TimeAttributionCalculator.Compute(Input(LongUpdateWithSecondVisit(), At(125), 7500))!;
|
||||
|
||||
AssertExactPartition(b);
|
||||
Assert.Equal(4, b.AttributionVersion);
|
||||
Assert.Equal(120, Total(b, TimeAttributionSegments.DevicePrep));
|
||||
Assert.Equal(18 * 60 + 5, Total(b, TimeAttributionSegments.EspApps)); // +2m → page start
|
||||
Assert.Equal(100 * 60 + 31, Total(b, TimeAttributionSegments.OsUpdate)); // page start → second visit ends
|
||||
Assert.Equal(92, Total(b, TimeAttributionSegments.AwaitingSignIn)); // → desktop
|
||||
Assert.Equal(0, Total(b, TimeAttributionSegments.IdentityHello)); // the early AccountSetup lay inside the update
|
||||
Assert.Equal(172, Total(b, TimeAttributionSegments.DesktopHandoff));
|
||||
|
||||
var update = Assert.Single(b.OsUpdates);
|
||||
Assert.Equal(At(20, 5), update.StartUtc);
|
||||
Assert.Equal(At(120, 36), update.EndUtc);
|
||||
Assert.Equal(100 * 60 + 31, update.Seconds);
|
||||
Assert.Equal(new[] { "KB5129195" }, update.Kbs);
|
||||
Assert.Equal(3, update.RebootCount);
|
||||
|
||||
// The update's restarts sit in its own segment.
|
||||
Assert.Equal(3, b.RebootSpans.Count);
|
||||
Assert.All(b.RebootSpans, r => Assert.Equal(TimeAttributionSegments.OsUpdate, r.SegmentKey));
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void LongUpdate_WasIdentityHelloBeforeV4()
|
||||
{
|
||||
// Same stream without the update signals = what v3 saw: the AccountSetup declaration
|
||||
// took the whole update.
|
||||
var withoutUpdate = LongUpdateWithSecondVisit()
|
||||
.Where(e => e.EventType != "oobe_update_page" && e.EventType != "windows_update_servicing")
|
||||
.ToList();
|
||||
|
||||
var b = TimeAttributionCalculator.Compute(Input(withoutUpdate, At(125), 7500))!;
|
||||
|
||||
AssertExactPartition(b);
|
||||
Assert.Equal(0, Total(b, TimeAttributionSegments.OsUpdate));
|
||||
Assert.Equal(0, Total(b, TimeAttributionSegments.AwaitingSignIn));
|
||||
Assert.Equal((122 * 60 + 8) - (22 * 60 + 36), Total(b, TimeAttributionSegments.IdentityHello));
|
||||
Assert.Empty(b.OsUpdates);
|
||||
}
|
||||
|
||||
// ── golden: update inside the apps phase, long wait with standby (field: 48 min) ──
|
||||
|
||||
[Fact]
|
||||
public void UpdateBeforeAccountSetup_TakesItsTimeFromTheAppsPhase_AndTheWaitHoldsTheStandby()
|
||||
{
|
||||
var events = DeviceEsp();
|
||||
events.AddRange(new[]
|
||||
{
|
||||
PageStart(At(20, 4), "OobeNDUP"),
|
||||
PageName(At(21), "ExpeditedUpdate_startWUScanStarted"),
|
||||
Servicing(At(30), "initiating", package: Lcu, targetState: "Staged"),
|
||||
Servicing(At(38, 50), "reboot_required", package: Lcu),
|
||||
PageStart(At(38, 55), "RebootNDUP"),
|
||||
RebootDetected(At(40, 10), lastBoot: At(39, 30)),
|
||||
Evt(At(41), "agent_shutting_down"),
|
||||
RebootDetected(At(42, 30), lastBoot: At(42)),
|
||||
Servicing(At(43), "state_reached", package: Lcu),
|
||||
// The user is away: the device sleeps 45 minutes at the lock screen.
|
||||
Evt(At(89), "system_sleep_episode", data: new()
|
||||
{
|
||||
["enteredAt"] = At(44).ToString("o"),
|
||||
["exitedAt"] = At(89).ToString("o"),
|
||||
["kind"] = "modern_standby",
|
||||
}),
|
||||
Evt(At(90, 50), "esp_phase_changed", EnrollmentPhase.AccountSetup),
|
||||
Evt(At(91), "hello_wizard_started"),
|
||||
Evt(At(91), "esp_phase_changed", EnrollmentPhase.FinalizingSetup),
|
||||
Evt(At(93), "desktop_arrived"),
|
||||
Evt(At(95), "enrollment_complete"),
|
||||
});
|
||||
|
||||
var b = TimeAttributionCalculator.Compute(Input(events, At(95), 5700))!;
|
||||
|
||||
AssertExactPartition(b);
|
||||
Assert.Equal(18 * 60 + 4, Total(b, TimeAttributionSegments.EspApps)); // +2m → page start only
|
||||
Assert.Equal(22 * 60 + 56, Total(b, TimeAttributionSegments.OsUpdate)); // → servicing reports Installed
|
||||
// The wait ends at the first evidence of the user: the Hello wizard, not the AccountSetup row.
|
||||
Assert.Equal((91 - 43) * 60, Total(b, TimeAttributionSegments.AwaitingSignIn));
|
||||
Assert.Equal(120, Total(b, TimeAttributionSegments.IdentityHello)); // Hello → desktop
|
||||
|
||||
var update = Assert.Single(b.OsUpdates);
|
||||
Assert.Empty(update.Kbs); // RollupFix names no KB
|
||||
Assert.Equal(2, update.RebootCount);
|
||||
var sleep = Assert.Single(b.SleepSpans);
|
||||
Assert.Equal(TimeAttributionSegments.AwaitingSignIn, sleep.SegmentKey);
|
||||
}
|
||||
|
||||
// ── no update, no segment ───────────────────────────────────────────────
|
||||
|
||||
private static List<EnrollmentEvent> WithAccountPhase(IEnumerable<EnrollmentEvent> updatePart)
|
||||
{
|
||||
var events = DeviceEsp();
|
||||
events.AddRange(updatePart);
|
||||
events.AddRange(new[]
|
||||
{
|
||||
Evt(At(21), "esp_phase_changed", EnrollmentPhase.AccountSetup),
|
||||
Evt(At(26), "hello_wizard_started"),
|
||||
Evt(At(26), "esp_phase_changed", EnrollmentPhase.FinalizingSetup),
|
||||
Evt(At(28), "desktop_arrived"),
|
||||
Evt(At(30), "enrollment_complete"),
|
||||
});
|
||||
// Canonical order = event time here: the update part was created first.
|
||||
var ordered = events.OrderBy(e => e.Timestamp).ToList();
|
||||
foreach (var evt in ordered) evt.Sequence = ++_seq;
|
||||
return ordered;
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void CancelledPage_LeavesThePhasePartitionUnchanged()
|
||||
{
|
||||
// AllowOOBEUpdates=0: the page checks the CSP gate and cancels within seconds.
|
||||
var cancelled = WithAccountPhase(new[]
|
||||
{
|
||||
PageStart(At(20, 2), "OobeNDUP"),
|
||||
PageName(At(20, 3), "ExpeditedUpdate_isNDUPAllowedByCSPSucceeded", "false"),
|
||||
PageStop(At(20, 5), "OobeNDUP", "cancel"),
|
||||
PageStart(At(20, 6), "RebootNDUP"),
|
||||
});
|
||||
var plain = WithAccountPhase(Array.Empty<EnrollmentEvent>());
|
||||
|
||||
var b = TimeAttributionCalculator.Compute(Input(cancelled, At(30), 1800))!;
|
||||
var v3 = TimeAttributionCalculator.Compute(Input(plain, At(30), 1800))!;
|
||||
|
||||
AssertExactPartition(b);
|
||||
Assert.Empty(b.OsUpdates);
|
||||
Assert.Equal(v3.Segments.Select(s => (s.SegmentKey, s.Seconds)), b.Segments.Select(s => (s.SegmentKey, s.Seconds)));
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void ScanThatFoundNothing_IsNoUpdate()
|
||||
{
|
||||
// Every visit logs the same init names — with "Install" and "Download" in them.
|
||||
var events = WithAccountPhase(new[]
|
||||
{
|
||||
PageStart(At(20, 2), "OobeNDUP"),
|
||||
PageName(At(20, 3), "ExpeditedUpdate_isNDUPAllowedByCSPSucceeded", "true"),
|
||||
PageName(At(20, 4), "SdxWebAppCloudNDUP_initialize_NDUPInstallCanceledInOptOut", "false"),
|
||||
PageName(At(20, 4), "SdxWebAppCloudNDUP_initialize_NDUPDownloadInstallPreviousFailureCount", "0"),
|
||||
PageName(At(20, 9), "ExpeditedUpdate_startWUScanStarted"),
|
||||
PageName(At(20, 58), "SdxWebAppCloudNDUP_updateManager_processUpdatesMetadata_osUpdatesWithNDUPPI", "false"),
|
||||
PageStop(At(20, 59), "OobeNDUP", "cancel"),
|
||||
});
|
||||
|
||||
var b = TimeAttributionCalculator.Compute(Input(events, At(30), 1800))!;
|
||||
|
||||
AssertExactPartition(b);
|
||||
Assert.Empty(b.OsUpdates);
|
||||
Assert.Equal(0, Total(b, TimeAttributionSegments.OsUpdate));
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void ServicingBesideACancelledPage_IsSomeOtherUpdate()
|
||||
{
|
||||
// The page was seen and did not update; a servicing step during the account phase is
|
||||
// not the OOBE update.
|
||||
var events = WithAccountPhase(new[]
|
||||
{
|
||||
PageStart(At(20, 2), "OobeNDUP"),
|
||||
PageStop(At(20, 5), "OobeNDUP", "cancel"),
|
||||
Servicing(At(23), "initiating", targetState: "Staged"),
|
||||
});
|
||||
|
||||
var b = TimeAttributionCalculator.Compute(Input(events, At(30), 1800))!;
|
||||
|
||||
AssertExactPartition(b);
|
||||
Assert.Empty(b.OsUpdates);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void UpdateAfterTheDesktop_StaysATimelineEvent()
|
||||
{
|
||||
var events = WithAccountPhase(new[]
|
||||
{
|
||||
Servicing(At(28, 30), "initiating", targetState: "Staged"),
|
||||
Servicing(At(29, 30), "state_reached", targetState: "Staged"),
|
||||
});
|
||||
|
||||
var b = TimeAttributionCalculator.Compute(Input(events, At(30), 1800))!;
|
||||
|
||||
AssertExactPartition(b);
|
||||
Assert.Empty(b.OsUpdates);
|
||||
Assert.Equal(120, Total(b, TimeAttributionSegments.DesktopHandoff));
|
||||
}
|
||||
|
||||
// ── update without a restart: no wait ──────────────────────────────────
|
||||
|
||||
[Fact]
|
||||
public void UpdateWithoutRestart_HasNoWaitForSignIn()
|
||||
{
|
||||
// Without a restart the user who started the enrollment is still signed in.
|
||||
var events = WithAccountPhase(new[]
|
||||
{
|
||||
PageStart(At(20, 2), "OobeNDUP"),
|
||||
PageName(At(20, 40), "ExpeditedUpdate_commitExpeditionDownloadInstallAsyncSucceeded"),
|
||||
PageStop(At(20, 50), "OobeNDUP", "success"),
|
||||
});
|
||||
|
||||
var b = TimeAttributionCalculator.Compute(Input(events, At(30), 1800))!;
|
||||
|
||||
AssertExactPartition(b);
|
||||
var update = Assert.Single(b.OsUpdates);
|
||||
Assert.Equal(0, update.RebootCount);
|
||||
Assert.Equal(48, Total(b, TimeAttributionSegments.OsUpdate)); // page start → page stop
|
||||
Assert.Equal(0, Total(b, TimeAttributionSegments.AwaitingSignIn));
|
||||
}
|
||||
|
||||
// ── the page start was not observed ─────────────────────────────────────
|
||||
|
||||
[Fact]
|
||||
public void WithoutAnObservedPageStart_TheFirstServicingStepAfterTheEspExitBeginsTheUpdate()
|
||||
{
|
||||
var events = DeviceEsp();
|
||||
events.AddRange(new[]
|
||||
{
|
||||
Servicing(At(10), "initiating", targetState: "Staged"), // during the ESP: not the OOBE update
|
||||
Servicing(At(25), "initiating", targetState: "Staged"),
|
||||
Servicing(At(35), "reboot_required"),
|
||||
PageStart(At(35, 10), "RebootNDUP"),
|
||||
RebootDetected(At(37), lastBoot: At(36)),
|
||||
Servicing(At(38), "state_reached"),
|
||||
Evt(At(40), "desktop_arrived"),
|
||||
Evt(At(42), "enrollment_complete"),
|
||||
});
|
||||
|
||||
var b = TimeAttributionCalculator.Compute(Input(events, At(42), 2520))!;
|
||||
|
||||
AssertExactPartition(b);
|
||||
var update = Assert.Single(b.OsUpdates);
|
||||
Assert.Equal(At(25), update.StartUtc);
|
||||
Assert.Equal(At(38), update.EndUtc);
|
||||
Assert.Equal(120, Total(b, TimeAttributionSegments.AwaitingSignIn));
|
||||
Assert.Equal(23 * 60, Total(b, TimeAttributionSegments.EspApps)); // the hole until the first step stays the phase's
|
||||
}
|
||||
|
||||
[Theory]
|
||||
[InlineData("ExpeditedUpdate_commitExpeditionDownloadInstallAsyncStarted", true)]
|
||||
[InlineData("SdxWebAppCloudNDUP_processStatusChangeFromHandler_downloadSucceeded", true)]
|
||||
[InlineData("SdxWebAppCloudNDUP_processStatusChangeFromHandler_installSucceededRebootRequired_lcu", true)]
|
||||
[InlineData("SdxWebAppCloudNDUP_updateUSOProgressBar_DownloadPhase_progress100", true)]
|
||||
[InlineData("SdxWebAppCloudNDUP_downloadInstallFailureHelper", true)]
|
||||
[InlineData("SdxWebAppCloudNDUP_rebootCountdown_starting", true)]
|
||||
[InlineData("SdxWebAppCloudNDUP_initialize_NDUPInstallCanceledInOptOut", false)]
|
||||
[InlineData("SdxWebAppCloudNDUP_initialize_NDUPDownloadInstallPreviousFailureCount", false)]
|
||||
[InlineData("SdxWebAppCloudNDUP_processStatusChangeFromHandler_installSucceededNoReboot", false)]
|
||||
[InlineData("SdxWebAppCloudNDUP_handleInstallHelper", false)]
|
||||
[InlineData("ExpeditedUpdate_getUpdateResultsSucceeded", false)]
|
||||
[InlineData(null, false)]
|
||||
public void UpdateActivityNames_AreTheOnesOnlyAnUpdateWrites(string? name, bool expected)
|
||||
{
|
||||
Assert.Equal(expected, TimeAttributionCalculator.IsUpdateActivityName(name));
|
||||
}
|
||||
|
||||
// ── restarts ────────────────────────────────────────────────────────────
|
||||
|
||||
[Fact]
|
||||
public void ClockSyncAtBoot_DoesNotShortenTheRestart()
|
||||
{
|
||||
// The hardware clock sync is logged 0.1 s before lastBootUtc; the restart began with
|
||||
// the last real event before it.
|
||||
var events = DeviceEsp();
|
||||
events.AddRange(new[]
|
||||
{
|
||||
PageStart(At(20, 2), "OobeNDUP"),
|
||||
Servicing(At(25), "initiating", targetState: "Staged"),
|
||||
Servicing(At(30), "reboot_required"),
|
||||
PageStart(At(30, 5), "RebootNDUP"),
|
||||
Evt(At(31).AddMilliseconds(-140), "system_clock_changed"),
|
||||
RebootDetected(At(31, 20), lastBoot: At(31)),
|
||||
Servicing(At(32), "state_reached"),
|
||||
Evt(At(34), "desktop_arrived"),
|
||||
Evt(At(35), "enrollment_complete"),
|
||||
});
|
||||
|
||||
var b = TimeAttributionCalculator.Compute(Input(events, At(35), 2100))!;
|
||||
|
||||
AssertExactPartition(b);
|
||||
var restart = Assert.Single(b.RebootSpans);
|
||||
Assert.Equal(At(30, 5), restart.StartUtc); // not the clock sync
|
||||
Assert.Equal(At(31, 20), restart.EndUtc);
|
||||
Assert.Equal(75, restart.Seconds);
|
||||
Assert.Equal(TimeAttributionSegments.OsUpdate, restart.SegmentKey);
|
||||
}
|
||||
|
||||
// ── robustness ──────────────────────────────────────────────────────────
|
||||
|
||||
[Fact]
|
||||
public void BackfillDuplicates_ChangeNothing()
|
||||
{
|
||||
var once = LongUpdateWithSecondVisit();
|
||||
var twice = LongUpdateWithSecondVisit();
|
||||
// An agent restart re-sends the page records it read before, with their event times.
|
||||
twice.AddRange(twice.Where(e => e.EventType == "oobe_update_page").Select(e => Evt(e.Timestamp, e.EventType, data: e.Data)).ToList());
|
||||
|
||||
var a = TimeAttributionCalculator.Compute(Input(once, At(125), 7500))!;
|
||||
var b = TimeAttributionCalculator.Compute(Input(twice, At(125), 7500))!;
|
||||
|
||||
AssertExactPartition(b);
|
||||
Assert.Equal(a.Segments.Select(s => (s.SegmentKey, s.Seconds)), b.Segments.Select(s => (s.SegmentKey, s.Seconds)));
|
||||
Assert.Equal(a.OsUpdates.Single().Seconds, b.OsUpdates.Single().Seconds);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void FailedDeclaration_EndsTheUpdateToo()
|
||||
{
|
||||
var events = DeviceEsp();
|
||||
events.AddRange(new[]
|
||||
{
|
||||
PageStart(At(20, 2), "OobeNDUP"),
|
||||
Servicing(At(25), "initiating", targetState: "Staged"),
|
||||
Evt(At(50), "enrollment_failed", EnrollmentPhase.Failed),
|
||||
Servicing(At(55), "state_reached", targetState: "Staged"),
|
||||
});
|
||||
|
||||
var b = TimeAttributionCalculator.Compute(Input(events, At(60), 3600, status: "Failed"))!;
|
||||
|
||||
AssertExactPartition(b);
|
||||
var update = Assert.Single(b.OsUpdates);
|
||||
Assert.Equal(At(25), update.EndUtc); // the step after the failure is not attributed
|
||||
Assert.Equal(4 * 60 + 58, Total(b, TimeAttributionSegments.OsUpdate));
|
||||
Assert.Equal(0, Total(b, TimeAttributionSegments.AwaitingSignIn));
|
||||
Assert.True(b.UnattributedSeconds >= 10 * 60); // the post-failure tail stays unattributed
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void WhiteGlove_UpdateInTheUserPart_StaysInsideItsWindow()
|
||||
{
|
||||
var part1End = At(30);
|
||||
var resumedAt = T0.AddDays(2);
|
||||
var completedAt = resumedAt.AddMinutes(40);
|
||||
var events = new List<EnrollmentEvent>
|
||||
{
|
||||
Evt(T0, "agent_started", EnrollmentPhase.DeviceSetup),
|
||||
Evt(At(2), "esp_phase_changed", EnrollmentPhase.AppsDevice),
|
||||
Evt(part1End, "whiteglove_part1_complete"),
|
||||
Evt(resumedAt.AddSeconds(30), "agent_started", EnrollmentPhase.DeviceSetup),
|
||||
Evt(resumedAt.AddMinutes(3), "esp_exiting"),
|
||||
PageStart(resumedAt.AddMinutes(3).AddSeconds(4), "OobeNDUP"),
|
||||
Servicing(resumedAt.AddMinutes(10), "initiating", targetState: "Staged"),
|
||||
Servicing(resumedAt.AddMinutes(20), "reboot_required"),
|
||||
PageStart(resumedAt.AddMinutes(20).AddSeconds(5), "RebootNDUP"),
|
||||
RebootDetected(resumedAt.AddMinutes(23), lastBoot: resumedAt.AddMinutes(22)),
|
||||
Servicing(resumedAt.AddMinutes(24), "state_reached"),
|
||||
Evt(resumedAt.AddMinutes(30), "esp_phase_changed", EnrollmentPhase.AccountSetup),
|
||||
Evt(resumedAt.AddMinutes(32), "hello_wizard_started"),
|
||||
Evt(resumedAt.AddMinutes(38), "desktop_arrived"),
|
||||
Evt(completedAt, "enrollment_complete"),
|
||||
};
|
||||
|
||||
var b = TimeAttributionCalculator.Compute(
|
||||
Input(events, completedAt, durationSeconds: 30 * 60 + 40 * 60, wg: true, resumedAt: resumedAt))!;
|
||||
|
||||
AssertExactPartition(b);
|
||||
var update = Assert.Single(b.OsUpdates);
|
||||
Assert.Equal(resumedAt.AddMinutes(3).AddSeconds(4), update.StartUtc);
|
||||
Assert.Equal(resumedAt.AddMinutes(24), update.EndUtc);
|
||||
Assert.Equal(8 * 60, Total(b, TimeAttributionSegments.AwaitingSignIn)); // → Hello wizard
|
||||
Assert.All(b.Segments, s => Assert.True(s.EndUtc <= part1End || s.StartUtc >= resumedAt, "no span in the pause"));
|
||||
}
|
||||
}
|
||||
+26
-1
@@ -51,6 +51,10 @@ public class TimeAttributionPersistenceAndAggregationTests
|
||||
{
|
||||
new() { StartUtc = T0.AddMinutes(20), EndUtc = T0.AddMinutes(26), Seconds = 360, SegmentKey = TimeAttributionSegments.EspApps, Kind = "modern_standby" },
|
||||
},
|
||||
OsUpdates = new List<OsUpdateSpan>
|
||||
{
|
||||
new() { StartUtc = T0.AddMinutes(9), EndUtc = T0.AddMinutes(19), Seconds = 600, Kbs = new List<string> { "KB5129195", "KB5054156" }, RebootCount = 2 },
|
||||
},
|
||||
BlockingApps = new List<BlockingAppInterval>
|
||||
{
|
||||
new() { AppId = AppX, AppName = "App X", StartUtc = T0.AddMinutes(6), EndUtc = T0.AddMinutes(16), Seconds = 600 },
|
||||
@@ -89,12 +93,30 @@ public class TimeAttributionPersistenceAndAggregationTests
|
||||
Assert.Equal(T0.AddMinutes(20), sleep.StartUtc);
|
||||
Assert.Equal(360, sleep.Seconds);
|
||||
|
||||
var update = Assert.Single(mapped.OsUpdates);
|
||||
Assert.Equal(T0.AddMinutes(9), update.StartUtc);
|
||||
Assert.Equal(T0.AddMinutes(19), update.EndUtc);
|
||||
Assert.Equal(600, update.Seconds);
|
||||
Assert.Equal(new[] { "KB5129195", "KB5054156" }, update.Kbs);
|
||||
Assert.Equal(2, update.RebootCount);
|
||||
|
||||
var app = Assert.Single(mapped.BlockingApps);
|
||||
Assert.Equal(AppX, app.AppId);
|
||||
Assert.Equal("App X", app.AppName);
|
||||
Assert.Equal(600, app.Seconds);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void BreakdownEntity_WrittenBeforeOsUpdates_MapsToAnEmptyList()
|
||||
{
|
||||
// v3 rows have no OsUpdatesJson column; the sweep recomputes them, reads must not fail.
|
||||
var entity = TableStorageService.BuildSessionTimeBreakdownEntity(
|
||||
new SessionTimeBreakdown { TenantId = TenantA, SessionId = "s-1", WallClockSeconds = 600 });
|
||||
entity.Remove("OsUpdatesJson");
|
||||
|
||||
Assert.Empty(TableStorageService.MapToSessionTimeBreakdown(entity).OsUpdates);
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public void BreakdownEntity_OccupancyTriState_AbsentColumnMapsToNull_NeverZero()
|
||||
{
|
||||
@@ -376,9 +398,12 @@ public class TimeAttributionPersistenceAndAggregationTests
|
||||
pairs, Array.Empty<SessionSummary>(), T0)
|
||||
.Single(a => a.TenantId == TenantA);
|
||||
|
||||
Assert.Equal(6, aggregate.SegmentStats.Count); // 5 canonical + unattributed — the full stack
|
||||
Assert.Equal(8, aggregate.SegmentStats.Count); // 7 canonical + unattributed — the full stack
|
||||
// The fixture has no user_esp span → honest 0, not absent.
|
||||
Assert.Equal(0, aggregate.SegmentStats.Single(s => s.SegmentKey == TimeAttributionSegments.UserEsp).MedianSeconds);
|
||||
// A session without an OOBE update contributes 0 to the update and the wait.
|
||||
Assert.Equal(0, aggregate.SegmentStats.Single(s => s.SegmentKey == TimeAttributionSegments.OsUpdate).MedianSeconds);
|
||||
Assert.Equal(0, aggregate.SegmentStats.Single(s => s.SegmentKey == TimeAttributionSegments.AwaitingSignIn).MedianSeconds);
|
||||
Assert.Equal(42, aggregate.SegmentStats.Single(s => s.SegmentKey == TimeAttributionSegments.Unattributed).MedianSeconds);
|
||||
}
|
||||
|
||||
|
||||
+3
@@ -57,6 +57,9 @@ namespace AutopilotMonitor.Functions.DataAccess.TableStorage
|
||||
public Task<RawPage<SessionSummary>> GetSessionsPageAsync(string tenantId, int? days, int pageSize, string? continuation)
|
||||
=> _storage.GetSessionsPageAsync(tenantId, days, pageSize, continuation);
|
||||
|
||||
public Task<bool> HasAnySessionStrictAsync(string tenantId)
|
||||
=> _storage.HasAnySessionStrictAsync(tenantId);
|
||||
|
||||
public Task<RawPage<SessionSummary>> GetAllSessionsPageAsync(string? tenantIdFilter, int? days, int pageSize, string? continuation, IReadOnlyCollection<string>? allowedTenantIds = null, IEnumerable<string>? select = null, CancellationToken cancellationToken = default)
|
||||
=> _storage.GetAllSessionsPageAsync(tenantIdFilter, days, pageSize, continuation, allowedTenantIds, select, cancellationToken);
|
||||
|
||||
|
||||
+75
@@ -0,0 +1,75 @@
|
||||
using AutopilotMonitor.Functions.Helpers;
|
||||
using AutopilotMonitor.Functions.Services;
|
||||
using AutopilotMonitor.Shared.DataAccess;
|
||||
using AutopilotMonitor.Shared.Models;
|
||||
using Microsoft.Azure.Functions.Worker;
|
||||
using Microsoft.Azure.Functions.Worker.Http;
|
||||
using Microsoft.Extensions.Logging;
|
||||
|
||||
namespace AutopilotMonitor.Functions.Functions.Progress;
|
||||
|
||||
/// <summary>
|
||||
/// Tells the Progress Portal whether the caller's own organization looks unused. A member without a
|
||||
/// role only ever sees the portal; without this hint they never learn that their organization already
|
||||
/// runs the product, or that nobody looks after it anymore. Reveals no session data: the JWT tenant
|
||||
/// only, a flag and the signup date.
|
||||
/// </summary>
|
||||
public class ProgressTenantStatusFunction
|
||||
{
|
||||
/// <summary>A younger organization is still being set up, not abandoned.</summary>
|
||||
internal static readonly TimeSpan UnusedAfter = TimeSpan.FromDays(14);
|
||||
|
||||
private readonly ILogger<ProgressTenantStatusFunction> _logger;
|
||||
private readonly TenantConfigurationService _tenantConfigService;
|
||||
private readonly ISessionRepository _sessionRepo;
|
||||
|
||||
public ProgressTenantStatusFunction(
|
||||
ILogger<ProgressTenantStatusFunction> logger,
|
||||
TenantConfigurationService tenantConfigService,
|
||||
ISessionRepository sessionRepo)
|
||||
{
|
||||
_logger = logger;
|
||||
_tenantConfigService = tenantConfigService;
|
||||
_sessionRepo = sessionRepo;
|
||||
}
|
||||
|
||||
/// <summary>GET /api/progress/tenant-status — the caller's own tenant (catalog: TenantScoping.Jwt).</summary>
|
||||
[Function("ProgressGetTenantStatus")]
|
||||
public async Task<HttpResponseData> GetTenantStatus(
|
||||
[HttpTrigger(AuthorizationLevel.Anonymous, "get", Route = "progress/tenant-status")] HttpRequestData req)
|
||||
{
|
||||
try
|
||||
{
|
||||
var tenantId = req.GetRequestContext().TenantId;
|
||||
|
||||
// Both reads are strict: a storage failure must surface as 500, never as "unused".
|
||||
var configTask = _tenantConfigService.GetConfigurationIfExistsAsync(tenantId);
|
||||
var hasSessionTask = _sessionRepo.HasAnySessionStrictAsync(tenantId);
|
||||
await Task.WhenAll(configTask, hasSessionTask);
|
||||
|
||||
return await req.OkAsync(Evaluate(configTask.Result, hasSessionTask.Result, DateTime.UtcNow));
|
||||
}
|
||||
catch (Exception ex)
|
||||
{
|
||||
return await req.InternalServerErrorAsync(_logger, ex, "ProgressGetTenantStatus");
|
||||
}
|
||||
}
|
||||
|
||||
internal static ProgressTenantStatusResponse Evaluate(TenantConfiguration? config, bool hasAnySession, DateTime utcNow)
|
||||
{
|
||||
// No configuration row: not an onboarded organization, nothing to call unused.
|
||||
if (config == null)
|
||||
return new ProgressTenantStatusResponse { Success = true };
|
||||
|
||||
// A row from before OnboardedAt existed is old by definition.
|
||||
var signedUpAt = config.OnboardedAt;
|
||||
var settled = signedUpAt == null || utcNow - signedUpAt.Value >= UnusedAfter;
|
||||
|
||||
return new ProgressTenantStatusResponse
|
||||
{
|
||||
Success = true,
|
||||
Unused = !hasAnySession && settled,
|
||||
SignedUpAt = signedUpAt
|
||||
};
|
||||
}
|
||||
}
|
||||
@@ -1,4 +1,5 @@
|
||||
using System.Globalization;
|
||||
using System.Text.RegularExpressions;
|
||||
using AutopilotMonitor.Shared;
|
||||
using AutopilotMonitor.Shared.Models;
|
||||
|
||||
@@ -65,6 +66,11 @@ public sealed class TimeAttributionInput
|
||||
/// <item><b>Reboot spans from event gaps</b> around the <c>lastBootUtc</c> payload — the
|
||||
/// <c>system_reboot_detected</c> event is detection-time-stamped by the next run and never used
|
||||
/// as the reboot moment (audit Q7). Reboots are a cross-cutting annotation, not a segment.</item>
|
||||
/// <item><b>The OOBE quality update takes its time from the phase segments</b> (v4, D-314):
|
||||
/// <c>os_update</c> from the start of the update page that installed an update to the last
|
||||
/// update evidence before the user is back, then — after a restart — <c>awaiting_sign_in</c>
|
||||
/// until the first evidence of the user. Without update evidence (the page cancelled or found
|
||||
/// nothing) the partition is the phase partition unchanged.</item>
|
||||
/// </list>
|
||||
/// </summary>
|
||||
public static class TimeAttributionCalculator
|
||||
@@ -74,7 +80,9 @@ public static class TimeAttributionCalculator
|
||||
// pre-enrollment state on disk are now flagged and excluded from fleet segment stats.
|
||||
// v3: SleepSpans — completed sleep/standby episodes (system_sleep_episode) as cross-cutting
|
||||
// annotations mirroring RebootSpans; the maintenance sweep recomputes older rows.
|
||||
public const int CurrentVersion = 3;
|
||||
// v4: os_update + awaiting_sign_in — the OOBE quality update and the wait for the user after
|
||||
// its restart, cut out of the phase segment they overlap (D-314), with OsUpdates naming the KBs.
|
||||
public const int CurrentVersion = 4;
|
||||
|
||||
/// <summary>
|
||||
/// Enrollment class for fleet aggregation — classes are NEVER mixed in one aggregate (a
|
||||
@@ -142,6 +150,12 @@ public static class TimeAttributionCalculator
|
||||
var anchors = BuildAnchors(events, ref flags);
|
||||
var spans = BuildSegmentSpans(windows, anchors);
|
||||
|
||||
// D-310: the OOBE quality update and the wait for the user after its restart take their
|
||||
// time from the phase segment they overlap — the ESP is over, the device is updating.
|
||||
var rebootGaps = FindRebootGaps(events);
|
||||
var osUpdates = BuildOsUpdates(events, windows, anchors, rebootGaps);
|
||||
spans = ApplyOsUpdates(spans, windows, osUpdates);
|
||||
|
||||
var attributedSeconds = spans.Sum(s => s.Seconds);
|
||||
var unattributed = wallClock - attributedSeconds;
|
||||
|
||||
@@ -169,7 +183,7 @@ public static class TimeAttributionCalculator
|
||||
occupancy = ComputeOccupancySeconds(blockingAppSegments, espAppsSpans);
|
||||
}
|
||||
|
||||
var rebootSpans = BuildRebootSpans(events, windows, spans);
|
||||
var rebootSpans = BuildRebootSpans(rebootGaps, windows, spans);
|
||||
var sleepSpans = BuildSleepSpans(events, windows, spans);
|
||||
|
||||
if (events.Any(e => e.EventType == Constants.EventTypes.AgentLateStart))
|
||||
@@ -196,6 +210,16 @@ public static class TimeAttributionCalculator
|
||||
RebootSpans = rebootSpans,
|
||||
SleepSeconds = sleepSpans.Sum(s => s.Seconds),
|
||||
SleepSpans = sleepSpans,
|
||||
OsUpdates = osUpdates
|
||||
.Select(u => new OsUpdateSpan
|
||||
{
|
||||
StartUtc = u.Start,
|
||||
EndUtc = u.End,
|
||||
Seconds = ClampToWindows(u.Start, u.End, windows)?.Seconds ?? 0,
|
||||
Kbs = u.Kbs,
|
||||
RebootCount = u.RebootCount,
|
||||
})
|
||||
.ToList(),
|
||||
BlockingApps = blockingApps
|
||||
.OrderByDescending(a => a.Seconds)
|
||||
.ThenBy(a => a.AppName, StringComparer.OrdinalIgnoreCase)
|
||||
@@ -642,16 +666,17 @@ public static class TimeAttributionCalculator
|
||||
// ── reboot spans ────────────────────────────────────────────────────────
|
||||
|
||||
/// <summary>
|
||||
/// One span per distinct observed boot: the event-stream gap bracketing <c>lastBootUtc</c>
|
||||
/// One gap per distinct observed boot: the event-stream gap bracketing <c>lastBootUtc</c>
|
||||
/// (last event before the boot → first event at/after it). Fallback without a usable
|
||||
/// payload: previous event → the detection event itself (which is genuinely post-boot —
|
||||
/// usable as an observation bound, never as the boot moment). Spans are clipped to the
|
||||
/// observation hull, so a WhiteGlove-pause reboot contributes nothing.
|
||||
/// usable as an observation bound, never as the boot moment). Unclipped; the update interval
|
||||
/// and <see cref="BuildRebootSpans"/> read the same gaps. A <c>system_clock_changed</c> row is
|
||||
/// no bound (v4): the hardware clock sync at boot is logged a fraction of a second before
|
||||
/// <c>lastBootUtc</c> and shrank the outage to seconds (field: 4–10 s for restarts of a minute).
|
||||
/// </summary>
|
||||
private static List<RebootSpan> BuildRebootSpans(
|
||||
List<EnrollmentEvent> events, List<Window> windows, List<TimeAttributionSpan> spans)
|
||||
private static List<(DateTime Start, DateTime End)> FindRebootGaps(List<EnrollmentEvent> events)
|
||||
{
|
||||
var result = new List<RebootSpan>();
|
||||
var result = new List<(DateTime Start, DateTime End)>();
|
||||
var seenBoots = new HashSet<DateTime>();
|
||||
|
||||
for (var i = 0; i < events.Count; i++)
|
||||
@@ -677,6 +702,7 @@ public static class TimeAttributionCalculator
|
||||
if (!seenBoots.Add(lastBoot.Value)) continue; // duplicate detection of the same boot
|
||||
foreach (var e in events)
|
||||
{
|
||||
if (e.EventType == Constants.EventTypes.SystemClockChanged) continue;
|
||||
if (e.Timestamp < lastBoot.Value)
|
||||
{
|
||||
if (!gapStart.HasValue || e.Timestamp > gapStart.Value) gapStart = e.Timestamp;
|
||||
@@ -694,8 +720,23 @@ public static class TimeAttributionCalculator
|
||||
}
|
||||
|
||||
if (!gapStart.HasValue || !gapEnd.HasValue || gapEnd.Value <= gapStart.Value) continue;
|
||||
result.Add((gapStart.Value, gapEnd.Value));
|
||||
}
|
||||
|
||||
var clamped = ClampToWindows(gapStart.Value, gapEnd.Value, windows);
|
||||
return result;
|
||||
}
|
||||
|
||||
/// <summary>
|
||||
/// One span per reboot gap, clipped to the observation hull, so a WhiteGlove-pause reboot
|
||||
/// contributes nothing.
|
||||
/// </summary>
|
||||
private static List<RebootSpan> BuildRebootSpans(
|
||||
List<(DateTime Start, DateTime End)> gaps, List<Window> windows, List<TimeAttributionSpan> spans)
|
||||
{
|
||||
var result = new List<RebootSpan>();
|
||||
foreach (var gap in gaps)
|
||||
{
|
||||
var clamped = ClampToWindows(gap.Start, gap.End, windows);
|
||||
if (!clamped.HasValue) continue;
|
||||
// In-window seconds — a reboot gap bracketing the WhiteGlove pause contributes
|
||||
// only its in-window flanks, never the pause itself.
|
||||
@@ -714,6 +755,296 @@ public static class TimeAttributionCalculator
|
||||
return result;
|
||||
}
|
||||
|
||||
// ── OOBE quality update (D-310) ─────────────────────────────────────────
|
||||
|
||||
/// <summary>CXID of the OOBE update page; <see cref="UpdateRestartPage"/> follows it and restarts for the update.</summary>
|
||||
internal const string UpdatePage = "OobeNDUP";
|
||||
internal const string UpdateRestartPage = "RebootNDUP";
|
||||
|
||||
// "Package_for_KB5129195~31bf…": the KB follows an underscore, so no \b before it.
|
||||
private static readonly Regex KbPattern = new(
|
||||
@"(?<![A-Za-z0-9])KB(\d{6,8})(?![0-9])", RegexOptions.IgnoreCase | RegexOptions.CultureInvariant, TimeSpan.FromMilliseconds(100));
|
||||
|
||||
private sealed class OsUpdate
|
||||
{
|
||||
public DateTime Start;
|
||||
public DateTime End;
|
||||
|
||||
/// <summary>End of the wait for the user after the update's restart; null without a restart.</summary>
|
||||
public DateTime? AwaitingSignInEnd;
|
||||
|
||||
public List<string> Kbs = new();
|
||||
public int RebootCount;
|
||||
}
|
||||
|
||||
private readonly struct PageRecord
|
||||
{
|
||||
public PageRecord(DateTime at, string cxhEvent, string? page, string? name)
|
||||
{
|
||||
At = at;
|
||||
CxhEvent = cxhEvent;
|
||||
Page = page;
|
||||
Name = name;
|
||||
}
|
||||
|
||||
public DateTime At { get; }
|
||||
public string CxhEvent { get; }
|
||||
public string? Page { get; }
|
||||
public string? Name { get; }
|
||||
|
||||
public bool IsStartOf(string page) => CxhEvent == "page_started" && string.Equals(Page, page, StringComparison.OrdinalIgnoreCase);
|
||||
public bool IsStopOf(string page) => CxhEvent == "page_stopped" && string.Equals(Page, page, StringComparison.OrdinalIgnoreCase);
|
||||
}
|
||||
|
||||
/// <summary>
|
||||
/// Page names that only an update in progress writes (field data 2026-10-02). Every visit
|
||||
/// logs init names such as <c>initialize_NDUPInstallCanceledInOptOut</c> and
|
||||
/// <c>initialize_NDUPDownloadInstallPreviousFailureCount</c>, a scan that found nothing
|
||||
/// included, and <c>installSucceededNoReboot</c> follows the language check of visits whose
|
||||
/// update came later — so "Download"/"Install" in a name proves nothing.
|
||||
/// </summary>
|
||||
private static readonly string[] UpdateActivityMarkers =
|
||||
{
|
||||
"commitExpeditionDownloadInstall", // the page commits the download and install
|
||||
"downloadSucceeded",
|
||||
"installSucceededRebootRequired",
|
||||
"DownloadPhase", // the progress bars of the download …
|
||||
"installPhase", // … and of the install
|
||||
"downloadInstallFailureHelper", // a download or install failed
|
||||
"rebootCountdown", // the page restarts for the update
|
||||
};
|
||||
|
||||
/// <summary>
|
||||
/// The update page's own record of a download or an install — evidence of an update next to
|
||||
/// the servicing steps (an agent caps the page names per run, so this is the weaker of the two).
|
||||
/// </summary>
|
||||
internal static bool IsUpdateActivityName(string? name) =>
|
||||
name != null &&
|
||||
UpdateActivityMarkers.Any(marker => name.IndexOf(marker, StringComparison.OrdinalIgnoreCase) >= 0);
|
||||
|
||||
/// <summary>
|
||||
/// At most one update per observation window. <b>Begin:</b> the start of the update page
|
||||
/// (<see cref="UpdatePage"/>) whose visit holds update evidence — a servicing step or an
|
||||
/// update-activity name before the visit ends (its stop, the <see cref="UpdateRestartPage"/>
|
||||
/// start or the next visit). Only when no page start was observed in the window: the first
|
||||
/// servicing step after the device-ESP exit. Never after the user is back. <b>Bound:</b> the first evidence of the
|
||||
/// user (user ESP apps, desktop, Hello wizard, a Complete declaration), the end of
|
||||
/// attribution (Failed) or the window end. <b>End:</b> the latest update evidence before the
|
||||
/// bound — page record, servicing step, or the end of a restart that began in the interval.
|
||||
/// With a restart in the interval the user is signed out: <c>awaiting_sign_in</c> runs from
|
||||
/// the end to the bound.
|
||||
/// </summary>
|
||||
private static List<OsUpdate> BuildOsUpdates(
|
||||
List<EnrollmentEvent> events, List<Window> windows, List<Anchor> anchors,
|
||||
List<(DateTime Start, DateTime End)> rebootGaps)
|
||||
{
|
||||
var result = new List<OsUpdate>();
|
||||
|
||||
var pages = new List<PageRecord>();
|
||||
var servicing = new List<(DateTime At, string? Package)>();
|
||||
foreach (var evt in events)
|
||||
{
|
||||
if (evt.EventType == Constants.EventTypes.OobeUpdatePage && evt.Data != null)
|
||||
{
|
||||
pages.Add(new PageRecord(evt.Timestamp,
|
||||
DataString(evt.Data, "cxhEvent") ?? string.Empty,
|
||||
DataString(evt.Data, "page"),
|
||||
DataString(evt.Data, "name")));
|
||||
}
|
||||
else if (evt.EventType == Constants.EventTypes.WindowsUpdateServicing)
|
||||
{
|
||||
servicing.Add((evt.Timestamp, evt.Data != null ? DataString(evt.Data, "package") : null));
|
||||
}
|
||||
}
|
||||
if (servicing.Count == 0 && !pages.Any(p => IsUpdateActivityName(p.Name))) return result;
|
||||
|
||||
pages = pages.OrderBy(p => p.At).ToList();
|
||||
servicing = servicing.OrderBy(c => c.At).ToList();
|
||||
var evidence = servicing.Select(c => c.At)
|
||||
.Concat(pages.Where(p => IsUpdateActivityName(p.Name)).Select(p => p.At))
|
||||
.OrderBy(t => t)
|
||||
.ToList();
|
||||
|
||||
// The user is back (or the enrollment declared itself complete): from here on the time
|
||||
// is not the update's. A Failed declaration ends attribution altogether.
|
||||
var userBack = anchors
|
||||
.Where(a => a.Bucket == TimeAttributionSegments.UserEsp || a.Bucket == TimeAttributionSegments.DesktopHandoff)
|
||||
.Select(a => a.Ts)
|
||||
.Concat(events.Where(e => e.EventType == Constants.EventTypes.HelloWizardStarted).Select(e => e.Timestamp))
|
||||
.OrderBy(t => t)
|
||||
.ToList();
|
||||
var attributionEnd = anchors.FirstOrDefault(a => a.Bucket == null)?.Ts;
|
||||
var deviceEspExit = events.FirstOrDefault(e => e.EventType == Constants.EventTypes.EspExiting)?.Timestamp;
|
||||
|
||||
foreach (var window in windows)
|
||||
{
|
||||
var begin = FindUpdateBegin(window, pages, evidence, servicing, deviceEspExit, userBack);
|
||||
if (!begin.HasValue) continue;
|
||||
|
||||
var bound = window.End;
|
||||
if (attributionEnd.HasValue && attributionEnd.Value < bound) bound = attributionEnd.Value;
|
||||
foreach (var t in userBack)
|
||||
{
|
||||
if (t <= begin.Value) continue;
|
||||
if (t < bound) bound = t;
|
||||
break;
|
||||
}
|
||||
if (bound <= begin.Value) continue;
|
||||
|
||||
var update = new OsUpdate { Start = begin.Value, End = begin.Value };
|
||||
foreach (var page in pages)
|
||||
{
|
||||
if (page.At > update.End && page.At < bound) update.End = page.At;
|
||||
}
|
||||
foreach (var (at, package) in servicing)
|
||||
{
|
||||
if (at < begin.Value || at >= bound) continue;
|
||||
if (at > update.End) update.End = at;
|
||||
var kb = ExtractKb(package);
|
||||
if (kb != null && !update.Kbs.Contains(kb)) update.Kbs.Add(kb);
|
||||
}
|
||||
foreach (var (gapStart, gapEnd) in rebootGaps)
|
||||
{
|
||||
if (gapStart < begin.Value || gapStart >= bound) continue;
|
||||
update.RebootCount++;
|
||||
var restartEnd = gapEnd < bound ? gapEnd : bound;
|
||||
if (restartEnd > update.End) update.End = restartEnd;
|
||||
}
|
||||
|
||||
// The update's restart signed the user out; until the user is back the time is
|
||||
// waiting, not updating.
|
||||
if (update.RebootCount > 0 && bound > update.End)
|
||||
update.AwaitingSignInEnd = bound;
|
||||
|
||||
result.Add(update);
|
||||
}
|
||||
|
||||
return result;
|
||||
}
|
||||
|
||||
private static DateTime? FindUpdateBegin(
|
||||
Window window, List<PageRecord> pages, List<DateTime> evidence,
|
||||
List<(DateTime At, string? Package)> servicing, DateTime? deviceEspExit, List<DateTime> userBack)
|
||||
{
|
||||
// An update after the user is back runs beside the enrollment, not instead of it.
|
||||
bool UserBackBy(DateTime t) => userBack.Any(u => u > window.Start && u <= t);
|
||||
|
||||
var pageStartSeen = false;
|
||||
for (var i = 0; i < pages.Count; i++)
|
||||
{
|
||||
var start = pages[i];
|
||||
if (!start.IsStartOf(UpdatePage) || start.At < window.Start || start.At >= window.End) continue;
|
||||
pageStartSeen = true;
|
||||
if (UserBackBy(start.At)) continue;
|
||||
|
||||
// The visit ends with its stop, the restart page or the next visit — whichever comes
|
||||
// first; an update page that restarts the device writes no stop of its own.
|
||||
var visitEnd = window.End;
|
||||
for (var j = i + 1; j < pages.Count; j++)
|
||||
{
|
||||
var next = pages[j];
|
||||
if (next.IsStopOf(UpdatePage) || next.IsStartOf(UpdateRestartPage) || next.IsStartOf(UpdatePage))
|
||||
{
|
||||
visitEnd = next.At;
|
||||
break;
|
||||
}
|
||||
}
|
||||
foreach (var t in userBack)
|
||||
{
|
||||
if (t <= start.At) continue;
|
||||
if (t < visitEnd) visitEnd = t;
|
||||
break;
|
||||
}
|
||||
|
||||
if (evidence.Any(t => t >= start.At && t <= visitEnd)) return start.At;
|
||||
}
|
||||
|
||||
// A page that was seen and did not update (it cancelled, or found nothing) is the answer;
|
||||
// a servicing step beside it is some other update.
|
||||
if (pageStartSeen) return null;
|
||||
|
||||
// Fallback: the page start was not observed (the agent started after it). The first
|
||||
// servicing step after the device-ESP exit — without the download before it.
|
||||
if (!deviceEspExit.HasValue) return null;
|
||||
foreach (var (at, _) in servicing)
|
||||
{
|
||||
if (at < deviceEspExit.Value || at < window.Start || at >= window.End) continue;
|
||||
return UserBackBy(at) ? null : at;
|
||||
}
|
||||
return null;
|
||||
}
|
||||
|
||||
private static string? ExtractKb(string? package)
|
||||
{
|
||||
if (string.IsNullOrEmpty(package)) return null;
|
||||
try
|
||||
{
|
||||
var match = KbPattern.Match(package);
|
||||
return match.Success ? "KB" + match.Groups[1].Value : null;
|
||||
}
|
||||
catch (RegexMatchTimeoutException)
|
||||
{
|
||||
return null;
|
||||
}
|
||||
}
|
||||
|
||||
private static string? DataString(Dictionary<string, object> data, string key) =>
|
||||
data.TryGetValue(key, out var value) ? value?.ToString() : null;
|
||||
|
||||
/// <summary>
|
||||
/// Cuts the update and the wait for the user out of the phase spans and adds them as their
|
||||
/// own spans, clipped to the windows — a hole inside the interval is filled, the WhiteGlove
|
||||
/// pause never. Sessions without an update keep their phase partition unchanged.
|
||||
/// </summary>
|
||||
private static List<TimeAttributionSpan> ApplyOsUpdates(
|
||||
List<TimeAttributionSpan> spans, List<Window> windows, List<OsUpdate> updates)
|
||||
{
|
||||
if (updates.Count == 0) return spans;
|
||||
|
||||
var overrides = new List<(DateTime Start, DateTime End, string Key)>();
|
||||
foreach (var update in updates)
|
||||
{
|
||||
overrides.Add((update.Start, update.End, TimeAttributionSegments.OsUpdate));
|
||||
if (update.AwaitingSignInEnd.HasValue)
|
||||
overrides.Add((update.End, update.AwaitingSignInEnd.Value, TimeAttributionSegments.AwaitingSignIn));
|
||||
}
|
||||
|
||||
var result = new List<TimeAttributionSpan>();
|
||||
foreach (var span in spans)
|
||||
{
|
||||
var pieces = new List<(DateTime Start, DateTime End)> { (span.StartUtc, span.EndUtc) };
|
||||
foreach (var cut in overrides)
|
||||
{
|
||||
var next = new List<(DateTime Start, DateTime End)>();
|
||||
foreach (var (start, end) in pieces)
|
||||
{
|
||||
if (cut.End <= start || cut.Start >= end)
|
||||
{
|
||||
next.Add((start, end));
|
||||
continue;
|
||||
}
|
||||
if (cut.Start > start) next.Add((start, cut.Start));
|
||||
if (cut.End < end) next.Add((cut.End, end));
|
||||
}
|
||||
pieces = next;
|
||||
}
|
||||
foreach (var (start, end) in pieces)
|
||||
AddSpan(result, span.SegmentKey, start, end);
|
||||
}
|
||||
|
||||
foreach (var (start, end, key) in overrides)
|
||||
{
|
||||
foreach (var window in windows)
|
||||
{
|
||||
var clippedStart = start > window.Start ? start : window.Start;
|
||||
var clippedEnd = end < window.End ? end : window.End;
|
||||
AddSpan(result, key, clippedStart, clippedEnd);
|
||||
}
|
||||
}
|
||||
|
||||
return result.OrderBy(sp => sp.StartUtc).ToList();
|
||||
}
|
||||
|
||||
// ── sleep spans ─────────────────────────────────────────────────────────
|
||||
|
||||
/// <summary>
|
||||
|
||||
@@ -256,6 +256,9 @@ public static class EndpointAccessPolicyCatalog
|
||||
// ProgressPortalFunction; regression history c4dabeee).
|
||||
new("GET", "progress/sessions/lookup", EndpointPolicy.AuthenticatedUserWithRole, TenantScoping.QueryParam),
|
||||
new("GET", "progress/sessions/{sessionId}/events", EndpointPolicy.AuthenticatedUser, TenantScoping.QueryParam),
|
||||
// The caller's own (JWT) tenant only, and no session data: a "looks unused" flag plus the signup
|
||||
// date, so the portal can tell a member without a role whom to ask for access.
|
||||
new("GET", "progress/tenant-status", EndpointPolicy.AuthenticatedUser, TenantScoping.Jwt),
|
||||
// AuthenticatedUserWithRole (not plain AuthenticatedUser): the activating user is still
|
||||
// roleless during first-touch signup, so the tier must admit non-members — but the address is
|
||||
// tenant-shared state feeding the welcome/farewell mails, so the function re-gates on the
|
||||
|
||||
@@ -36,16 +36,16 @@ public enum TableMemberState
|
||||
/// <see cref="MemberRoleInfo.CanManageBootstrapTokens"/>, or to revoke access) by adding an
|
||||
/// explicit table row for that user.
|
||||
///
|
||||
/// Only Admin and Operator are mappable from claims; Viewer and the platform-wide GlobalAdmin
|
||||
/// role are intentionally never derived from claims.
|
||||
/// The tenant roles Admin, Operator and Viewer are mappable from claims; the platform-wide
|
||||
/// GlobalAdmin role is intentionally never derived from claims.
|
||||
/// </summary>
|
||||
public static class EntraAppRoleResolver
|
||||
{
|
||||
/// <summary>
|
||||
/// Maps raw Entra app-role values to a <see cref="MemberRoleInfo"/>. Admin outranks Operator
|
||||
/// when both are present. Returns null when no mappable role exists.
|
||||
/// Maps raw Entra app-role values to a <see cref="MemberRoleInfo"/>. The highest role wins when
|
||||
/// several are present: Admin, then Operator, then Viewer. Returns null when no mappable role exists.
|
||||
/// A claim-derived Admin implicitly gets <see cref="MemberRoleInfo.CanManageBootstrapTokens"/>;
|
||||
/// a claim Operator does not (granular bootstrap permission is a table-only override).
|
||||
/// a claim Operator or Viewer does not (granular bootstrap permission is a table-only override).
|
||||
/// </summary>
|
||||
public static MemberRoleInfo? MapClaimRole(IEnumerable<string>? appRoles)
|
||||
{
|
||||
@@ -63,6 +63,9 @@ public static class EntraAppRoleResolver
|
||||
if (roles.Any(r => string.Equals(r, Constants.TenantRoles.Operator, StringComparison.OrdinalIgnoreCase)))
|
||||
return new MemberRoleInfo { Role = Constants.TenantRoles.Operator, CanManageBootstrapTokens = false };
|
||||
|
||||
if (roles.Any(r => string.Equals(r, Constants.TenantRoles.Viewer, StringComparison.OrdinalIgnoreCase)))
|
||||
return new MemberRoleInfo { Role = Constants.TenantRoles.Viewer, CanManageBootstrapTokens = false };
|
||||
|
||||
return null;
|
||||
}
|
||||
|
||||
|
||||
+11
-8
@@ -1,4 +1,5 @@
|
||||
using AutopilotMonitor.DecisionCore.State;
|
||||
using AutopilotMonitor.Shared;
|
||||
using AutopilotMonitor.Shared.Models;
|
||||
using Microsoft.Extensions.Logging;
|
||||
|
||||
@@ -9,19 +10,18 @@ namespace AutopilotMonitor.Functions.Services
|
||||
/// </summary>
|
||||
public sealed partial class EventIngestProcessor
|
||||
{
|
||||
private EventClassification ClassifyEvents(List<EnrollmentEvent> storedEvents)
|
||||
internal static EventClassification ClassifyEvents(List<EnrollmentEvent> storedEvents)
|
||||
{
|
||||
var classification = new EventClassification();
|
||||
|
||||
foreach (var evt in storedEvents)
|
||||
{
|
||||
// System-timeline-watcher rows (clock steps, sleep episodes) are backfilled
|
||||
// from the Windows event log with original timestamps up to 24h before the
|
||||
// agent started — environment observation, not enrollment activity. They must
|
||||
// not pull the session anchor toward pre-enrollment OOBE idle time (mirrors
|
||||
// TableStorageService.IsSessionAnchorEligible on the Events-table probe;
|
||||
// field case d0c5b672).
|
||||
var anchorEligible = evt.Source != "SystemTimelineWatcher";
|
||||
// Backfilled environment observations (clock steps, sleep, update and servicing
|
||||
// activity from before the agent started) are timeline rows, not enrollment
|
||||
// activity: they must not pull the session anchor into pre-enrollment time
|
||||
// (Constants.EventSources.SessionAnchorIneligible; the Events-table probe applies
|
||||
// the same rule).
|
||||
var anchorEligible = Constants.EventSources.IsSessionAnchorEligible(evt.Source);
|
||||
if (anchorEligible &&
|
||||
(!classification.EarliestEventTimestamp.HasValue || evt.Timestamp < classification.EarliestEventTimestamp.Value))
|
||||
classification.EarliestEventTimestamp = evt.Timestamp;
|
||||
@@ -480,6 +480,9 @@ namespace AutopilotMonitor.Functions.Services
|
||||
// observation too — a device that slept through its stall must stay Stalled.
|
||||
"system_clock_changed" => true,
|
||||
"system_sleep_episode" => true,
|
||||
// A platform run corrected after the fact from IME's saved result (D-316): registry
|
||||
// observation of an earlier run, not progress — a stalled session stays Stalled.
|
||||
Constants.EventTypes.ScriptOutputReconciliation => true,
|
||||
_ => false
|
||||
};
|
||||
|
||||
|
||||
@@ -1,6 +1,7 @@
|
||||
using System;
|
||||
using System.Collections.Generic;
|
||||
using System.Diagnostics;
|
||||
using System.Globalization;
|
||||
using System.IO;
|
||||
using System.Linq;
|
||||
using System.Text;
|
||||
@@ -405,7 +406,7 @@ namespace AutopilotMonitor.Functions.Services
|
||||
/// contributes no per-app intervals); excluded and missing ones are counted, never
|
||||
/// silently dropped (rule 7).
|
||||
/// Rows are written even below the ≥20 UI gate — the UI needs the n (rule 4). Segment
|
||||
/// stats always carry the five canonical segments + unattributed (a session without a
|
||||
/// stats always carry the seven canonical segments + unattributed (a session without a
|
||||
/// span of a segment contributes 0 — the honest "per enrollment of this class" answer).
|
||||
/// Per-app rows gate at ≥5 sessions, order by median interval, cap 20.
|
||||
/// </summary>
|
||||
@@ -468,6 +469,8 @@ namespace AutopilotMonitor.Functions.Services
|
||||
{
|
||||
TimeAttributionSegments.DevicePrep,
|
||||
TimeAttributionSegments.EspApps,
|
||||
TimeAttributionSegments.OsUpdate,
|
||||
TimeAttributionSegments.AwaitingSignIn,
|
||||
TimeAttributionSegments.IdentityHello,
|
||||
TimeAttributionSegments.UserEsp,
|
||||
TimeAttributionSegments.DesktopHandoff,
|
||||
@@ -793,7 +796,7 @@ namespace AutopilotMonitor.Functions.Services
|
||||
|
||||
var containerClient = new BlobContainerClient(new Uri(containerSasUrl));
|
||||
var generatedAtUtc = DateTime.UtcNow;
|
||||
var versionedFileName = $"platform-stats.{generatedAtUtc:yyyy-MM-dd}.json";
|
||||
var versionedFileName = PlatformStatsVersionedFileName(generatedAtUtc);
|
||||
|
||||
var versionedPayload = new
|
||||
{
|
||||
@@ -829,19 +832,34 @@ namespace AutopilotMonitor.Functions.Services
|
||||
}
|
||||
}
|
||||
|
||||
/// <summary>
|
||||
/// Name of the versioned stats file of one publish. The file is served immutable for a year
|
||||
/// (<see cref="PlatformStatsVersionedCacheControl"/>), so a name must never be written twice:
|
||||
/// maintenance publishes every 2 hours, and the per-day name of the once-a-night schedule was
|
||||
/// rewritten up to 12 times a day under that header — caches kept the first copy of the day.
|
||||
/// Browsers revalidate only the manifest, which names the current file.
|
||||
/// </summary>
|
||||
internal static string PlatformStatsVersionedFileName(DateTime generatedAtUtc) =>
|
||||
$"platform-stats.{generatedAtUtc.ToString("yyyy-MM-dd'T'HHmmss'Z'", CultureInfo.InvariantCulture)}.json";
|
||||
|
||||
private async Task UploadJsonBlobAsync(BlobContainerClient containerClient, string blobName, object payload, string cacheControl)
|
||||
{
|
||||
var blobClient = containerClient.GetBlobClient(blobName);
|
||||
var json = JsonConvert.SerializeObject(payload);
|
||||
await using var stream = new MemoryStream(Encoding.UTF8.GetBytes(json));
|
||||
|
||||
await blobClient.UploadAsync(stream, overwrite: true);
|
||||
await blobClient.SetHttpHeadersAsync(new BlobHttpHeaders
|
||||
// Headers and tier travel with the upload, which still overwrites (the manifest relies on
|
||||
// it). Set in follow-up calls, the blob was briefly served without Cache-Control and
|
||||
// content type, and stayed that way when a follow-up call failed.
|
||||
await blobClient.UploadAsync(stream, new BlobUploadOptions
|
||||
{
|
||||
ContentType = "application/json; charset=utf-8",
|
||||
CacheControl = cacheControl
|
||||
HttpHeaders = new BlobHttpHeaders
|
||||
{
|
||||
ContentType = "application/json; charset=utf-8",
|
||||
CacheControl = cacheControl
|
||||
},
|
||||
AccessTier = AccessTier.Hot
|
||||
});
|
||||
await blobClient.SetAccessTierAsync(AccessTier.Hot);
|
||||
}
|
||||
|
||||
/// <summary>
|
||||
|
||||
@@ -60,6 +60,7 @@ namespace AutopilotMonitor.Functions.Services
|
||||
|
||||
private const string PlatformStatsAliasFileName = "platform-stats.json";
|
||||
private const string PlatformStatsAliasCacheControl = "public, max-age=300, stale-while-revalidate=86400";
|
||||
// Holds only because every publish writes a new name (PlatformStatsVersionedFileName).
|
||||
private const string PlatformStatsVersionedCacheControl = "public, max-age=31536000, immutable";
|
||||
|
||||
public MaintenanceService(
|
||||
|
||||
@@ -1144,6 +1144,31 @@ namespace AutopilotMonitor.Functions.Services
|
||||
return new RawPage<SessionSummary>(page.Sessions, page.HasMore ? page.NextCursor : null);
|
||||
}
|
||||
|
||||
/// <summary>
|
||||
/// Key-only existence probe: the tenant's SessionsIndex partition first, then the primary
|
||||
/// table (the page read's pre-migration fallback). No catch — a failed read must never
|
||||
/// answer "no sessions".
|
||||
/// </summary>
|
||||
public async Task<bool> HasAnySessionStrictAsync(string tenantId)
|
||||
{
|
||||
SecurityValidator.EnsureValidGuid(tenantId, nameof(tenantId));
|
||||
|
||||
var filter = $"PartitionKey eq '{tenantId}'";
|
||||
var keysOnly = new[] { "PartitionKey", "RowKey" };
|
||||
foreach (var table in new[] { Constants.TableNames.SessionsIndex, Constants.TableNames.Sessions })
|
||||
{
|
||||
var rows = _tableServiceClient.GetTableClient(table)
|
||||
.QueryAsync<TableEntity>(filter: filter, maxPerPage: 1, select: keysOnly)
|
||||
.GetAsyncEnumerator();
|
||||
await using (rows)
|
||||
{
|
||||
if (await rows.MoveNextAsync())
|
||||
return true;
|
||||
}
|
||||
}
|
||||
return false;
|
||||
}
|
||||
|
||||
/// <summary>
|
||||
/// Cross-tenant paged variant of <see cref="GetAllSessionsAsync"/>.
|
||||
/// <paramref name="tenantIdFilter"/> optionally restricts to one tenant.
|
||||
@@ -3515,18 +3540,15 @@ namespace AutopilotMonitor.Functions.Services
|
||||
}
|
||||
|
||||
/// <summary>
|
||||
/// Event sources whose rows never anchor the session. The system timeline watcher
|
||||
/// backfills environment observations (clock steps, sleep episodes) from the Windows
|
||||
/// event log with their ORIGINAL timestamps — up to 24h before the agent started.
|
||||
/// They belong on the timeline, but they are not enrollment activity: anchoring on
|
||||
/// them silently stretches StartedAt/DurationSeconds toward pre-enrollment OOBE idle
|
||||
/// time (field case d0c5b672: a pre-agent clock correction pulled StartedAt ~14min
|
||||
/// before the first real activity; the 2h backward-shift guard only caps, not
|
||||
/// prevents, this). User decision 2026-08-21: the session anchor stays on real
|
||||
/// enrollment activity.
|
||||
/// Whether an event row may anchor the session (<see cref="Constants.EventSources.SessionAnchorIneligible"/>).
|
||||
/// Backfilled environment observations carry their ORIGINAL event time, up to 24h before
|
||||
/// the agent started; anchoring on them silently stretches StartedAt/DurationSeconds into
|
||||
/// pre-enrollment time (field case d0c5b672: a pre-agent clock correction, ~14 min; the 2h
|
||||
/// backward-shift guard only caps this). User decision 2026-08-21: the session anchor
|
||||
/// stays on real enrollment activity.
|
||||
/// </summary>
|
||||
internal static bool IsSessionAnchorEligible(TableEntity eventRow)
|
||||
=> eventRow.GetString("Source") != "SystemTimelineWatcher";
|
||||
=> Constants.EventSources.IsSessionAnchorEligible(eventRow.GetString("Source"));
|
||||
|
||||
/// <summary>
|
||||
/// Returns the earliest ANCHOR-ELIGIBLE event timestamp persisted for a session, if
|
||||
|
||||
@@ -123,6 +123,7 @@ namespace AutopilotMonitor.Functions.Services
|
||||
["SegmentsJson"] = JsonSerializer.Serialize(b.Segments),
|
||||
["RebootSpansJson"] = JsonSerializer.Serialize(b.RebootSpans),
|
||||
["SleepSpansJson"] = JsonSerializer.Serialize(b.SleepSpans),
|
||||
["OsUpdatesJson"] = JsonSerializer.Serialize(b.OsUpdates),
|
||||
["BlockingAppsJson"] = JsonSerializer.Serialize(b.BlockingApps),
|
||||
["ComputedAt"] = DateTime.UtcNow,
|
||||
};
|
||||
@@ -151,6 +152,7 @@ namespace AutopilotMonitor.Functions.Services
|
||||
Segments = DeserializeJsonColumn<TimeAttributionSpan>(entity.GetString("SegmentsJson")),
|
||||
RebootSpans = DeserializeJsonColumn<RebootSpan>(entity.GetString("RebootSpansJson")),
|
||||
SleepSpans = DeserializeJsonColumn<SleepSpan>(entity.GetString("SleepSpansJson")),
|
||||
OsUpdates = DeserializeJsonColumn<OsUpdateSpan>(entity.GetString("OsUpdatesJson")),
|
||||
BlockingApps = DeserializeJsonColumn<BlockingAppInterval>(entity.GetString("BlockingAppsJson")),
|
||||
};
|
||||
}
|
||||
|
||||
@@ -12,7 +12,7 @@ import { describe, it, expect } from 'vitest';
|
||||
import { mkdtemp, mkdir, writeFile, rm } from 'node:fs/promises';
|
||||
import { tmpdir } from 'node:os';
|
||||
import { join } from 'node:path';
|
||||
import { loadDocsCorpus, parseFrontmatter, docUrl, slugify, docSections } from '../docs-corpus.js';
|
||||
import { loadDocsCorpus, parseFrontmatter, docUrl, slugify, docSections, summaryFolderSlugs } from '../docs-corpus.js';
|
||||
|
||||
async function withBundle<T>(
|
||||
files: Record<string, string>,
|
||||
@@ -60,9 +60,50 @@ describe('parseFrontmatter', () => {
|
||||
});
|
||||
});
|
||||
|
||||
const SUMMARY = [
|
||||
'# Table of contents',
|
||||
'',
|
||||
'* [Introduction](README.md)',
|
||||
'',
|
||||
'## Concepts',
|
||||
'',
|
||||
'* [Roles & Permissions](concepts/roles-and-permissions.md)',
|
||||
'',
|
||||
'## Trust & Security',
|
||||
'',
|
||||
'* [Security & Privacy FAQ](trust/security-faq.md)',
|
||||
'',
|
||||
'## Troubleshooting & Support',
|
||||
'',
|
||||
'* [FAQ](troubleshooting/faq.md)',
|
||||
'* [How to Purchase](troubleshooting-and-support/how-to-purchase/README.md)',
|
||||
' * [Cleverbridge](troubleshooting-and-support/how-to-purchase/cleverbridge.md)',
|
||||
].join('\r\n');
|
||||
|
||||
describe('summaryFolderSlugs', () => {
|
||||
it('maps only the folders GitBook publishes under a different group slug', () => {
|
||||
expect(summaryFolderSlugs(SUMMARY)).toEqual(
|
||||
new Map([
|
||||
['trust', 'trust-and-security'],
|
||||
['troubleshooting', 'troubleshooting-and-support'],
|
||||
]),
|
||||
);
|
||||
});
|
||||
});
|
||||
|
||||
describe('docUrl', () => {
|
||||
it('maps a page path to its published URL', () => {
|
||||
expect(docUrl('trust/security-faq.md')).toBe('https://docs.autopilotmonitor.com/trust/security-faq');
|
||||
expect(docUrl('concepts/roles-and-permissions.md')).toBe('https://docs.autopilotmonitor.com/concepts/roles-and-permissions');
|
||||
});
|
||||
|
||||
it('publishes a page under its SUMMARY group slug, not its folder', () => {
|
||||
// The folder URL of a page created after the group rename is a 404 (measured 2026-10-02).
|
||||
const slugs = summaryFolderSlugs(SUMMARY);
|
||||
expect(docUrl('troubleshooting/faq.md', slugs)).toBe('https://docs.autopilotmonitor.com/troubleshooting-and-support/faq');
|
||||
expect(docUrl('trust/security-faq.md', slugs)).toBe('https://docs.autopilotmonitor.com/trust-and-security/security-faq');
|
||||
expect(docUrl('troubleshooting-and-support/how-to-purchase/README.md', slugs)).toBe(
|
||||
'https://docs.autopilotmonitor.com/troubleshooting-and-support/how-to-purchase',
|
||||
);
|
||||
});
|
||||
|
||||
it('collapses README.md to its folder', () => {
|
||||
@@ -84,6 +125,22 @@ describe('slugify', () => {
|
||||
describe('loadDocsCorpus', () => {
|
||||
const page = (fm: string, body: string) => `---\n${fm}\n---\n\n${body}`;
|
||||
|
||||
it('cites the URL GitBook publishes, read from SUMMARY.md', async () => {
|
||||
const chunks = await withBundle(
|
||||
{
|
||||
'SUMMARY.md': SUMMARY,
|
||||
'troubleshooting/faq.md': page('type: Troubleshooting', ['# FAQ', '', '## Who is my admin?', '', 'Ask the team that runs Intune or device enrollment in your organization.'].join('\n')),
|
||||
},
|
||||
(root) => loadDocsCorpus(root),
|
||||
);
|
||||
|
||||
expect(chunks.map((c) => c.metadata.url)).toContain(
|
||||
'https://docs.autopilotmonitor.com/troubleshooting-and-support/faq#who-is-my-admin',
|
||||
);
|
||||
// The section filter keeps the folder taxonomy.
|
||||
expect(chunks[0].metadata.section).toBe('troubleshooting');
|
||||
});
|
||||
|
||||
it('splits on h2/h3 headings and carries a breadcrumb', async () => {
|
||||
const chunks = await withBundle(
|
||||
{
|
||||
|
||||
@@ -0,0 +1,95 @@
|
||||
/**
|
||||
* D-316: a platform run whose script_failed came from another script's end block is corrected by a later
|
||||
* script_output_reconciliation (outcome "foreign", IME result Success). get_session_summary must not count the
|
||||
* stored script_failed as an error, must not rank it as one and must not attach the foreign exit code's catalog
|
||||
* text; the correction itself stays a Warning key event.
|
||||
*
|
||||
* Pure unit tests: fetch is stubbed and the registered tool handler is invoked directly.
|
||||
*/
|
||||
import { describe, it, expect, vi, afterEach } from 'vitest';
|
||||
import { McpServer } from '@modelcontextprotocol/server';
|
||||
import { registerTools } from '../tools.js';
|
||||
import { runWithCaller } from '../client.js';
|
||||
import { foreignSuccessRunIds, isCorrectedForeignFailure } from '../tools/shared.js';
|
||||
|
||||
type ToolHandler = (args: Record<string, unknown>, extra: unknown) => Promise<{ content?: Array<{ type: string; text?: string }> }>;
|
||||
|
||||
const SESSION = 'e259c121-1234-4abc-9def-0123456789ab';
|
||||
const GA = { token: 'ga', isGlobalAdmin: true };
|
||||
const extra = { signal: new AbortController().signal };
|
||||
|
||||
function summaryHandler(): ToolHandler {
|
||||
const server = new McpServer({ name: 'test', version: '0.0.0' });
|
||||
registerTools(server, undefined, undefined, undefined, true, true, false);
|
||||
const registry = (server as unknown as { _registeredTools: Record<string, { handler: ToolHandler }> })._registeredTools;
|
||||
return registry['get_session_summary'].handler;
|
||||
}
|
||||
|
||||
function stubBackend(events: unknown[]): void {
|
||||
const body = {
|
||||
success: true,
|
||||
session: { sessionId: SESSION, tenantId: 't', status: 'Succeeded', startedAt: '2026-10-03T20:49:00Z' },
|
||||
events,
|
||||
results: [],
|
||||
annotations: [],
|
||||
count: events.length,
|
||||
};
|
||||
vi.stubGlobal('fetch', vi.fn(async () => ({ ok: true, status: 200, json: async () => body, text: async () => JSON.stringify(body) }) as unknown as Response));
|
||||
}
|
||||
|
||||
afterEach(() => vi.unstubAllGlobals());
|
||||
|
||||
const foreignFailure = {
|
||||
timestamp: '2026-10-03T20:59:04Z',
|
||||
eventType: 'script_failed',
|
||||
severity: 'Error',
|
||||
source: 'ImeLogTracker',
|
||||
message: 'Platform script d94468af: Success (exit: 1)',
|
||||
data: { scriptType: 'platform', result: 'Success', exitCode: '1', runId: 'run-1' },
|
||||
};
|
||||
|
||||
const correction = (data: Record<string, unknown>) => ({
|
||||
timestamp: '2026-10-03T20:59:08Z',
|
||||
eventType: 'script_output_reconciliation',
|
||||
severity: 'Warning',
|
||||
source: 'RegistryScriptResult',
|
||||
message: "Platform script d94468af: output corrected from IME's saved result",
|
||||
data: { scriptType: 'platform', outcome: 'foreign', result: 'Success', runId: 'run-1', ...data },
|
||||
});
|
||||
|
||||
async function summary(events: unknown[]): Promise<Record<string, any>> {
|
||||
stubBackend(events);
|
||||
const result = await runWithCaller(GA, () => summaryHandler()({ sessionId: SESSION }, extra));
|
||||
return JSON.parse((result.content ?? []).map((c) => c.text ?? '').join(''));
|
||||
}
|
||||
|
||||
describe('get_session_summary with a corrected platform run', () => {
|
||||
it('does not count the foreign script_failed as an error and drops its exit-code text', async () => {
|
||||
const body = await summary([foreignFailure, correction({})]);
|
||||
|
||||
expect(body.stats.errorCount).toBe(0);
|
||||
expect(body.stats.warningCount).toBe(1);
|
||||
const failed = body.keyEvents.find((e: { eventType: string }) => e.eventType === 'script_failed');
|
||||
expect(failed.correctedByImeSavedResult).toBe(true);
|
||||
expect(failed.errorCode).toBeUndefined();
|
||||
expect(body.keyEvents.some((e: { eventType: string }) => e.eventType === 'script_output_reconciliation')).toBe(true);
|
||||
});
|
||||
|
||||
it('keeps counting a failure IME itself reported, and an uncorrected one', async () => {
|
||||
expect((await summary([foreignFailure, correction({ result: 'Failed' })])).stats.errorCount).toBe(1);
|
||||
expect((await summary([foreignFailure, correction({ outcome: 'repaired' })])).stats.errorCount).toBe(1);
|
||||
expect((await summary([foreignFailure, correction({ runId: 'another-run' })])).stats.errorCount).toBe(1);
|
||||
expect((await summary([foreignFailure])).stats.errorCount).toBe(1);
|
||||
});
|
||||
});
|
||||
|
||||
describe('foreignSuccessRunIds / isCorrectedForeignFailure', () => {
|
||||
it('names only foreign corrections whose IME result is Success, and only script_failed rows', () => {
|
||||
const runs = foreignSuccessRunIds([correction({}), correction({ runId: 'r2', result: 'Failed' }), correction({ runId: 'r3', outcome: 'repaired' })]);
|
||||
expect([...runs]).toEqual(['run-1']);
|
||||
expect(isCorrectedForeignFailure('script_failed', { runId: 'run-1' }, runs)).toBe(true);
|
||||
expect(isCorrectedForeignFailure('script_completed', { runId: 'run-1' }, runs)).toBe(false);
|
||||
expect(isCorrectedForeignFailure('script_failed', { runId: 'r2' }, runs)).toBe(false);
|
||||
expect(isCorrectedForeignFailure('script_failed', undefined, runs)).toBe(false);
|
||||
});
|
||||
});
|
||||
@@ -188,21 +188,49 @@ export function slugify(text: string): string {
|
||||
.slice(0, 60);
|
||||
}
|
||||
|
||||
/**
|
||||
* Top-level folder → URL segment, read from SUMMARY.md. GitBook publishes a page under
|
||||
* the slug of the `## Group` heading that lists it, not under its folder:
|
||||
* `troubleshooting/faq.md` below "Troubleshooting & Support" is
|
||||
* `/troubleshooting-and-support/faq`. The folder URL of a page that predates a group
|
||||
* rename still redirects; for a newer page it is a 404. Only folders whose slug differs
|
||||
* are returned.
|
||||
*/
|
||||
export function summaryFolderSlugs(summary: string): Map<string, string> {
|
||||
const slugs = new Map<string, string>();
|
||||
let group: string | undefined;
|
||||
for (const line of normalizeNewlines(summary).split('\n')) {
|
||||
const heading = /^##\s+(.+)$/.exec(line.trim());
|
||||
if (heading) {
|
||||
group = heading[1].toLowerCase().replace(/&/g, ' and ').replace(/[^a-z0-9]+/g, '-').replace(/^-+|-+$/g, '');
|
||||
continue;
|
||||
}
|
||||
const link = /\]\(([^)#\s]+\.md)\)/.exec(line);
|
||||
if (!group || !link || !link[1].includes('/')) continue;
|
||||
const folder = link[1].split('/')[0];
|
||||
if (folder !== group) slugs.set(folder, group);
|
||||
}
|
||||
return slugs;
|
||||
}
|
||||
|
||||
/**
|
||||
* Public GitBook URL for a bundle-relative path, or undefined when the file is
|
||||
* not published as a page.
|
||||
* not published as a page. `folderSlugs` (from {@link summaryFolderSlugs}) maps a
|
||||
* top-level folder to the segment GitBook publishes it under.
|
||||
*
|
||||
* `index.md` is an OKF reserved file that the bundle deliberately keeps out of
|
||||
* SUMMARY.md, so GitBook never renders it — emitting a link would hand callers a
|
||||
* 404. Its content is still indexed (it is the documentation map); it just has no
|
||||
* citable URL.
|
||||
*/
|
||||
export function docUrl(relPath: string): string | undefined {
|
||||
export function docUrl(relPath: string, folderSlugs: ReadonlyMap<string, string> = new Map()): string | undefined {
|
||||
const posix = relPath.split(sep).join('/');
|
||||
if (posix === 'index.md') return undefined;
|
||||
const withoutExt = posix.replace(/\.md$/, '');
|
||||
const path = withoutExt === 'README' ? '' : withoutExt.replace(/\/README$/, '');
|
||||
return path ? `${DOCS_BASE_URL}/${path}` : DOCS_BASE_URL;
|
||||
const [folder, ...rest] = path.split('/');
|
||||
const published = rest.length > 0 && folderSlugs.has(folder) ? [folderSlugs.get(folder), ...rest].join('/') : path;
|
||||
return published ? `${DOCS_BASE_URL}/${published}` : DOCS_BASE_URL;
|
||||
}
|
||||
|
||||
// ── Sectioning ───────────────────────────────────────────────
|
||||
@@ -407,6 +435,8 @@ export async function loadDocsCorpus(docsRoot: string): Promise<SearchDocument[]
|
||||
const files = (await walkMarkdown(docsRoot)).sort();
|
||||
const docs: SearchDocument[] = [];
|
||||
const usedIds = new Set<string>();
|
||||
// No SUMMARY.md (a partial local bundle): folder URLs, as GitBook would serve an unrenamed group.
|
||||
const folderSlugs = summaryFolderSlugs(await readFile(join(docsRoot, 'SUMMARY.md'), 'utf-8').catch(() => ''));
|
||||
|
||||
for (const relPath of files) {
|
||||
let raw: string;
|
||||
@@ -430,7 +460,7 @@ export async function loadDocsCorpus(docsRoot: string): Promise<SearchDocument[]
|
||||
// Top-level directory doubles as the bundle's section taxonomy
|
||||
// (getting-started, concepts, portal-guide, …). Root files are 'general'.
|
||||
const section = posixPath.includes('/') ? posixPath.split('/')[0] : 'general';
|
||||
const url = docUrl(relPath);
|
||||
const url = docUrl(relPath, folderSlugs);
|
||||
|
||||
// Drop the h1 line itself — it is carried in every chunk's header instead.
|
||||
const withoutH1 = body.replace(/^#\s+.+$/m, '');
|
||||
|
||||
@@ -3054,6 +3054,18 @@ export interface OpsEventListResponse {
|
||||
nextLink?: string;
|
||||
}
|
||||
|
||||
/** One OOBE quality update behind an OsUpdate span (D-310) — the interval and what the evidence names. Annotation like RebootSpan; the partition itself is in Segments. */
|
||||
export interface OsUpdateSpan {
|
||||
startUtc: string;
|
||||
endUtc: string;
|
||||
/** In-window seconds of the interval. */
|
||||
seconds: number;
|
||||
/** KB numbers of the packages Windows serviced in the interval ("KB5129195"), in order of first appearance; empty when no package named one. */
|
||||
kbs: string[];
|
||||
/** Restarts that began inside the interval. */
|
||||
rebootCount: number;
|
||||
}
|
||||
|
||||
/** Body of PATCH global/config: { "fields": { <fieldName>: <value>, ... } } with at least one field, keyed by the AdminConfiguration wire name. Only the fields sent are written; values take the field's own JSON type. */
|
||||
export interface PatchAdminConfigurationRequest {
|
||||
fields?: Record<string, unknown>;
|
||||
@@ -3231,6 +3243,15 @@ export interface ProgressLookupSessionResponse {
|
||||
session?: SessionSummary;
|
||||
}
|
||||
|
||||
/** Response of GET /api/progress/tenant-status — whether the caller's own organization looks unused, so the Progress Portal can tell a member without a role whom to ask for access. */
|
||||
export interface ProgressTenantStatusResponse {
|
||||
success: boolean;
|
||||
/** True when the organization holds no session and signed up more than 14 days ago. */
|
||||
unused: boolean;
|
||||
/** When the organization signed up; null (key omitted on the wire) when unknown. */
|
||||
signedUpAt?: string;
|
||||
}
|
||||
|
||||
/** Error body of POST /api/global/raw/logs when the telemetry store rejected or failed the query (400 for a caller-side KQL error, 502 for store/grant failures): the envelope prefix plus the store's own error code, HTTP status and — capped — its full response, so nothing the CLI would print is lost. hint tells the caller how to fix the query. */
|
||||
export interface QueryBackendLogsErrorResponse {
|
||||
error: string;
|
||||
@@ -4334,6 +4355,8 @@ export interface SessionTimeBreakdown {
|
||||
/** Total observed in-window sleep seconds. Cross-cutting annotation like RebootSeconds — the wall clock keeps the pause; this discloses it. */
|
||||
sleepSeconds: number;
|
||||
sleepSpans: SleepSpan[];
|
||||
/** The OOBE quality updates behind the OsUpdate spans (at most one per observation window). */
|
||||
osUpdates: OsUpdateSpan[];
|
||||
/** Install intervals of ESP-blocking apps (positive-evidence join against the latest esp_config_detected lists), top 20 by duration. BlockingAppCount carries the uncapped count of matched blocking apps (including those without a measurable interval, e.g. unobserved start). */
|
||||
blockingApps: BlockingAppInterval[];
|
||||
/** Uncapped count of apps matched against the blocking set (see BlockingApps). */
|
||||
@@ -4904,7 +4927,7 @@ export interface TenantConfiguration {
|
||||
unrestrictedModeEnabled: boolean;
|
||||
/** When effective, agent guardrails are relaxed: all registry paths, WMI queries, and commands are allowed via GatherRules. File paths and diagnostics paths are allowed except C:\Users. Default: false. Can only be toggled by tenant admins when UnrestrictedModeEnabled is true. EFFECTIVE only while the tenant's edition is Pro (read-time re-gate, fail-closed on trial expiry/downgrade) — see TenantEntitlementService.IsUnrestrictedModeActive. */
|
||||
unrestrictedMode: boolean;
|
||||
/** When enabled, tenant member roles (Admin / Operator) may also be granted via Entra ID app-role assignments on the application's Enterprise App (the "roles" claim in the user's token), in addition to the TenantAdmins table. Resolution is table-first: an explicit TenantAdmins entry always overrides a claim-derived role (e.g. to grant an Operator CanManageBootstrapTokens). Only Admin and Operator are claim-mappable; the platform-wide GlobalAdmin role is never derived from claims. Off by default — per-tenant opt-in. Backend-only setting: not delivered to the agent (no ConfigVersion impact). */
|
||||
/** When enabled, tenant member roles (Admin / Operator / Viewer) may also be granted via Entra ID app-role assignments on the application's Enterprise App (the "roles" claim in the user's token), in addition to the TenantAdmins table. Resolution is table-first: an explicit TenantAdmins entry always overrides a claim-derived role (e.g. to grant an Operator CanManageBootstrapTokens). The platform-wide GlobalAdmin role is never derived from claims. Off by default — per-tenant opt-in. Backend-only setting: not delivered to the agent (no ConfigVersion impact). */
|
||||
entraAppRolesEnabled: boolean;
|
||||
/** JSON-serialized list of tenant-specific additional log paths/wildcards to include in the diagnostics ZIP package (additive to global paths). Each entry: { "path": "...", "description": "...", "isBuiltIn": false } */
|
||||
diagnosticsLogPathsJson: string;
|
||||
|
||||
@@ -96,7 +96,7 @@ export const EVENT_TYPES_CATALOG = {
|
||||
'office_install_failed',
|
||||
'office_preinstalled_detected',
|
||||
],
|
||||
script_events: ['script_started', 'script_completed', 'script_failed', 'script_timeout_suspected', 'script_recurrence_summary', 'historic_ime_replay_detected'],
|
||||
script_events: ['script_started', 'script_completed', 'script_failed', 'script_output_reconciliation', 'script_timeout_suspected', 'script_recurrence_summary', 'historic_ime_replay_detected'],
|
||||
network_events: [
|
||||
'network_state_change',
|
||||
'network_connectivity_check',
|
||||
|
||||
@@ -2057,9 +2057,11 @@ export function registerAdminTools(server: McpServer, ga: boolean, strictGa: boo
|
||||
title: 'Enrollment Time Attribution',
|
||||
description:
|
||||
'Answer "where did the enrollment time go?". Two modes: pass sessionId for one terminal session\'s ' +
|
||||
'time breakdown — wall-clock partition into device_prep / esp_apps / identity_hello / user_esp / ' +
|
||||
'desktop_handoff spans plus an EXPLICIT unattributed remainder (sums are exact against the session\'s ' +
|
||||
'authoritative duration; the WhiteGlove pause is excluded by design), the ESP-blocking app install ' +
|
||||
'time breakdown — wall-clock partition into device_prep / esp_apps / os_update / awaiting_sign_in / ' +
|
||||
'identity_hello / user_esp / desktop_handoff spans plus an EXPLICIT unattributed remainder (sums are exact ' +
|
||||
'against the session\'s authoritative duration; the WhiteGlove pause is excluded by design; os_update = the ' +
|
||||
'OOBE quality update, its KBs and restarts in osUpdates; awaiting_sign_in = after that update\'s restart ' +
|
||||
'until the user is back), the ESP-blocking app install ' +
|
||||
'intervals with critical-path occupancy (an app\'s seconds = its ACTIVE install time summed across all ' +
|
||||
'IME passes/attempts — deliberately broader than get_app_install_metrics\' final-attempt duration, ' +
|
||||
'because a failed attempt and an evaluation pass still occupied the critical path), reboot outage ' +
|
||||
|
||||
@@ -2,7 +2,7 @@ import { McpServer } from '@modelcontextprotocol/server';
|
||||
import { z } from 'zod';
|
||||
import { ApiError, apiFetch, buildQuery, jsonBody, DEFAULT_FIRST_PAGE_SIZE, effectivePageSize, enforceDelegatedTenant, enforceDelegatedTenantForPage, followNextLink, pageSizeForCall, pickGlobalOrTenantPath, scanUntilMatch, scanWithTimeoutFallback } from '../client.js';
|
||||
import { withToolTelemetry } from '../telemetry.js';
|
||||
import { READ_ONLY, MAX_RESULT_SIZE_CHARS, LEAN_EVENT_FIELDS, LEAN_EVENT_OMISSION, leanFieldSelection, SUMMARY_EVENT_FIELDS, toolResultText, SessionIdSchema, isBenignHealthDetectionReport, tenantIdDescription, pageSizeDescription, CONTINUATION_DESCRIPTION, daysDescription } from './shared.js';
|
||||
import { READ_ONLY, MAX_RESULT_SIZE_CHARS, LEAN_EVENT_FIELDS, LEAN_EVENT_OMISSION, leanFieldSelection, SUMMARY_EVENT_FIELDS, toolResultText, SessionIdSchema, isBenignHealthDetectionReport, foreignSuccessRunIds, isCorrectedForeignFailure, tenantIdDescription, pageSizeDescription, CONTINUATION_DESCRIPTION, daysDescription } from './shared.js';
|
||||
import { toolError } from './error-handler.js';
|
||||
import { lookupErrorCode } from '../error-code-catalog.js';
|
||||
import { withEventTypeNote, assertKnownDevicePropertyKeys } from '../resource-catalog.js';
|
||||
@@ -534,6 +534,8 @@ export function registerSessionTools(server: McpServer, ga: boolean, delegated:
|
||||
// Observation coverage: what the agent could and could not see, folded from the
|
||||
// health/lifecycle events that the triage timeline below ranks low or drops.
|
||||
const coverage = buildSessionCoverage(s, allEvents);
|
||||
// Platform runs IME's saved result proved to carry another script's exit code (D-316).
|
||||
const foreignRuns = foreignSuccessRunIds(allEvents);
|
||||
|
||||
let errorCount = 0;
|
||||
let warningCount = 0;
|
||||
@@ -545,7 +547,8 @@ export function registerSessionTools(server: McpServer, ga: boolean, delegated:
|
||||
const sev = String(e.severity ?? '');
|
||||
// A compliant health-script detection mis-stamped script_failed/Error is benign —
|
||||
// exclude it so a green session's errorCount isn't inflated by routine compliance reports.
|
||||
const benign = isBenignHealthDetectionReport(String(e.eventType ?? ''), e.data);
|
||||
const benign = isBenignHealthDetectionReport(String(e.eventType ?? ''), e.data)
|
||||
|| isCorrectedForeignFailure(String(e.eventType ?? ''), e.data, foreignRuns);
|
||||
if (!benign && (sev === 'Error' || sev === 'Critical')) errorCount++;
|
||||
if (sev === 'Warning') warningCount++;
|
||||
const et = String(e.eventType ?? '');
|
||||
@@ -571,6 +574,8 @@ export function registerSessionTools(server: McpServer, ga: boolean, delegated:
|
||||
const relevanceScore = (e: Partial<EnrollmentEvent>): number => {
|
||||
// Benign compliant detection mis-stamped Error → rank as info-level, not top.
|
||||
if (isBenignHealthDetectionReport(String(e.eventType ?? ''), e.data)) return 10;
|
||||
// A failure that was another script's exit code is not a failure of this one.
|
||||
if (isCorrectedForeignFailure(String(e.eventType ?? ''), e.data, foreignRuns)) return 10;
|
||||
const sev = SEVERITY_RANK[String(e.severity ?? '')] ?? -1;
|
||||
if (sev >= 3) return 100; // Error/Critical
|
||||
if (PHASE_EVENT_TYPES.has(String(e.eventType ?? ''))) return 60;
|
||||
@@ -597,7 +602,10 @@ export function registerSessionTools(server: McpServer, ga: boolean, delegated:
|
||||
phase: phaseName(e.phase, s.enrollmentType),
|
||||
message: e.message,
|
||||
source: e.source,
|
||||
...keyEventErrorCode(e.data, e.source),
|
||||
// The exit code on a corrected run was another script's: no catalog text for it.
|
||||
...(isCorrectedForeignFailure(String(e.eventType ?? ''), e.data, foreignRuns)
|
||||
? { correctedByImeSavedResult: true }
|
||||
: keyEventErrorCode(e.data, e.source)),
|
||||
}));
|
||||
|
||||
let analysis = null;
|
||||
|
||||
@@ -75,6 +75,8 @@ export function leanFieldSelection(
|
||||
export const SUMMARY_EVENT_FIELDS =
|
||||
'eventType,severity,source,phase,timestamp,message,sequence,' +
|
||||
'data.scriptType,data.script_type,data.scriptPart,data.script_part,data.result,' +
|
||||
// Platform-run corrections from IME's saved result (foreignSuccessRunIds below).
|
||||
'data.runId,data.outcome,' +
|
||||
'data.rejectedSourceTimestamp,data.rejected_source_timestamp,' +
|
||||
'data.errorCode,data.exitCode,data.hresult,data.hresultFromWin32,data.hresultSymbol,' +
|
||||
'data.errorCodeInfo,data.exitCodeInfo,data.hresultInfo,data.hresultFromWin32Info,' +
|
||||
@@ -125,6 +127,38 @@ export function isBenignHealthDetectionReport(
|
||||
return true;
|
||||
}
|
||||
|
||||
/**
|
||||
* Run ids of platform runs whose `script_failed` came from another script's end block while IME
|
||||
* itself reported Success: `script_output_reconciliation` with outcome "foreign" and result Success
|
||||
* (D-316 — the agent had attributed a foreign executor's exit code and output; IME's saved result
|
||||
* proved it). The stored `script_failed` stays as written; read sides treat it like the benign
|
||||
* detection reports above: no error count, info-level rank, no exit-code catalog text.
|
||||
*/
|
||||
export function foreignSuccessRunIds(
|
||||
events: ReadonlyArray<{ eventType?: string | null; data?: Record<string, unknown> }>,
|
||||
): Set<string> {
|
||||
const runs = new Set<string>();
|
||||
for (const e of events) {
|
||||
if (e.eventType !== 'script_output_reconciliation' || !e.data) continue;
|
||||
if (String(e.data.outcome ?? '') !== 'foreign') continue;
|
||||
if (String(e.data.result ?? '').toLowerCase() !== 'success') continue;
|
||||
const runId = e.data.runId;
|
||||
if (typeof runId === 'string' && runId.length > 0) runs.add(runId);
|
||||
}
|
||||
return runs;
|
||||
}
|
||||
|
||||
/** True for a `script_failed` whose run `foreignSuccessRunIds` names. */
|
||||
export function isCorrectedForeignFailure(
|
||||
eventType: string | undefined,
|
||||
data: Record<string, unknown> | undefined,
|
||||
foreignRuns: ReadonlySet<string>,
|
||||
): boolean {
|
||||
if (eventType !== 'script_failed' || !data || foreignRuns.size === 0) return false;
|
||||
const runId = data.runId;
|
||||
return typeof runId === 'string' && foreignRuns.has(runId);
|
||||
}
|
||||
|
||||
/**
|
||||
* Builds the role-aware description for a tenant-boundable tool's `tenantId` argument. MCP clients weigh
|
||||
* the per-arg schema heavily, so a delegated (MSP) caller — for whom omitting tenantId is REJECTED, not
|
||||
|
||||
@@ -543,6 +543,13 @@ namespace AutopilotMonitor.Shared
|
||||
// policies on its own schedule for as long as the device is up; the first run and
|
||||
// every run with a different result are still emitted in full.
|
||||
public const string ScriptRecurrenceSummary = "script_recurrence_summary";
|
||||
// A platform script's emitted output disagreed with IME's own saved result
|
||||
// (HKLM\...\IntuneManagementExtension\Policies\<user>\<policy>, written after IME reported the
|
||||
// script batch): Data.outcome "foreign" (Warning, immediate upload — the run had been given
|
||||
// another executor's end block; Data.stdout/stderr replace it, the exit code is unverified) or
|
||||
// "repaired" (Info — the log had delivered the output incomplete). Data.runId names the corrected
|
||||
// script_completed/script_failed. Observability only, never DecisionEngine input.
|
||||
public const string ScriptOutputReconciliation = "script_output_reconciliation";
|
||||
// One-shot per agent run: the IME adapter detected replayed log content from a
|
||||
// previous enrollment (source lines > 24 h stale, e.g. IME logs surviving a
|
||||
// re-enrollment) and suppressed the historic script (script_started/completed/
|
||||
@@ -913,6 +920,37 @@ namespace AutopilotMonitor.Shared
|
||||
/// author-defined (no error-code enrichment unless <see cref="GatherRuleDataKeys.EnrichErrorCodes"/>).
|
||||
/// </summary>
|
||||
public const string GatherRuleExecutor = "GatherRuleExecutor";
|
||||
|
||||
/// <summary>Clock steps and sleep episodes from the Windows System log.</summary>
|
||||
public const string SystemTimelineWatcher = "SystemTimelineWatcher";
|
||||
|
||||
/// <summary>Windows Update client events (System and Operational log).</summary>
|
||||
public const string WindowsUpdateWatcher = "WindowsUpdateWatcher";
|
||||
|
||||
/// <summary>CBS servicing steps from the Setup log.</summary>
|
||||
public const string ServicingWatcher = "ServicingWatcher";
|
||||
|
||||
/// <summary>
|
||||
/// Sources whose rows never set a session's start. Their watchers backfill the Windows
|
||||
/// event logs with the original event time — clock steps and sleep up to 24 h, update
|
||||
/// and servicing activity up to 60 min before the agent started — so their earliest row
|
||||
/// is environment observation from before the enrollment, not its first step. Every
|
||||
/// place that derives the start from events applies this list: backend ingest and the
|
||||
/// Events-table probe, and the portal's session duration via shared-manifests.json.
|
||||
/// </summary>
|
||||
public static readonly string[] SessionAnchorIneligible =
|
||||
{
|
||||
SystemTimelineWatcher,
|
||||
WindowsUpdateWatcher,
|
||||
ServicingWatcher,
|
||||
};
|
||||
|
||||
/// <summary>
|
||||
/// False for <see cref="SessionAnchorIneligible"/> sources; true otherwise, including a
|
||||
/// row without a source.
|
||||
/// </summary>
|
||||
public static bool IsSessionAnchorEligible(string? source) =>
|
||||
System.Array.IndexOf(SessionAnchorIneligible, source) < 0;
|
||||
}
|
||||
|
||||
/// <summary>
|
||||
|
||||
@@ -54,6 +54,13 @@ namespace AutopilotMonitor.Shared.DataAccess
|
||||
Task<RawPage<SessionSummary>> GetSessionsPageAsync(
|
||||
string tenantId, int? days, int pageSize, string? continuation);
|
||||
|
||||
/// <summary>
|
||||
/// True when <paramref name="tenantId"/> holds at least one session (SessionsIndex, with the
|
||||
/// same primary-table fallback as <see cref="GetSessionsPageAsync"/>). Strict: storage failures
|
||||
/// PROPAGATE — the page read answers an empty list on failure, which would read as "no sessions".
|
||||
/// </summary>
|
||||
Task<bool> HasAnySessionStrictAsync(string tenantId);
|
||||
|
||||
/// <summary>
|
||||
/// Cross-tenant variant of <see cref="GetSessionsPageAsync"/> (Global Admin).
|
||||
/// <paramref name="tenantIdFilter"/> optionally restricts to a single tenant.
|
||||
|
||||
@@ -662,12 +662,12 @@ namespace AutopilotMonitor.Shared.Models
|
||||
// ===== ENTRA APP ROLES (RBAC) =====
|
||||
|
||||
/// <summary>
|
||||
/// When enabled, tenant member roles (Admin / Operator) may also be granted via Entra ID
|
||||
/// When enabled, tenant member roles (Admin / Operator / Viewer) may also be granted via Entra ID
|
||||
/// app-role assignments on the application's Enterprise App (the "roles" claim in the user's
|
||||
/// token), in addition to the TenantAdmins table. Resolution is table-first: an explicit
|
||||
/// TenantAdmins entry always overrides a claim-derived role (e.g. to grant an Operator
|
||||
/// CanManageBootstrapTokens). Only Admin and Operator are claim-mappable; the platform-wide
|
||||
/// GlobalAdmin role is never derived from claims. Off by default — per-tenant opt-in.
|
||||
/// CanManageBootstrapTokens). The platform-wide GlobalAdmin role is never derived from
|
||||
/// claims. Off by default — per-tenant opt-in.
|
||||
/// Backend-only setting: not delivered to the agent (no ConfigVersion impact).
|
||||
/// </summary>
|
||||
public bool EntraAppRolesEnabled { get; set; } = false;
|
||||
|
||||
@@ -17,6 +17,21 @@ namespace AutopilotMonitor.Shared.Models
|
||||
/// <summary>Device-scope ESP apps phase (EnrollmentPhase.AppsDevice spans).</summary>
|
||||
public const string EspApps = "esp_apps";
|
||||
|
||||
/// <summary>
|
||||
/// The OOBE quality update (D-310): from the start of the update page that installed an
|
||||
/// update to the last update evidence before the user is back — download, install, the
|
||||
/// restarts and the servicing after them. Takes the time from the phase segment it
|
||||
/// overlaps; one <see cref="OsUpdateSpan"/> per interval names the packages.
|
||||
/// </summary>
|
||||
public const string OsUpdate = "os_update";
|
||||
|
||||
/// <summary>
|
||||
/// After an OOBE update that restarted the device: from the update's end to the first
|
||||
/// evidence of the user (desktop, Hello wizard, user ESP apps) — the restart signed the
|
||||
/// user out, so this is the time until someone signs in again.
|
||||
/// </summary>
|
||||
public const string AwaitingSignIn = "awaiting_sign_in";
|
||||
|
||||
/// <summary>Identity / sign-in / Windows Hello (AccountSetup + FinalizingSetup spans).</summary>
|
||||
public const string IdentityHello = "identity_hello";
|
||||
|
||||
@@ -168,6 +183,26 @@ namespace AutopilotMonitor.Shared.Models
|
||||
public string Kind { get; set; } = string.Empty;
|
||||
}
|
||||
|
||||
/// <summary>
|
||||
/// One OOBE quality update behind an <see cref="TimeAttributionSegments.OsUpdate"/> span
|
||||
/// (D-310) — the interval and what the evidence names. Annotation like
|
||||
/// <see cref="RebootSpan"/>; the partition itself is in <see cref="SessionTimeBreakdown.Segments"/>.
|
||||
/// </summary>
|
||||
public class OsUpdateSpan
|
||||
{
|
||||
public DateTime StartUtc { get; set; }
|
||||
public DateTime EndUtc { get; set; }
|
||||
|
||||
/// <summary>In-window seconds of the interval.</summary>
|
||||
public int Seconds { get; set; }
|
||||
|
||||
/// <summary>KB numbers of the packages Windows serviced in the interval ("KB5129195"), in order of first appearance; empty when no package named one.</summary>
|
||||
public List<string> Kbs { get; set; } = new List<string>();
|
||||
|
||||
/// <summary>Restarts that began inside the interval.</summary>
|
||||
public int RebootCount { get; set; }
|
||||
}
|
||||
|
||||
/// <summary>
|
||||
/// Per-session enrollment time attribution (F1, insights spec) — an exact partition of the
|
||||
/// session's authoritative wall clock into named segments plus an explicit unattributed
|
||||
@@ -213,6 +248,9 @@ namespace AutopilotMonitor.Shared.Models
|
||||
|
||||
public List<SleepSpan> SleepSpans { get; set; } = new List<SleepSpan>();
|
||||
|
||||
/// <summary>The OOBE quality updates behind the <see cref="TimeAttributionSegments.OsUpdate"/> spans (at most one per observation window).</summary>
|
||||
public List<OsUpdateSpan> OsUpdates { get; set; } = new List<OsUpdateSpan>();
|
||||
|
||||
/// <summary>
|
||||
/// Install intervals of ESP-blocking apps (positive-evidence join against the latest
|
||||
/// <c>esp_config_detected</c> lists), top 20 by duration. <see cref="BlockingAppCount"/>
|
||||
|
||||
@@ -1,3 +1,4 @@
|
||||
using System;
|
||||
using System.Collections.Generic;
|
||||
|
||||
namespace AutopilotMonitor.Shared.Models
|
||||
@@ -30,4 +31,20 @@ namespace AutopilotMonitor.Shared.Models
|
||||
public int Count { get; set; }
|
||||
public IReadOnlyList<EnrollmentEvent> Events { get; set; } = default!;
|
||||
}
|
||||
|
||||
/// <summary>
|
||||
/// Response of GET /api/progress/tenant-status — whether the caller's own organization looks
|
||||
/// unused, so the Progress Portal can tell a member without a role whom to ask for access.
|
||||
/// </summary>
|
||||
// Declaration order == wire order.
|
||||
public class ProgressTenantStatusResponse : IApiResponse
|
||||
{
|
||||
public bool Success { get; set; }
|
||||
|
||||
/// <summary>True when the organization holds no session and signed up more than 14 days ago.</summary>
|
||||
public bool Unused { get; set; }
|
||||
|
||||
/// <summary>When the organization signed up; null (key omitted on the wire) when unknown.</summary>
|
||||
public DateTime? SignedUpAt { get; set; }
|
||||
}
|
||||
}
|
||||
|
||||
@@ -5,6 +5,8 @@ import { useRouter } from "next/navigation";
|
||||
import { useEffect, useRef, useState, useSyncExternalStore } from "react";
|
||||
import { api } from "@/lib/api";
|
||||
import { apiErrorText, fetchOk, jsonBody } from "@/lib/apiClient";
|
||||
import { landingTarget } from "@/lib/landingTarget";
|
||||
import { consumePostLoginReturnUrl } from "@/lib/postLoginReturn";
|
||||
import { DOCS_URL } from "@/utils/config";
|
||||
import { BrandMark } from "../../components/BrandMark";
|
||||
import type { SaveNotificationEmailRequest } from "@/utils/wire-types.generated";
|
||||
@@ -62,6 +64,7 @@ export default function ActivationPage() {
|
||||
// are asked for an address; an already-activated tenant opening /activation later is passed
|
||||
// straight through, exactly as before.
|
||||
const arrivedPendingRef = useRef<boolean | null>(null);
|
||||
const leftRef = useRef(false);
|
||||
|
||||
// Redirect out of the activation page — but not while the address question is still open.
|
||||
useEffect(() => {
|
||||
@@ -85,7 +88,11 @@ export default function ActivationPage() {
|
||||
// which is why almost no tenant ever got a welcome mail. Hold until the user has answered.
|
||||
if (arrivedPendingRef.current && !addressDecided) return;
|
||||
|
||||
router.push(user.isTenantAdmin || user.isGlobalAdmin ? "/dashboard" : "/progress");
|
||||
// Leave once: the deep link is consumed here, so a re-run before unmount must not route again
|
||||
// without it. The landing gate kept it during activation for exactly this hand-off.
|
||||
if (leftRef.current) return;
|
||||
leftRef.current = true;
|
||||
router.push(landingTarget(user, consumePostLoginReturnUrl()));
|
||||
}, [demo, isAuthenticated, isLoading, user, isActivationPending, addressDecided, router]);
|
||||
|
||||
// Poll while activation is pending: the auto-approve worker activates the tenant
|
||||
|
||||
@@ -4,8 +4,10 @@ import { useEffect, useState } from "react";
|
||||
import { api } from "@/lib/api";
|
||||
import { apiErrorText, fetchJson, fetchOk, jsonBody } from "@/lib/apiClient";
|
||||
import { useCanMutatePlatform } from "@/hooks/useCanMutatePlatform";
|
||||
import { AddMemberForm } from "@/components/members/AddMemberForm";
|
||||
import { MemberList } from "@/components/members/MemberList";
|
||||
import type { AddTenantAdminRequest, TenantAdminRow, UpdateMemberPermissionsRequest } from "@/utils/wire-types.generated";
|
||||
import { isApplicationKey, looksLikeGuid, principalLabel, type MemberKind } from "@/utils/principalKeys";
|
||||
import { looksLikeGuid, type MemberKind } from "@/utils/principalKeys";
|
||||
|
||||
// Wire type is generated from the backend DTO ("role" is absent for legacy pre-role rows).
|
||||
type TenantAdmin = TenantAdminRow;
|
||||
@@ -35,16 +37,11 @@ export function TenantAdminSection({
|
||||
const [addingAdmin, setAddingAdmin] = useState(false);
|
||||
const [removingAdmin, setRemovingAdmin] = useState<string | null>(null);
|
||||
const [togglingAdmin, setTogglingAdmin] = useState<string | null>(null);
|
||||
const [currentAdminPage, setCurrentAdminPage] = useState(0);
|
||||
const [adminSearchQuery, setAdminSearchQuery] = useState("");
|
||||
const adminsPerPage = 5;
|
||||
|
||||
// Fetch tenant admins when tenantId changes
|
||||
const fetchTenantAdmins = async (tid: string) => {
|
||||
try {
|
||||
setLoadingAdmins(true);
|
||||
setCurrentAdminPage(0); // Reset to first page when loading new tenant
|
||||
|
||||
const data = await fetchJson<TenantAdmin[]>(api.tenants.admins(tid), getAccessToken);
|
||||
setTenantAdmins(data);
|
||||
} catch (err) {
|
||||
@@ -98,11 +95,7 @@ export function TenantAdminSection({
|
||||
};
|
||||
|
||||
const handleRemoveTenantAdmin = async (adminUpn: string) => {
|
||||
if (!canMutate) return; // read-only Global Reader
|
||||
if (!confirm(`Are you sure you want to remove ${adminUpn} as an admin?`)) {
|
||||
return;
|
||||
}
|
||||
|
||||
if (!canMutate) return; // read-only Global Reader (the row asks for confirmation first)
|
||||
try {
|
||||
setRemovingAdmin(adminUpn);
|
||||
setError(null);
|
||||
@@ -176,261 +169,38 @@ export function TenantAdminSection({
|
||||
}
|
||||
};
|
||||
|
||||
// Admin Pagination with Search
|
||||
const filteredAdmins = tenantAdmins.filter(admin =>
|
||||
principalLabel(admin.upn).toLowerCase().includes(adminSearchQuery.toLowerCase())
|
||||
);
|
||||
const totalAdminPages = Math.ceil(filteredAdmins.length / adminsPerPage);
|
||||
const startAdminIndex = currentAdminPage * adminsPerPage;
|
||||
const endAdminIndex = startAdminIndex + adminsPerPage;
|
||||
const paginatedAdmins = filteredAdmins.slice(startAdminIndex, endAdminIndex);
|
||||
|
||||
return (
|
||||
<div className="bg-purple-50 border border-purple-200 rounded-lg p-4">
|
||||
<div className="flex items-start space-x-3">
|
||||
<svg className="w-5 h-5 text-purple-600 mt-0.5" fill="none" stroke="currentColor" viewBox="0 0 24 24">
|
||||
<path strokeLinecap="round" strokeLinejoin="round" strokeWidth={2} d="M12 4.354a4 4 0 110 5.292M15 21H3v-1a6 6 0 0112 0v1zm0 0h6v-1a6 6 0 00-9-5.197M13 7a4 4 0 11-8 0 4 4 0 018 0z" />
|
||||
</svg>
|
||||
<div className="flex-1">
|
||||
<p className="font-semibold text-purple-900 mb-2">Admin Users Management</p>
|
||||
<div className="bg-purple-50 border border-purple-200 rounded-lg p-4 space-y-4">
|
||||
<h3 className="font-semibold text-purple-900">
|
||||
Members
|
||||
{loadingAdmins && <span className="ml-2 text-sm font-normal text-purple-700">(Loading...)</span>}
|
||||
</h3>
|
||||
|
||||
{/* Current Admins List */}
|
||||
<div className="mb-3">
|
||||
<p className="text-sm text-purple-800 font-medium mb-2">
|
||||
Current Admins ({tenantAdmins.length}):
|
||||
</p>
|
||||
<AddMemberForm
|
||||
value={newAdminEmail}
|
||||
onValueChange={setNewAdminEmail}
|
||||
role={newMemberRole}
|
||||
onRoleChange={setNewMemberRole}
|
||||
kind={newMemberKind}
|
||||
onKindChange={setNewMemberKind}
|
||||
adding={addingAdmin}
|
||||
onAdd={handleAddTenantAdmin}
|
||||
disabled={!canMutate}
|
||||
stacked
|
||||
/>
|
||||
|
||||
{/* Search Field */}
|
||||
<div className="mb-3">
|
||||
<div className="relative">
|
||||
<input
|
||||
type="text"
|
||||
name="admin-search-modal"
|
||||
value={adminSearchQuery}
|
||||
onChange={(e) => {
|
||||
setAdminSearchQuery(e.target.value);
|
||||
setCurrentAdminPage(0);
|
||||
}}
|
||||
placeholder="Search by email..."
|
||||
autoComplete="off"
|
||||
className="w-full px-3 py-2 pl-9 pr-9 border border-gray-300 rounded-lg text-sm text-gray-900 placeholder-gray-500 focus:outline-none focus:ring-2 focus:ring-purple-500 focus:border-purple-500 transition-colors"
|
||||
/>
|
||||
<svg className="absolute left-2.5 top-2.5 w-4 h-4 text-gray-400" fill="none" stroke="currentColor" viewBox="0 0 24 24">
|
||||
<path strokeLinecap="round" strokeLinejoin="round" strokeWidth={2} d="M21 21l-6-6m2-5a7 7 0 11-14 0 7 7 0 0114 0z" />
|
||||
</svg>
|
||||
{adminSearchQuery && (
|
||||
<button
|
||||
onClick={() => {
|
||||
setAdminSearchQuery("");
|
||||
setCurrentAdminPage(0);
|
||||
}}
|
||||
className="absolute right-2.5 top-2.5 text-gray-400 hover:text-gray-600 transition-colors"
|
||||
title="Clear search"
|
||||
>
|
||||
<svg className="w-4 h-4" fill="none" stroke="currentColor" viewBox="0 0 24 24">
|
||||
<path strokeLinecap="round" strokeLinejoin="round" strokeWidth={2} d="M6 18L18 6M6 6l12 12" />
|
||||
</svg>
|
||||
</button>
|
||||
)}
|
||||
</div>
|
||||
</div>
|
||||
|
||||
{loadingAdmins ? (
|
||||
<div className="text-sm text-purple-700">Loading admins...</div>
|
||||
) : tenantAdmins.length === 0 ? (
|
||||
<div className="text-sm text-purple-700 italic">No admins configured yet</div>
|
||||
) : filteredAdmins.length === 0 ? (
|
||||
<div className="text-sm text-purple-700 italic p-3 text-center bg-purple-50 rounded-lg">
|
||||
No admins match your search
|
||||
</div>
|
||||
) : (
|
||||
<>
|
||||
<div className="space-y-2">
|
||||
{paginatedAdmins.map((admin) => {
|
||||
const isApplication = isApplicationKey(admin.upn);
|
||||
const effectiveRole = isApplication ? "Viewer" : (admin.role ?? "Admin");
|
||||
return (
|
||||
<div
|
||||
key={admin.upn}
|
||||
className={`p-2 bg-white border rounded text-sm ${
|
||||
admin.isEnabled ? 'border-purple-200' : 'border-gray-300 bg-gray-50'
|
||||
}`}
|
||||
>
|
||||
<div className="flex flex-col sm:flex-row sm:items-center sm:justify-between gap-2">
|
||||
<div className="flex-1 min-w-0">
|
||||
<div className="flex flex-wrap items-center gap-1.5">
|
||||
<div className="font-medium text-gray-900 truncate">{principalLabel(admin.upn)}</div>
|
||||
{isApplication && (
|
||||
<span className="inline-flex items-center px-2 py-0.5 rounded text-xs font-medium bg-gray-100 text-gray-700" title="Service principal — automation with its own token, or an app whose users connect through it; read-only">
|
||||
App
|
||||
</span>
|
||||
)}
|
||||
<span className={`inline-flex items-center px-2 py-0.5 rounded text-xs font-medium ${
|
||||
effectiveRole === "Admin"
|
||||
? "bg-purple-100 text-purple-800"
|
||||
: effectiveRole === "Operator"
|
||||
? "bg-blue-100 text-blue-800"
|
||||
: "bg-gray-100 text-gray-700"
|
||||
}`}>
|
||||
{effectiveRole}
|
||||
</span>
|
||||
{!admin.isEnabled && (
|
||||
<span className="inline-flex items-center px-2 py-0.5 rounded text-xs font-medium bg-gray-200 text-gray-700">
|
||||
Disabled
|
||||
</span>
|
||||
)}
|
||||
</div>
|
||||
<div className="text-xs text-gray-500">
|
||||
Added {new Date(admin.addedDate).toLocaleDateString()} by {admin.addedBy}
|
||||
</div>
|
||||
</div>
|
||||
<div className="flex flex-wrap items-center gap-2">
|
||||
<select
|
||||
value={effectiveRole}
|
||||
onChange={(e) => handleUpdatePermissions(admin.upn, e.target.value, admin.canManageBootstrapTokens)}
|
||||
disabled={!canMutate || isApplication || togglingAdmin === admin.upn}
|
||||
title={isApplication ? "A service principal is always read-only (Viewer)" : undefined}
|
||||
className="px-2 py-1 text-xs border border-gray-300 rounded bg-white text-gray-700 focus:outline-none focus:ring-1 focus:ring-purple-500 disabled:opacity-50"
|
||||
>
|
||||
<option value="Admin">Admin</option>
|
||||
<option value="Operator">Operator</option>
|
||||
<option value="Viewer">Viewer</option>
|
||||
</select>
|
||||
<button
|
||||
onClick={() => handleToggleTenantAdmin(admin.upn, admin.isEnabled)}
|
||||
disabled={!canMutate || togglingAdmin === admin.upn}
|
||||
className={`px-2 py-1 text-xs rounded hover:opacity-80 disabled:opacity-50 disabled:cursor-not-allowed ${
|
||||
admin.isEnabled
|
||||
? 'bg-yellow-600 text-white hover:bg-yellow-700'
|
||||
: 'bg-green-600 text-white hover:bg-green-700'
|
||||
}`}
|
||||
>
|
||||
{togglingAdmin === admin.upn
|
||||
? "..."
|
||||
: admin.isEnabled ? "Disable" : "Enable"}
|
||||
</button>
|
||||
<button
|
||||
onClick={() => handleRemoveTenantAdmin(admin.upn)}
|
||||
disabled={!canMutate || removingAdmin === admin.upn}
|
||||
className="px-2 py-1 text-xs bg-red-600 text-white rounded hover:bg-red-700 disabled:opacity-50 disabled:cursor-not-allowed"
|
||||
>
|
||||
{removingAdmin === admin.upn ? "..." : "Remove"}
|
||||
</button>
|
||||
</div>
|
||||
</div>
|
||||
|
||||
{/* Bootstrap token permission toggle for Operators */}
|
||||
{effectiveRole === "Operator" && (
|
||||
<div className="mt-2 pt-2 border-t border-gray-200">
|
||||
<label className="flex items-center space-x-2 cursor-pointer">
|
||||
<input
|
||||
type="checkbox"
|
||||
checked={admin.canManageBootstrapTokens}
|
||||
onChange={(e) => handleUpdatePermissions(admin.upn, "Operator", e.target.checked)}
|
||||
disabled={!canMutate || togglingAdmin === admin.upn}
|
||||
className="h-4 w-4 text-purple-600 rounded border-gray-300 focus:ring-purple-500 disabled:opacity-50"
|
||||
/>
|
||||
<span className="text-sm text-gray-700">Can manage bootstrap tokens</span>
|
||||
</label>
|
||||
</div>
|
||||
)}
|
||||
</div>
|
||||
);
|
||||
})}
|
||||
</div>
|
||||
|
||||
{/* Pagination */}
|
||||
{totalAdminPages > 1 && (
|
||||
<div className="flex items-center justify-between pt-3 mt-3 border-t border-purple-200">
|
||||
<button
|
||||
onClick={() => setCurrentAdminPage(p => Math.max(0, p - 1))}
|
||||
disabled={currentAdminPage === 0}
|
||||
className="px-3 py-1 text-xs font-medium text-purple-700 bg-white border border-purple-300 rounded hover:bg-purple-50 disabled:opacity-50 disabled:cursor-not-allowed transition-colors"
|
||||
>
|
||||
Previous
|
||||
</button>
|
||||
<span className="text-xs text-purple-700">
|
||||
Page {currentAdminPage + 1} of {totalAdminPages} ({filteredAdmins.length} admin{filteredAdmins.length !== 1 ? 's' : ''})
|
||||
</span>
|
||||
<button
|
||||
onClick={() => setCurrentAdminPage(p => Math.min(totalAdminPages - 1, p + 1))}
|
||||
disabled={currentAdminPage >= totalAdminPages - 1}
|
||||
className="px-3 py-1 text-xs font-medium text-purple-700 bg-white border border-purple-300 rounded hover:bg-purple-50 disabled:opacity-50 disabled:cursor-not-allowed transition-colors"
|
||||
>
|
||||
Next
|
||||
</button>
|
||||
</div>
|
||||
)}
|
||||
</>
|
||||
)}
|
||||
</div>
|
||||
|
||||
{/* Add New Admin */}
|
||||
<div>
|
||||
<div className="flex flex-wrap items-center gap-2 mb-2">
|
||||
<p className="text-sm text-purple-800 font-medium">Add New Admin:</p>
|
||||
<div className="inline-flex rounded border border-purple-300 overflow-hidden text-xs" role="group" aria-label="Member type">
|
||||
{([["user", "User"], ["application", "Service principal"]] as const).map(([kind, label]) => (
|
||||
<button
|
||||
key={kind}
|
||||
type="button"
|
||||
onClick={() => { setNewMemberKind(kind); setNewAdminEmail(""); }}
|
||||
className={`px-2 py-1 ${newMemberKind === kind ? "bg-purple-600 text-white" : "bg-white text-purple-700 hover:bg-purple-50"}`}
|
||||
>
|
||||
{label}
|
||||
</button>
|
||||
))}
|
||||
</div>
|
||||
</div>
|
||||
{addingApplication && (
|
||||
<p className="text-xs text-purple-700 mb-2">
|
||||
An application in this tenant, always read-only (Viewer). Automation calling with an app-only token
|
||||
(for example through a federated credential) needs the{" "}
|
||||
<span className="font-mono">access_as_application</span> permission. An app that signs users in and
|
||||
sends their tokens needs the delegated{" "}
|
||||
<span className="font-mono">access_as_user</span> permission, and its users can only read. Either is
|
||||
granted by admin consent in the tenant.
|
||||
</p>
|
||||
)}
|
||||
<div className="flex space-x-2">
|
||||
<input
|
||||
type={addingApplication ? "text" : "email"}
|
||||
name="modal-new-admin-email"
|
||||
id="modal-add-admin-email-input"
|
||||
value={newAdminEmail}
|
||||
onChange={(e) => setNewAdminEmail(e.target.value)}
|
||||
placeholder={addingApplication ? "Application (client) ID, e.g. 00000000-0000-0000-0000-000000000000" : "admin@tenant.com"}
|
||||
autoComplete="off"
|
||||
className="flex-1 px-3 py-2 border border-gray-300 rounded-lg text-sm text-gray-900 placeholder-gray-500 focus:outline-none focus:ring-2 focus:ring-green-500 focus:border-green-500 transition-colors"
|
||||
onKeyDown={(e) => {
|
||||
if (e.key === 'Enter') {
|
||||
e.preventDefault();
|
||||
handleAddTenantAdmin();
|
||||
}
|
||||
}}
|
||||
/>
|
||||
<select
|
||||
value={addingApplication ? "Viewer" : newMemberRole}
|
||||
onChange={(e) => setNewMemberRole(e.target.value)}
|
||||
disabled={addingApplication}
|
||||
title={addingApplication ? "A service principal is always read-only (Viewer)" : undefined}
|
||||
className="px-3 py-2 border border-gray-300 rounded-lg text-sm text-gray-700 bg-white focus:outline-none focus:ring-2 focus:ring-purple-500 focus:border-purple-500 transition-colors disabled:opacity-50"
|
||||
>
|
||||
<option value="Admin">Admin</option>
|
||||
<option value="Operator">Operator</option>
|
||||
<option value="Viewer">Viewer</option>
|
||||
</select>
|
||||
<button
|
||||
onClick={() => handleAddTenantAdmin()}
|
||||
disabled={!canMutate || addingAdmin || !newMemberInputValid}
|
||||
className="px-4 py-2 bg-purple-600 text-white rounded-lg hover:bg-purple-700 disabled:opacity-50 disabled:cursor-not-allowed transition-colors text-sm"
|
||||
>
|
||||
{addingAdmin ? "Adding..." : "Add"}
|
||||
</button>
|
||||
</div>
|
||||
</div>
|
||||
</div>
|
||||
</div>
|
||||
{/* key: a tenant switch starts on page 1 with no filter, search or open row. */}
|
||||
<MemberList
|
||||
key={tenantId}
|
||||
members={tenantAdmins}
|
||||
loading={loadingAdmins}
|
||||
canMutate={canMutate}
|
||||
removingUpn={removingAdmin}
|
||||
updatingUpn={togglingAdmin}
|
||||
onRemove={handleRemoveTenantAdmin}
|
||||
onToggleEnabled={handleToggleTenantAdmin}
|
||||
onUpdatePermissions={handleUpdatePermissions}
|
||||
/>
|
||||
</div>
|
||||
);
|
||||
}
|
||||
|
||||
@@ -1255,7 +1255,7 @@ function TenantManagementSectionInner({
|
||||
<span className="text-sm font-medium text-gray-700">Enable Entra App Roles</span>
|
||||
</label>
|
||||
<p className="text-xs text-gray-400 mt-1 ml-6">
|
||||
Allow Admin/Operator roles to be granted via Entra app-role assignments on the Enterprise App (the token's roles claim), in addition to the member table. The member table always wins.
|
||||
Allow Admin/Operator/Viewer roles to be granted via Entra app-role assignments on the Enterprise App (the token's roles claim), in addition to the member table. The member table always wins.
|
||||
</p>
|
||||
</div>
|
||||
|
||||
|
||||
@@ -4,6 +4,8 @@
|
||||
* and are marked noindex (events.guard.test.ts pins all four).
|
||||
*/
|
||||
|
||||
import { SUPPORT_EMAIL } from "@/lib/supportContact";
|
||||
|
||||
export interface EventArt {
|
||||
src: string;
|
||||
width: number;
|
||||
@@ -21,7 +23,7 @@ export interface FollowupEvent {
|
||||
art?: { hero: EventArt; starPointer: EventArt };
|
||||
}
|
||||
|
||||
export const WALKTHROUGH_EMAIL = "support@autopilotmonitor.com";
|
||||
export const WALKTHROUGH_EMAIL = SUPPORT_EMAIL;
|
||||
|
||||
/** Robots metadata of every event page. Not a robots.txt disallow: crawlers would then never see it. */
|
||||
export const EVENT_PAGE_ROBOTS = {
|
||||
|
||||
@@ -53,6 +53,8 @@ const MIN_SESSIONS_FOR_PANEL = 20;
|
||||
const SEGMENT_META: { key: string; label: string; color: string }[] = [
|
||||
{ key: "device_prep", label: "Device preparation", color: "bg-slate-400" },
|
||||
{ key: "esp_apps", label: "Apps (ESP)", color: "bg-blue-500" },
|
||||
{ key: "os_update", label: "Windows Update", color: "bg-cyan-500" },
|
||||
{ key: "awaiting_sign_in", label: "Waiting for sign-in", color: "bg-sky-200" },
|
||||
{ key: "identity_hello", label: "Identity & Hello", color: "bg-violet-500" },
|
||||
{ key: "user_esp", label: "User ESP", color: "bg-indigo-400" },
|
||||
{ key: "desktop_handoff", label: "Desktop handoff", color: "bg-emerald-500" },
|
||||
|
||||
@@ -152,6 +152,8 @@ export const KNOWN_EVENT_TYPES: EventTypeEntry[] = [
|
||||
description: "A platform script completed, or one phase (detection / remediation / post-detection) of a health script completed. Health scripts emit up to three of these per policy run." },
|
||||
{ value: "script_failed", label: "script_failed", category: "script",
|
||||
description: "A platform script crashed (exit code != 0), or the remediation phase of a health script crashed. Health-script detection / post-detection phases use exit code as a compliance verdict (non-zero = non-compliant) and emit script_completed even on non-zero exit; only a true script crash in those phases would surface here." },
|
||||
{ value: "script_output_reconciliation", label: "script_output_reconciliation", category: "script",
|
||||
description: "A platform script's reported output disagreed with the result IME saved after reporting the script batch. Outcome \"foreign\" (Warning): the run had been given another script's output and exit code; the saved output replaces it and the exit code is unknown. Outcome \"repaired\" (Info): the output had arrived incomplete. Carries runId (the corrected run), policyId, outcome, reason, result, stdout and stderr." },
|
||||
{ value: "script_timeout_suspected", label: "script_timeout_suspected", category: "script",
|
||||
description: "A platform script ran to the IME script-execution timeout (~30 min; threshold 25 min) and was marked Failed while the enrollment was in progress. IME runs platform scripts serially, so a hung script starves app installs and the Autopilot-Monitor bootstrap — the prime suspect behind a late agent start / pre-failed ESP. Advisory (one per policyId); carries durationSeconds, exitCode and espPhase." },
|
||||
{ value: "script_recurrence_summary", label: "script_recurrence_summary", category: "script",
|
||||
|
||||
@@ -1,41 +1,17 @@
|
||||
import { AuthGate } from "../components/landing/AuthGate";
|
||||
import { LandingNavbar } from "../components/landing/LandingNavbar";
|
||||
import { Hero } from "../components/landing/Hero";
|
||||
import { StatsBand } from "../components/landing/StatsBand";
|
||||
import { JustAsk } from "../components/landing/JustAsk";
|
||||
import { Story } from "../components/landing/Story";
|
||||
import { CapabilitiesStrip } from "../components/landing/CapabilitiesStrip";
|
||||
import { Comparison } from "../components/landing/Comparison";
|
||||
import { HowItWorks } from "../components/landing/HowItWorks";
|
||||
import { Testimonials } from "../components/landing/Testimonials";
|
||||
import { FinalCta } from "../components/landing/FinalCta";
|
||||
import { SiteFooter } from "../components/SiteFooter";
|
||||
import { MarketingTracker } from "../components/MarketingTracker";
|
||||
import { LandingPage } from "../components/landing/LandingPage";
|
||||
import { loadPlatformStatsSnapshot } from "../lib/platformStats";
|
||||
|
||||
// The stats read below runs once per `next build` and bypasses Next's fetch cache (`no-store`,
|
||||
// see lib/platformStats.ts). force-static keeps that legal in the static export; the landing
|
||||
// tree reads no request-time API (cookies, headers, search params) that it would blank out.
|
||||
export const dynamic = "force-static";
|
||||
|
||||
/**
|
||||
* Landing page v2 — a scroll story of one enrollment.
|
||||
* All theming goes through the lp-* tokens (globals.css); sections live
|
||||
* in components/landing/. Auth behavior (AuthGate redirect, LoginButton
|
||||
* portal handoff) is unchanged from v1.
|
||||
* The landing page with the platform stats of the build baked into its static HTML, so
|
||||
* crawlers and LLM fetchers that run no JS see the numbers too; browsers then load the live
|
||||
* ones (components/landing/StatsBand.tsx). Awaited here, not under a Suspense boundary: React
|
||||
* would move a resolved boundary of a page this size into a hidden div at the end of the body.
|
||||
*/
|
||||
export default function LandingPage() {
|
||||
return (
|
||||
<div className="landing-v2 min-h-screen bg-[var(--lp-bg)]">
|
||||
{/* Client component: handles auth redirect + loading overlay */}
|
||||
<AuthGate />
|
||||
<MarketingTracker page="landing">
|
||||
<LandingNavbar />
|
||||
<Hero />
|
||||
<StatsBand />
|
||||
<JustAsk />
|
||||
<Story />
|
||||
<CapabilitiesStrip />
|
||||
<Comparison />
|
||||
<HowItWorks />
|
||||
<Testimonials />
|
||||
<FinalCta />
|
||||
<SiteFooter />
|
||||
</MarketingTracker>
|
||||
</div>
|
||||
);
|
||||
export default async function Page() {
|
||||
return <LandingPage statsSnapshot={await loadPlatformStatsSnapshot()} />;
|
||||
}
|
||||
|
||||
@@ -0,0 +1,42 @@
|
||||
import { DOCS_PATHS } from "@/lib/docsPaths";
|
||||
import { SUPPORT_EMAIL } from "@/lib/supportContact";
|
||||
import { DOCS_URL } from "@/utils/config";
|
||||
import type { ProgressAccessHint as Hint } from "../hooks/progressAccessHint";
|
||||
|
||||
export const ACCESS_HINT_DOCS_URL = `${DOCS_URL}${DOCS_PATHS.progressPortalOnly}`;
|
||||
|
||||
const LINK_CLASS = "text-green-700 underline hover:text-green-800";
|
||||
|
||||
/** One muted line below the search telling a member without a role whom to ask for the full portal. */
|
||||
export function ProgressAccessHint({ hint }: { hint: Hint }) {
|
||||
const learnMore = (
|
||||
<a href={ACCESS_HINT_DOCS_URL} target="_blank" rel="noopener noreferrer" className={LINK_CLASS}>
|
||||
Learn more
|
||||
</a>
|
||||
);
|
||||
|
||||
if (hint.kind === "member") {
|
||||
return (
|
||||
<p className="mt-10 text-center text-sm text-gray-500">
|
||||
{"Looking for the full portal? Your organization already uses Autopilot Monitor. Ask your Autopilot Monitor admin for a role."}
|
||||
{" "}
|
||||
{learnMore}
|
||||
</p>
|
||||
);
|
||||
}
|
||||
|
||||
const signedUp = hint.signedUpOn ? ` on ${hint.signedUpOn}` : "";
|
||||
return (
|
||||
<p className="mt-10 text-center text-sm text-gray-500">
|
||||
{`Looking for the full portal? Your organization signed up for Autopilot Monitor${signedUp}, but no device has been monitored recently. Ask your Autopilot Monitor admin for a role, or write to`}
|
||||
{" "}
|
||||
<a href={`mailto:${SUPPORT_EMAIL}`} className={LINK_CLASS}>
|
||||
{SUPPORT_EMAIL}
|
||||
</a>
|
||||
{" "}
|
||||
{"if no one looks after it anymore."}
|
||||
{" "}
|
||||
{learnMore}
|
||||
</p>
|
||||
);
|
||||
}
|
||||
+47
@@ -0,0 +1,47 @@
|
||||
import { describe, expect, it } from "vitest";
|
||||
import { createElement } from "react";
|
||||
import { renderToStaticMarkup } from "react-dom/server";
|
||||
import { ACCESS_HINT_DOCS_URL, ProgressAccessHint } from "../ProgressAccessHint";
|
||||
import { SUPPORT_EMAIL } from "@/lib/supportContact";
|
||||
import { DOCS_URL } from "@/utils/config";
|
||||
|
||||
const render = (hint: Parameters<typeof ProgressAccessHint>[0]["hint"]) =>
|
||||
renderToStaticMarkup(createElement(ProgressAccessHint, { hint }));
|
||||
|
||||
describe("ProgressAccessHint", () => {
|
||||
it("points a member to their admins and names no contact address", () => {
|
||||
const html = render({ kind: "member" });
|
||||
|
||||
expect(html).toContain(
|
||||
"Looking for the full portal? Your organization already uses Autopilot Monitor. Ask your Autopilot Monitor admin for a role.",
|
||||
);
|
||||
expect(html).not.toContain("mailto:");
|
||||
});
|
||||
|
||||
it("offers the support mailbox for an unused organization, with spaces around the link", () => {
|
||||
const html = render({ kind: "unused", signedUpOn: "12 March 2026" });
|
||||
|
||||
expect(html).toContain("signed up for Autopilot Monitor on 12 March 2026, but no device has been monitored recently.");
|
||||
expect(html).toContain(`href="mailto:${SUPPORT_EMAIL}"`);
|
||||
expect(html).toMatch(/or write to <a [^>]+>support@autopilotmonitor\.com<\/a> if no one looks after it anymore\./);
|
||||
});
|
||||
|
||||
it("drops the date clause cleanly when the date is unknown", () => {
|
||||
const html = render({ kind: "unused", signedUpOn: null });
|
||||
|
||||
expect(html).toContain("signed up for Autopilot Monitor, but no device");
|
||||
});
|
||||
|
||||
it("links both variants to the troubleshooting article, after a space", () => {
|
||||
// GitBook publishes troubleshooting/ under its group slug; the folder URL of a new page is a 404.
|
||||
expect(ACCESS_HINT_DOCS_URL).toBe(`${DOCS_URL}/troubleshooting-and-support/progress-portal-only`);
|
||||
// Plain substring match: a URL interpolated into a RegExp needs every dot escaped.
|
||||
const link = `. <a href="${ACCESS_HINT_DOCS_URL}" target="_blank" rel="noopener noreferrer"`;
|
||||
for (const hint of [{ kind: "member" as const }, { kind: "unused" as const, signedUpOn: null }]) {
|
||||
const html = render(hint);
|
||||
const start = html.indexOf(link);
|
||||
expect(start).toBeGreaterThanOrEqual(0);
|
||||
expect(html.slice(start, html.indexOf("</a>", start))).toMatch(/>Learn more$/);
|
||||
}
|
||||
});
|
||||
});
|
||||
@@ -0,0 +1,35 @@
|
||||
import { describe, expect, it } from "vitest";
|
||||
import { formatSignupDate, progressAccessHint } from "../progressAccessHint";
|
||||
|
||||
describe("progressAccessHint", () => {
|
||||
it("keeps the member hint while the status is pending or failed", () => {
|
||||
expect(progressAccessHint(null)).toEqual({ kind: "member" });
|
||||
});
|
||||
|
||||
it("keeps the member hint for an organization in use", () => {
|
||||
expect(progressAccessHint({ success: true, unused: false, signedUpAt: "2026-03-12T08:30:00Z" })).toEqual({
|
||||
kind: "member",
|
||||
});
|
||||
});
|
||||
|
||||
it("names the signup date of an unused organization", () => {
|
||||
expect(progressAccessHint({ success: true, unused: true, signedUpAt: "2026-03-12T08:30:00Z" })).toEqual({
|
||||
kind: "unused",
|
||||
signedUpOn: "12 March 2026",
|
||||
});
|
||||
});
|
||||
|
||||
it("leaves the date out when the backend does not know it", () => {
|
||||
expect(progressAccessHint({ success: true, unused: true })).toEqual({ kind: "unused", signedUpOn: null });
|
||||
});
|
||||
});
|
||||
|
||||
describe("formatSignupDate", () => {
|
||||
it("reads the date in UTC, so a late-evening signup keeps its day", () => {
|
||||
expect(formatSignupDate("2026-03-12T23:30:00Z")).toBe("12 March 2026");
|
||||
});
|
||||
|
||||
it("returns null for an unparsable value", () => {
|
||||
expect(formatSignupDate("not a date")).toBeNull();
|
||||
});
|
||||
});
|
||||
@@ -0,0 +1,23 @@
|
||||
import type { ProgressTenantStatusResponse } from "@/utils/wire-types.generated";
|
||||
|
||||
/** The note below the Progress Portal search for a member without a role. */
|
||||
export type ProgressAccessHint =
|
||||
| { kind: "member" }
|
||||
| { kind: "unused"; signedUpOn: string | null };
|
||||
|
||||
/**
|
||||
* A member without a role always gets the hint; the tenant status only sharpens it. A pending or
|
||||
* failed status read (null) keeps the plain member hint, which needs no data.
|
||||
*/
|
||||
export function progressAccessHint(status: ProgressTenantStatusResponse | null): ProgressAccessHint {
|
||||
if (!status?.unused) return { kind: "member" };
|
||||
return { kind: "unused", signedUpOn: formatSignupDate(status.signedUpAt) };
|
||||
}
|
||||
|
||||
/** "12 March 2026" (the docs' date style); null for a missing or unparsable date. */
|
||||
export function formatSignupDate(iso: string | undefined): string | null {
|
||||
if (!iso) return null;
|
||||
const date = new Date(iso);
|
||||
if (Number.isNaN(date.getTime())) return null;
|
||||
return date.toLocaleDateString("en-GB", { day: "numeric", month: "long", year: "numeric", timeZone: "UTC" });
|
||||
}
|
||||
@@ -0,0 +1,34 @@
|
||||
"use client";
|
||||
|
||||
import { useEffect, useState } from "react";
|
||||
import { api } from "@/lib/api";
|
||||
import { fetchJson, type GetAccessToken } from "@/lib/apiClient";
|
||||
import type { ProgressTenantStatusResponse } from "@/utils/wire-types.generated";
|
||||
|
||||
/**
|
||||
* One read of the caller's tenant status for the access hint, only for members without a role
|
||||
* (`enabled`). Any failure leaves null: the hint then stays the plain member note, so nothing here
|
||||
* is worth a notification.
|
||||
*/
|
||||
export function useProgressTenantStatus(
|
||||
enabled: boolean,
|
||||
getAccessToken: GetAccessToken,
|
||||
): ProgressTenantStatusResponse | null {
|
||||
const [status, setStatus] = useState<ProgressTenantStatusResponse | null>(null);
|
||||
|
||||
useEffect(() => {
|
||||
if (!enabled) return;
|
||||
let cancelled = false;
|
||||
const run = async () => {
|
||||
const data = await fetchJson<ProgressTenantStatusResponse>(api.progress.tenantStatus(), getAccessToken)
|
||||
.catch(() => null);
|
||||
if (!cancelled) setStatus(data);
|
||||
};
|
||||
void run();
|
||||
return () => {
|
||||
cancelled = true;
|
||||
};
|
||||
}, [enabled, getAccessToken]);
|
||||
|
||||
return status;
|
||||
}
|
||||
@@ -10,8 +10,12 @@ import { useProgressEvents } from "./hooks/useProgressEvents";
|
||||
import { useProgressSignalR } from "./hooks/useProgressSignalR";
|
||||
import { useProgressDerivedData } from "./hooks/useProgressDerivedData";
|
||||
import { DeviceStatusChips } from "./components/DeviceStatusChips";
|
||||
import { ProgressAccessHint } from "./components/ProgressAccessHint";
|
||||
import type { PresentationKind } from "./hooks/progressLayout";
|
||||
import { progressAccessHint } from "./hooks/progressAccessHint";
|
||||
import { useProgressTenantStatus } from "./hooks/useProgressTenantStatus";
|
||||
import { useNotifications } from "../../contexts/NotificationContext";
|
||||
import { hasTenantReadScope } from "../../lib/tenantScope";
|
||||
|
||||
function formatDuration(ms: number): string {
|
||||
const seconds = Math.floor(ms / 1000);
|
||||
@@ -49,10 +53,14 @@ function stepState(index: number, activeStepIndex: number, kind: PresentationKin
|
||||
|
||||
export default function ProgressPortalPage() {
|
||||
const { tenantId } = useTenant();
|
||||
const { getAccessToken } = useAuth();
|
||||
const { user, getAccessToken } = useAuth();
|
||||
const { addNotification } = useNotifications();
|
||||
const signalR = useSignalR();
|
||||
|
||||
// Members without a role only ever see this page; tell them the full portal exists.
|
||||
const showAccessHint = !!user && !hasTenantReadScope(user);
|
||||
const tenantStatus = useProgressTenantStatus(showAccessHint, getAccessToken);
|
||||
|
||||
const search = useProgressSearch({
|
||||
tenantId,
|
||||
getAccessToken,
|
||||
@@ -506,6 +514,9 @@ export default function ProgressPortalPage() {
|
||||
</div>
|
||||
</div>
|
||||
)}
|
||||
|
||||
{/* Search view only: someone following their device never sees it under the progress. */}
|
||||
{showAccessHint && !session && <ProgressAccessHint hint={progressAccessHint(tenantStatus)} />}
|
||||
</div>
|
||||
</div>
|
||||
</ProtectedRoute>
|
||||
|
||||
@@ -1,6 +1,6 @@
|
||||
"use client";
|
||||
|
||||
import { useState, useMemo, useDeferredValue } from "react";
|
||||
import { createContext, useContext, useState, useMemo, useDeferredValue } from "react";
|
||||
import { EnrollmentEvent, Session } from "@/types";
|
||||
import { normalizeEventDataForDisplay, shortenBuildHashInMessage } from "../utils/eventHelpers";
|
||||
import { buildEventSearchMatcher, formatEventSearchTerm, parseEventSearchQuery } from "../utils/eventSearchQuery";
|
||||
@@ -8,6 +8,11 @@ import { getEnrichedOrLookup, formatErrorCode, errorCodeTooltip, type ErrorCodeI
|
||||
import { readTimeProvenance, classifyTimeJump, readClockChangeDeltaMs } from "@/lib/timeProvenance";
|
||||
import { isRebootOrRetryClass } from "@/lib/installProgress";
|
||||
import { formatDuration, formatUtcOffset } from "@/lib/formatting";
|
||||
import { SCRIPT_OUTPUT_RECONCILIATION } from "@/lib/scriptExecutions";
|
||||
|
||||
// runId → outcome of every platform run that IME's saved result corrected later (D-316): the
|
||||
// run's own row says so, so its emitted output is never read as the script's.
|
||||
const CorrectedRunsContext = createContext<ReadonlyMap<string, "foreign" | "repaired">>(new Map());
|
||||
|
||||
const SEARCH_SYNTAX_HINT =
|
||||
"Searches event type, message, source and the details JSON (e.g. gather output). " +
|
||||
@@ -104,10 +109,20 @@ export default function EventTimeline({
|
||||
[events],
|
||||
);
|
||||
|
||||
const correctedRuns = useMemo(() => {
|
||||
const runs = new Map<string, "foreign" | "repaired">();
|
||||
for (const e of events) {
|
||||
if (e.eventType !== SCRIPT_OUTPUT_RECONCILIATION) continue;
|
||||
const runId = e.data?.runId;
|
||||
if (typeof runId === "string" && runId.length > 0) runs.set(runId, e.data?.outcome === "foreign" ? "foreign" : "repaired");
|
||||
}
|
||||
return runs;
|
||||
}, [events]);
|
||||
|
||||
const filterPhaseEvents = (phaseEvents: EnrollmentEvent[]) =>
|
||||
matchesSearch ? phaseEvents.filter(matchesSearch) : phaseEvents;
|
||||
|
||||
return (
|
||||
const timeline = (
|
||||
<div className="space-y-6">
|
||||
{/* Search + Severity filters + Expand/Collapse — shared controls above the timeline(s) */}
|
||||
<div className="flex flex-col sm:flex-row sm:items-center gap-2">
|
||||
@@ -356,6 +371,8 @@ export default function EventTimeline({
|
||||
)}
|
||||
</div>
|
||||
);
|
||||
|
||||
return <CorrectedRunsContext.Provider value={correctedRuns}>{timeline}</CorrectedRunsContext.Provider>;
|
||||
}
|
||||
|
||||
function PhaseSection({
|
||||
@@ -515,7 +532,13 @@ function EventRow({ event, showScriptOutput, prevEvent, clockDeltas }: { event:
|
||||
// timeline still applies the same script-event styling/iconography.
|
||||
const isScriptEvent = event.eventType === "script_started"
|
||||
|| event.eventType === "script_completed"
|
||||
|| event.eventType === "script_failed";
|
||||
|| event.eventType === "script_failed"
|
||||
|| event.eventType === SCRIPT_OUTPUT_RECONCILIATION;
|
||||
const correctedRuns = useContext(CorrectedRunsContext);
|
||||
const eventRunId = event.data?.runId;
|
||||
const laterCorrection = event.eventType !== SCRIPT_OUTPUT_RECONCILIATION && typeof eventRunId === "string"
|
||||
? correctedRuns.get(eventRunId)
|
||||
: undefined;
|
||||
const detailData = useMemo(() => {
|
||||
if (!rawDetailData || !isScriptEvent || showScriptOutput !== false) return rawDetailData;
|
||||
const filtered = { ...rawDetailData };
|
||||
@@ -611,6 +634,13 @@ function EventRow({ event, showScriptOutput, prevEvent, clockDeltas }: { event:
|
||||
<span className="text-sm font-medium text-gray-900">{event.eventType}</span>
|
||||
</div>
|
||||
<p className="mt-1 text-sm text-gray-600" title={event.message || undefined}>{shortenBuildHashInMessage(event.message)}</p>
|
||||
{laterCorrection && (
|
||||
<p className="mt-0.5 text-xs text-gray-500">
|
||||
{laterCorrection === "foreign"
|
||||
? "Corrected later from IME's saved result: the output and exit code on this row belonged to another script."
|
||||
: "Output completed later from IME's saved result."}
|
||||
</p>
|
||||
)}
|
||||
{/* Exit code / HRESULT badge for app install events */}
|
||||
{(event.eventType === "app_install_failed" || event.eventType === "app_install_completed") && (() => {
|
||||
const ec = (event.data?.exitCode ?? event.data?.exit_code) as string | number | undefined;
|
||||
|
||||
@@ -49,6 +49,8 @@ export type SessionTimeBreakdownDto = SessionTimeBreakdown;
|
||||
const SEGMENT_META: { key: string; label: string; color: string }[] = [
|
||||
{ key: "device_prep", label: "Device preparation", color: "bg-slate-400" },
|
||||
{ key: "esp_apps", label: "Apps (ESP)", color: "bg-blue-500" },
|
||||
{ key: "os_update", label: "Windows Update", color: "bg-cyan-500" },
|
||||
{ key: "awaiting_sign_in", label: "Waiting for sign-in", color: "bg-sky-200" },
|
||||
{ key: "identity_hello", label: "Identity & Hello", color: "bg-violet-500" },
|
||||
{ key: "user_esp", label: "User ESP", color: "bg-indigo-400" },
|
||||
{ key: "desktop_handoff", label: "Desktop handoff", color: "bg-emerald-500" },
|
||||
@@ -83,8 +85,22 @@ export default function TimeAttributionLane({ breakdown }: { breakdown: SessionT
|
||||
}
|
||||
totals.set("unattributed", breakdown.unattributedSeconds);
|
||||
|
||||
// What the OOBE quality update installed and how often it restarted — named on the
|
||||
// Windows Update slice (the server computed it; the client only joins the lists).
|
||||
const osUpdates = breakdown.osUpdates ?? [];
|
||||
const updateKbs = Array.from(new Set(osUpdates.flatMap(u => u.kbs ?? [])));
|
||||
const updateRestarts = osUpdates.reduce((sum, u) => sum + (u.rebootCount ?? 0), 0);
|
||||
const updateDetail = [
|
||||
updateKbs.join(", "),
|
||||
updateRestarts > 0 ? `${updateRestarts} restart${updateRestarts !== 1 ? "s" : ""}` : "",
|
||||
].filter(Boolean).join(" · ");
|
||||
|
||||
const parts = SEGMENT_META
|
||||
.map(meta => ({ ...meta, seconds: totals.get(meta.key) ?? 0 }))
|
||||
.map(meta => ({
|
||||
...meta,
|
||||
seconds: totals.get(meta.key) ?? 0,
|
||||
detail: meta.key === "os_update" ? updateDetail : "",
|
||||
}))
|
||||
.filter(p => p.seconds > 0);
|
||||
|
||||
const flags = breakdown.qualityFlags
|
||||
@@ -132,7 +148,7 @@ export default function TimeAttributionLane({ breakdown }: { breakdown: SessionT
|
||||
key={p.key}
|
||||
className={`${p.color} h-full`}
|
||||
style={{ width: `${(p.seconds / wallClock) * 100}%` }}
|
||||
title={`${p.label}: ${formatDuration(p.seconds)}`}
|
||||
title={`${p.label}: ${formatDuration(p.seconds)}${p.detail ? ` · ${p.detail}` : ""}`}
|
||||
/>
|
||||
))}
|
||||
</div>
|
||||
@@ -143,7 +159,7 @@ export default function TimeAttributionLane({ breakdown }: { breakdown: SessionT
|
||||
<span key={p.key} className="inline-flex items-center text-xs text-gray-600">
|
||||
<span className={`w-2.5 h-2.5 rounded-sm mr-1.5 ${p.color}`} />
|
||||
{p.label}
|
||||
<span className="ml-1 text-gray-400">{formatDuration(p.seconds)}</span>
|
||||
<span className="ml-1 text-gray-400">{p.detail ? `${formatDuration(p.seconds)} · ${p.detail}` : formatDuration(p.seconds)}</span>
|
||||
</span>
|
||||
))}
|
||||
</div>
|
||||
|
||||
@@ -234,6 +234,8 @@ function SessionDetailContent() {
|
||||
e => e.eventType === "script_started"
|
||||
|| e.eventType === "script_completed"
|
||||
|| e.eventType === "script_failed"
|
||||
// Corrections of a platform run from IME's saved result (D-316) — applied by the reducer.
|
||||
|| e.eventType === "script_output_reconciliation"
|
||||
),
|
||||
[events]
|
||||
);
|
||||
|
||||
@@ -320,10 +320,6 @@ interface TenantConfigContextValue {
|
||||
addingAdmin: boolean;
|
||||
removingAdmin: string | null;
|
||||
togglingAdmin: string | null;
|
||||
adminSearchQuery: string;
|
||||
setAdminSearchQuery: (v: string) => void;
|
||||
currentAdminPage: number;
|
||||
setCurrentAdminPage: (v: SetStateAction<number>) => void;
|
||||
handleAddAdmin: () => Promise<void>;
|
||||
handleRemoveAdmin: (adminUpn: string) => Promise<void>;
|
||||
handleToggleTenantAdmin: (adminUpn: string, isEnabled: boolean) => Promise<void>;
|
||||
@@ -401,8 +397,6 @@ export function TenantConfigProvider({ children }: { children: React.ReactNode }
|
||||
const [addingAdmin, setAddingAdmin] = useState(false);
|
||||
const [removingAdmin, setRemovingAdmin] = useState<string | null>(null);
|
||||
const [togglingAdmin, setTogglingAdmin] = useState<string | null>(null);
|
||||
const [adminSearchQuery, setAdminSearchQuery] = useState("");
|
||||
const [currentAdminPage, setCurrentAdminPage] = useState(0);
|
||||
|
||||
// Offboard
|
||||
const [showOffboardDialog, setShowOffboardDialog] = useState(false);
|
||||
@@ -1382,7 +1376,6 @@ export function TenantConfigProvider({ children }: { children: React.ReactNode }
|
||||
|
||||
const handleRemoveAdmin = useCallback(async (adminUpn: string) => {
|
||||
if (!tenantId) return;
|
||||
if (!confirm(`Are you sure you want to remove ${adminUpn} as an admin?`)) return;
|
||||
|
||||
try {
|
||||
setRemovingAdmin(adminUpn);
|
||||
@@ -1677,8 +1670,6 @@ export function TenantConfigProvider({ children }: { children: React.ReactNode }
|
||||
newMemberRole, setNewMemberRole,
|
||||
newMemberKind, setNewMemberKind,
|
||||
addingAdmin, removingAdmin, togglingAdmin,
|
||||
adminSearchQuery, setAdminSearchQuery,
|
||||
currentAdminPage, setCurrentAdminPage,
|
||||
handleAddAdmin, handleRemoveAdmin, handleToggleTenantAdmin, handleUpdatePermissions,
|
||||
|
||||
// Bootstrap sessions
|
||||
@@ -1730,7 +1721,6 @@ export function TenantConfigProvider({ children }: { children: React.ReactNode }
|
||||
tenantDiagPaths, newDiagPath, newDiagDesc,
|
||||
handleSaveDiagnostics, handleResetDiagnostics,
|
||||
admins, loadingAdmins, newAdminEmail, newMemberRole, newMemberKind, addingAdmin, removingAdmin, togglingAdmin,
|
||||
adminSearchQuery, currentAdminPage,
|
||||
handleAddAdmin, handleRemoveAdmin, handleToggleTenantAdmin, handleUpdatePermissions,
|
||||
bootstrapSessions, bootstrapLoading, fetchBootstrapSessions, createBootstrapSession, revokeBootstrapSession,
|
||||
dataRetentionDays, sessionTimeoutHours, handleSaveDataManagement, handleResetDataManagement,
|
||||
|
||||
@@ -1,9 +1,12 @@
|
||||
"use client";
|
||||
|
||||
import { useState } from "react";
|
||||
import { TenantAdmin } from "../types";
|
||||
import { SectionCardHeader } from "@/components/SectionCardHeader";
|
||||
import { AddMemberForm } from "@/components/members/AddMemberForm";
|
||||
import { MemberList } from "@/components/members/MemberList";
|
||||
import { DOCS_PATHS } from "@/lib/docsPaths";
|
||||
import { isApplicationKey, looksLikeGuid, principalLabel, type MemberKind } from "@/utils/principalKeys";
|
||||
import type { MemberKind } from "@/utils/principalKeys";
|
||||
|
||||
interface AdminManagementSectionProps {
|
||||
admins: TenantAdmin[];
|
||||
@@ -17,47 +20,15 @@ interface AdminManagementSectionProps {
|
||||
addingAdmin: boolean;
|
||||
removingAdmin: string | null;
|
||||
togglingAdmin: string | null;
|
||||
adminSearchQuery: string;
|
||||
setAdminSearchQuery: (value: string) => void;
|
||||
currentAdminPage: number;
|
||||
setCurrentAdminPage: (value: number | ((prev: number) => number)) => void;
|
||||
user: { upn?: string } | null;
|
||||
/** The tenant also takes roles from Entra app-role assignments (an operator opt-in). */
|
||||
entraAppRolesEnabled: boolean;
|
||||
onAddAdmin: () => void;
|
||||
onRemoveAdmin: (upn: string) => void;
|
||||
onRemoveAdmin: (upn: string) => Promise<void>;
|
||||
onToggleAdmin: (upn: string, isEnabled: boolean) => void;
|
||||
onUpdatePermissions: (upn: string, role: string, canManageBootstrapTokens: boolean) => void;
|
||||
}
|
||||
|
||||
function getRoleBadge(role: string | null | undefined) {
|
||||
const effectiveRole = role ?? "Admin";
|
||||
switch (effectiveRole) {
|
||||
case "Admin":
|
||||
return (
|
||||
<span className="inline-flex items-center px-2 py-0.5 rounded text-xs font-medium bg-green-100 text-green-800">
|
||||
Admin
|
||||
</span>
|
||||
);
|
||||
case "Operator":
|
||||
return (
|
||||
<span className="inline-flex items-center px-2 py-0.5 rounded text-xs font-medium bg-blue-100 text-blue-800">
|
||||
Operator
|
||||
</span>
|
||||
);
|
||||
case "Viewer":
|
||||
return (
|
||||
<span className="inline-flex items-center px-2 py-0.5 rounded text-xs font-medium bg-gray-100 text-gray-800">
|
||||
Viewer
|
||||
</span>
|
||||
);
|
||||
default:
|
||||
return (
|
||||
<span className="inline-flex items-center px-2 py-0.5 rounded text-xs font-medium bg-gray-100 text-gray-600">
|
||||
{effectiveRole}
|
||||
</span>
|
||||
);
|
||||
}
|
||||
}
|
||||
|
||||
export default function AdminManagementSection({
|
||||
admins,
|
||||
loadingAdmins,
|
||||
@@ -70,17 +41,15 @@ export default function AdminManagementSection({
|
||||
addingAdmin,
|
||||
removingAdmin,
|
||||
togglingAdmin,
|
||||
adminSearchQuery,
|
||||
setAdminSearchQuery,
|
||||
currentAdminPage,
|
||||
setCurrentAdminPage,
|
||||
user,
|
||||
entraAppRolesEnabled,
|
||||
onAddAdmin,
|
||||
onRemoveAdmin,
|
||||
onToggleAdmin,
|
||||
onUpdatePermissions,
|
||||
}: AdminManagementSectionProps) {
|
||||
const addingApplication = newMemberKind === "application";
|
||||
const [rolesOpen, setRolesOpen] = useState(false);
|
||||
|
||||
return (
|
||||
<div className="bg-white rounded-lg shadow">
|
||||
<SectionCardHeader
|
||||
@@ -90,15 +59,31 @@ export default function AdminManagementSection({
|
||||
subtitle="Manage team members and their roles for this tenant"
|
||||
docsPath={DOCS_PATHS.accessManagement}
|
||||
/>
|
||||
<div className="p-6 space-y-4">
|
||||
<div className="bg-blue-50 border border-blue-200 rounded-lg p-4">
|
||||
<div className="flex items-start space-x-3">
|
||||
<svg className="w-5 h-5 text-blue-600 mt-0.5" fill="none" stroke="currentColor" viewBox="0 0 24 24">
|
||||
<div className="p-6 space-y-5">
|
||||
<div className="bg-blue-50 border border-blue-200 rounded-lg">
|
||||
<button
|
||||
type="button"
|
||||
aria-expanded={rolesOpen}
|
||||
onClick={() => setRolesOpen((open) => !open)}
|
||||
className="w-full flex items-center gap-3 px-4 py-2.5 text-left"
|
||||
>
|
||||
<svg className="w-5 h-5 flex-shrink-0 text-blue-600" fill="none" stroke="currentColor" viewBox="0 0 24 24" aria-hidden="true">
|
||||
<path strokeLinecap="round" strokeLinejoin="round" strokeWidth={2} d="M13 16h-1v-4h-1m1-4h.01M21 12a9 9 0 11-18 0 9 9 0 0118 0z" />
|
||||
</svg>
|
||||
<div className="text-sm text-blue-800">
|
||||
<p className="font-medium">About Roles</p>
|
||||
<p className="mt-1">
|
||||
<span className="flex-1 text-sm font-medium text-blue-800">About Roles</span>
|
||||
<svg
|
||||
className={`w-4 h-4 flex-shrink-0 text-blue-600 transition-transform ${rolesOpen ? "rotate-180" : ""}`}
|
||||
fill="none"
|
||||
stroke="currentColor"
|
||||
viewBox="0 0 24 24"
|
||||
aria-hidden="true"
|
||||
>
|
||||
<path strokeLinecap="round" strokeLinejoin="round" strokeWidth={2} d="M19 9l-7 7-7-7" />
|
||||
</svg>
|
||||
</button>
|
||||
{rolesOpen && (
|
||||
<div className="px-4 pb-3 pl-12 text-sm text-blue-800">
|
||||
<p>
|
||||
<strong>Member</strong> — No role assigned. Sees only the Progress Portal for their own enrollments.
|
||||
</p>
|
||||
<p className="mt-1">
|
||||
@@ -114,279 +99,40 @@ export default function AdminManagementSection({
|
||||
<strong>Your email:</strong> {user?.upn}
|
||||
</p>
|
||||
</div>
|
||||
</div>
|
||||
</div>
|
||||
|
||||
{/* Current Members List */}
|
||||
<div>
|
||||
<label className="block mb-2">
|
||||
<span className="text-gray-700 font-medium">Current Team Members</span>
|
||||
{loadingAdmins && (
|
||||
<span className="ml-2 text-sm text-gray-500">(Loading...)</span>
|
||||
)}
|
||||
</label>
|
||||
|
||||
{/* Search Field */}
|
||||
<div className="mb-3">
|
||||
<div className="relative">
|
||||
<input
|
||||
type="text"
|
||||
name="admin-search-field"
|
||||
value={adminSearchQuery}
|
||||
onChange={(e) => {
|
||||
setAdminSearchQuery(e.target.value);
|
||||
setCurrentAdminPage(0);
|
||||
}}
|
||||
placeholder="Search by email..."
|
||||
autoComplete="off"
|
||||
className="w-full px-4 py-2 pl-10 pr-10 border border-gray-300 rounded-lg text-sm text-gray-900 placeholder-gray-500 focus:outline-none focus:ring-2 focus:ring-purple-500 focus:border-purple-500 transition-colors"
|
||||
/>
|
||||
<svg className="absolute left-3 top-2.5 w-5 h-5 text-gray-400" fill="none" stroke="currentColor" viewBox="0 0 24 24">
|
||||
<path strokeLinecap="round" strokeLinejoin="round" strokeWidth={2} d="M21 21l-6-6m2-5a7 7 0 11-14 0 7 7 0 0114 0z" />
|
||||
</svg>
|
||||
{adminSearchQuery && (
|
||||
<button
|
||||
onClick={() => {
|
||||
setAdminSearchQuery("");
|
||||
setCurrentAdminPage(0);
|
||||
}}
|
||||
className="absolute right-3 top-2.5 text-gray-400 hover:text-gray-600 transition-colors"
|
||||
title="Clear search"
|
||||
>
|
||||
<svg className="w-5 h-5" fill="none" stroke="currentColor" viewBox="0 0 24 24">
|
||||
<path strokeLinecap="round" strokeLinejoin="round" strokeWidth={2} d="M6 18L18 6M6 6l12 12" />
|
||||
</svg>
|
||||
</button>
|
||||
)}
|
||||
</div>
|
||||
</div>
|
||||
|
||||
{admins.length === 0 && !loadingAdmins ? (
|
||||
<div className="text-sm text-gray-500 italic">No members found</div>
|
||||
) : (
|
||||
<>
|
||||
{/* Filtered and Paginated Member List */}
|
||||
{(() => {
|
||||
const filteredAdmins = admins.filter(admin =>
|
||||
principalLabel(admin.upn).toLowerCase().includes(adminSearchQuery.toLowerCase())
|
||||
);
|
||||
|
||||
if (filteredAdmins.length === 0) {
|
||||
return (
|
||||
<div className="text-sm text-gray-500 italic p-4 text-center bg-gray-50 rounded-lg">
|
||||
No members match your search
|
||||
</div>
|
||||
);
|
||||
}
|
||||
|
||||
const adminsPerPage = 3;
|
||||
const totalAdminPages = Math.ceil(filteredAdmins.length / adminsPerPage);
|
||||
const startAdminIndex = currentAdminPage * adminsPerPage;
|
||||
const endAdminIndex = startAdminIndex + adminsPerPage;
|
||||
const paginatedAdmins = filteredAdmins.slice(startAdminIndex, endAdminIndex);
|
||||
|
||||
return (
|
||||
<>
|
||||
<div className="space-y-2">
|
||||
{paginatedAdmins.map((admin) => {
|
||||
const isApplication = isApplicationKey(admin.upn);
|
||||
const effectiveRole = isApplication ? "Viewer" : (admin.role ?? "Admin");
|
||||
const isCurrentUser = admin.upn.toLowerCase() === user?.upn?.toLowerCase();
|
||||
|
||||
return (
|
||||
<div
|
||||
key={admin.upn}
|
||||
className={`p-3 border rounded-lg ${
|
||||
admin.isEnabled
|
||||
? "bg-gray-50 border-gray-200"
|
||||
: "bg-gray-100 border-gray-300"
|
||||
}`}
|
||||
>
|
||||
<div className="flex flex-col sm:flex-row sm:items-center sm:justify-between gap-2">
|
||||
<div className="flex-1 min-w-0">
|
||||
<div className="flex flex-wrap items-center gap-1.5">
|
||||
<div className="font-medium text-gray-900 truncate">{principalLabel(admin.upn)}</div>
|
||||
{isApplication && (
|
||||
<span className="inline-flex items-center px-2 py-0.5 rounded text-xs font-medium bg-gray-100 text-gray-700" title="Service principal — automation with its own token, or an app whose users connect through it; read-only">
|
||||
App
|
||||
</span>
|
||||
)}
|
||||
{getRoleBadge(effectiveRole)}
|
||||
{!admin.isEnabled && (
|
||||
<span className="inline-flex items-center px-2 py-0.5 rounded text-xs font-medium bg-gray-200 text-gray-700">
|
||||
Disabled
|
||||
</span>
|
||||
)}
|
||||
</div>
|
||||
<div className="text-xs text-gray-500 mt-1">
|
||||
Added {new Date(admin.addedDate).toLocaleDateString()} by {admin.addedBy}
|
||||
</div>
|
||||
</div>
|
||||
<div className="flex flex-wrap items-center gap-2">
|
||||
{isCurrentUser ? (
|
||||
<span className="text-sm text-blue-600 font-medium">(You)</span>
|
||||
) : (
|
||||
<>
|
||||
{/* Role change dropdown */}
|
||||
<select
|
||||
value={effectiveRole}
|
||||
onChange={(e) => onUpdatePermissions(admin.upn, e.target.value, admin.canManageBootstrapTokens)}
|
||||
disabled={isApplication || togglingAdmin === admin.upn}
|
||||
title={isApplication ? "A service principal is always read-only (Viewer)" : undefined}
|
||||
className="px-2 py-1 text-sm border border-gray-300 rounded bg-white text-gray-700 focus:outline-none focus:ring-1 focus:ring-purple-500 disabled:opacity-50"
|
||||
>
|
||||
<option value="Admin">Admin</option>
|
||||
<option value="Operator">Operator</option>
|
||||
<option value="Viewer">Viewer</option>
|
||||
</select>
|
||||
<button
|
||||
onClick={() => onToggleAdmin(admin.upn, admin.isEnabled)}
|
||||
disabled={togglingAdmin === admin.upn}
|
||||
className={`px-3 py-1 text-sm text-white rounded transition-colors disabled:opacity-50 disabled:cursor-not-allowed ${
|
||||
admin.isEnabled
|
||||
? "bg-yellow-600 hover:bg-yellow-700"
|
||||
: "bg-green-600 hover:bg-green-700"
|
||||
}`}
|
||||
>
|
||||
{togglingAdmin === admin.upn
|
||||
? "..."
|
||||
: admin.isEnabled
|
||||
? "Disable"
|
||||
: "Enable"}
|
||||
</button>
|
||||
<button
|
||||
onClick={() => onRemoveAdmin(admin.upn)}
|
||||
disabled={removingAdmin === admin.upn}
|
||||
className="px-3 py-1 text-sm bg-red-600 text-white rounded hover:bg-red-700 disabled:opacity-50 disabled:cursor-not-allowed transition-colors"
|
||||
>
|
||||
{removingAdmin === admin.upn ? "Removing..." : "Remove"}
|
||||
</button>
|
||||
</>
|
||||
)}
|
||||
</div>
|
||||
</div>
|
||||
|
||||
{/* Bootstrap token permission toggle for Operators */}
|
||||
{effectiveRole === "Operator" && !isCurrentUser && (
|
||||
<div className="mt-2 pt-2 border-t border-gray-200">
|
||||
<label className="flex items-center space-x-2 cursor-pointer">
|
||||
<input
|
||||
type="checkbox"
|
||||
checked={admin.canManageBootstrapTokens}
|
||||
onChange={(e) => onUpdatePermissions(admin.upn, "Operator", e.target.checked)}
|
||||
disabled={togglingAdmin === admin.upn}
|
||||
className="h-4 w-4 text-purple-600 rounded border-gray-300 focus:ring-purple-500 disabled:opacity-50"
|
||||
/>
|
||||
<span className="text-sm text-gray-700">Can manage bootstrap tokens</span>
|
||||
</label>
|
||||
</div>
|
||||
)}
|
||||
</div>
|
||||
);
|
||||
})}
|
||||
</div>
|
||||
|
||||
{/* Pagination Controls */}
|
||||
{totalAdminPages > 1 && (
|
||||
<div className="flex items-center justify-between mt-4 pt-4 border-t border-gray-200">
|
||||
<button
|
||||
onClick={() => setCurrentAdminPage(prev => Math.max(0, prev - 1))}
|
||||
disabled={currentAdminPage === 0}
|
||||
className="px-4 py-2 text-sm font-medium text-gray-700 bg-white border border-gray-300 rounded-lg hover:bg-gray-50 disabled:opacity-50 disabled:cursor-not-allowed transition-colors"
|
||||
>
|
||||
Previous
|
||||
</button>
|
||||
<span className="text-sm text-gray-600">
|
||||
Page {currentAdminPage + 1} of {totalAdminPages} ({filteredAdmins.length} member{filteredAdmins.length !== 1 ? 's' : ''})
|
||||
</span>
|
||||
<button
|
||||
onClick={() => setCurrentAdminPage(prev => Math.min(totalAdminPages - 1, prev + 1))}
|
||||
disabled={currentAdminPage >= totalAdminPages - 1}
|
||||
className="px-4 py-2 text-sm font-medium text-gray-700 bg-white border border-gray-300 rounded-lg hover:bg-gray-50 disabled:opacity-50 disabled:cursor-not-allowed transition-colors"
|
||||
>
|
||||
Next
|
||||
</button>
|
||||
</div>
|
||||
)}
|
||||
</>
|
||||
);
|
||||
})()}
|
||||
</>
|
||||
)}
|
||||
</div>
|
||||
|
||||
{/* Add New Member */}
|
||||
<AddMemberForm
|
||||
value={newAdminEmail}
|
||||
onValueChange={setNewAdminEmail}
|
||||
role={newMemberRole}
|
||||
onRoleChange={setNewMemberRole}
|
||||
kind={newMemberKind}
|
||||
onKindChange={setNewMemberKind}
|
||||
adding={addingAdmin}
|
||||
onAdd={onAddAdmin}
|
||||
/>
|
||||
|
||||
<div>
|
||||
<label className="block mb-2">
|
||||
<span className="text-gray-700 font-medium">Add New Team Member</span>
|
||||
<div className="flex flex-wrap items-center gap-2 mb-2">
|
||||
<p className="text-sm text-gray-500">
|
||||
{addingApplication
|
||||
? "Enter the application (client) ID of an app in your Entra tenant; it is always read-only (Viewer). Automation calling with its own token needs the access_as_application permission. An app that signs users in and sends their tokens needs the delegated access_as_user permission, and its users can only read. Grant either by admin consent in your Entra tenant."
|
||||
: "Enter the user email (UPN) and select a role to grant access."}
|
||||
</p>
|
||||
</div>
|
||||
<div className="flex flex-wrap gap-2">
|
||||
<div className="inline-flex rounded-lg border border-gray-300 overflow-hidden text-sm" role="group" aria-label="Member type">
|
||||
{([["user", "User"], ["application", "Service principal"]] as const).map(([kind, label]) => (
|
||||
<button
|
||||
key={kind}
|
||||
type="button"
|
||||
onClick={() => { setNewMemberKind(kind); setNewAdminEmail(""); }}
|
||||
className={`px-3 py-2 ${newMemberKind === kind ? "bg-purple-600 text-white" : "bg-white text-gray-700 hover:bg-gray-50"}`}
|
||||
>
|
||||
{label}
|
||||
</button>
|
||||
))}
|
||||
</div>
|
||||
<input
|
||||
type={addingApplication ? "text" : "email"}
|
||||
name="new-admin-email"
|
||||
id="add-new-admin-email-input"
|
||||
value={newAdminEmail}
|
||||
onChange={(e) => setNewAdminEmail(e.target.value)}
|
||||
placeholder={addingApplication ? "Application (client) ID, e.g. 00000000-0000-0000-0000-000000000000" : "user@tenant.com"}
|
||||
autoComplete="off"
|
||||
className="flex-1 min-w-0 px-4 py-2 border border-gray-300 rounded-lg text-gray-900 placeholder-gray-500 focus:outline-none focus:ring-2 focus:ring-purple-500 focus:border-purple-500 transition-colors"
|
||||
onKeyDown={(e) => {
|
||||
if (e.key === 'Enter') {
|
||||
e.preventDefault();
|
||||
onAddAdmin();
|
||||
}
|
||||
}}
|
||||
/>
|
||||
<select
|
||||
value={addingApplication ? "Viewer" : newMemberRole}
|
||||
onChange={(e) => setNewMemberRole(e.target.value)}
|
||||
disabled={addingApplication}
|
||||
title={addingApplication ? "A service principal is always read-only (Viewer)" : undefined}
|
||||
className="px-3 py-2 border border-gray-300 rounded-lg text-gray-700 bg-white focus:outline-none focus:ring-2 focus:ring-purple-500 focus:border-purple-500 transition-colors disabled:opacity-50"
|
||||
>
|
||||
<option value="Admin">Admin</option>
|
||||
<option value="Operator">Operator</option>
|
||||
<option value="Viewer">Viewer</option>
|
||||
</select>
|
||||
<button
|
||||
onClick={onAddAdmin}
|
||||
disabled={addingAdmin || !(addingApplication ? looksLikeGuid(newAdminEmail) : newAdminEmail.trim())}
|
||||
className="px-6 py-2 bg-purple-600 text-white rounded-lg hover:bg-purple-700 disabled:opacity-50 disabled:cursor-not-allowed transition-colors flex items-center space-x-2"
|
||||
>
|
||||
{addingAdmin ? (
|
||||
<>
|
||||
<div className="animate-spin rounded-full h-4 w-4 border-b-2 border-white"></div>
|
||||
<span>Adding...</span>
|
||||
</>
|
||||
) : (
|
||||
<>
|
||||
<svg className="w-5 h-5" fill="none" stroke="currentColor" viewBox="0 0 24 24">
|
||||
<path strokeLinecap="round" strokeLinejoin="round" strokeWidth={2} d="M12 4v16m8-8H4" />
|
||||
</svg>
|
||||
<span>Add</span>
|
||||
</>
|
||||
)}
|
||||
</button>
|
||||
</div>
|
||||
</label>
|
||||
<h3 className="mb-2 text-gray-700 font-medium">
|
||||
Team members
|
||||
{loadingAdmins && <span className="ml-2 text-sm font-normal text-gray-500">(Loading...)</span>}
|
||||
</h3>
|
||||
{entraAppRolesEnabled && (
|
||||
<p className="mb-2 text-xs text-gray-500">
|
||||
Entra app roles are enabled for this tenant. Users with the Admin, Operator or Viewer app role on the enterprise application get that role when they sign in, without an entry here. An entry here always takes precedence, and a disabled entry blocks access.
|
||||
</p>
|
||||
)}
|
||||
<MemberList
|
||||
members={admins}
|
||||
loading={loadingAdmins}
|
||||
currentUserUpn={user?.upn}
|
||||
removingUpn={removingAdmin}
|
||||
updatingUpn={togglingAdmin}
|
||||
onRemove={onRemoveAdmin}
|
||||
onToggleEnabled={onToggleAdmin}
|
||||
onUpdatePermissions={onUpdatePermissions}
|
||||
/>
|
||||
</div>
|
||||
|
||||
<div className="bg-yellow-50 border border-yellow-200 rounded-lg p-3">
|
||||
|
||||
+2
-6
@@ -7,13 +7,12 @@ import AdminManagementSection from "../../components/AdminManagementSection";
|
||||
export function SectionAccessManagement() {
|
||||
const {
|
||||
canEditConfig,
|
||||
config,
|
||||
admins, loadingAdmins,
|
||||
newAdminEmail, setNewAdminEmail,
|
||||
newMemberRole, setNewMemberRole,
|
||||
newMemberKind, setNewMemberKind,
|
||||
addingAdmin, removingAdmin, togglingAdmin,
|
||||
adminSearchQuery, setAdminSearchQuery,
|
||||
currentAdminPage, setCurrentAdminPage,
|
||||
user,
|
||||
handleAddAdmin, handleRemoveAdmin,
|
||||
handleToggleTenantAdmin, handleUpdatePermissions,
|
||||
@@ -45,11 +44,8 @@ export function SectionAccessManagement() {
|
||||
addingAdmin={addingAdmin}
|
||||
removingAdmin={removingAdmin}
|
||||
togglingAdmin={togglingAdmin}
|
||||
adminSearchQuery={adminSearchQuery}
|
||||
setAdminSearchQuery={setAdminSearchQuery}
|
||||
currentAdminPage={currentAdminPage}
|
||||
setCurrentAdminPage={setCurrentAdminPage}
|
||||
user={user}
|
||||
entraAppRolesEnabled={config?.entraAppRolesEnabled === true}
|
||||
onAddAdmin={handleAddAdmin}
|
||||
onRemoveAdmin={handleRemoveAdmin}
|
||||
onToggleAdmin={handleToggleTenantAdmin}
|
||||
|
||||
@@ -141,6 +141,8 @@ export interface TenantConfiguration {
|
||||
// Unrestricted mode
|
||||
unrestrictedModeEnabled?: boolean;
|
||||
unrestrictedMode?: boolean;
|
||||
/** Roles may also come from Entra app-role assignments. GA-only, read-only here (Access Management hint). */
|
||||
entraAppRolesEnabled?: boolean;
|
||||
// Plan / edition (read-only here — mutated only via the dedicated plan/trial endpoints)
|
||||
planTier?: string;
|
||||
trialExpiresUtc?: string | null;
|
||||
|
||||
@@ -30,6 +30,14 @@ import PhaseDivider from "@/components/PhaseDivider";
|
||||
// span is hours of offset error rather than run time (a 10 s script once read "1h 00m").
|
||||
const DURATION_SUPPRESSED_TITLE = "Run time not measurable: the start and end log lines were resolved on different timezone assumptions, so their span would be offset error, not run time";
|
||||
|
||||
// IME's saved result corrected the run (script_output_reconciliation): the log had attributed
|
||||
// another script's end block to it, so its exit code is unknown and the output shown is IME's.
|
||||
const EXIT_UNVERIFIED_TITLE = "Exit code unknown: the IME log had attributed another script's output and exit code to this run. The output shown is this script's own, as IME saved it.";
|
||||
const OUTPUT_CORRECTED_TITLE: Record<"foreign" | "repaired", string> = {
|
||||
foreign: "The IME log had attributed another script's output to this run. This is the script's own output, as IME saved it after reporting the result.",
|
||||
repaired: "The IME log delivered this output incomplete. This is the full output, as IME saved it after reporting the result.",
|
||||
};
|
||||
|
||||
interface ScriptExecutionsProps {
|
||||
events: ScriptInputEvent[];
|
||||
showScriptOutput?: boolean;
|
||||
@@ -528,6 +536,9 @@ function ScriptItemRow({ item, showScriptOutput, latestBootstrapVersion, nested,
|
||||
exit {item.exitCode}
|
||||
</span>
|
||||
)}
|
||||
{item.exitCode == null && item.outputCorrection === "foreign" && (
|
||||
<span className="font-mono text-gray-400" title={EXIT_UNVERIFIED_TITLE}>exit n/a</span>
|
||||
)}
|
||||
{durationLabel && (
|
||||
<span
|
||||
className={`font-mono ${isSlowDuration ? "text-amber-600 font-medium" : "text-gray-500"}`}
|
||||
@@ -564,6 +575,9 @@ function ScriptItemRow({ item, showScriptOutput, latestBootstrapVersion, nested,
|
||||
{!nested && item.runContext && <span><span className="font-medium text-gray-700">Context:</span> {item.runContext}</span>}
|
||||
{!nested && item.targetType != null && <span><span className="font-medium text-gray-700">Target:</span> {item.targetType === 2 ? "Device" : "User"}</span>}
|
||||
{item.exitCode != null && <span><span className="font-medium text-gray-700">Exit Code:</span> <span className="font-mono">{item.exitCode}</span></span>}
|
||||
{item.exitCode == null && item.outputCorrection === "foreign" && (
|
||||
<span title={EXIT_UNVERIFIED_TITLE}><span className="font-medium text-gray-700">Exit Code:</span> <span className="font-mono text-gray-400">n/a</span></span>
|
||||
)}
|
||||
{detailDurationLabel && <span><span className="font-medium text-gray-700">Duration:</span> <span className={`font-mono ${isSlowDuration ? "text-amber-600" : ""}`}>{detailDurationLabel}</span></span>}
|
||||
{!detailDurationLabel && item.durationSuppressedReason && (
|
||||
<span title={DURATION_SUPPRESSED_TITLE}><span className="font-medium text-gray-700">Duration:</span> <span className="font-mono text-gray-400">n/a</span></span>
|
||||
@@ -601,7 +615,12 @@ function ScriptItemRow({ item, showScriptOutput, latestBootstrapVersion, nested,
|
||||
|
||||
{hasStdout && (
|
||||
<div>
|
||||
<div className="text-xs font-medium text-gray-500 mb-1">stdout</div>
|
||||
<div className="text-xs font-medium text-gray-500 mb-1">
|
||||
stdout
|
||||
{item.outputCorrection && (
|
||||
<span className="font-normal text-gray-400" title={OUTPUT_CORRECTED_TITLE[item.outputCorrection]}>{" · from IME's saved result"}</span>
|
||||
)}
|
||||
</div>
|
||||
<div className="p-2 bg-gray-900 rounded text-xs text-gray-100 font-mono overflow-x-auto max-h-48 overflow-y-auto">
|
||||
<pre className="whitespace-pre-wrap break-words">{item.stdout}</pre>
|
||||
</div>
|
||||
@@ -614,7 +633,12 @@ function ScriptItemRow({ item, showScriptOutput, latestBootstrapVersion, nested,
|
||||
|
||||
{hasStderr && (
|
||||
<div>
|
||||
<div className="text-xs font-medium text-red-500 mb-1">stderr</div>
|
||||
<div className="text-xs font-medium text-red-500 mb-1">
|
||||
stderr
|
||||
{item.outputCorrection && (
|
||||
<span className="font-normal text-gray-400" title={OUTPUT_CORRECTED_TITLE[item.outputCorrection]}>{" · from IME's saved result"}</span>
|
||||
)}
|
||||
</div>
|
||||
<div className="p-2 bg-gray-900 rounded text-xs text-red-300 font-mono overflow-x-auto max-h-48 overflow-y-auto">
|
||||
<pre className="whitespace-pre-wrap break-words">{item.stderr}</pre>
|
||||
</div>
|
||||
|
||||
@@ -0,0 +1,67 @@
|
||||
import { describe, it, expect, vi } from "vitest";
|
||||
import { createElement } from "react";
|
||||
import { renderToStaticMarkup } from "react-dom/server";
|
||||
import { prerender } from "react-dom/static";
|
||||
|
||||
// LandingNavbar and LoginButton read the auth context; the public pages render signed out.
|
||||
vi.mock("@/contexts/AuthContext", () => ({
|
||||
useAuth: () => ({ login: async () => undefined, isAuthenticated: false, user: null, getAccessToken: async () => null }),
|
||||
}));
|
||||
// AuthGate only redirects signed-in visitors (it needs the app router) and renders no links.
|
||||
vi.mock("@/components/landing/AuthGate", () => ({ AuthGate: () => null }));
|
||||
|
||||
const { SNAPSHOT } = vi.hoisted(() => ({
|
||||
SNAPSHOT: {
|
||||
items: [
|
||||
{ label: "enrollments monitored", value: "12,481" },
|
||||
{ label: "events processed", value: "8.3M" },
|
||||
],
|
||||
asOf: "2026-10-02T14:00:03.1234567Z",
|
||||
},
|
||||
}));
|
||||
// The blob read itself is covered in lib/__tests__/platformStats.test.ts.
|
||||
vi.mock("@/lib/platformStats", async importOriginal => ({
|
||||
...(await importOriginal<typeof import("@/lib/platformStats")>()),
|
||||
loadPlatformStatsSnapshot: async () => SNAPSHOT,
|
||||
}));
|
||||
|
||||
import LandingRoute from "@/app/page";
|
||||
import { StatsBand } from "@/components/landing/StatsBand";
|
||||
|
||||
/**
|
||||
* Crawlers and LLM fetchers run no JS: the platform stats only reach them when the build renders
|
||||
* the numbers into the landing page's HTML (lib/platformStats.ts, app/page.tsx).
|
||||
*/
|
||||
describe("platform stats in the landing page's static HTML", () => {
|
||||
it("the band renders the baked numbers and marks the snapshot", () => {
|
||||
const html = renderToStaticMarkup(createElement(StatsBand, { snapshot: SNAPSHOT }));
|
||||
expect(html).toContain(">12,481<");
|
||||
expect(html).toContain(">enrollments monitored<");
|
||||
expect(html).toContain(">8.3M<");
|
||||
expect(html).toContain(`data-stats-snapshot="${SNAPSHOT.asOf}"`);
|
||||
expect(html).not.toContain("animate-pulse");
|
||||
});
|
||||
|
||||
it("without a snapshot the band shows the loading skeleton and no marker", () => {
|
||||
const html = renderToStaticMarkup(createElement(StatsBand, { snapshot: null }));
|
||||
expect(html).toContain('data-track-section="stats"');
|
||||
expect(html).toContain("animate-pulse");
|
||||
expect(html).not.toContain("data-stats-snapshot");
|
||||
});
|
||||
|
||||
// A Suspense boundary around the read would still resolve at build time, but React moves a
|
||||
// resolved boundary of a page this size into a hidden div at the end of the body.
|
||||
it("the page renders the numbers in place, not in a hidden streaming segment", async () => {
|
||||
const { prelude } = await prerender(createElement(LandingRoute));
|
||||
const html = await new Response(prelude).text();
|
||||
|
||||
const bandStart = html.indexOf('data-track-section="stats"');
|
||||
const nextSection = html.indexOf('data-track-section="just_ask"');
|
||||
const figure = html.indexOf(">12,481<");
|
||||
expect(bandStart).toBeGreaterThan(-1);
|
||||
expect(figure).toBeGreaterThan(bandStart);
|
||||
expect(figure).toBeLessThan(nextSection);
|
||||
expect(html).toContain(`data-stats-snapshot="${SNAPSHOT.asOf}"`);
|
||||
expect(html).not.toMatch(/<div hidden id="S:/);
|
||||
});
|
||||
});
|
||||
@@ -9,7 +9,7 @@ vi.mock("@/contexts/AuthContext", () => ({
|
||||
// AuthGate only redirects signed-in visitors (it needs the app router) and renders no links.
|
||||
vi.mock("@/components/landing/AuthGate", () => ({ AuthGate: () => null }));
|
||||
|
||||
import LandingPage from "@/app/page";
|
||||
import { LandingPage } from "@/components/landing/LandingPage";
|
||||
import GetStartedPage from "@/app/get-started/page";
|
||||
import AiPage from "@/app/ai/page";
|
||||
import AboutPage from "@/app/about/page";
|
||||
@@ -25,7 +25,8 @@ import TermsPage from "@/app/terms/page";
|
||||
*/
|
||||
|
||||
const PAGES: Record<string, ComponentType> = {
|
||||
landing: LandingPage,
|
||||
// app/page.tsx only awaits the build-time stats and renders this body; the sync renderer cannot await.
|
||||
landing: () => createElement(LandingPage, { statsSnapshot: null }),
|
||||
"get-started": GetStartedPage,
|
||||
ai: AiPage,
|
||||
about: AboutPage,
|
||||
|
||||
@@ -11,7 +11,7 @@ vi.mock("@/contexts/AuthContext", () => ({
|
||||
// AuthGate only redirects signed-in visitors (it needs the app router) and renders no links.
|
||||
vi.mock("@/components/landing/AuthGate", () => ({ AuthGate: () => null }));
|
||||
|
||||
import LandingPage from "@/app/page";
|
||||
import { LandingPage } from "@/components/landing/LandingPage";
|
||||
import GetStartedPage from "@/app/get-started/page";
|
||||
import AiPage from "@/app/ai/page";
|
||||
import robots from "@/app/robots";
|
||||
@@ -27,6 +27,8 @@ import { sitePageUrl } from "@/utils/config";
|
||||
*/
|
||||
|
||||
const render = (Page: ComponentType) => renderToStaticMarkup(createElement(Page));
|
||||
// app/page.tsx only awaits the build-time stats and renders this body; the sync renderer cannot await.
|
||||
const Landing = () => createElement(LandingPage, { statsSnapshot: null });
|
||||
const trackIds = (html: string) => [...html.matchAll(/data-track="([^"]+)"/g)].map(m => m[1]);
|
||||
const sectionIds = (html: string) => [...html.matchAll(/data-track-section="([^"]+)"/g)].map(m => m[1]);
|
||||
const untracked = (html: string) =>
|
||||
@@ -37,7 +39,7 @@ const untracked = (html: string) =>
|
||||
const PAGES: { name: string; Page: ComponentType; sections: string[] }[] = [
|
||||
{
|
||||
name: "landing",
|
||||
Page: LandingPage,
|
||||
Page: Landing,
|
||||
sections: ["hero", "stats", "just_ask", "story", "capabilities", "comparison", "how_it_works", "testimonials", "final_cta"],
|
||||
},
|
||||
{ name: "get-started", Page: GetStartedPage, sections: ["steps", "signup"] },
|
||||
@@ -60,7 +62,7 @@ describe("marketing page tracking", () => {
|
||||
}
|
||||
|
||||
it("the landing links to the AI page from the navbar, Then just ask and the footer", () => {
|
||||
const ids = trackIds(render(LandingPage));
|
||||
const ids = trackIds(render(Landing));
|
||||
expect(ids).toEqual(expect.arrayContaining(["nav_ai", "just_ask_ai", "footer_ai"]));
|
||||
});
|
||||
|
||||
|
||||
@@ -4,9 +4,8 @@ import { useAuth } from "../../contexts/AuthContext";
|
||||
import { useRouter } from "next/navigation";
|
||||
import { useEffect } from "react";
|
||||
import type { Route } from "next";
|
||||
import { trustedRoute } from "../../lib/routes";
|
||||
import { landingTarget } from "../../lib/landingTarget";
|
||||
import { consumePostLoginReturnUrl, peekPostLoginReturnUrl } from "../../lib/postLoginReturn";
|
||||
import { hasOwnTenantOrPlatformRole, hasTenantReadScope } from "../../lib/tenantScope";
|
||||
import { portalHandoverUrl, shouldCrossOriginToPortal } from "../../lib/hostRouting";
|
||||
import { consumePendingRehome, getSelectedAuthApp, legacyConfigured, switchAuthApp, tryBeginRehome } from "../../lib/authApp";
|
||||
import { activeAuthApp } from "../../lib/msalConfig";
|
||||
@@ -39,22 +38,9 @@ export function AuthGate() {
|
||||
// follows, and leaving it in place beats re-saving it.
|
||||
// While activation is pending the link is only PEEKED as well: an invited customer admin whose
|
||||
// tenant is still being activated must land on the invitation once activation completes, not on
|
||||
// /dashboard — the link survives the /activation detour for the AuthGate pass that follows.
|
||||
// /dashboard — the link survives the /activation detour, and the activation page consumes it.
|
||||
const returnUrl = rehomeNow || isActivationPending ? peekPostLoginReturnUrl() : consumePostLoginReturnUrl();
|
||||
let target: Route;
|
||||
if (isActivationPending) {
|
||||
target = "/activation";
|
||||
} else if (returnUrl) {
|
||||
// Restore the deep link the user originally opened before re-auth.
|
||||
target = trustedRoute(returnUrl);
|
||||
} else if (user.isDelegated && !hasOwnTenantOrPlatformRole(user)) {
|
||||
// A delegated ("MSP") admin with no own-tenant/platform role manages a fleet → land on /fleet.
|
||||
target = "/fleet";
|
||||
} else if (hasTenantReadScope(user)) {
|
||||
target = "/dashboard";
|
||||
} else {
|
||||
target = "/progress";
|
||||
}
|
||||
const target: Route = isActivationPending ? "/activation" : landingTarget(user, returnUrl);
|
||||
// On the public host, hand over to the portal origin in ONE full-page
|
||||
// navigation instead of router.push + HostRoutingGuard bounce. Auth state
|
||||
// is per-origin — the portal side runs its own (silent) MSAL sign-in, on
|
||||
|
||||
@@ -0,0 +1,46 @@
|
||||
import { AuthGate } from "./AuthGate";
|
||||
import { LandingNavbar } from "./LandingNavbar";
|
||||
import { Hero } from "./Hero";
|
||||
import { StatsBand } from "./StatsBand";
|
||||
import { JustAsk } from "./JustAsk";
|
||||
import { Story } from "./Story";
|
||||
import { CapabilitiesStrip } from "./CapabilitiesStrip";
|
||||
import { Comparison } from "./Comparison";
|
||||
import { HowItWorks } from "./HowItWorks";
|
||||
import { Testimonials } from "./Testimonials";
|
||||
import { FinalCta } from "./FinalCta";
|
||||
import { SiteFooter } from "../SiteFooter";
|
||||
import { MarketingTracker } from "../MarketingTracker";
|
||||
import type { PlatformStatsSnapshot } from "@/lib/platformStats";
|
||||
|
||||
/**
|
||||
* Landing page v2 — a scroll story of one enrollment.
|
||||
* All theming goes through the lp-* tokens (globals.css); sections live
|
||||
* in components/landing/. Auth behavior (AuthGate redirect, LoginButton
|
||||
* portal handoff) is unchanged from v1.
|
||||
*
|
||||
* Synchronous on purpose: app/page.tsx awaits the build-time stats and hands
|
||||
* them in, and the marketing guard tests render this body with the sync
|
||||
* renderToStaticMarkup.
|
||||
*/
|
||||
export function LandingPage({ statsSnapshot }: { statsSnapshot: PlatformStatsSnapshot | null }) {
|
||||
return (
|
||||
<div className="landing-v2 min-h-screen bg-[var(--lp-bg)]">
|
||||
{/* Client component: handles auth redirect + loading overlay */}
|
||||
<AuthGate />
|
||||
<MarketingTracker page="landing">
|
||||
<LandingNavbar />
|
||||
<Hero />
|
||||
<StatsBand snapshot={statsSnapshot} />
|
||||
<JustAsk />
|
||||
<Story />
|
||||
<CapabilitiesStrip />
|
||||
<Comparison />
|
||||
<HowItWorks />
|
||||
<Testimonials />
|
||||
<FinalCta />
|
||||
<SiteFooter />
|
||||
</MarketingTracker>
|
||||
</div>
|
||||
);
|
||||
}
|
||||
@@ -1,61 +1,12 @@
|
||||
"use client";
|
||||
|
||||
import { useEffect, useState } from "react";
|
||||
|
||||
interface PlatformStatsManifest {
|
||||
latest: string;
|
||||
generatedAtUtc: string;
|
||||
}
|
||||
|
||||
interface PlatformStatsPayload {
|
||||
totalEnrollments?: number;
|
||||
totalUsers?: number;
|
||||
totalTenants?: number;
|
||||
totalSignedUpTenants?: number;
|
||||
uniqueDeviceModels?: number;
|
||||
totalEventsProcessed?: number;
|
||||
successfulEnrollments?: number;
|
||||
issuesDetected?: number;
|
||||
lastFullCompute?: string;
|
||||
lastUpdated?: string;
|
||||
}
|
||||
|
||||
function resolvePlatformStatsManifestUrl(rawUrl?: string): string {
|
||||
const trimmed = rawUrl?.trim();
|
||||
if (!trimmed) {
|
||||
return "/platform-stats.json";
|
||||
}
|
||||
|
||||
const hashIndex = trimmed.indexOf("#");
|
||||
const withoutHash = hashIndex >= 0 ? trimmed.slice(0, hashIndex) : trimmed;
|
||||
const hash = hashIndex >= 0 ? trimmed.slice(hashIndex) : "";
|
||||
|
||||
const queryIndex = withoutHash.indexOf("?");
|
||||
const basePath = queryIndex >= 0 ? withoutHash.slice(0, queryIndex) : withoutHash;
|
||||
const query = queryIndex >= 0 ? withoutHash.slice(queryIndex) : "";
|
||||
|
||||
if (/\.json$/i.test(basePath)) {
|
||||
return trimmed;
|
||||
}
|
||||
|
||||
const normalizedBasePath = basePath.endsWith("/") ? basePath.slice(0, -1) : basePath;
|
||||
const manifestPath = `${normalizedBasePath}/platform-stats.json`;
|
||||
return `${manifestPath}${query}${hash}`;
|
||||
}
|
||||
|
||||
const PLATFORM_STATS_MANIFEST_URL =
|
||||
resolvePlatformStatsManifestUrl(process.env.NEXT_PUBLIC_PLATFORM_STATS_MANIFEST_URL);
|
||||
|
||||
interface StatItem {
|
||||
label: string;
|
||||
value: string;
|
||||
}
|
||||
|
||||
/** 8,341,206 → "8.3M"; smaller values keep their grouped form. */
|
||||
function compact(n: number): string {
|
||||
if (n >= 1_000_000) return `${(n / 1_000_000).toFixed(1)}M`;
|
||||
return n.toLocaleString("en-US");
|
||||
}
|
||||
import {
|
||||
fetchLivePlatformStats,
|
||||
toStatItems,
|
||||
type PlatformStatsSnapshot,
|
||||
type StatItem,
|
||||
} from "@/lib/platformStats";
|
||||
|
||||
/**
|
||||
* Sample values for local development only, where no stats blob is
|
||||
@@ -71,81 +22,51 @@ const DEV_SAMPLE_STATS: StatItem[] = [
|
||||
];
|
||||
|
||||
/**
|
||||
* Full-bleed platform stats band under the hero shot. Skeleton while
|
||||
* loading; on fetch failure it shows dev sample data locally and
|
||||
* disappears entirely in production (never an endless skeleton, never
|
||||
* fake numbers).
|
||||
* Full-bleed platform stats band under the hero shot. Starts with the
|
||||
* numbers the build baked in (`snapshot`, lib/platformStats.ts), so the
|
||||
* static HTML carries them for crawlers and LLM fetchers, then swaps in the
|
||||
* live numbers. A failed live read keeps the baked numbers; without either,
|
||||
* it shows dev sample data locally and disappears entirely in production
|
||||
* (never an endless skeleton, never fake numbers). The skeleton only shows
|
||||
* while a page built without a snapshot loads.
|
||||
*/
|
||||
export function StatsBand() {
|
||||
const [stats, setStats] = useState<StatItem[] | null>(null);
|
||||
export function StatsBand({ snapshot }: { snapshot: PlatformStatsSnapshot | null }) {
|
||||
const [live, setLive] = useState<StatItem[] | null>(null);
|
||||
const [failed, setFailed] = useState(false);
|
||||
|
||||
useEffect(() => {
|
||||
let cancelled = false;
|
||||
|
||||
const fail = () => {
|
||||
const loadLiveStats = async () => {
|
||||
const payload = await fetchLivePlatformStats();
|
||||
if (cancelled) return;
|
||||
if (process.env.NODE_ENV === "development") {
|
||||
setStats(DEV_SAMPLE_STATS);
|
||||
const items = payload ? toStatItems(payload) : [];
|
||||
if (items.length > 0) {
|
||||
setLive(items);
|
||||
} else {
|
||||
setFailed(true);
|
||||
}
|
||||
};
|
||||
|
||||
const loadPlatformStats = async () => {
|
||||
try {
|
||||
const manifestResponse = await fetch(PLATFORM_STATS_MANIFEST_URL, { cache: "no-store" });
|
||||
if (!manifestResponse.ok) return fail();
|
||||
|
||||
const manifest = (await manifestResponse.json()) as PlatformStatsManifest;
|
||||
if (!manifest?.latest) return fail();
|
||||
|
||||
const versionedUrl = new URL(manifest.latest, manifestResponse.url).toString();
|
||||
const statsResponse = await fetch(versionedUrl, { cache: "force-cache" });
|
||||
if (!statsResponse.ok) return fail();
|
||||
|
||||
const payload = (await statsResponse.json()) as PlatformStatsPayload;
|
||||
if (cancelled) return;
|
||||
|
||||
const items: StatItem[] = [];
|
||||
if (payload.totalEnrollments) {
|
||||
items.push({ label: "enrollments monitored", value: payload.totalEnrollments.toLocaleString("en-US") });
|
||||
}
|
||||
if (payload.issuesDetected) {
|
||||
items.push({ label: "issues detected", value: payload.issuesDetected.toLocaleString("en-US") });
|
||||
}
|
||||
if (payload.totalSignedUpTenants) {
|
||||
items.push({ label: "organisations", value: payload.totalSignedUpTenants.toLocaleString("en-US") });
|
||||
}
|
||||
if (payload.uniqueDeviceModels) {
|
||||
items.push({ label: "device models", value: payload.uniqueDeviceModels.toLocaleString("en-US") });
|
||||
}
|
||||
if (payload.totalEventsProcessed) {
|
||||
items.push({ label: "events processed", value: compact(payload.totalEventsProcessed) });
|
||||
}
|
||||
if (items.length > 0) {
|
||||
setStats(items);
|
||||
} else {
|
||||
fail();
|
||||
}
|
||||
} catch {
|
||||
// The band is decorative and must never break the page.
|
||||
fail();
|
||||
}
|
||||
};
|
||||
|
||||
loadPlatformStats();
|
||||
loadLiveStats();
|
||||
return () => {
|
||||
cancelled = true;
|
||||
};
|
||||
}, []);
|
||||
|
||||
if (failed) {
|
||||
const devFallback = failed && process.env.NODE_ENV === "development" ? DEV_SAMPLE_STATS : null;
|
||||
const stats = live ?? snapshot?.items ?? devFallback;
|
||||
if (!stats && failed) {
|
||||
return null;
|
||||
}
|
||||
|
||||
return (
|
||||
<section data-track-section="stats" className="border-y border-[var(--lp-line-soft)] bg-[var(--lp-surface-2)]">
|
||||
<section
|
||||
data-track-section="stats"
|
||||
// Which build snapshot the static HTML carries; deploy-web.yml warns when it is missing.
|
||||
data-stats-snapshot={snapshot ? (snapshot.asOf ?? "") : undefined}
|
||||
className="border-y border-[var(--lp-line-soft)] bg-[var(--lp-surface-2)]"
|
||||
>
|
||||
<div className="max-w-7xl mx-auto px-6 grid grid-cols-2 sm:grid-cols-3 lg:grid-cols-5 gap-y-6 py-8 lg:divide-x lg:divide-[var(--lp-line)]">
|
||||
{(stats ?? Array.from({ length: 5 }, () => null)).map((item, i) =>
|
||||
item ? (
|
||||
|
||||
@@ -0,0 +1,125 @@
|
||||
"use client";
|
||||
|
||||
import { looksLikeGuid, type MemberKind } from "@/utils/principalKeys";
|
||||
import { MEMBER_ROLES } from "./memberListModel";
|
||||
|
||||
interface AddMemberFormProps {
|
||||
value: string;
|
||||
onValueChange: (value: string) => void;
|
||||
role: string;
|
||||
onRoleChange: (role: string) => void;
|
||||
kind: MemberKind;
|
||||
onKindChange: (kind: MemberKind) => void;
|
||||
adding: boolean;
|
||||
onAdd: () => void;
|
||||
/** Read-only caller: the form stays visible but cannot submit. */
|
||||
disabled?: boolean;
|
||||
/**
|
||||
* The input always takes a line of its own (the GA tenant editor modal). Without it the input keeps a
|
||||
* minimum width and wraps to the next line when the row has no room; the layout follows the space the
|
||||
* host gives it, never a viewport breakpoint, because the same viewport can mean a wide page or a narrow
|
||||
* column next to the sidebar.
|
||||
*/
|
||||
stacked?: boolean;
|
||||
}
|
||||
|
||||
const KINDS = [["user", "User"], ["application", "Service principal"]] as const;
|
||||
|
||||
const USER_HINT = "Enter the user email (UPN) and select a role to grant access.";
|
||||
const APPLICATION_HINT =
|
||||
"Enter the application (client) ID of an app in your Entra tenant; it is always read-only (Viewer). Automation calling with its own token needs the access_as_application permission. An app that signs users in and sends their tokens needs the delegated access_as_user permission, and its users can only read. Grant either by admin consent in your Entra tenant.";
|
||||
|
||||
/** Adds a person by UPN or a service principal by application ID; a service principal is always a Viewer. */
|
||||
export function AddMemberForm({
|
||||
value,
|
||||
onValueChange,
|
||||
role,
|
||||
onRoleChange,
|
||||
kind,
|
||||
onKindChange,
|
||||
adding,
|
||||
onAdd,
|
||||
disabled = false,
|
||||
stacked = false,
|
||||
}: AddMemberFormProps) {
|
||||
const addingApplication = kind === "application";
|
||||
const valid = addingApplication ? looksLikeGuid(value) : value.trim().length > 0;
|
||||
const canSubmit = !disabled && !adding && valid;
|
||||
|
||||
return (
|
||||
<div>
|
||||
<h3 className="text-gray-700 font-medium">Add member</h3>
|
||||
<p className="mt-0.5 mb-2 text-sm text-gray-500">{addingApplication ? APPLICATION_HINT : USER_HINT}</p>
|
||||
<div className="flex flex-wrap gap-2">
|
||||
<div className="inline-flex rounded-lg border border-gray-300 overflow-hidden text-sm" role="group" aria-label="Member type">
|
||||
{KINDS.map(([k, label]) => (
|
||||
<button
|
||||
key={k}
|
||||
type="button"
|
||||
aria-pressed={kind === k}
|
||||
onClick={() => {
|
||||
onKindChange(k);
|
||||
onValueChange("");
|
||||
}}
|
||||
className={`px-3 py-2 ${kind === k ? "bg-purple-600 text-white" : "bg-white text-gray-700 hover:bg-gray-50"}`}
|
||||
>
|
||||
{label}
|
||||
</button>
|
||||
))}
|
||||
</div>
|
||||
<input
|
||||
type={addingApplication ? "text" : "email"}
|
||||
name="new-member"
|
||||
value={value}
|
||||
onChange={(e) => onValueChange(e.target.value)}
|
||||
placeholder={addingApplication ? "Application (client) ID, e.g. 00000000-0000-0000-0000-000000000000" : "user@tenant.com"}
|
||||
aria-label={addingApplication ? "Application (client) ID" : "User email (UPN)"}
|
||||
autoComplete="off"
|
||||
className={`${stacked ? "basis-full" : "grow basis-72"} min-w-0 px-4 py-2 border border-gray-300 rounded-lg text-gray-900 placeholder-gray-500 focus:outline-none focus:ring-2 focus:ring-purple-500 focus:border-purple-500 transition-colors`}
|
||||
onKeyDown={(e) => {
|
||||
if (e.key === "Enter") {
|
||||
e.preventDefault();
|
||||
if (canSubmit) onAdd();
|
||||
}
|
||||
}}
|
||||
/>
|
||||
<div className="flex gap-2">
|
||||
<select
|
||||
value={addingApplication ? "Viewer" : role}
|
||||
onChange={(e) => onRoleChange(e.target.value)}
|
||||
disabled={addingApplication}
|
||||
aria-label="Role"
|
||||
title={addingApplication ? "A service principal is always read-only (Viewer)" : undefined}
|
||||
className="px-3 py-2 border border-gray-300 rounded-lg text-gray-700 bg-white focus:outline-none focus:ring-2 focus:ring-purple-500 focus:border-purple-500 transition-colors disabled:opacity-50"
|
||||
>
|
||||
{MEMBER_ROLES.map((r) => (
|
||||
<option key={r} value={r}>
|
||||
{r}
|
||||
</option>
|
||||
))}
|
||||
</select>
|
||||
<button
|
||||
type="button"
|
||||
onClick={onAdd}
|
||||
disabled={!canSubmit}
|
||||
className="px-6 py-2 bg-purple-600 text-white rounded-lg hover:bg-purple-700 disabled:opacity-50 disabled:cursor-not-allowed transition-colors flex items-center gap-2"
|
||||
>
|
||||
{adding ? (
|
||||
<>
|
||||
<span className="animate-spin rounded-full h-4 w-4 border-b-2 border-white" aria-hidden="true" />
|
||||
Adding...
|
||||
</>
|
||||
) : (
|
||||
<>
|
||||
<svg className="w-5 h-5" fill="none" stroke="currentColor" viewBox="0 0 24 24" aria-hidden="true">
|
||||
<path strokeLinecap="round" strokeLinejoin="round" strokeWidth={2} d="M12 4v16m8-8H4" />
|
||||
</svg>
|
||||
Add
|
||||
</>
|
||||
)}
|
||||
</button>
|
||||
</div>
|
||||
</div>
|
||||
</div>
|
||||
);
|
||||
}
|
||||
@@ -0,0 +1,427 @@
|
||||
"use client";
|
||||
|
||||
import { useState } from "react";
|
||||
import type { TenantAdminRow } from "@/utils/wire-types.generated";
|
||||
import { isApplicationKey, principalLabel } from "@/utils/principalKeys";
|
||||
import {
|
||||
MEMBER_ROLES,
|
||||
effectiveMemberFilter,
|
||||
effectiveMemberRole,
|
||||
matchesMemberFilter,
|
||||
matchesMemberSearch,
|
||||
memberCounts,
|
||||
memberPage,
|
||||
permissionChange,
|
||||
sortMembers,
|
||||
visibleMemberFilters,
|
||||
type MemberFilter,
|
||||
} from "./memberListModel";
|
||||
|
||||
interface MemberListProps {
|
||||
members: TenantAdminRow[];
|
||||
loading: boolean;
|
||||
/** The signed-in user's UPN: that row shows "You" and offers no actions. */
|
||||
currentUserUpn?: string | null;
|
||||
/** False for a read-only caller: rows still open, their actions stay disabled. */
|
||||
canMutate?: boolean;
|
||||
/** The member whose removal is in flight. */
|
||||
removingUpn: string | null;
|
||||
/** The member whose role, bootstrap permission or enabled state is being saved. */
|
||||
updatingUpn: string | null;
|
||||
onRemove: (upn: string) => void | Promise<void>;
|
||||
onToggleEnabled: (upn: string, isEnabled: boolean) => void;
|
||||
onUpdatePermissions: (upn: string, role: string, canManageBootstrapTokens: boolean) => void;
|
||||
}
|
||||
|
||||
const FILTER_LABEL: Record<MemberFilter, string> = {
|
||||
all: "All",
|
||||
Admin: "Admin",
|
||||
Operator: "Operator",
|
||||
Viewer: "Viewer",
|
||||
disabled: "Disabled",
|
||||
};
|
||||
|
||||
const ROLE_BADGE: Record<string, string> = {
|
||||
Admin: "bg-green-100 text-green-800",
|
||||
Operator: "bg-blue-100 text-blue-800",
|
||||
Viewer: "bg-gray-100 text-gray-800",
|
||||
};
|
||||
|
||||
const PILL = "inline-flex items-center px-2 py-0.5 rounded text-xs font-medium";
|
||||
const CONTEXT_PILL = `${PILL} bg-gray-100 border border-gray-300 text-gray-600`;
|
||||
const APPLICATION_TITLE =
|
||||
"Service principal — automation with its own token, or an app whose users connect through it; read-only";
|
||||
|
||||
/**
|
||||
* Tenant members as one line each. A click opens a row with who added it and its actions (role,
|
||||
* bootstrap permission, disable, remove with an in-row confirmation). Role chips with counts and the
|
||||
* search narrow the list; it pages at 25 rows and never shows a page past the end.
|
||||
*/
|
||||
export function MemberList({
|
||||
members,
|
||||
loading,
|
||||
currentUserUpn,
|
||||
canMutate = true,
|
||||
removingUpn,
|
||||
updatingUpn,
|
||||
onRemove,
|
||||
onToggleEnabled,
|
||||
onUpdatePermissions,
|
||||
}: MemberListProps) {
|
||||
const [query, setQuery] = useState("");
|
||||
const [filter, setFilter] = useState<MemberFilter>("all");
|
||||
const [page, setPage] = useState(0);
|
||||
const [expandedUpn, setExpandedUpn] = useState<string | null>(null);
|
||||
const [confirmRemoveUpn, setConfirmRemoveUpn] = useState<string | null>(null);
|
||||
|
||||
if (members.length === 0) {
|
||||
return <p className="text-sm text-gray-500 italic">{loading ? "Loading members…" : "No members found"}</p>;
|
||||
}
|
||||
|
||||
const counts = memberCounts(members);
|
||||
const activeFilter = effectiveMemberFilter(filter, counts);
|
||||
const matching = sortMembers(
|
||||
members.filter((m) => matchesMemberFilter(m, activeFilter) && matchesMemberSearch(m, query)),
|
||||
);
|
||||
const shown = memberPage(matching, page);
|
||||
const ownUpn = currentUserUpn?.toLowerCase();
|
||||
|
||||
// A vanished chip or a shrunken list moves the selection for good (guarded, converges after one extra
|
||||
// render), so a member disabled or added later never snaps the list back to the old chip or page.
|
||||
if (activeFilter !== filter) setFilter(activeFilter);
|
||||
if (shown.page !== page) setPage(shown.page);
|
||||
|
||||
const changeQuery = (value: string) => {
|
||||
setQuery(value);
|
||||
setPage(0);
|
||||
};
|
||||
const toggleRow = (upn: string) => {
|
||||
setExpandedUpn((open) => (open === upn ? null : upn));
|
||||
setConfirmRemoveUpn(null);
|
||||
};
|
||||
const confirmRemove = async (upn: string) => {
|
||||
await onRemove(upn);
|
||||
setConfirmRemoveUpn(null);
|
||||
};
|
||||
|
||||
return (
|
||||
<div className="space-y-2">
|
||||
<div className="flex flex-col gap-2 sm:flex-row sm:items-center">
|
||||
<div role="group" aria-label="Filter members by role" className="flex flex-wrap items-center gap-1.5">
|
||||
{visibleMemberFilters(counts).map((f) => {
|
||||
const active = f === activeFilter;
|
||||
return (
|
||||
<button
|
||||
key={f}
|
||||
type="button"
|
||||
aria-pressed={active}
|
||||
disabled={f !== "all" && counts[f] === 0}
|
||||
onClick={() => {
|
||||
setFilter(f);
|
||||
setPage(0);
|
||||
}}
|
||||
className={`inline-flex items-center gap-1.5 px-2.5 py-1 rounded-md border text-xs font-medium transition-colors disabled:opacity-50 disabled:cursor-not-allowed ${
|
||||
active
|
||||
? "bg-purple-100 border-purple-300 text-purple-900"
|
||||
: "bg-white border-gray-300 text-gray-700 hover:bg-gray-50"
|
||||
}`}
|
||||
>
|
||||
{FILTER_LABEL[f]}
|
||||
<span className={active ? "text-purple-700" : "text-gray-500"}>{counts[f]}</span>
|
||||
</button>
|
||||
);
|
||||
})}
|
||||
</div>
|
||||
<div className="relative sm:ml-auto sm:w-64">
|
||||
<input
|
||||
type="text"
|
||||
name="member-search"
|
||||
value={query}
|
||||
onChange={(e) => changeQuery(e.target.value)}
|
||||
placeholder="Search members..."
|
||||
aria-label="Search members"
|
||||
autoComplete="off"
|
||||
className="w-full pl-8 pr-8 py-1.5 border border-gray-300 rounded-lg text-sm text-gray-900 placeholder-gray-500 focus:outline-none focus:ring-2 focus:ring-purple-500 focus:border-purple-500 transition-colors"
|
||||
/>
|
||||
<svg className="absolute left-2.5 top-2 w-4 h-4 text-gray-400" fill="none" stroke="currentColor" viewBox="0 0 24 24" aria-hidden="true">
|
||||
<path strokeLinecap="round" strokeLinejoin="round" strokeWidth={2} d="M21 21l-6-6m2-5a7 7 0 11-14 0 7 7 0 0114 0z" />
|
||||
</svg>
|
||||
{query && (
|
||||
<button
|
||||
type="button"
|
||||
onClick={() => changeQuery("")}
|
||||
className="absolute right-2.5 top-2 text-gray-400 hover:text-gray-600 transition-colors"
|
||||
title="Clear search"
|
||||
>
|
||||
<svg className="w-4 h-4" fill="none" stroke="currentColor" viewBox="0 0 24 24" aria-hidden="true">
|
||||
<path strokeLinecap="round" strokeLinejoin="round" strokeWidth={2} d="M6 18L18 6M6 6l12 12" />
|
||||
</svg>
|
||||
</button>
|
||||
)}
|
||||
</div>
|
||||
</div>
|
||||
|
||||
{matching.length === 0 ? (
|
||||
<p className="text-sm text-gray-500 italic p-4 text-center bg-gray-50 rounded-lg">No members match your search</p>
|
||||
) : (
|
||||
<ul className="border border-gray-200 rounded-lg divide-y divide-gray-100 bg-white">
|
||||
{shown.rows.map((m) => (
|
||||
<MemberRow
|
||||
key={m.upn}
|
||||
member={m}
|
||||
open={expandedUpn === m.upn}
|
||||
confirmingRemove={confirmRemoveUpn === m.upn}
|
||||
isCurrentUser={ownUpn !== undefined && m.upn.toLowerCase() === ownUpn}
|
||||
canMutate={canMutate}
|
||||
removing={removingUpn === m.upn}
|
||||
updating={updatingUpn === m.upn}
|
||||
onToggleOpen={() => toggleRow(m.upn)}
|
||||
onAskRemove={() => setConfirmRemoveUpn(m.upn)}
|
||||
onCancelRemove={() => setConfirmRemoveUpn(null)}
|
||||
onConfirmRemove={() => void confirmRemove(m.upn)}
|
||||
onToggleEnabled={() => onToggleEnabled(m.upn, m.isEnabled)}
|
||||
onSavePermissions={(role, canManageBootstrapTokens) => onUpdatePermissions(m.upn, role, canManageBootstrapTokens)}
|
||||
/>
|
||||
))}
|
||||
</ul>
|
||||
)}
|
||||
|
||||
{shown.pageCount > 1 && (
|
||||
<div className="flex items-center justify-between pt-1">
|
||||
<button
|
||||
type="button"
|
||||
onClick={() => setPage(shown.page - 1)}
|
||||
disabled={shown.page === 0}
|
||||
className="px-3 py-1.5 text-sm font-medium text-gray-700 bg-white border border-gray-300 rounded-lg hover:bg-gray-50 disabled:opacity-50 disabled:cursor-not-allowed transition-colors"
|
||||
>
|
||||
Previous
|
||||
</button>
|
||||
<span className="text-xs text-gray-600">
|
||||
{`Page ${shown.page + 1} of ${shown.pageCount} (${matching.length} members)`}
|
||||
</span>
|
||||
<button
|
||||
type="button"
|
||||
onClick={() => setPage(shown.page + 1)}
|
||||
disabled={shown.page >= shown.pageCount - 1}
|
||||
className="px-3 py-1.5 text-sm font-medium text-gray-700 bg-white border border-gray-300 rounded-lg hover:bg-gray-50 disabled:opacity-50 disabled:cursor-not-allowed transition-colors"
|
||||
>
|
||||
Next
|
||||
</button>
|
||||
</div>
|
||||
)}
|
||||
</div>
|
||||
);
|
||||
}
|
||||
|
||||
interface MemberRowProps {
|
||||
member: TenantAdminRow;
|
||||
open: boolean;
|
||||
confirmingRemove: boolean;
|
||||
isCurrentUser: boolean;
|
||||
canMutate: boolean;
|
||||
removing: boolean;
|
||||
updating: boolean;
|
||||
onToggleOpen: () => void;
|
||||
onAskRemove: () => void;
|
||||
onCancelRemove: () => void;
|
||||
onConfirmRemove: () => void;
|
||||
onToggleEnabled: () => void;
|
||||
onSavePermissions: (role: string, canManageBootstrapTokens: boolean) => void;
|
||||
}
|
||||
|
||||
function MemberRow({ member, open, onToggleOpen, ...details }: MemberRowProps) {
|
||||
const isApplication = isApplicationKey(member.upn);
|
||||
const role = effectiveMemberRole(member);
|
||||
const label = principalLabel(member.upn);
|
||||
const added = new Date(member.addedDate).toLocaleDateString();
|
||||
|
||||
return (
|
||||
<li className={open ? "bg-gray-50" : undefined}>
|
||||
<button
|
||||
type="button"
|
||||
aria-expanded={open}
|
||||
onClick={onToggleOpen}
|
||||
className="w-full flex items-start sm:items-center gap-2 px-3 py-2 text-left text-sm hover:bg-gray-50 focus:outline-none focus-visible:ring-2 focus-visible:ring-inset focus-visible:ring-purple-500"
|
||||
>
|
||||
<span className="flex min-w-0 flex-1 flex-wrap sm:flex-nowrap items-center gap-x-2 gap-y-1">
|
||||
<span
|
||||
className={`min-w-0 basis-full sm:basis-auto break-all sm:truncate font-medium ${member.isEnabled ? "text-gray-900" : "text-gray-500"}`}
|
||||
title={label}
|
||||
>
|
||||
{label}
|
||||
</span>
|
||||
<span className="flex flex-shrink-0 flex-wrap items-center gap-1.5">
|
||||
{details.isCurrentUser && <span className={CONTEXT_PILL}>You</span>}
|
||||
{isApplication && (
|
||||
<span className={`${PILL} bg-gray-100 text-gray-700`} title={APPLICATION_TITLE}>
|
||||
App
|
||||
</span>
|
||||
)}
|
||||
<span className={`${PILL} ${ROLE_BADGE[role] ?? "bg-gray-100 text-gray-600"}`}>{role}</span>
|
||||
{role === "Operator" && member.canManageBootstrapTokens && (
|
||||
<span className={CONTEXT_PILL} title="Can manage bootstrap tokens">
|
||||
Bootstrap tokens
|
||||
</span>
|
||||
)}
|
||||
{!member.isEnabled && <span className={`${PILL} bg-gray-200 text-gray-700`}>Disabled</span>}
|
||||
</span>
|
||||
</span>
|
||||
<span className="hidden sm:inline flex-shrink-0 text-xs text-gray-400">{`Added ${added}`}</span>
|
||||
<svg
|
||||
className={`mt-0.5 sm:mt-0 h-4 w-4 flex-shrink-0 text-gray-400 transition-transform ${open ? "rotate-180" : ""}`}
|
||||
fill="none"
|
||||
stroke="currentColor"
|
||||
viewBox="0 0 24 24"
|
||||
aria-hidden="true"
|
||||
>
|
||||
<path strokeLinecap="round" strokeLinejoin="round" strokeWidth={2} d="M19 9l-7 7-7-7" />
|
||||
</svg>
|
||||
</button>
|
||||
|
||||
{open && <MemberDetails member={member} label={label} added={added} {...details} />}
|
||||
</li>
|
||||
);
|
||||
}
|
||||
|
||||
interface MemberDetailsProps extends Omit<MemberRowProps, "open" | "onToggleOpen"> {
|
||||
label: string;
|
||||
added: string;
|
||||
}
|
||||
|
||||
/**
|
||||
* The open part of a row. Role and bootstrap permission stay drafts until Save, so a stray select change
|
||||
* never alters anyone's access; the part unmounts with the closed row, which discards an unsaved draft.
|
||||
*/
|
||||
function MemberDetails({
|
||||
member,
|
||||
label,
|
||||
added,
|
||||
confirmingRemove,
|
||||
isCurrentUser,
|
||||
canMutate,
|
||||
removing,
|
||||
updating,
|
||||
onAskRemove,
|
||||
onCancelRemove,
|
||||
onConfirmRemove,
|
||||
onToggleEnabled,
|
||||
onSavePermissions,
|
||||
}: MemberDetailsProps) {
|
||||
const isApplication = isApplicationKey(member.upn);
|
||||
const role = effectiveMemberRole(member);
|
||||
const [draftRole, setDraftRole] = useState(role);
|
||||
const [draftBootstrap, setDraftBootstrap] = useState(member.canManageBootstrapTokens);
|
||||
const change = permissionChange(member, draftRole, draftBootstrap);
|
||||
const busy = removing || updating;
|
||||
|
||||
const discard = () => {
|
||||
setDraftRole(role);
|
||||
setDraftBootstrap(member.canManageBootstrapTokens);
|
||||
};
|
||||
|
||||
return (
|
||||
<div className="space-y-2 px-3 pb-3 text-sm">
|
||||
<p className="text-xs text-gray-500">{`Added ${added} by ${member.addedBy}`}</p>
|
||||
{isCurrentUser ? (
|
||||
<p className="text-xs text-gray-500">This is your own entry. Only another admin can change its role or access.</p>
|
||||
) : (
|
||||
<div className="flex flex-wrap items-center gap-x-4 gap-y-2">
|
||||
<label className="flex items-center gap-2 text-gray-700">
|
||||
Role
|
||||
<select
|
||||
value={draftRole}
|
||||
onChange={(e) => setDraftRole(e.target.value)}
|
||||
disabled={!canMutate || isApplication || busy}
|
||||
title={isApplication ? "A service principal is always read-only (Viewer)" : undefined}
|
||||
className="px-2 py-1 text-sm border border-gray-300 rounded bg-white text-gray-700 focus:outline-none focus:ring-1 focus:ring-purple-500 disabled:opacity-50"
|
||||
>
|
||||
{MEMBER_ROLES.map((r) => (
|
||||
<option key={r} value={r}>
|
||||
{r}
|
||||
</option>
|
||||
))}
|
||||
</select>
|
||||
</label>
|
||||
{draftRole === "Operator" && (
|
||||
<label className="flex items-center gap-2 text-gray-700 cursor-pointer">
|
||||
<input
|
||||
type="checkbox"
|
||||
checked={draftBootstrap}
|
||||
onChange={(e) => setDraftBootstrap(e.target.checked)}
|
||||
disabled={!canMutate || busy}
|
||||
className="h-4 w-4 text-purple-600 rounded border-gray-300 focus:ring-purple-500 disabled:opacity-50"
|
||||
/>
|
||||
Can manage bootstrap tokens
|
||||
</label>
|
||||
)}
|
||||
{!isApplication && (
|
||||
<span className="flex items-center gap-2">
|
||||
<button
|
||||
type="button"
|
||||
onClick={() => onSavePermissions(draftRole, change.canManageBootstrapTokens)}
|
||||
disabled={!canMutate || busy || !change.dirty}
|
||||
className="px-3 py-1 text-sm bg-purple-600 text-white rounded hover:bg-purple-700 disabled:opacity-50 disabled:cursor-not-allowed transition-colors"
|
||||
>
|
||||
Save
|
||||
</button>
|
||||
{change.dirty && (
|
||||
<button
|
||||
type="button"
|
||||
onClick={discard}
|
||||
disabled={busy}
|
||||
className="px-2 py-1 text-sm text-gray-600 hover:text-gray-800 disabled:opacity-50"
|
||||
>
|
||||
Discard
|
||||
</button>
|
||||
)}
|
||||
</span>
|
||||
)}
|
||||
<span className="flex flex-wrap items-center gap-2 sm:ml-auto">
|
||||
{confirmingRemove ? (
|
||||
<>
|
||||
<span className="text-xs text-gray-600">{`Remove ${label}?`}</span>
|
||||
<button
|
||||
type="button"
|
||||
onClick={onConfirmRemove}
|
||||
disabled={!canMutate || busy}
|
||||
className="px-3 py-1 text-sm bg-red-600 text-white rounded hover:bg-red-700 disabled:opacity-50 disabled:cursor-not-allowed transition-colors"
|
||||
>
|
||||
{removing ? "Removing..." : "Remove"}
|
||||
</button>
|
||||
<button
|
||||
type="button"
|
||||
onClick={onCancelRemove}
|
||||
disabled={removing}
|
||||
className="px-2 py-1 text-sm text-gray-600 hover:text-gray-800 disabled:opacity-50"
|
||||
>
|
||||
Cancel
|
||||
</button>
|
||||
</>
|
||||
) : (
|
||||
<>
|
||||
<button
|
||||
type="button"
|
||||
onClick={onToggleEnabled}
|
||||
disabled={!canMutate || busy}
|
||||
className={`px-3 py-1 text-sm text-white rounded transition-colors disabled:opacity-50 disabled:cursor-not-allowed ${
|
||||
member.isEnabled ? "bg-yellow-600 hover:bg-yellow-700" : "bg-green-600 hover:bg-green-700"
|
||||
}`}
|
||||
>
|
||||
{updating ? "..." : member.isEnabled ? "Disable" : "Enable"}
|
||||
</button>
|
||||
<button
|
||||
type="button"
|
||||
onClick={onAskRemove}
|
||||
disabled={!canMutate || busy}
|
||||
className="px-3 py-1 text-sm bg-red-600 text-white rounded hover:bg-red-700 disabled:opacity-50 disabled:cursor-not-allowed transition-colors"
|
||||
>
|
||||
Remove
|
||||
</button>
|
||||
</>
|
||||
)}
|
||||
</span>
|
||||
</div>
|
||||
)}
|
||||
</div>
|
||||
);
|
||||
}
|
||||
@@ -0,0 +1,47 @@
|
||||
import { describe, it, expect } from "vitest";
|
||||
import { createElement } from "react";
|
||||
import { renderToStaticMarkup } from "react-dom/server";
|
||||
import { AddMemberForm } from "../AddMemberForm";
|
||||
|
||||
const noop = () => {};
|
||||
|
||||
function render(stacked?: boolean): string {
|
||||
return renderToStaticMarkup(
|
||||
createElement(AddMemberForm, {
|
||||
value: "",
|
||||
onValueChange: noop,
|
||||
role: "Admin",
|
||||
onRoleChange: noop,
|
||||
kind: "user",
|
||||
onKindChange: noop,
|
||||
adding: false,
|
||||
onAdd: noop,
|
||||
stacked,
|
||||
}),
|
||||
);
|
||||
}
|
||||
|
||||
function inputClasses(html: string): string[] {
|
||||
const input = html.match(/<input [^>]*name="new-member"[^>]*>/)?.[0] ?? "";
|
||||
return (input.match(/class="([^"]*)"/)?.[1] ?? "").split(" ");
|
||||
}
|
||||
|
||||
describe("AddMemberForm", () => {
|
||||
it("keeps a minimum width for the input and wraps instead of squeezing it, whatever the viewport", () => {
|
||||
const classes = inputClasses(render());
|
||||
expect(classes).toEqual(expect.arrayContaining(["grow", "basis-72", "min-w-0"]));
|
||||
// No viewport breakpoint decides the layout: a wide window can still host a narrow column.
|
||||
expect(classes.filter((c) => /^(sm|md|lg|xl):/.test(c))).toEqual([]);
|
||||
});
|
||||
|
||||
it("gives the input a line of its own when stacked (the GA tenant editor modal)", () => {
|
||||
const classes = inputClasses(render(true));
|
||||
expect(classes).toContain("basis-full");
|
||||
expect(classes).not.toContain("basis-72");
|
||||
});
|
||||
|
||||
it("keeps role and Add together, so they wrap as one unit", () => {
|
||||
const html = render();
|
||||
expect(html).toMatch(/<div class="flex gap-2"><select [^>]*aria-label="Role"[\s\S]*?<\/select><button [^>]*>[\s\S]*?Add<\/button><\/div>/);
|
||||
});
|
||||
});
|
||||
@@ -0,0 +1,88 @@
|
||||
import { describe, it, expect } from "vitest";
|
||||
import { createElement } from "react";
|
||||
import { renderToStaticMarkup } from "react-dom/server";
|
||||
import type { TenantAdminRow } from "@/utils/wire-types.generated";
|
||||
import { MemberList } from "../MemberList";
|
||||
import { MEMBER_PAGE_SIZE } from "../memberListModel";
|
||||
|
||||
const noop = () => {};
|
||||
|
||||
function row(upn: string, overrides: Partial<TenantAdminRow> = {}): TenantAdminRow {
|
||||
return {
|
||||
tenantId: "11111111-2222-3333-4444-555555555555",
|
||||
upn,
|
||||
isEnabled: true,
|
||||
addedDate: "2026-09-01T10:00:00Z",
|
||||
addedBy: "first.admin@tenant.example",
|
||||
role: "Viewer",
|
||||
canManageBootstrapTokens: false,
|
||||
...overrides,
|
||||
};
|
||||
}
|
||||
|
||||
function render(members: TenantAdminRow[], currentUserUpn?: string) {
|
||||
return renderToStaticMarkup(
|
||||
createElement(MemberList, {
|
||||
members,
|
||||
loading: false,
|
||||
currentUserUpn,
|
||||
removingUpn: null,
|
||||
updatingUpn: null,
|
||||
onRemove: noop,
|
||||
onToggleEnabled: noop,
|
||||
onUpdatePermissions: noop,
|
||||
}),
|
||||
);
|
||||
}
|
||||
|
||||
describe("MemberList", () => {
|
||||
it("renders closed one-line rows: badges only, the actions wait behind a click", () => {
|
||||
const html = render([
|
||||
row("admin@tenant.example", { role: "Admin" }),
|
||||
row("op@tenant.example", { role: "Operator", canManageBootstrapTokens: true }),
|
||||
row("off@tenant.example", { isEnabled: false }),
|
||||
]);
|
||||
expect(html.match(/aria-expanded="false"/g)?.length).toBe(3);
|
||||
expect(html).toContain("Bootstrap tokens");
|
||||
expect(html).toContain(">Disabled</span>");
|
||||
expect(html).not.toContain("<select");
|
||||
expect(html).not.toContain(">Remove</button>");
|
||||
expect(html).not.toContain(">Disable</button>");
|
||||
});
|
||||
|
||||
it("shows the role chips with counts, All pressed, and Disabled only when an entry is disabled", () => {
|
||||
const html = render([
|
||||
row("a@tenant.example", { role: "Admin" }),
|
||||
row("b@tenant.example", { role: "Viewer" }),
|
||||
row("c@tenant.example", { role: "Viewer" }),
|
||||
]);
|
||||
const chips = html.split('<div role="group" aria-label="Filter members by role"')[1].split("</div>")[0];
|
||||
expect(chips).toContain('aria-pressed="true"');
|
||||
expect(chips.match(/<button /g)?.length).toBe(4);
|
||||
expect(chips).toMatch(/All<span[^>]*>3<\/span>/);
|
||||
expect(chips).toMatch(/Viewer<span[^>]*>2<\/span>/);
|
||||
// No Operator yet: the chip stays in place but cannot be picked.
|
||||
expect(chips).toMatch(/disabled=""[^>]*>Operator<span[^>]*>0<\/span>/);
|
||||
expect(chips).not.toContain("Disabled");
|
||||
});
|
||||
|
||||
it("marks the signed-in user's row", () => {
|
||||
const html = render([row("me@tenant.example", { role: "Admin" }), row("other@tenant.example")], "ME@tenant.example");
|
||||
const ownRow = html.split("<li").find((chunk) => chunk.includes("me@tenant.example"));
|
||||
expect(ownRow).toContain(">You</span>");
|
||||
const otherRow = html.split("<li").find((chunk) => chunk.includes("other@tenant.example"));
|
||||
expect(otherRow).not.toContain(">You</span>");
|
||||
});
|
||||
|
||||
it(`pages at ${MEMBER_PAGE_SIZE} rows`, () => {
|
||||
const members = Array.from({ length: MEMBER_PAGE_SIZE + 5 }, (_, i) => row(`user${String(i).padStart(2, "0")}@tenant.example`));
|
||||
const html = render(members);
|
||||
expect(html.match(/<li/g)?.length).toBe(MEMBER_PAGE_SIZE);
|
||||
expect(html).toContain(`Page 1 of 2 (${MEMBER_PAGE_SIZE + 5} members)`);
|
||||
});
|
||||
|
||||
it("renders no pager for one page and an empty state without members", () => {
|
||||
expect(render([row("a@tenant.example")])).not.toContain("Next");
|
||||
expect(render([])).toContain("No members found");
|
||||
});
|
||||
});
|
||||
Some files were not shown because too many files have changed in this diff Show More
Reference in New Issue
Block a user