gsadmin/AutopilotMonitor
1
0
Fork 0
mirror of https://github.com/okieselbach/AutopilotMonitor.git synced 2026-10-24 12:42:38 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix crash rate: only count exception crashes, not hard/reboot kills

Browse Source 
Hard kills and reboot kills are expected during enrollment (reboots, process
termination) and should not inflate the crash rate. Only exception crashes
represent actual failures. UI updated to visually separate expected exits.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
Oliver Kieselbach
2026-04-03 14:50:51 +02:00
parent 23195dcd1b
commit ab030dce7f
2 changed files with 9 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/Backend/AutopilotMonitor.Functions/Services/PlatformMetricsService.cs
+1 -2
View File
@@ -275,10 +275,9 @@ namespace AutopilotMonitor.Functions.Services
}
}
var crashCount = metrics.ExceptionCrashes + metrics.HardKills;
var nonFirstRuns = metrics.TotalStarts - metrics.FirstRuns;
metrics.CrashRatePercent = nonFirstRuns > 0
? Math.Round((double)crashCount / nonFirstRuns * 100, 1)
? Math.Round((double)metrics.ExceptionCrashes / nonFirstRuns * 100, 1)
: 0;
metrics.TopExceptions = exceptionCounts
src/Web/autopilot-monitor-web/app/admin/metrics/sections/SectionAgentMetrics.tsx
+8 -8
View File
@@ -629,14 +629,14 @@ export function SectionAgentMetrics() {
{/* Crash Rate */}
<div>
<h3 className="text-sm font-medium text-gray-700 mb-3">Agent Crash Rate</h3>
<h3 className="text-sm font-medium text-gray-700 mb-3">Agent Exit Statistics</h3>
{crashRate && crashRate.totalStarts > 0 ? (
<div className="space-y-2">
<div className="flex items-baseline gap-2">
<span className={`text-2xl font-bold ${crashRate.crashRatePercent === 0 ? 'text-green-600' : crashRate.crashRatePercent < 5 ? 'text-yellow-600' : 'text-red-600'}`}>
{crashRate.crashRatePercent.toFixed(1)}%
</span>
<span className="text-xs text-gray-500">crash rate</span>
<span className="text-xs text-gray-500">exception crash rate</span>
</div>
<div className="space-y-1 text-sm">
<div className="flex justify-between">
@@ -647,16 +647,16 @@ export function SectionAgentMetrics() {
<span className="text-gray-500">Exception crashes</span>
<span className={`font-mono ${crashRate.exceptionCrashes > 0 ? 'text-red-600' : 'text-gray-400'}`}>{crashRate.exceptionCrashes}</span>
</div>
<div className="flex justify-between">
<span className="text-gray-500">Hard kills</span>
<span className={`font-mono ${crashRate.hardKills > 0 ? 'text-orange-600' : 'text-gray-400'}`}>{crashRate.hardKills}</span>
<div className="flex justify-between border-t border-gray-100 pt-1 mt-1">
<span className="text-gray-400">Hard kills (expected)</span>
<span className={`font-mono ${crashRate.hardKills > 0 ? 'text-gray-500' : 'text-gray-400'}`}>{crashRate.hardKills}</span>
</div>
<div className="flex justify-between">
<span className="text-gray-500">Reboot kills</span>
<span className={`font-mono ${(crashRate.rebootKills ?? 0) > 0 ? 'text-blue-500' : 'text-gray-400'}`}>{crashRate.rebootKills ?? 0}</span>
<span className="text-gray-400">Reboot kills (expected)</span>
<span className={`font-mono ${(crashRate.rebootKills ?? 0) > 0 ? 'text-gray-500' : 'text-gray-400'}`}>{crashRate.rebootKills ?? 0}</span>
</div>
<div className="flex justify-between">
<span className="text-gray-500">First runs</span>
<span className="text-gray-400">First runs</span>
<span className="font-mono text-gray-400">{crashRate.firstRuns}</span>
</div>
</div>