Files
ziti/controller/model/router_model.go
T
Paul Lorenz 6c20e68038 Apply managed link heartbeat and queue settings at runtime. For #3743
- applies the router.link.v1 heartbeat settings (sendInterval, checkInterval,
  closeUnresponsiveTimeout) and payload/ack sender queue sizes at runtime,
  replacing the hardcoded 10s/1s link heartbeat intervals and the ignored fields;
  new links take them at bind time, established links are re-tuned in place
  through the channel HeartbeatControl, and queue sizes reach new links only
- publishes heartbeat settings as an immutable generation in one atomic swap, so
  no reader pairs one generation's interval with another's timeout, and has each
  link enforce the timeout belonging to its own intervals
- pushes a generation and its intervals as one step under the link's lock and
  ignores a generation at or below the one applied, so an overtaken update cannot
  roll a link back; reconciles every channel of a link, including a split link
  whose channels bind on either side of a config change, to the newest generation
- adopts the first registered settings explicitly, since a router with no managed
  link config publishes its defaults at generation 0
- re-arms a link's liveness deadline when its generation changes, so age
  accumulated under the previous intervals cannot close a healthy link when a
  timeout is shortened
- honors a closeUnresponsiveTimeout below 30s, which previously sat behind the
  unhealthy threshold; treats a zero timeout as closing nothing, and reports a
  closing link unhealthy
- scales the unhealthy threshold with the intervals, to max(30s, 2 x (send +
  check)): reporting unhealthy poisons the latency metric the controller routes
  on, so a fixed 30s priced healthy links with a long send interval out of
  routing every cycle
- validates heartbeat timing on the controller and the router: durations must be
  positive, their sum representable, and the timeout at least 10s and greater
  than sendInterval + checkInterval; a timeout under two heartbeat cycles is
  accepted with a warning
- adds a per-config-type semantic validator registry to ConfigManager, run after
  schema validation, and moves the router.link config definition to
  common/config/routerlink so the controller applies the same rules
- treats a link section in router YAML, of any content, as local config that
  takes precedence over the controller's for the whole router.link type, since
  the loader defaults every field and so now records presence separately; warns
  at startup when that section has no listeners or dialers
- translates local heartbeat timing leniently, since a local failure stops the
  router from starting: keeps an explicit zero, raises a timeout below the floor
  to it, and falls back to the defaults for other invalid timing, each with a
  warning
- stamps UpdateLinkListeners with the config generation it came from and has the
  controller drop superseded sets, which a multi-underlay control channel can
  deliver out of order and which would otherwise send peers to withdrawn
  addresses
- logs every successful link config apply, including those that dispatch no work,
  and pins that a queue-size-only change triggers no GC pass
- deprecates split links, documents the feature in the changelog and the router
  config design doc, and brings both up to date

Builds on the channel/v5 HeartbeatControl from openziti/channel#265.
2026-09-23 13:35:30 -04:00

212 lines
7.5 KiB
Go

/*
Copyright NetFoundry Inc.
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
https://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/
package model
import (
"fmt"
"sync"
"sync/atomic"
"time"
"github.com/openziti/foundation/v2/errorz"
"github.com/openziti/foundation/v2/versions"
"github.com/openziti/ziti/v2/common/capabilities"
"github.com/openziti/ziti/v2/common/ctrlchan"
"github.com/openziti/ziti/v2/common/pb/ctrl_pb"
"github.com/openziti/ziti/v2/controller/db"
"github.com/openziti/ziti/v2/controller/models"
"github.com/openziti/ziti/v2/controller/storage/boltz"
"go.etcd.io/bbolt"
)
type Router struct {
models.BaseEntity
Name string
Fingerprint *string
// listeners is the router's currently-advertised link listener set.
// Hello carries the initial snapshot; UpdateLinkListeners pushes
// mid-session changes from the router. Guarded by mu, so it is
// unexported: reach it through SetLinkListeners / GetLinkListeners.
listeners []*ctrl_pb.Listener
// listenerGeneration is the generation of the recorded listener set, scoped
// to the current control channel session. Zero means nothing recorded yet.
listenerGeneration uint64
// mu guards the fields a connected Router mutates mid-session, which
// today is just listeners. Fields added later should share it rather
// than take their own lock; contention is irrelevant at this scale.
mu sync.RWMutex
Control ctrlchan.CtrlChannel
Connected atomic.Bool
ConnectTime time.Time
// VersionInfo is reported in the router's hello and is not persisted, so it is only populated on the
// instance built for a control-channel connection. It is nil on an instance loaded from the database.
// Read it from GetConnected rather than from whatever instance is to hand.
VersionInfo *versions.VersionInfo
routerLinks RouterLinks
Cost uint16
NoTraversal bool
Disabled bool
Capabilities *capabilities.RouterCapabilityMask
Interfaces []*Interface
CtrlChanListeners map[string][]string
Configs []string
}
func (entity *Router) GetLinks() []*Link {
return entity.routerLinks.GetLinks()
}
func (entity *Router) toBoltEntityForUpdate(tx *bbolt.Tx, env Env, checker boltz.FieldChecker) (*db.Router, error) {
if err := validateRouterConfigs(tx, env, entity.Configs, checker); err != nil {
return nil, err
}
return entity.toBoltEntity(), nil
}
func (entity *Router) toBoltEntityForCreate(tx *bbolt.Tx, env Env) (*db.Router, error) {
if err := validateRouterConfigs(tx, env, entity.Configs, nil); err != nil {
return nil, err
}
return entity.toBoltEntity(), nil
}
func (entity *Router) toBoltEntity() *db.Router {
return &db.Router{
BaseExtEntity: *boltz.NewExtEntity(entity.Id, entity.Tags),
Name: entity.Name,
Fingerprint: entity.Fingerprint,
Cost: entity.Cost,
NoTraversal: entity.NoTraversal,
Disabled: entity.Disabled,
CtrlChanListeners: entity.CtrlChanListeners,
Interfaces: InterfacesToBolt(entity.Interfaces),
Configs: entity.Configs,
}
}
// validateRouterConfigs validates that all configs target routers and have unique config types.
// If checker is non-nil and the configs field is not being updated, validation is skipped.
func validateRouterConfigs(tx *bbolt.Tx, env Env, configs []string, checker boltz.FieldChecker) error {
if checker != nil && !checker.IsUpdated(db.EntityTypeConfigs) {
return nil
}
if len(configs) == 0 {
return nil
}
typeMap := map[string]*db.Config{}
configStore := env.GetStores().Config
configTypeStore := env.GetStores().ConfigType
for _, id := range configs {
config, err := configStore.LoadById(tx, id)
if err != nil {
return err
}
configType, err := configTypeStore.LoadById(tx, config.TypeId)
if err != nil {
if boltz.IsErrNotFoundErr(err) {
msg := fmt.Sprintf("config %v references config type %v which does not exist",
config.Name, config.TypeId)
return errorz.NewFieldError(msg, "configs", configs)
}
return err
}
if configType.Target != db.ConfigTypeTargetRouter {
msg := fmt.Sprintf("config %v has config type %v which does not target routers",
config.Name, configType.Name)
return errorz.NewFieldError(msg, "configs", configs)
}
if conflictConfig, found := typeMap[config.TypeId]; found {
msg := fmt.Sprintf("duplicate configs named %v and %v found for config type %v. Only one config of a given type is allowed per router",
conflictConfig.Name, config.Name, configType.Name)
return errorz.NewFieldError(msg, "configs", configs)
}
typeMap[config.TypeId] = config
}
return nil
}
func (entity *Router) fillFrom(_ Env, _ *bbolt.Tx, boltRouter *db.Router) error {
entity.Name = boltRouter.Name
entity.Fingerprint = boltRouter.Fingerprint
entity.Cost = boltRouter.Cost
entity.NoTraversal = boltRouter.NoTraversal
entity.Disabled = boltRouter.Disabled
entity.CtrlChanListeners = boltRouter.CtrlChanListeners
entity.Interfaces = InterfacesFromBolt(boltRouter.Interfaces)
entity.Configs = boltRouter.Configs
entity.FillCommon(boltRouter)
return nil
}
func (entity *Router) addLinkListener(addr, linkProtocol string, groups []string) {
entity.mu.Lock()
defer entity.mu.Unlock()
entity.listeners = append(entity.listeners, &ctrl_pb.Listener{
Address: addr,
Protocol: linkProtocol,
Groups: groups,
})
}
// SetLinkListeners atomically replaces the router's link listener slice.
// Callers do not mutate the previous slice — readers may still hold and
// iterate it safely after a Set.
// SetLinkListeners records listeners when generation is newer than the last
// recorded for this control channel session, and reports whether it did. Older
// generations are dropped: a multi-underlay control channel doesn't order updates
// across underlays, and a stale set would be redistributed to peers.
func (entity *Router) SetLinkListeners(listeners []*ctrl_pb.Listener, generation uint64) bool {
entity.mu.Lock()
defer entity.mu.Unlock()
if generation <= entity.listenerGeneration && entity.listenerGeneration != 0 {
return false
}
entity.listeners = listeners
entity.listenerGeneration = generation
return true
}
// ResetLinkListeners clears the listener set and the generation it was recorded
// at, for a newly-connected control channel. The router mints generations per
// process, so they restart when it does; a generation remembered from a
// previous session would reject a restarted router's first updates.
func (entity *Router) ResetLinkListeners() {
entity.mu.Lock()
defer entity.mu.Unlock()
entity.listeners = nil
entity.listenerGeneration = 0
}
// GetLinkListeners returns the current link listener slice under a read
// lock. The returned slice is the live header — safe to iterate because
// SetLinkListeners always replaces the whole slice rather than mutating
// it in place — but callers should not modify it.
func (entity *Router) GetLinkListeners() []*ctrl_pb.Listener {
entity.mu.RLock()
defer entity.mu.RUnlock()
return entity.listeners
}
func (entity *Router) HasCapability(capability capabilities.RouterCapability) bool {
return entity.Capabilities != nil && entity.Capabilities.IsSet(capability)
}