Files
Paul Lorenz db39bd0a86 Close a control channel whose controller stops answering heartbeats. Fixes #4247
- closes the channel from the router's heartbeat check once no heartbeat response has arrived within closeUnresponsiveTimeout, which the controller already does for its side but the router did not
- recovers a channel whose underlays are dead but not yet detected: until it closes, the channel keeps its group and dials only additional underlays, which the controller refuses once it has torn its side of the group down, so nothing re-establishes the group until the operating system abandons the connection, which takes roughly fifteen minutes
- leaves being unresponsive as purely a selection signal, so a controller that is merely slow is deprioritized rather than disconnected, and a zero timeout disables the teardown
- seeds the last-response time when the channel is created, so a channel is not judged before its first heartbeat could be answered
- tests that a silent controller's channel is closed, that a slow but answering one is not, and that a zero timeout disables it
2026-08-13 23:54:41 -04:00

205 lines
6.0 KiB
Go

/*
Copyright NetFoundry Inc.
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
https://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
*/
package env
import (
"sync/atomic"
"time"
"github.com/michaelquigley/pfxlog"
"github.com/openziti/foundation/v2/versions"
"github.com/openziti/ziti/v2/common/ctrlchan"
"github.com/openziti/channel/v5"
)
type NetworkController interface {
Channel() channel.Channel
CtrlChannel() ctrlchan.CtrlChannel
Address() string
Latency() time.Duration
HeartbeatCallback() channel.HeartbeatCallback
IsUnresponsive() bool
isMoreResponsive(other NetworkController) bool
GetVersion() *versions.VersionInfo
TimeSinceLastContact() time.Duration
IsConnected() bool
GetLastReportedDataModelIndex() uint64
updateDataModelIndex(index uint64)
}
func newNetworkCtrl(ch ctrlchan.CtrlChannel, address string, heartbeatOptions *HeartbeatOptions) *networkCtrl {
result := &networkCtrl{
ch: ch,
address: address,
heartbeatOptions: heartbeatOptions,
}
// Seed the response time so a channel is not judged unresponsive before its first heartbeat has had a
// chance to be answered.
result.lastRx = time.Now().UnixMilli()
result.lastContact.Store(result.lastRx)
return result
}
type networkCtrl struct {
ch ctrlchan.CtrlChannel
address string
heartbeatOptions *HeartbeatOptions
lastTx int64
lastRx int64
latency atomic.Int64
unresponsive atomic.Bool
versionInfo *versions.VersionInfo
lastContact atomic.Int64
currentIndex atomic.Uint64
}
func (self *networkCtrl) TimeSinceLastContact() time.Duration {
return time.Millisecond * time.Duration(time.Now().UnixMilli()-self.lastContact.Load())
}
func (self *networkCtrl) HeartbeatCallback() channel.HeartbeatCallback {
return self
}
func (self *networkCtrl) Channel() channel.Channel {
return self.ch.GetChannel()
}
func (self *networkCtrl) CtrlChannel() ctrlchan.CtrlChannel {
return self.ch
}
func (self *networkCtrl) GetVersion() *versions.VersionInfo {
return self.versionInfo
}
func (self *networkCtrl) Address() string {
return self.address
}
func (self *networkCtrl) GetLastReportedDataModelIndex() uint64 {
return self.currentIndex.Load()
}
func (self *networkCtrl) updateDataModelIndex(index uint64) {
self.currentIndex.Store(index)
}
func (self *networkCtrl) Latency() time.Duration {
return time.Duration(self.latency.Load())
}
func (self *networkCtrl) IsUnresponsive() bool {
return self.unresponsive.Load()
}
func (self *networkCtrl) isMoreResponsive(other NetworkController) bool {
if self.IsConnected() && !other.IsConnected() {
return true
} else if other.IsConnected() && !self.IsConnected() {
return false
} else if self.IsUnresponsive() {
if !other.IsUnresponsive() {
return false
}
} else if other.IsUnresponsive() {
return true
}
return self.Latency() < other.Latency()
}
func (self *networkCtrl) HeartbeatTx(int64) {
self.lastTx = time.Now().UnixMilli()
self.lastContact.Store(self.lastTx)
}
func (self *networkCtrl) HeartbeatRx(int64) {
}
func (self *networkCtrl) HeartbeatRespTx(int64) {
}
func (self *networkCtrl) HeartbeatRespRx(ts int64) {
now := time.Now()
self.lastRx = now.UnixMilli()
self.latency.Store(now.UnixNano() - ts)
self.lastContact.Store(self.lastRx)
}
func (self *networkCtrl) CheckHeartBeat() {
if time.Duration(self.latency.Load()) > self.heartbeatOptions.UnresponsiveAfter {
// if latency is greater than 5 seconds, consider this channel unresponsive
self.unresponsive.Store(true)
} else if self.lastTx > 0 && self.lastRx < self.lastTx && (time.Now().UnixMilli()-self.lastTx) > 5000 {
// if we've sent a heartbeat and not gotten a response in over 5s, consider ourselves unresponsive
self.unresponsive.Store(true)
} else if !self.IsConnected() {
self.unresponsive.Store(true)
} else {
self.unresponsive.Store(false)
}
// Unresponsive alone only deprioritizes. A channel whose underlays are dead but undetected keeps its
// group and dials only additional underlays, which the controller refuses once its side is gone, so
// nothing re-establishes the group until the OS abandons the connection minutes later.
if timeout := self.heartbeatOptions.CloseUnresponsiveTimeout; timeout > 0 && self.timeSinceLastResponse() > timeout {
log := pfxlog.Logger().
WithField("address", self.address).
WithField("timeSinceLastResponse", self.timeSinceLastResponse())
log.Error("no heartbeat response from controller in time, closing control channel")
if err := self.ch.Close(); err != nil {
log.WithError(err).Error("error closing unresponsive control channel")
}
}
}
// timeSinceLastResponse reports how long it has been since the controller last answered a heartbeat. It is
// only read on the heartbeat goroutine, which is also the only writer of lastRx.
func (self *networkCtrl) timeSinceLastResponse() time.Duration {
return time.Duration(time.Now().UnixMilli()-self.lastRx) * time.Millisecond
}
func (self *networkCtrl) IsConnected() bool {
return self.ch.IsConnected()
}
func NewDefaultHeartbeatOptions() *HeartbeatOptions {
return &HeartbeatOptions{
HeartbeatOptions: *channel.DefaultHeartbeatOptions(),
UnresponsiveAfter: 5 * time.Second,
}
}
func NewHeartbeatOptions(options *channel.HeartbeatOptions) (*HeartbeatOptions, error) {
unresponsiveAfter, err := options.GetDuration("unresponsiveAfter")
if err != nil {
return nil, err
}
result := NewDefaultHeartbeatOptions()
result.HeartbeatOptions = *options
if unresponsiveAfter != nil {
result.UnresponsiveAfter = *unresponsiveAfter
}
return result, nil
}
type HeartbeatOptions struct {
channel.HeartbeatOptions
UnresponsiveAfter time.Duration
}