mirror of
https://github.com/openziti/ziti.git
synced 2026-09-10 00:35:41 +00:00
34133bd7d6
Signal retry on leaderless terminator operations
91 lines
3.1 KiB
Go
91 lines
3.1 KiB
Go
/*
|
|
Copyright NetFoundry Inc.
|
|
|
|
Licensed under the Apache License, Version 2.0 (the "License");
|
|
you may not use this file except in compliance with the License.
|
|
You may obtain a copy of the License at
|
|
|
|
https://www.apache.org/licenses/LICENSE-2.0
|
|
|
|
Unless required by applicable law or agreed to in writing, software
|
|
distributed under the License is distributed on an "AS IS" BASIS,
|
|
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
See the License for the specific language governing permissions and
|
|
limitations under the License.
|
|
*/
|
|
|
|
package handler_ctrl
|
|
|
|
import (
|
|
"github.com/michaelquigley/pfxlog"
|
|
"github.com/openziti/channel/v5"
|
|
"github.com/openziti/ziti/v2/common/handler_common"
|
|
"github.com/openziti/ziti/v2/common/pb/ctrl_pb"
|
|
"github.com/openziti/ziti/v2/controller/command"
|
|
"github.com/openziti/ziti/v2/controller/model"
|
|
"github.com/openziti/ziti/v2/controller/network"
|
|
"google.golang.org/protobuf/proto"
|
|
)
|
|
|
|
type removeTerminatorsHandler struct {
|
|
baseHandler
|
|
}
|
|
|
|
func newRemoveTerminatorsHandler(network *network.Network, router *model.Router) *removeTerminatorsHandler {
|
|
return &removeTerminatorsHandler{
|
|
baseHandler: baseHandler{
|
|
router: router,
|
|
network: network,
|
|
},
|
|
}
|
|
}
|
|
|
|
func (self *removeTerminatorsHandler) ContentType() int32 {
|
|
return int32(ctrl_pb.ContentType_RemoveTerminatorsRequestType)
|
|
}
|
|
|
|
func (self *removeTerminatorsHandler) HandleReceive(msg *channel.Message, ch channel.Channel) {
|
|
log := pfxlog.ContextLogger(ch.Label())
|
|
|
|
request := &ctrl_pb.RemoveTerminatorsRequest{}
|
|
if err := proto.Unmarshal(msg.Body, request); err != nil {
|
|
log.WithError(err).Error("failed to unmarshal remove terminator message")
|
|
return
|
|
}
|
|
|
|
go self.handleRemoveTerminators(msg, ch, request)
|
|
}
|
|
|
|
func (self *removeTerminatorsHandler) handleRemoveTerminators(msg *channel.Message, ch channel.Channel, request *ctrl_pb.RemoveTerminatorsRequest) {
|
|
log := pfxlog.ContextLogger(ch.Label())
|
|
|
|
if len(request.TerminatorIds) == 0 {
|
|
handler_common.SendSuccess(msg, ch, "")
|
|
return
|
|
}
|
|
|
|
// Drop ids this router doesn't own, so it can't remove another router's terminators. Absent ids
|
|
// are kept (not pre-filtered by presence): the create for a terminator may be in-flight in raft
|
|
// but not yet applied to the DB, so sending it through raft orders the delete after the create,
|
|
// and ApplyDeleteBatch handles non-existent ids gracefully.
|
|
toDelete := self.selectOwnedTerminators(request.TerminatorIds)
|
|
if len(toDelete) == 0 {
|
|
handler_common.SendSuccess(msg, ch, "")
|
|
return
|
|
}
|
|
|
|
if err := self.network.Terminator.DeleteBatch(toDelete, self.newChangeContext(ch, "fabric.remove.terminators.batch")); err == nil {
|
|
log.
|
|
WithField("routerId", ch.Id()).
|
|
WithField("terminatorIds", toDelete).
|
|
Info("removed terminators")
|
|
handler_common.SendSuccess(msg, ch, "")
|
|
} else if command.WasRateLimited(err) || command.WasLeaderless(err) {
|
|
// A leaderless cluster (during a membership change) is transient; signal busy so the router retries
|
|
// rather than treating the removal as a permanent failure.
|
|
handler_common.SendServerBusy(msg, ch, "remove.terminators")
|
|
} else {
|
|
handler_common.SendFailure(msg, ch, err.Error())
|
|
}
|
|
}
|