From 6c0bc85cbefe7768bb62bc3c977efe2010bcc0d3 Mon Sep 17 00:00:00 2001 From: Andrew Martinez Date: Mon, 30 Oct 2023 09:53:42 -0400 Subject: [PATCH] use UTC to avoid daylight savings time issues --- router/xgress_edge/certchecker_test.go | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/router/xgress_edge/certchecker_test.go b/router/xgress_edge/certchecker_test.go index 11e557120..9e693779d 100644 --- a/router/xgress_edge/certchecker_test.go +++ b/router/xgress_edge/certchecker_test.go @@ -50,7 +50,7 @@ func Test_CertExpirationChecker(t *testing.T) { req := require.New(t) certChecker, _ := newCertChecker() - now := time.Now() + now := time.Now().UTC() notAfter := now.AddDate(0, 0, 7) certChecker.id.Cert().Leaf.NotAfter = notAfter @@ -59,7 +59,7 @@ func Test_CertExpirationChecker(t *testing.T) { waitTime, err := certChecker.getWaitTime() req.NoError(err) - req.LessOrEqual(waitTime, 1*time.Hour+1*time.Second) + req.Equal(0*time.Second, waitTime) }) t.Run("both 4d out is 0", func(t *testing.T) { @@ -210,7 +210,7 @@ func Test_CertExpirationChecker(t *testing.T) { req := require.New(t) certChecker, _ := newCertChecker() - now := time.Now() + now := time.Now().UTC() notAfter := now.AddDate(0, 0, 7) certChecker.id.ServerCert()[0].Leaf.NotAfter = notAfter @@ -218,7 +218,7 @@ func Test_CertExpirationChecker(t *testing.T) { waitTime, err := certChecker.getWaitTime() req.NoError(err) - req.LessOrEqual(waitTime, 1*time.Hour+1*time.Second, waitTime) + req.Equal(0*time.Second, waitTime) }) t.Run("server 7d30s out returns 0", func(t *testing.T) {