From 3890e83c8d6416cbc2e64f8fcbd8892f4254c710 Mon Sep 17 00:00:00 2001
From: Shawn Carey <shawn.carey@netfoundry.io>
Date: Fri, 7 Apr 2023 12:15:26 +0000
Subject: [PATCH] remove iptables chains only when stopping interceptor (#1408)

---
 tunnel/intercept/tproxy/tproxy_linux.go | 8 +-------
 1 file changed, 1 insertion(+), 7 deletions(-)

diff --git a/tunnel/intercept/tproxy/tproxy_linux.go b/tunnel/intercept/tproxy/tproxy_linux.go
index 13411bcdd..05ad96ff3 100644
--- a/tunnel/intercept/tproxy/tproxy_linux.go
+++ b/tunnel/intercept/tproxy/tproxy_linux.go
@@ -135,16 +135,11 @@ type interceptor struct {
 }
 
 func (self *interceptor) Stop() {
-	servicesRemoved := false
 	self.serviceProxies.IterCb(func(key string, proxy *tProxy) {
 		proxy.Stop(alwaysRemoveAddressTracker{})
-		servicesRemoved = true
 	})
 	self.serviceProxies.Clear()
-
-	if servicesRemoved {
-		self.cleanupChains()
-	}
+	self.cleanupChains()
 }
 
 func (self *interceptor) Intercept(service *entities.Service, resolver dns.Resolver, tracker intercept.AddressTracker) error {
@@ -160,7 +155,6 @@ func (self *interceptor) StopIntercepting(serviceName string, tracker intercept.
 	if proxy, found := self.serviceProxies.Get(serviceName); found {
 		proxy.Stop(tracker)
 		self.serviceProxies.Remove(serviceName)
-		self.cleanupChains()
 	}
 	return nil
 }