From 2e353f77d8b82b045b93d221efbb81d30e545f53 Mon Sep 17 00:00:00 2001
From: John Lotoski <john.lotoski@iohk.io>
Date: Thu, 13 Oct 2022 14:10:44 -0500
Subject: [PATCH] fix: shellcheck

---
 quickstart/docker/image/ziti-cli-functions.sh | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/quickstart/docker/image/ziti-cli-functions.sh b/quickstart/docker/image/ziti-cli-functions.sh
index d5fafdc48..b94e5526b 100755
--- a/quickstart/docker/image/ziti-cli-functions.sh
+++ b/quickstart/docker/image/ziti-cli-functions.sh
@@ -979,7 +979,8 @@ function ziti_createEnvFile {
 
   export ZITI_HOME="${ZITI_HOME}"
   if [[ "${ZITI_OSTYPE}" == "windows" ]]; then
-    export ZITI_HOME_OS_SPECIFIC="$(cygpath -m "${ZITI_HOME}")"
+    ZITI_HOME_OS_SPECIFIC="$(cygpath -m "${ZITI_HOME}")"
+    export ZITI_HOME_OS_SPECIFIC
   else
     export ZITI_HOME_OS_SPECIFIC="${ZITI_HOME}"
   fi
@@ -1016,7 +1017,8 @@ function ziti_createEnvFile {
 
   export ZITI_PKI="${ZITI_SHARED}/pki"
   if [[ "${ZITI_OSTYPE}" == "windows" ]]; then
-    export ZITI_PKI_OS_SPECIFIC="$(cygpath -m "${ZITI_PKI}")"
+    ZITI_PKI_OS_SPECIFIC="$(cygpath -m "${ZITI_PKI}")"
+    export ZITI_PKI_OS_SPECIFIC
   else
     export ZITI_PKI_OS_SPECIFIC="${ZITI_PKI}"
   fi
@@ -1382,7 +1384,7 @@ function createZacSystemdFile {
 
   if which node >/dev/null; then
     # store the absolute path to the node executable because it's required by systemd on Amazon Linux, at least
-    NODE_BIN=$(readlink -f $(which node))
+    NODE_BIN=$(readlink -f "$(which node)")
   else
     echo "ERROR: missing executable 'node'" >&2
     return 1
@@ -1439,6 +1441,7 @@ function checkEnvVariable() {
   do
     # Parameter expansion is different between shells
     if [[ -n "$ZSH_VERSION" ]]; then
+      # shellcheck disable=SC2296
       if [[ -z "${(P)arg}" ]]; then
         echo -e "  * ERROR: $(RED "${arg} is not set") "
         return 1