From 2a27850097c63cf08acdea0968c1cfc2abb501fb Mon Sep 17 00:00:00 2001 From: Andrew Martinez Date: Wed, 28 Oct 2020 07:51:19 -0400 Subject: [PATCH] fix go vet issues --- ziti-fabric-gw/subcmd/root.go | 2 +- ziti-fabric-test/subcmd/root.go | 2 +- ziti-probe/subcmd/run.go | 2 +- ziti/cmd/ziti/cmd/edge_controller/create_posture_check.go | 3 --- 4 files changed, 3 insertions(+), 6 deletions(-) diff --git a/ziti-fabric-gw/subcmd/root.go b/ziti-fabric-gw/subcmd/root.go index 8e473d74f..b5a222c7d 100644 --- a/ziti-fabric-gw/subcmd/root.go +++ b/ziti-fabric-gw/subcmd/root.go @@ -39,6 +39,6 @@ var verbose bool func Execute() { if err := root.Execute(); err != nil { - fmt.Errorf("error: %s", err) + println(fmt.Errorf("error: %s", err)) } } diff --git a/ziti-fabric-test/subcmd/root.go b/ziti-fabric-test/subcmd/root.go index 03a150a2f..8baae27ae 100644 --- a/ziti-fabric-test/subcmd/root.go +++ b/ziti-fabric-test/subcmd/root.go @@ -41,6 +41,6 @@ var verbose bool func Execute() { if err := Root.Execute(); err != nil { - fmt.Errorf("error: %s", err) + println(fmt.Errorf("error: %s", err)) } } diff --git a/ziti-probe/subcmd/run.go b/ziti-probe/subcmd/run.go index fbf363af8..f1ff0d515 100644 --- a/ziti-probe/subcmd/run.go +++ b/ziti-probe/subcmd/run.go @@ -142,7 +142,7 @@ func (p *probe) run(_ *cobra.Command, args []string) { for { if _, err = p.ctx.GetServices(); err != nil { sleepDuration := 5 * time.Second - log.Error("failed to load available services, try again in %.2f seconds: %v", sleepDuration.Seconds(), err) + log.Errorf("failed to load available services, try again in %.2f seconds: %v", sleepDuration.Seconds(), err) time.Sleep(sleepDuration) } else { break diff --git a/ziti/cmd/ziti/cmd/edge_controller/create_posture_check.go b/ziti/cmd/ziti/cmd/edge_controller/create_posture_check.go index 88ad2bdd6..383b0b525 100644 --- a/ziti/cmd/ziti/cmd/edge_controller/create_posture_check.go +++ b/ziti/cmd/ziti/cmd/edge_controller/create_posture_check.go @@ -502,8 +502,6 @@ func runCreatePostureCheckOs(o *createPostureCheckOsOptions) error { panic(err) } - return err - return nil } @@ -536,5 +534,4 @@ func parseOsSpec(osSpecStr string) (*osSpec, error) { Type: osType, Versions: cleanVersions, }, nil - }