Commit Graph

16 Commits

Author SHA1 Message Date
Ivar Conradi Østhus 3fc64a5f9f fix: FeatureHasTagError is formatting error message as Joi 2021-02-09 10:34:39 +01:00
Christopher Kolstad d1d271bb41 Add db-error code file 2021-02-09 10:19:35 +01:00
Christopher Kolstad 063d3f0e4a Make feature-toggle-store return 409
- After seeing frontend behaviour where the user could add the same
tag multiple times, and not get errors or be stopped doing so, we'll
change the backend to return a 409 if you tag a feature with a tag it
already has.

- Previous to this commit, the setup was to do `onConflict().ignore()`
  which caused the frontend to not get any help from the backend as to
  whether or not the operation was allowed

- This fix adds a custom error and adds a branch to the handleError util
  method for handling just that error type with a 409.

- This caused a couple of tests to receive 409, probably due to
  insufficient cleanup between tests. Adding faker as a dev-dependency and randomising
  toggle names and tag values for each test reduces the chance that
  we'll run into duplicate issues in the future for the tests that
  touches this problem

fixes: #711
2021-02-08 16:22:15 +01:00
Ivar Conradi Østhus b644071a34 feat: Add technical support for projects 2020-11-23 21:47:51 +01:00
Ivar Conradi Østhus b532c86695 fix: Upgrade to @hapi/joi (#543) 2020-02-20 08:34:32 +01:00
ivaosthu e256db29a5 fix(http-status): Client errors should use 400 status codes 2020-02-20 08:34:19 +01:00
ivaosthu d5db78d140 chore(modernize): Use joi for url-friendly name validation 2020-02-20 08:34:18 +01:00
ivaosthu 62e6d1075a chore(modernize): remove express-validator 2020-02-20 08:34:18 +01:00
ivaosthu 39bc265daf chore(modernize): Use joi schema-validation in FeatureController 2020-02-20 08:34:17 +01:00
sveisvei 375a8b1d4f Prettier/lint 2020-02-20 08:30:50 +01:00
sveisvei 1d3faca238 fix lint 2020-02-20 08:30:45 +01:00
ivaosthu 90859701c6 remove all lerna stuff 2020-02-20 08:30:37 +01:00
sveisvei 7bacad7b90 use lerna for multipackaging 2020-02-20 08:30:26 +01:00
Anders Olsen Sandvik a96a9f38ce #108 Add eslint-config-spt and remove jshint (#111)
* #108 Add eslint-config-spt

* #108 Ignore bundle.js file

* #108 Change eslint ignore path to a glob file

* Remove jshint and follow more of eslint rules
2020-02-20 08:30:24 +01:00
ivaosthu 32125ca4fb Clean up strategyApi with chained-promises 2020-02-20 08:30:18 +01:00
ivaosthu ae0fdce395 Cleaned up and changed promises used in the feature API 2020-02-20 08:30:18 +01:00