Upgrade prom-client and yargs

This commit is contained in:
Simen Bekkhus
2017-06-28 14:21:05 +02:00
committed by Ivar Conradi Østhus
parent 1d060591c4
commit e1cc0b2e99
5 changed files with 17 additions and 51 deletions
+8 -8
View File
@@ -9,14 +9,14 @@ exports.startMonitoring = (enable, eventBus) => {
const client = require('prom-client');
const requestDuration = new client.Summary(
'http_request_duration_milliseconds',
'App response time',
['path', 'method', 'status'],
{
percentiles: [0.1, 0.5, 0.9, 0.99],
}
);
client.collectDefaultMetrics();
const requestDuration = new client.Summary({
name: 'http_request_duration_milliseconds',
help: 'App response time',
labelNames: ['path', 'method', 'status'],
percentiles: [0.1, 0.5, 0.9, 0.99],
});
eventBus.on(events.REQUEST_TIME, ({ path, method, time, statusCode }) => {
requestDuration.labels(path, method, statusCode).observe(time);
+1 -1
View File
@@ -5,7 +5,7 @@ const { EventEmitter } = require('events');
const eventBus = new EventEmitter();
const { REQUEST_TIME } = require('./events');
const { startMonitoring } = require('./metrics');
const prometheusRegister = require('prom-client/lib/register');
const { register: prometheusRegister } = require('prom-client');
test('should collect metrics for requests', t => {
startMonitoring(true, eventBus);
+2 -2
View File
@@ -1,14 +1,14 @@
'use strict';
const { Router } = require('express');
const prometheusRegister = require('prom-client/lib/register');
const { register: prometheusRegister } = require('prom-client');
exports.router = config => {
const router = Router();
if (config.serverMetrics) {
router.get('/prometheus', (req, res) => {
res.writeHead(200, { 'Content-Type': 'text/plain' });
res.set('Content-Type', prometheusRegister.contentType);
res.end(prometheusRegister.metrics());
});
}