From fcb4ea2a1bb3a8f2127a481dc21903ba6cddd0a0 Mon Sep 17 00:00:00 2001 From: mus65 Date: Sat, 18 May 2024 18:15:52 +0200 Subject: [PATCH] fix flaky ReceiveOnServerSocketShouldReturnZero test (#1404) * fix flaky ReceiveOnServerSocketShouldReturnZero test ReceiveOnServerSocketShouldReturnZero assumed that the disconnect already happened on the server side, but it never waits for this. This could cause ServerSocket.Receive to still return valid data and fail the test. example: https://ci.appveyor.com/project/drieseng/ssh-net/builds/49836561/job/wen5tjd1c7wgxrfh * Update test/Renci.SshNet.Tests/Classes/SessionTest_Connected_Disconnect.cs --------- Co-authored-by: Rob Hague --- .../Classes/SessionTest_Connected_Disconnect.cs | 3 +++ 1 file changed, 3 insertions(+) diff --git a/test/Renci.SshNet.Tests/Classes/SessionTest_Connected_Disconnect.cs b/test/Renci.SshNet.Tests/Classes/SessionTest_Connected_Disconnect.cs index 462055e3..5710a998 100644 --- a/test/Renci.SshNet.Tests/Classes/SessionTest_Connected_Disconnect.cs +++ b/test/Renci.SshNet.Tests/Classes/SessionTest_Connected_Disconnect.cs @@ -15,7 +15,10 @@ namespace Renci.SshNet.Tests.Classes { protected override void Act() { + using ManualResetEventSlim clientDisconnected = new ManualResetEventSlim(false); + ServerListener.Disconnected += (socket) => clientDisconnected.Set(); Session.Disconnect(); + clientDisconnected.Wait(10000); } [TestMethod]