diff --git a/src/Renci.SshNet.Tests/Classes/Connection/ProtocolVersionExchangeTest_ServerResponseValid_TerminatedByLineFeedWithoutCarriageReturn.cs b/src/Renci.SshNet.Tests/Classes/Connection/ProtocolVersionExchangeTest_ServerResponseValid_TerminatedByLineFeedWithoutCarriageReturn.cs new file mode 100644 index 00000000..98bbf6fe --- /dev/null +++ b/src/Renci.SshNet.Tests/Classes/Connection/ProtocolVersionExchangeTest_ServerResponseValid_TerminatedByLineFeedWithoutCarriageReturn.cs @@ -0,0 +1,119 @@ +using Microsoft.VisualStudio.TestTools.UnitTesting; +using Renci.SshNet.Common; +using Renci.SshNet.Connection; +using Renci.SshNet.Tests.Common; +using System; +using System.Collections.Generic; +using System.Linq; +using System.Net; +using System.Net.Sockets; +using System.Text; + +namespace Renci.SshNet.Tests.Classes.Connection +{ + [TestClass] + public class ProtocolVersionExchangeTest_ServerResponseValid_TerminatedByLineFeedWithoutCarriageReturn + { + private AsyncSocketListener _server; + private ProtocolVersionExchange _protocolVersionExchange; + private string _clientVersion; + private TimeSpan _timeout; + private IPEndPoint _serverEndPoint; + private List _dataReceivedByServer; + private byte[] _serverIdentification; + private bool _clientDisconnected; + private Socket _client; + private SshIdentification _actual; + + [TestInitialize] + public void Setup() + { + Arrange(); + Act(); + } + + [TestCleanup] + public void Cleanup() + { + if (_server != null) + { + _server.Dispose(); + _server = null; + } + + if (_client != null) + { + _client.Shutdown(SocketShutdown.Both); + _client.Close(); + _client = null; + } + } + + protected void Arrange() + { + _clientVersion = "SSH-2.0-Renci.SshNet.SshClient.0.0.1"; + _timeout = TimeSpan.FromSeconds(5); + _serverEndPoint = new IPEndPoint(IPAddress.Loopback, 8122); + _dataReceivedByServer = new List(); + _serverIdentification = Encoding.UTF8.GetBytes("Welcome stranger!\n\nSSH-Zero-OurSSHAppliance\n\0"); + + _server = new AsyncSocketListener(_serverEndPoint); + _server.Start(); + _server.BytesReceived += (bytes, socket) => + { + _dataReceivedByServer.AddRange(bytes); + socket.Send(_serverIdentification); + socket.Shutdown(SocketShutdown.Send); + }; + _server.Disconnected += (socket) => _clientDisconnected = true; + + _client = new Socket(AddressFamily.InterNetwork, SocketType.Stream, ProtocolType.Tcp); + _client.Connect(_serverEndPoint); + + _protocolVersionExchange = new ProtocolVersionExchange(); + } + + protected void Act() + { + _actual = _protocolVersionExchange.Start(_clientVersion, _client, _timeout); + } + + [TestMethod] + public void StartShouldReturnIdentificationOfServer() + { + Assert.IsNotNull(_actual); + Assert.AreEqual("Zero", _actual.ProtocolVersion); + Assert.AreEqual("OurSSHAppliance", _actual.SoftwareVersion); + Assert.IsNull(_actual.Comments); + } + + [TestMethod] + public void ClientIdentificationWasSentToServer() + { + var expected = Encoding.UTF8.GetBytes(_clientVersion); + + Assert.AreEqual(expected.Length + 2, _dataReceivedByServer.Count); + + Assert.IsTrue(expected.SequenceEqual(_dataReceivedByServer.Take(expected.Length))); + Assert.AreEqual(Session.CarriageReturn, _dataReceivedByServer[_dataReceivedByServer.Count - 2]); + Assert.AreEqual(Session.LineFeed, _dataReceivedByServer[_dataReceivedByServer.Count - 1]); + } + + [TestMethod] + public void ClientRemainsConnected() + { + Assert.IsTrue(_client.Connected); + Assert.IsFalse(_clientDisconnected); + } + + [TestMethod] + public void ClientDidNotReadPastIdentification() + { + var buffer = new byte[1]; + + var bytesReceived = _client.Receive(buffer); + Assert.AreEqual(1, bytesReceived); + Assert.AreEqual(0x00, buffer[0]); + } + } +} diff --git a/src/Renci.SshNet/Connection/ProtocolVersionExchange.cs b/src/Renci.SshNet/Connection/ProtocolVersionExchange.cs index 21b0e469..1d529a6d 100644 --- a/src/Renci.SshNet/Connection/ProtocolVersionExchange.cs +++ b/src/Renci.SshNet/Connection/ProtocolVersionExchange.cs @@ -133,10 +133,21 @@ namespace Renci.SshNet.Connection PacketDump.Create(buffer.ToArray(), 2))); } - if (byteRead == Session.LineFeed && buffer.Count > startPosition + 1 && buffer[buffer.Count - 2] == Session.CarriageReturn) + if (byteRead == Session.LineFeed) { - // Return current line without CRLF - return Encoding.UTF8.GetString(buffer.ToArray(), startPosition, buffer.Count - (startPosition + 2)); + if (buffer.Count > startPosition + 1 && buffer[buffer.Count - 2] == Session.CarriageReturn) + { + // Return current line without CRLF + return Encoding.UTF8.GetString(buffer.ToArray(), startPosition, buffer.Count - (startPosition + 2)); + } + else + { + // Even though RFC4253 clearly indicates that the identification string should be terminated + // by a CR LF we also support banners and identification strings that are terminated by a LF + + // Return current line without LF + return Encoding.UTF8.GetString(buffer.ToArray(), startPosition, buffer.Count - (startPosition + 1)); + } } }