From 3bd1b4eec0d2fdf2314878780fe7012b2379e551 Mon Sep 17 00:00:00 2001 From: drieseng Date: Sun, 11 Sep 2016 20:46:54 +0200 Subject: [PATCH] Modify tests to take into account fact that we no longer explicitly disconnect the SftpSession, but instead immediately dispose it. --- .../Classes/SftpClientTest_Dispose_Connected.cs | 5 ++--- .../Classes/SftpClientTest_Dispose_Disconnected.cs | 5 ++--- .../Classes/SftpClientTest_Dispose_Disposed.cs | 5 ++--- 3 files changed, 6 insertions(+), 9 deletions(-) diff --git a/src/Renci.SshNet.Tests/Classes/SftpClientTest_Dispose_Connected.cs b/src/Renci.SshNet.Tests/Classes/SftpClientTest_Dispose_Connected.cs index db06da60..a8d880ba 100644 --- a/src/Renci.SshNet.Tests/Classes/SftpClientTest_Dispose_Connected.cs +++ b/src/Renci.SshNet.Tests/Classes/SftpClientTest_Dispose_Connected.cs @@ -48,7 +48,6 @@ namespace Renci.SshNet.Tests.Classes .Returns(_sftpSessionMock.Object); _sftpSessionMock.InSequence(sequence).Setup(p => p.Connect()); _sessionMock.InSequence(sequence).Setup(p => p.OnDisconnecting()); - _sftpSessionMock.InSequence(sequence).Setup(p => p.Disconnect()); _sftpSessionMock.InSequence(sequence).Setup(p => p.Dispose()); _sessionMock.InSequence(sequence).Setup(p => p.Disconnect()); _sessionMock.InSequence(sequence).Setup(p => p.Dispose()); @@ -76,9 +75,9 @@ namespace Renci.SshNet.Tests.Classes } [TestMethod] - public void DisconnectOnNetConfSessionShouldBeInvokedOnce() + public void DisconnectOnNetConfSessionShouldNeverBeInvoked() { - _sftpSessionMock.Verify(p => p.Disconnect(), Times.Once); + _sftpSessionMock.Verify(p => p.Disconnect(), Times.Never); } [TestMethod] diff --git a/src/Renci.SshNet.Tests/Classes/SftpClientTest_Dispose_Disconnected.cs b/src/Renci.SshNet.Tests/Classes/SftpClientTest_Dispose_Disconnected.cs index d5e4f53c..eb83e3b9 100644 --- a/src/Renci.SshNet.Tests/Classes/SftpClientTest_Dispose_Disconnected.cs +++ b/src/Renci.SshNet.Tests/Classes/SftpClientTest_Dispose_Disconnected.cs @@ -48,7 +48,6 @@ namespace Renci.SshNet.Tests.Classes .Returns(_sftpSessionMock.Object); _sftpSessionMock.InSequence(sequence).Setup(p => p.Connect()); _sessionMock.InSequence(sequence).Setup(p => p.OnDisconnecting()); - _sftpSessionMock.InSequence(sequence).Setup(p => p.Disconnect()); _sftpSessionMock.InSequence(sequence).Setup(p => p.Dispose()); _sessionMock.InSequence(sequence).Setup(p => p.Disconnect()); _sessionMock.InSequence(sequence).Setup(p => p.Dispose()); @@ -77,9 +76,9 @@ namespace Renci.SshNet.Tests.Classes } [TestMethod] - public void DisconnectOnNetConfSessionShouldBeInvokedOnce() + public void DisconnectOnNetConfSessionShouldNeverBeInvoked() { - _sftpSessionMock.Verify(p => p.Disconnect(), Times.Once); + _sftpSessionMock.Verify(p => p.Disconnect(), Times.Never); } [TestMethod] diff --git a/src/Renci.SshNet.Tests/Classes/SftpClientTest_Dispose_Disposed.cs b/src/Renci.SshNet.Tests/Classes/SftpClientTest_Dispose_Disposed.cs index 4fccdc72..4a1cf410 100644 --- a/src/Renci.SshNet.Tests/Classes/SftpClientTest_Dispose_Disposed.cs +++ b/src/Renci.SshNet.Tests/Classes/SftpClientTest_Dispose_Disposed.cs @@ -48,7 +48,6 @@ namespace Renci.SshNet.Tests.Classes .Returns(_sftpSessionMock.Object); _sftpSessionMock.InSequence(sequence).Setup(p => p.Connect()); _sessionMock.InSequence(sequence).Setup(p => p.OnDisconnecting()); - _sftpSessionMock.InSequence(sequence).Setup(p => p.Disconnect()); _sftpSessionMock.InSequence(sequence).Setup(p => p.Dispose()); _sessionMock.InSequence(sequence).Setup(p => p.Disconnect()); _sessionMock.InSequence(sequence).Setup(p => p.Dispose()); @@ -77,9 +76,9 @@ namespace Renci.SshNet.Tests.Classes } [TestMethod] - public void DisconnectOnNetConfSessionShouldBeInvokedOnce() + public void DisconnectOnNetConfSessionShouldNeverBeInvoked() { - _sftpSessionMock.Verify(p => p.Disconnect(), Times.Once); + _sftpSessionMock.Verify(p => p.Disconnect(), Times.Never); } [TestMethod]