From c5e65cae38d399f529fb344fdd192e7782357982 Mon Sep 17 00:00:00 2001
From: Julian Sommer <115516918+juliansommer@users.noreply.github.com>
Date: Wed, 20 May 2026 10:18:58 +1000
Subject: [PATCH] chore: bump golangci-lint

---
 .github/workflows/spinifex.yml         | 2 +-
 .golangci.yml                          | 1 +
 spinifex/services/vpcd/dhcp_manager.go | 2 +-
 3 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/.github/workflows/spinifex.yml b/.github/workflows/spinifex.yml
index 996cfe67a..bd1a6ac3b 100644
--- a/.github/workflows/spinifex.yml
+++ b/.github/workflows/spinifex.yml
@@ -136,7 +136,7 @@ jobs:
       - name: Lint
         uses: golangci/golangci-lint-action@v9
         with:
-          version: v2.11.3
+          version: v2.12.2
           working-directory: spinifex
 
       - name: Govulncheck
diff --git a/.golangci.yml b/.golangci.yml
index 046f86af9..5b129b81d 100644
--- a/.golangci.yml
+++ b/.golangci.yml
@@ -93,6 +93,7 @@ linters:
     modernize:
       disable:
         - newexpr # don't replace aws.String() with new() — AWS SDK idiom
+        - slicesbackward # less readable
         - stringsbuilder # don't replace small string concatenations with strings.Builder
 
     perfsprint:
diff --git a/spinifex/services/vpcd/dhcp_manager.go b/spinifex/services/vpcd/dhcp_manager.go
index b56c54c69..e41121106 100644
--- a/spinifex/services/vpcd/dhcp_manager.go
+++ b/spinifex/services/vpcd/dhcp_manager.go
@@ -397,7 +397,7 @@ func (m *DHCPManager) trackAndRenew(lease *dhcp.Lease) {
 	}
 
 	// cancel is stored in tracker.renewStop and fired from forget() or Close().
-	ctx, cancel := context.WithCancel(m.stopCtx) //nolint:gosec // G118: cancel stored in tracker.renewStop, fired via forget()/Close()
+	ctx, cancel := context.WithCancel(m.stopCtx)
 	tracker := &managedLease{
 		lease:     lease,
 		renewStop: cancel,