From 986ca34e340fffe2f77a6b4e998ab7ce87504210 Mon Sep 17 00:00:00 2001
From: Julian Sommer <115516918+juliansommer@users.noreply.github.com>
Date: Tue, 15 Sep 2026 11:46:06 +1000
Subject: [PATCH] chore: enable no-array-index-key rule

---
 spinifex/services/spinifexui/frontend/oxlint.config.ts           | 1 +
 .../spinifexui/frontend/src/components/cli-command-panel.tsx     | 1 +
 .../(load-balancers)/-components/create-load-balancer-page.tsx   | 1 +
 .../frontend/src/routes/_auth/ec2/(vpc)/create-vpc.tsx           | 1 +
 .../_auth/eks/(clusters)/-components/create-cluster-page.tsx     | 1 +
 5 files changed, 5 insertions(+)

diff --git a/spinifex/services/spinifexui/frontend/oxlint.config.ts b/spinifex/services/spinifexui/frontend/oxlint.config.ts
index a5f46d18f..0e1e5911f 100644
--- a/spinifex/services/spinifexui/frontend/oxlint.config.ts
+++ b/spinifex/services/spinifexui/frontend/oxlint.config.ts
@@ -45,6 +45,7 @@ export default defineConfig({
       "error",
       { namedComponents: "function-declaration" },
     ],
+    "react/no-array-index-key": "error",
     "react/jsx-handler-names": "off",
     "react/todo": "off",
     "react-you-might-not-need-an-effect/no-event-handler": "error",
diff --git a/spinifex/services/spinifexui/frontend/src/components/cli-command-panel.tsx b/spinifex/services/spinifexui/frontend/src/components/cli-command-panel.tsx
index 39fd673a7..897f9b6b6 100644
--- a/spinifex/services/spinifexui/frontend/src/components/cli-command-panel.tsx
+++ b/spinifex/services/spinifexui/frontend/src/components/cli-command-panel.tsx
@@ -127,6 +127,7 @@ export function CliCommandPanel({ commands }: CliCommandPanelProps) {
                 <pre className="font-mono text-xs/relaxed">
                   <code>
                     {cmd.parts.map((part, j) => (
+                      // oxlint-disable-next-line no-array-index-key -- positional tokens of one command, never reordered
                       <span key={j} className={partStyles[part.type]}>
                         {part.value}
                       </span>
diff --git a/spinifex/services/spinifexui/frontend/src/routes/_auth/ec2/(load-balancers)/-components/create-load-balancer-page.tsx b/spinifex/services/spinifexui/frontend/src/routes/_auth/ec2/(load-balancers)/-components/create-load-balancer-page.tsx
index cc55e4d1a..c1840a28f 100644
--- a/spinifex/services/spinifexui/frontend/src/routes/_auth/ec2/(load-balancers)/-components/create-load-balancer-page.tsx
+++ b/spinifex/services/spinifexui/frontend/src/routes/_auth/ec2/(load-balancers)/-components/create-load-balancer-page.tsx
@@ -353,6 +353,7 @@ export function CreateLoadBalancerPage() {
               </p>
               <ul className="mt-1 list-inside list-disc text-xs text-destructive">
                 {wizardResult.created.map((r, i) => (
+                  // oxlint-disable-next-line no-array-index-key -- static failure summary, never reordered or filtered
                   <li key={i}>
                     {r.type}: {r.id ?? "(created)"}
                   </li>
diff --git a/spinifex/services/spinifexui/frontend/src/routes/_auth/ec2/(vpc)/create-vpc.tsx b/spinifex/services/spinifexui/frontend/src/routes/_auth/ec2/(vpc)/create-vpc.tsx
index 1aca9ed3e..1023f5cf8 100644
--- a/spinifex/services/spinifexui/frontend/src/routes/_auth/ec2/(vpc)/create-vpc.tsx
+++ b/spinifex/services/spinifexui/frontend/src/routes/_auth/ec2/(vpc)/create-vpc.tsx
@@ -162,6 +162,7 @@ function CreateVpc() {
               </p>
               <ul className="mt-1 list-inside list-disc text-xs text-destructive">
                 {wizardResult.created.map((r, i) => (
+                  // oxlint-disable-next-line no-array-index-key -- static failure summary, never reordered or filtered
                   <li key={i}>
                     {r.type}: {r.id}
                   </li>
diff --git a/spinifex/services/spinifexui/frontend/src/routes/_auth/eks/(clusters)/-components/create-cluster-page.tsx b/spinifex/services/spinifexui/frontend/src/routes/_auth/eks/(clusters)/-components/create-cluster-page.tsx
index 9e8001b14..179853655 100644
--- a/spinifex/services/spinifexui/frontend/src/routes/_auth/eks/(clusters)/-components/create-cluster-page.tsx
+++ b/spinifex/services/spinifexui/frontend/src/routes/_auth/eks/(clusters)/-components/create-cluster-page.tsx
@@ -381,6 +381,7 @@ export function CreateClusterPage() {
                 <span className="font-mono">0.0.0.0/0</span>.
               </p>
               {publicCidrs.map((cidr, index) => (
+                // oxlint-disable-next-line no-array-index-key -- controlled inputs; a stable key needs publicAccessCidrs off string[]
                 <div className="flex items-center gap-2" key={index}>
                   <Input
                     aria-label={`Public access CIDR ${index + 1}`}