From 7dd3af3848ed7b56e8e3bed254ce3c0cfd0527ae Mon Sep 17 00:00:00 2001 From: joshsiv-mulga Date: Thu, 14 May 2026 11:16:53 +1000 Subject: [PATCH] revert(installer): undo grub-install changes that introduced PXE boot loop The --no-nvram flag removed the UEFI NVRAM boot entry, causing firmware to fall through to PXE on every reboot. Restore original --recheck behaviour which was confirmed working in manual testing. --- cmd/installer/install/install.go | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/cmd/installer/install/install.go b/cmd/installer/install/install.go index 1c1f83aa7..86c518d11 100644 --- a/cmd/installer/install/install.go +++ b/cmd/installer/install/install.go @@ -539,8 +539,7 @@ func installBootloader(disk string) error { "--boot-directory="+bootDir, "--bootloader-id=spinifex", "--removable", - "--no-nvram", - "--skip-fs-probe", + "--recheck", ) if efiErr != nil { slog.Warn("installBootloader: EFI install failed", "err", efiErr) @@ -548,7 +547,7 @@ func installBootloader(disk string) error { if biosErr := run("grub-install", "--target=i386-pc", "--boot-directory="+bootDir, - "--skip-fs-probe", + "--recheck", disk, ); biosErr != nil { if efiErr != nil { @@ -575,7 +574,6 @@ GRUB_TIMEOUT=5 GRUB_DISTRIBUTOR=Spinifex GRUB_CMDLINE_LINUX_DEFAULT="" GRUB_CMDLINE_LINUX="console=tty0 console=ttyS0,115200 systemd.show_status=1" -GRUB_DISABLE_OS_PROBER=true ` if err := os.WriteFile(filepath.Join(mountRoot, "etc/default/grub"), []byte(grubDefault), 0o644); err != nil {