mirror of
https://github.com/Studio-Saelix/sencho.git
synced 2026-08-13 12:17:34 +00:00
f5178889eb
* feat(recovery): capture complete authored Compose project for atomic rollback Replace the root-compose-only backup slot with staged recovery generations that record the managed inventory, exact Compose invocation, and prior image identity, and wire the same engine through deploy, update, manual rollback, and Git apply. * fix(recovery): satisfy CodeQL path barriers and update-guard mock Inline resolve+startsWith checks at generation/inventory fs sinks and stub getCurrentStackUpdateRecovery in UpdateGuardService tests. * fix(recovery): drop unused FileSystemService import in generation store test * fix(recovery): harden authored-project rollback for upgrade and restore safety Preserve legacy UUID backup rows, restore Git deploy state with files, make multi-file restore recoverable, evaluate policy on the restored target, and fail closed when Git capture cannot cover an apply. * fix(recovery): unblock Git apply unit tests and CodeQL pre-restore TOCTOU Mock recovery capture in git-source-service tests after fail-closed apply capture, and re-resolve live paths immediately before pre-restore snapshot reads. * fix(recovery): fall back to authored inventory when Git manifesto is missing First Git apply captures before promote, so a missing managed-project manifesto must not block rollback capture when the live stack already has authored files. * fix(recovery): make authored-project rollback atomic across Git state Restore the managed-project manifesto with files, keep nullable Git identity on first-apply captures, persist Git side-state in restore intents for startup reconcile, compensate legacy materialize failures, and refuse directory collisions before mutation. * fix(recovery): satisfy CodeQL path and TOCTOU barriers on manifesto restore Add inline resolve barriers for manifesto read/clear sinks and remove the access-then-read race when restoring a generation manifesto snapshot. * fix(recovery): close third-audit rollback generation blockers Fail closed on incomplete Git inventory fallbacks, execute captured Compose invocation during recovery, refuse startup and mutations while restore intents remain unresolved, propagate legacy stale-delete failures, and add Docker-level exact prior-image coverage plus regression tests. * fix(recovery): mark acquired before handoff in prior-image Docker test Match the production updateStack CAS sequence so the exact prior-image integration test does not fail handoff from the captured phase. * fix(recovery): close fourth-audit rollback safety blockers Evaluate policy against held images, use index-based pre-restore snapshots, hold the shared stack lock across Git apply, replay Mesh and empty captured invocations exactly, restore POSIX modes with fail-closed sensitive permissions, keep case-sensitive paths, and link Git auto-deploy health gates. Add regression coverage for these cases. * test(recovery): fix mocks for health-gate link and authored compose args Add linkGateOrRetain to the Git apply recovery mock, and mock authoredComposeArgs so the case-collision inventory test is not masked by a missing getComposeDir stub. * fix(recovery): close fifth-audit rollback safety blockers Share git_apply locking for webhook auto-apply, fail closed on malformed recovery service records, refuse mixed-image capture, and require exact probe counts with hold-tag eligibility checks. * fix(recovery): close sixth-audit rollback safety blockers Preserve the legacy backup slot during generation capture, encrypt sensitive pre-restore snapshots, revert files on a failed health probe without committing Git, fail closed when an absent-file revert would delete a directory, skip Compose one-offs, route manual and scheduled backup through the current generation, and persist runtime image platform identity. * fix(recovery): close seventh-audit rollback safety blockers Fleet snapshot restore and restore-all now capture a recovery generation under the stack lock before any authored file write, including on remote nodes. * fix(recovery): keep pre-deploy generations during health-gate observe Link deploy recovery generations to the observing gate so backup cannot replace them mid-observe. Distinguish missing hold tags from probe failures, refuse generation release when services metadata is corrupt, classify mixed-replica and coverage refusals, and toast the backend rollback message. * fix(recovery): wrap webhook deploy case for eslint const bindings in an unbraced switch case trip no-case-declarations. Match the pull case block.
113 lines
4.0 KiB
TypeScript
113 lines
4.0 KiB
TypeScript
/**
|
|
* Generation capture must not rewrite the legacy single-slot backup. A later
|
|
* capture failure has to leave a pre-migration recovery point byte-identical.
|
|
*/
|
|
import { describe, it, expect, beforeEach, afterEach, vi } from 'vitest';
|
|
import path from 'path';
|
|
import os from 'os';
|
|
import { promises as fsPromises } from 'fs';
|
|
|
|
const mockState = { composeDir: '', composeDirs: new Map<number, string>() };
|
|
|
|
vi.mock('../services/NodeRegistry', () => ({
|
|
NodeRegistry: {
|
|
getInstance: () => ({
|
|
getComposeDir: (nodeId?: number) => mockState.composeDirs.get(nodeId ?? 1) ?? mockState.composeDir,
|
|
getDefaultNodeId: () => 1,
|
|
}),
|
|
},
|
|
}));
|
|
|
|
vi.mock('../utils/debug', () => ({
|
|
isDebugEnabled: () => false,
|
|
}));
|
|
|
|
vi.mock('../services/rollbackInventory', () => ({
|
|
resolveRollbackInventory: vi.fn(),
|
|
}));
|
|
|
|
vi.mock('../services/DatabaseService', () => ({
|
|
DatabaseService: {
|
|
getInstance: () => ({
|
|
getStackProjectEnvFiles: () => [],
|
|
}),
|
|
},
|
|
}));
|
|
|
|
import { FileSystemService } from '../services/FileSystemService';
|
|
import { RollbackGenerationStore } from '../services/RollbackGenerationStore';
|
|
import { resolveRollbackInventory } from '../services/rollbackInventory';
|
|
import { resolveComposeProjectContext } from '../services/composeProjectContext';
|
|
|
|
describe('composeProjectContext backupFromContext', () => {
|
|
let composeDir: string;
|
|
let dataDir: string;
|
|
let originalDataDir: string | undefined;
|
|
|
|
beforeEach(async () => {
|
|
composeDir = await fsPromises.mkdtemp(path.join(os.tmpdir(), 'sencho-compose-'));
|
|
dataDir = await fsPromises.mkdtemp(path.join(os.tmpdir(), 'sencho-data-'));
|
|
mockState.composeDir = composeDir;
|
|
mockState.composeDirs = new Map([[1, composeDir]]);
|
|
originalDataDir = process.env.DATA_DIR;
|
|
process.env.DATA_DIR = dataDir;
|
|
});
|
|
|
|
afterEach(async () => {
|
|
if (originalDataDir === undefined) delete process.env.DATA_DIR;
|
|
else process.env.DATA_DIR = originalDataDir;
|
|
await fsPromises.rm(composeDir, { recursive: true, force: true });
|
|
await fsPromises.rm(dataDir, { recursive: true, force: true });
|
|
vi.restoreAllMocks();
|
|
});
|
|
|
|
it('preserves a seeded legacy backup when generation capture fails', async () => {
|
|
const stackName = 'legacy-slot';
|
|
const stackDir = path.join(composeDir, stackName);
|
|
await fsPromises.mkdir(stackDir, { recursive: true });
|
|
await fsPromises.writeFile(path.join(stackDir, 'compose.yaml'), 'ORIGINAL\n', 'utf8');
|
|
|
|
const fsSvc = FileSystemService.getInstance(1);
|
|
await fsSvc.backupStackFiles(stackName);
|
|
const backupPath = path.join(dataDir, 'backups', '1', stackName, 'compose.yaml');
|
|
const originalBackup = await fsPromises.readFile(backupPath);
|
|
|
|
await fsPromises.writeFile(path.join(stackDir, 'compose.yaml'), 'MUTATED\n', 'utf8');
|
|
|
|
vi.mocked(resolveRollbackInventory).mockResolvedValue({
|
|
entries: [{
|
|
relativePath: 'compose.yaml',
|
|
dependencyKind: 'compose-root',
|
|
provenance: 'authored',
|
|
sensitivity: 'low',
|
|
absolutePath: path.join(stackDir, 'compose.yaml'),
|
|
}],
|
|
invocation: {
|
|
composeArgsPrefix: [],
|
|
projectDirectory: null,
|
|
projectName: stackName,
|
|
explicitComposeFiles: ['compose.yaml'],
|
|
meshEnabled: false,
|
|
meshOverrideRelativePath: null,
|
|
},
|
|
git: null,
|
|
appliedDeploySpec: null,
|
|
lastAppliedContentHash: null,
|
|
manifestState: null,
|
|
manifestGeneration: null,
|
|
exactCoverage: true,
|
|
coverageRefusal: null,
|
|
});
|
|
vi.spyOn(RollbackGenerationStore, 'captureGeneration').mockRejectedValue(
|
|
new Error('injected capture failure'),
|
|
);
|
|
|
|
const ctx = await resolveComposeProjectContext(1, stackName);
|
|
await expect(ctx.backupFromContext('update')).rejects.toThrow(/injected capture failure/);
|
|
|
|
expect(await fsPromises.readFile(backupPath)).toEqual(originalBackup);
|
|
await fsSvc.restoreStackFiles(stackName);
|
|
expect(await fsPromises.readFile(path.join(stackDir, 'compose.yaml'), 'utf8')).toBe('ORIGINAL\n');
|
|
});
|
|
});
|