mirror of
https://github.com/Studio-Saelix/sencho.git
synced 2026-08-13 12:17:34 +00:00
Anso
3d1cf0f8f1
Pilot-agent hosts never run the first-run setup wizard, so the wizard path that normally generates auth_jwt_secret (routes/auth.ts) never fires. Without that secret, the agent-side loopback auth helper added in PR #990 (pilot/agent.ts::getLoopbackAuthHeader) returned null at mint time, no Authorization header was attached on the forwarded loopback request, and the local Sencho's authMiddleware rejected every proxied call with 401 "Authentication required". This was reproducible end-to-end on v0.74.1, .2, and .3. Add ensurePilotJwtSecret() to bootstrap/startup, called early in startServer (before LicenseService.initialize, which only reads system_state and does not touch global_settings, so the order is safe). When SENCHO_MODE=pilot and global_settings.auth_jwt_secret is empty, generate 64 random bytes (hex-encoded, matching the wizard's pattern in routes/auth.ts) and persist. Subsequent boots see the persisted value and no-op. Outside pilot mode the function is a no-op since the wizard owns the lifecycle. The helper is exported so the regression test can exercise the real function rather than maintaining a hand-mirrored copy. Three vitest cases cover: first-boot generation, no-op on persisted secret, no-op in non-pilot mode. Together with PR #989 (proxy-side bridge dispatch), PR #990 (agent-side loopback auth injection), PR #992 (cross-node control plane via HTTP proxy), and PR #994 (local-node mesh-reachable diagnostic), this completes the central, bridge, agent, local-Sencho HTTP path for pilot-agent-mode nodes.
78 lines
3.0 KiB
TypeScript
78 lines
3.0 KiB
TypeScript
/**
|
|
* Regression guard for the task #1 fix: pilot-agent hosts never run the
|
|
* first-run setup wizard, so the wizard's `auth_jwt_secret` generation
|
|
* (routes/auth.ts) never fires. Without that secret, the agent's loopback
|
|
* auth helper (pilot/agent.ts::getLoopbackAuthHeader) returns null and the
|
|
* local Sencho rejects every forwarded request with 401.
|
|
*
|
|
* `bootstrap/startup.ts` now generates the secret on pilot-mode boot when
|
|
* missing, and re-uses the persisted value on subsequent boots. This test
|
|
* exercises both branches by importing the underlying logic directly rather
|
|
* than starting a full server (the server would also try to bind a port and
|
|
* spawn pilot infrastructure).
|
|
*/
|
|
import { afterAll, afterEach, beforeAll, beforeEach, describe, expect, it } from 'vitest';
|
|
import { setupTestDb, cleanupTestDb } from './helpers/setupTestDb';
|
|
|
|
let tmpDir: string;
|
|
let DatabaseService: typeof import('../services/DatabaseService').DatabaseService;
|
|
let ensurePilotJwtSecret: typeof import('../bootstrap/startup').ensurePilotJwtSecret;
|
|
|
|
beforeAll(async () => {
|
|
tmpDir = await setupTestDb();
|
|
({ DatabaseService } = await import('../services/DatabaseService'));
|
|
({ ensurePilotJwtSecret } = await import('../bootstrap/startup'));
|
|
});
|
|
|
|
afterAll(() => {
|
|
cleanupTestDb(tmpDir);
|
|
});
|
|
|
|
beforeEach(() => {
|
|
delete process.env.SENCHO_MODE;
|
|
});
|
|
|
|
afterEach(() => {
|
|
delete process.env.SENCHO_MODE;
|
|
});
|
|
|
|
describe('pilot-agent bootstrap auth_jwt_secret', () => {
|
|
it('generates a secret on first pilot-mode boot when missing', () => {
|
|
const db = DatabaseService.getInstance();
|
|
// Wipe any existing secret to simulate a fresh pilot host.
|
|
db.updateGlobalSetting('auth_jwt_secret', '');
|
|
expect(db.getGlobalSettings().auth_jwt_secret).toBe('');
|
|
|
|
process.env.SENCHO_MODE = 'pilot';
|
|
const generated = ensurePilotJwtSecret();
|
|
expect(generated).toBe(true);
|
|
|
|
const after = db.getGlobalSettings().auth_jwt_secret;
|
|
expect(after).toBeTruthy();
|
|
expect(after.length).toBe(128); // 64 random bytes hex-encoded
|
|
});
|
|
|
|
it('does not regenerate on subsequent boots with a persisted secret', () => {
|
|
const db = DatabaseService.getInstance();
|
|
const seeded = 'a'.repeat(128);
|
|
db.updateGlobalSetting('auth_jwt_secret', seeded);
|
|
|
|
process.env.SENCHO_MODE = 'pilot';
|
|
const generated = ensurePilotJwtSecret();
|
|
expect(generated).toBe(false);
|
|
expect(db.getGlobalSettings().auth_jwt_secret).toBe(seeded);
|
|
});
|
|
|
|
it('does nothing in non-pilot mode (even if secret is missing)', () => {
|
|
const db = DatabaseService.getInstance();
|
|
db.updateGlobalSetting('auth_jwt_secret', '');
|
|
|
|
// Default: SENCHO_MODE unset — primary mode.
|
|
const generated = ensurePilotJwtSecret();
|
|
expect(generated).toBe(false);
|
|
// Still empty: primary mode goes through the setup wizard, not this
|
|
// pilot-only auto-init.
|
|
expect(db.getGlobalSettings().auth_jwt_secret).toBe('');
|
|
});
|
|
});
|