sencho/backend/src/__tests__/stacks-failure-notifications.test.ts

/**
 * Integration tests verifying that deploy_failure notifications are dispatched
 * when stack action routes encounter errors.
 *
 * Covers: deploy, down, restart, stop, update
 *
 * ComposeService and DockerController are mocked so no real Docker daemon is
 * required. NotificationService.dispatchAlert is spied on to assert dispatch.
 */
import { describe, it, expect, beforeAll, afterAll, vi, beforeEach, afterEach } from 'vitest';
import request from 'supertest';
import jwt from 'jsonwebtoken';
import { setupTestDb, cleanupTestDb, loginAsTestAdmin, TEST_JWT_SECRET } from './helpers/setupTestDb';
import { ComposeRollbackError } from '../services/ComposeService';
import * as policyGate from '../helpers/policyGate';

// ── Hoisted mocks (must come before importing the app) ──────────────────────

const {
  mockDeployStack,
  mockRunCommand,
  mockUpdateStack,
  mockGetContainersByStack,
  mockRestartContainer,
  mockStopContainer,
  mockListContainers,
  mockIsTrivyAvailable,
  mockGetImageDigest,
  mockRunScanAndPersist,
  mockGetBackupInfo,
  mockRestoreStackFiles,
  mockSnapshotStackFiles,
} = vi.hoisted(() => ({
  mockDeployStack: vi.fn(),
  mockRunCommand: vi.fn(),
  mockUpdateStack: vi.fn(),
  mockGetContainersByStack: vi.fn(),
  mockRestartContainer: vi.fn(),
  mockStopContainer: vi.fn(),
  mockListContainers: vi.fn(),
  mockIsTrivyAvailable: vi.fn(),
  mockGetImageDigest: vi.fn(),
  mockRunScanAndPersist: vi.fn(),
  mockGetBackupInfo: vi.fn(),
  mockRestoreStackFiles: vi.fn(),
  mockSnapshotStackFiles: vi.fn(),
}));

vi.mock('../services/ComposeService', async () => {
  const actual = await vi.importActual<typeof import('../services/ComposeService')>(
    '../services/ComposeService',
  );
  return {
    ...actual,
    ComposeService: {
      ...actual.ComposeService,
      getInstance: () => ({
        deployStack: mockDeployStack,
        runCommand: mockRunCommand,
        updateStack: mockUpdateStack,
      }),
    },
  };
});

vi.mock('../services/DockerController', async () => {
  const actual = await vi.importActual<typeof import('../services/DockerController')>(
    '../services/DockerController',
  );
  return {
    ...actual,
    default: {
      ...actual.default,
      getInstance: () => ({
        getContainersByStack: mockGetContainersByStack,
        restartContainer: mockRestartContainer,
        stopContainer: mockStopContainer,
        getDocker: () => ({
          listContainers: mockListContainers,
        }),
      }),
    },
  };
});

vi.mock('../services/TrivyService', async () => {
  const actual = await vi.importActual<typeof import('../services/TrivyService')>(
    '../services/TrivyService',
  );
  return {
    ...actual,
    default: {
      ...actual.default,
      getInstance: () => ({
        isTrivyAvailable: mockIsTrivyAvailable,
        getImageDigest: mockGetImageDigest,
        runScanAndPersist: mockRunScanAndPersist,
      }),
    },
  };
});

vi.mock('../services/FileSystemService', () => ({
  FileSystemService: {
    getInstance: () => ({
      getStacks: vi.fn().mockResolvedValue([]),
      getBaseDir: () => '/tmp/compose',
      readComposeFile: vi.fn().mockResolvedValue(''),
      hasComposeFile: vi.fn().mockResolvedValue(true),
      getBackupInfo: mockGetBackupInfo,
      restoreStackFiles: mockRestoreStackFiles,
      snapshotStackFiles: mockSnapshotStackFiles,
    }),
  },
}));

// ── Setup ───────────────────────────────────────────────────────────────────

let tmpDir: string;
let app: import('express').Express;
let authCookie: string;
let dispatchAlertSpy: ReturnType<typeof vi.spyOn>;

beforeAll(async () => {
  tmpDir = await setupTestDb();
  ({ app } = await import('../index'));
  authCookie = await loginAsTestAdmin(app);

  const { NotificationService } = await import('../services/NotificationService');
  dispatchAlertSpy = vi
    .spyOn(NotificationService.getInstance(), 'dispatchAlert')
    .mockResolvedValue(undefined);
});

afterAll(() => {
  vi.restoreAllMocks();
  cleanupTestDb(tmpDir);
});

beforeEach(() => {
  mockDeployStack.mockReset();
  mockRunCommand.mockReset();
  mockUpdateStack.mockReset();
  mockGetContainersByStack.mockReset();
  mockRestartContainer.mockReset();
  mockStopContainer.mockReset();
  mockListContainers.mockReset();
  mockIsTrivyAvailable.mockReset();
  mockGetImageDigest.mockReset();
  mockRunScanAndPersist.mockReset();
  mockIsTrivyAvailable.mockReturnValue(true);
  mockListContainers.mockResolvedValue([{ Image: 'nginx:latest' }]);
  mockGetImageDigest.mockResolvedValue(null);
  mockRunScanAndPersist.mockResolvedValue({
    critical_count: 0,
    high_count: 0,
  });
  mockGetBackupInfo.mockReset();
  mockRestoreStackFiles.mockReset();
  mockSnapshotStackFiles.mockReset();
  mockGetBackupInfo.mockResolvedValue({ exists: true, timestamp: 1 });
  mockRestoreStackFiles.mockResolvedValue(undefined);
  mockSnapshotStackFiles.mockResolvedValue(async () => {});
  dispatchAlertSpy.mockClear();
});

// ── Tests ───────────────────────────────────────────────────────────────────

describe('deploy_failure notification on /deploy error', () => {
  it('dispatches deploy_failure alert with correct stackName when deployStack throws', async () => {
    mockDeployStack.mockRejectedValue(new Error('image pull failed'));

    const res = await request(app)
      .post('/api/stacks/myapp/deploy')
      .set('Cookie', authCookie);

    expect(res.status).toBe(500);

    await new Promise(resolve => setImmediate(resolve));

    expect(dispatchAlertSpy).toHaveBeenCalledWith(
      'error',
      'deploy_failure',
      expect.stringContaining('image pull failed'),
      { stackName: 'myapp', actor: 'testadmin' },
    );
  });

  it('includes the error message in the dispatched alert', async () => {
    mockDeployStack.mockRejectedValue(new Error('network timeout'));

    await request(app)
      .post('/api/stacks/webapp/deploy')
      .set('Cookie', authCookie);

    await new Promise(resolve => setImmediate(resolve));

    const call = dispatchAlertSpy.mock.calls[0];
    expect(call[0]).toBe('error');
    expect(call[1]).toBe('deploy_failure');
    expect(call[2]).toContain('network timeout');
    expect(call[3]).toEqual({ stackName: 'webapp', actor: 'testadmin' });
  });

  it('returns rolledBack=true only when compose rollback completed', async () => {
    mockDeployStack.mockRejectedValue(
      new ComposeRollbackError(new Error('image pull failed'), true, true),
    );

    const res = await request(app)
      .post('/api/stacks/myapp/deploy')
      .set('Cookie', authCookie);

    expect(res.status).toBe(500);
    expect(res.body).toMatchObject({ rolledBack: true });
  });

  it('returns rolledBack=false when compose rollback failed', async () => {
    mockDeployStack.mockRejectedValue(
      new ComposeRollbackError(new Error('image pull failed'), true, false),
    );

    const res = await request(app)
      .post('/api/stacks/myapp/deploy')
      .set('Cookie', authCookie);

    expect(res.status).toBe(500);
    expect(res.body).toMatchObject({ rolledBack: false });
  });

  it('uses trusted proxy tier headers for remote atomic deploys', async () => {
    mockDeployStack.mockResolvedValue(undefined);
    const token = jwt.sign({ scope: 'node_proxy' }, TEST_JWT_SECRET, { expiresIn: '1m' });

    const res = await request(app)
      .post('/api/stacks/myapp/deploy')
      .set('Authorization', `Bearer ${token}`)
      .set('x-sencho-tier', 'paid');

    expect(res.status).toBe(200);
    expect(mockDeployStack.mock.calls[0][2]).toBe(true);
  });
});

describe('health gate begin call sites', () => {
  let beginSpy: ReturnType<typeof vi.spyOn>;

  beforeEach(async () => {
    const { HealthGateService } = await import('../services/HealthGateService');
    beginSpy = vi.spyOn(HealthGateService.getInstance(), 'begin').mockReturnValue('gate-123') as ReturnType<typeof vi.spyOn>;
  });

  afterEach(() => {
    beginSpy.mockRestore();
  });

  it('begins a gate after a manual deploy and returns its id', async () => {
    mockDeployStack.mockResolvedValue(undefined);
    const res = await request(app)
      .post('/api/stacks/myapp/deploy')
      .set('Cookie', authCookie)
      .send({ skip_scan: true });
    expect(res.status).toBe(200);
    expect(beginSpy).toHaveBeenCalledWith(expect.any(Number), 'myapp', 'deploy', 'testadmin');
    expect(res.body.healthGateId).toBe('gate-123');
  });

  it('begins a gate after a manual update and returns its id', async () => {
    mockUpdateStack.mockResolvedValue(undefined);
    const res = await request(app)
      .post('/api/stacks/myapp/update')
      .set('Cookie', authCookie)
      .send({ skip_scan: true });
    expect(res.status).toBe(200);
    expect(beginSpy).toHaveBeenCalledWith(expect.any(Number), 'myapp', 'update', 'testadmin');
    expect(res.body.healthGateId).toBe('gate-123');
  });

  it('begins a gate per stack in a bulk update and carries ids in the results', async () => {
    mockUpdateStack.mockResolvedValue(undefined);
    const res = await request(app)
      .post('/api/stacks/bulk')
      .set('Cookie', authCookie)
      .send({ action: 'update', stackNames: ['myapp', 'webapp'] });
    expect(res.status).toBe(200);
    expect(beginSpy).toHaveBeenCalledWith(expect.any(Number), 'myapp', 'update', 'testadmin');
    expect(beginSpy).toHaveBeenCalledWith(expect.any(Number), 'webapp', 'update', 'testadmin');
    const items = res.body.results as Array<{ stackName: string; ok: boolean; healthGateId?: string | null }>;
    expect(items).toHaveLength(2);
    for (const item of items) {
      expect(item.ok).toBe(true);
      expect(item.healthGateId).toBe('gate-123');
    }
  });

  it('does not begin a gate on a failed deploy', async () => {
    mockDeployStack.mockRejectedValue(new Error('boom'));
    await request(app).post('/api/stacks/myapp/deploy').set('Cookie', authCookie);
    expect(beginSpy).not.toHaveBeenCalled();
  });

  it('never begins a gate for the rollback recovery path', async () => {
    mockDeployStack.mockResolvedValue(undefined);
    const res = await request(app)
      .post('/api/stacks/myapp/rollback')
      .set('Cookie', authCookie);
    expect(res.status).toBe(200);
    expect(beginSpy).not.toHaveBeenCalled();
  });
});

describe('failure classification on deploy/update error responses', () => {
  it('classifies a failed deploy and includes failure in the body', async () => {
    mockDeployStack.mockRejectedValue(
      new Error('Bind for 0.0.0.0:8080 failed: port is already allocated'),
    );

    const res = await request(app)
      .post('/api/stacks/myapp/deploy')
      .set('Cookie', authCookie);

    expect(res.status).toBe(500);
    expect(res.body.failure).toMatchObject({ reason: 'port_conflict' });
    expect(typeof res.body.failure.label).toBe('string');
    expect(typeof res.body.failure.suggestion).toBe('string');
  });

  it('classifies a failed update and includes failure in the body', async () => {
    mockUpdateStack.mockRejectedValue(
      new Error('pull access denied for private/app, repository does not exist'),
    );

    const res = await request(app)
      .post('/api/stacks/myapp/update')
      .set('Cookie', authCookie);

    expect(res.status).toBe(500);
    expect(res.body.failure).toMatchObject({ reason: 'image_pull_failed' });
  });

  it('classifies the underlying cause when the update was rolled back', async () => {
    mockUpdateStack.mockRejectedValue(
      new ComposeRollbackError(
        new Error('dependency failed to start: container app-db-1 is unhealthy'),
        true,
        true,
      ),
    );

    const res = await request(app)
      .post('/api/stacks/myapp/update')
      .set('Cookie', authCookie);

    expect(res.status).toBe(500);
    expect(res.body).toMatchObject({
      rolledBack: true,
      failure: { reason: 'healthcheck_failed' },
    });
  });

  it('falls back to unknown for unrecognized failures', async () => {
    mockDeployStack.mockRejectedValue(new Error('weird one-off explosion'));

    const res = await request(app)
      .post('/api/stacks/myapp/deploy')
      .set('Cookie', authCookie);

    expect(res.status).toBe(500);
    expect(res.body.failure.reason).toBe('unknown');
  });
});

describe('post-deploy scan opt-out', () => {
  it('does not trigger a post-deploy scan when skip_scan is true', async () => {
    mockDeployStack.mockResolvedValue(undefined);

    const res = await request(app)
      .post('/api/stacks/myapp/deploy')
      .set('Cookie', authCookie)
      .send({ skip_scan: true });

    expect(res.status).toBe(200);
    await new Promise(resolve => setImmediate(resolve));

    expect(mockListContainers).not.toHaveBeenCalled();
    expect(mockRunScanAndPersist).not.toHaveBeenCalled();
  });
});

describe('deploy_failure notification on /down error', () => {
  it('dispatches deploy_failure alert when runCommand (down) throws', async () => {
    mockRunCommand.mockRejectedValue(new Error('container removal error'));

    const res = await request(app)
      .post('/api/stacks/myapp/down')
      .set('Cookie', authCookie);

    expect(res.status).toBe(500);

    await new Promise(resolve => setImmediate(resolve));

    expect(dispatchAlertSpy).toHaveBeenCalledWith(
      'error',
      'deploy_failure',
      expect.any(String),
      { stackName: 'myapp', actor: 'testadmin' },
    );
  });
});

describe('deploy_failure notification on /restart error', () => {
  it('dispatches deploy_failure alert when restartContainer throws', async () => {
    mockGetContainersByStack.mockResolvedValue([{ Id: 'c1', Service: 'web' }]);
    mockRestartContainer.mockRejectedValue(new Error('restart daemon error'));

    const res = await request(app)
      .post('/api/stacks/myapp/restart')
      .set('Cookie', authCookie);

    expect(res.status).toBe(500);

    await new Promise(resolve => setImmediate(resolve));

    expect(dispatchAlertSpy).toHaveBeenCalledWith(
      'error',
      'deploy_failure',
      expect.stringContaining('restart daemon error'),
      { stackName: 'myapp', actor: 'testadmin' },
    );
  });
});

describe('deploy_failure notification on /stop error', () => {
  it('dispatches deploy_failure alert when stopContainer throws', async () => {
    mockGetContainersByStack.mockResolvedValue([{ Id: 'c1', Service: 'web' }]);
    mockStopContainer.mockRejectedValue(new Error('stop daemon error'));

    const res = await request(app)
      .post('/api/stacks/myapp/stop')
      .set('Cookie', authCookie);

    expect(res.status).toBe(500);

    await new Promise(resolve => setImmediate(resolve));

    expect(dispatchAlertSpy).toHaveBeenCalledWith(
      'error',
      'deploy_failure',
      expect.stringContaining('stop daemon error'),
      { stackName: 'myapp', actor: 'testadmin' },
    );
  });
});

describe('deploy_failure notification on /update error', () => {
  it('dispatches deploy_failure alert with correct stackName when updateStack throws', async () => {
    mockUpdateStack.mockRejectedValue(new Error('image not found'));

    const res = await request(app)
      .post('/api/stacks/myapp/update')
      .set('Cookie', authCookie);

    expect(res.status).toBe(500);

    await new Promise(resolve => setImmediate(resolve));

    expect(dispatchAlertSpy).toHaveBeenCalledWith(
      'error',
      'deploy_failure',
      expect.stringContaining('image not found'),
      { stackName: 'myapp', actor: 'testadmin' },
    );
  });

  it('returns rollback completion status when updateStack throws rollback metadata', async () => {
    mockUpdateStack.mockRejectedValue(
      new ComposeRollbackError(new Error('image not found'), true, false),
    );

    const res = await request(app)
      .post('/api/stacks/myapp/update')
      .set('Cookie', authCookie);

    expect(res.status).toBe(500);
    expect(res.body).toMatchObject({ rolledBack: false });
  });

  it('uses trusted proxy tier headers for remote atomic updates', async () => {
    mockUpdateStack.mockResolvedValue(undefined);
    const token = jwt.sign({ scope: 'node_proxy' }, TEST_JWT_SECRET, { expiresIn: '1m' });

    const res = await request(app)
      .post('/api/stacks/myapp/update')
      .set('Authorization', `Bearer ${token}`)
      .set('x-sencho-tier', 'paid');

    expect(res.status).toBe(200);
    expect(mockUpdateStack.mock.calls[0][2]).toBe(true);
  });
});

describe('rollback file-revert safety on a policy-blocked rollback', () => {
  it('does not deploy and alerts the operator when the post-block file revert fails', async () => {
    // The restored backup is blocked by policy after files were already restored.
    const gateSpy = vi
      .spyOn(policyGate, 'runPolicyGate')
      .mockImplementation(async (_req, res) => {
        res.status(409).json({ error: 'Rollback blocked by policy' });
        return false;
      });
    // The revert that should undo the restore itself fails (e.g. EACCES on a
    // chowned bind mount), leaving disk inconsistent with the deployed stack.
    mockSnapshotStackFiles.mockResolvedValue(async () => {
      throw Object.assign(new Error('EACCES: permission denied'), { code: 'EACCES' });
    });
    try {
      const res = await request(app)
        .post('/api/stacks/myapp/rollback')
        .set('Cookie', authCookie);

      expect(res.status).toBe(409);
      // The rollback must not have deployed the blocked target.
      expect(mockDeployStack).not.toHaveBeenCalled();
      await new Promise(resolve => setImmediate(resolve));
      // The revert failure is escalated on the persistent alert feed.
      expect(dispatchAlertSpy).toHaveBeenCalledWith(
        'error',
        'deploy_failure',
        expect.stringContaining('EACCES'),
        { stackName: 'myapp', actor: 'testadmin' },
      );
    } finally {
      gateSpy.mockRestore();
    }
  });

  it('reverts cleanly and stays quiet when the policy block revert succeeds', async () => {
    const revert = vi.fn().mockResolvedValue(undefined);
    const gateSpy = vi
      .spyOn(policyGate, 'runPolicyGate')
      .mockImplementation(async (_req, res) => {
        res.status(409).json({ error: 'Rollback blocked by policy' });
        return false;
      });
    mockSnapshotStackFiles.mockResolvedValue(revert);
    try {
      const res = await request(app)
        .post('/api/stacks/myapp/rollback')
        .set('Cookie', authCookie);

      expect(res.status).toBe(409);
      expect(revert).toHaveBeenCalledTimes(1);
      expect(mockDeployStack).not.toHaveBeenCalled();
      await new Promise(resolve => setImmediate(resolve));
      expect(dispatchAlertSpy).not.toHaveBeenCalled();
    } finally {
      gateSpy.mockRestore();
    }
  });
});