mirror of
https://github.com/Studio-Saelix/sencho.git
synced 2026-08-27 10:46:51 +00:00
Anso
8980910153
* feat: add node-scoped Networking operator page Adds a Networking view with overview, topology, inventory, and findings. Shared aggregate reads back the page; Resources keeps prune and redirects here. Includes fail-closed network delete guards, operator docs, and /nodes/:slug/networking routing. * fix: rename unused variable n to _n to satisfy no-unused-vars lint * fix: keep top bar search clickable when nav grows * feat: complete Compose-first Networking Phase 2 operator assistant * fix: move networking action visibility helper out of component module * feat(networking): complete Compose-first Networking operator page Finish the node-scoped Networking page (Overview, Networks, Topology, Findings) with design-system parity and correct finding semantics. - Rebuild detail sheets on SystemSheet/SheetSection; align the tab band, masthead, and mobile tone with Fleet and Security. - Encode the host-mode and exposure severity matrix; fix collision counts so intentional shared externals are not flagged; add one typed drift predicate shared by inventory, topology, badges, and overview counts. - Preserve per-container attachments and IPs on topology node clicks; drawer-only click with an explicit logs action; ownership and boolean filters; bound large graphs before layout. - Aggregate cached Compose Doctor findings into the Findings tab with honest source labels, structural merge and dedupe, staleness reconciliation, and a shared exposure-context helper both engines use. - Networks tab: privacy-safe service search, precise ownership counts, schema v3 with version-2 adapters on every endpoint, pre-confirm delete reasons, and the shared sortable table with an internal scroll region. - Interop: Fleet node-card networking signal with pending-intent navigation, stack-to-node backlink, and Dossier/Drift deep links. - Enrich sanitized inspect with an allowlisted connected-container list; fetch topology once and filter client-side. - Docs and tests across every new finding kind, adapter, and flow. * fix(networking): correct drift count, exposure fail-soft, and inspect crash paths Address code-review findings on the Networking page implementation: - Fix the Overview drift count to use the shared drift-kind predicate instead of a hardcoded list that omitted external-network-missing. - Gate Compose Doctor's unclassified-exposure and reverse-proxy-undocumented rules on exposure-context availability, so a DB read failure no longer fabricates findings (mirrors the live engine's existing fail-soft behavior). - Guard the per-stack exposure-intent read in topology aggregation so a transient DB failure degrades to unknown intent instead of failing the whole response. - Harden the network detail drawer against a partial inspect payload from an older remote node, and log the real error instead of a bare catch. - Remove now-duplicated severity-rank and drift-kind helpers in favor of the shared modules; drop dead backend-only exports; widen the frontend schema version type to a plain number instead of casting past a literal type. - Add coverage for the delete-guard precedence, the full host-mode severity matrix, the schema-2 compatibility adapter, and the sanitized connected- container allowlist; tighten two tests that were not exercising the behavior they claimed to. * fix: add missing onOpenNodeNetworking prop to FleetView experimental test The added required prop on FleetViewProps broke the merge-build when the test file (on main but not on this branch) was compiled against the updated FleetView interface.
39 lines
1.8 KiB
TypeScript
39 lines
1.8 KiB
TypeScript
import { describe, it, expect } from 'vitest';
|
|
import { MOBILE_TREATMENTS, BESPOKE_MOBILE_VIEWS, type MobileTreatment } from './mobile-treatments';
|
|
|
|
const VALID: MobileTreatment[] = ['bespoke', 'responsive', 'desktop-only', 'detail'];
|
|
|
|
describe('mobile treatments', () => {
|
|
it('classifies every view with a known treatment', () => {
|
|
// The Record<ActiveView, MobileTreatment> type already forces every view to
|
|
// be present at compile time; this guards the values at runtime so a typo or
|
|
// a bad merge cannot leave an unknown treatment in the map.
|
|
for (const [view, treatment] of Object.entries(MOBILE_TREATMENTS)) {
|
|
expect(VALID, `${view} has an unknown treatment "${treatment}"`).toContain(treatment);
|
|
}
|
|
});
|
|
|
|
it('treats the Security view as a bespoke masthead-led phone screen', () => {
|
|
expect(MOBILE_TREATMENTS.security).toBe('bespoke');
|
|
});
|
|
|
|
it('keeps BESPOKE_MOBILE_VIEWS in lockstep with the bespoke treatments', () => {
|
|
const declaredBespoke = Object.entries(MOBILE_TREATMENTS)
|
|
.filter(([, treatment]) => treatment === 'bespoke')
|
|
.map(([view]) => view)
|
|
.sort();
|
|
expect([...BESPOKE_MOBILE_VIEWS].sort()).toEqual(declaredBespoke);
|
|
});
|
|
|
|
it('pins the set of bespoke phone screens (update deliberately when adding one)', () => {
|
|
// A change here means a top-level view gained or lost a bespoke phone screen.
|
|
// Updating this list should go hand in hand with wiring the screen's case in
|
|
// EditorLayout's renderMobileBespoke (a dedicated component under
|
|
// components/mobile/, or a masthead-led mobile branch of the desktop view as
|
|
// Security does).
|
|
expect([...BESPOKE_MOBILE_VIEWS].sort()).toEqual(
|
|
['audit-log', 'auto-updates', 'dashboard', 'fleet', 'global-observability', 'networking', 'resources', 'scheduled-ops', 'security', 'settings', 'templates'],
|
|
);
|
|
});
|
|
});
|