Files
sencho/backend/src/__tests__/database-stack-cleanup-intent-migration.test.ts
T
Anso 17a8dc8a94 fix(blueprints): fail closed on marker ownership for apply and withdraw (#1694)
* fix(blueprints): fail closed on marker ownership for apply and withdraw

Require a matching .blueprint.json under the stack lock, persist required_blueprint_id on deletion intents, remove the legacy remote apply fallback, and protect the marker in the file explorer.

* fix(blueprints): add CodeQL path barriers on ownership probes

Use the canonical resolve-and-startsWith sanitizer inline at the marker and stack-directory fs sinks so js/path-injection clears.

* fix(blueprints): block delete on failed withdraw and defer marker write

Refuse Blueprint DELETE when pre-delete withdraw does not complete, and write .blueprint.json only after a successful deploy so failed applies cannot orphan stacks or claim an unapplied revision.

* test(blueprints): align lock-order assert with deferred marker write

Update the per-stack lock ordering expectations to compose, cleanup, deploy, then marker after the partial-apply fix.

* fix(deps): bump postcss past GHSA-r28c-9q8g-f849 for npm audit

Raise the Vitest/Vite transitive postcss to 8.5.23 so Backend CI audit --audit-level=high passes.
2026-07-24 15:57:18 -04:00

65 lines
2.2 KiB
TypeScript

/**
* Legacy installations upgrade stack_update_cleanup_pending with nullable
* required_blueprint_id via maybeAddCol.
*/
import { describe, it, expect, beforeAll, afterAll } from 'vitest';
import { setupTestDb, cleanupTestDb } from './helpers/setupTestDb';
let tmpDir: string;
let DatabaseService: typeof import('../services/DatabaseService').DatabaseService;
beforeAll(async () => {
tmpDir = await setupTestDb();
({ DatabaseService } = await import('../services/DatabaseService'));
});
afterAll(() => cleanupTestDb(tmpDir));
describe('stack_update_cleanup_pending required_blueprint_id migration', () => {
it('upgrades a legacy table without the column and preserves null for old rows', () => {
const db = DatabaseService.getInstance();
const raw = db.getDb();
// Simulate a pre-migration installation: drop the column if present, then
// re-add it the same way initSchema's maybeAddCol does.
try {
raw.exec('ALTER TABLE stack_update_cleanup_pending DROP COLUMN required_blueprint_id');
} catch {
// Column may already be absent in a hand-built fixture.
}
const now = Date.now();
raw.prepare(`
INSERT INTO stack_update_cleanup_pending (
id, node_id, stack_name, status, target_kind, rollback_tags_json,
override_paths_json, prune_volumes_requested, created_at, updated_at
) VALUES (?, ?, ?, 'prepared', 'local_socket', '[]', '[]', 0, ?, ?)
`).run('legacy-1', 1, 'legacy-stack', now, now);
try {
raw.exec('ALTER TABLE stack_update_cleanup_pending ADD COLUMN required_blueprint_id INTEGER');
} catch {
// Idempotent if a parallel path re-added it.
}
const legacy = db.getCleanupPending('legacy-1');
expect(legacy).toBeDefined();
expect(legacy?.required_blueprint_id ?? null).toBeNull();
db.insertCleanupPending({
id: 'owned-1',
node_id: 2,
stack_name: 'bp-stack',
status: 'prepared',
target_kind: 'local_socket',
rollback_tags_json: '[]',
override_paths_json: '[]',
prune_volumes_requested: 0,
required_blueprint_id: 42,
created_at: now,
updated_at: now,
});
expect(db.getCleanupPending('owned-1')?.required_blueprint_id).toBe(42);
});
});