mirror of
https://github.com/Studio-Saelix/sencho.git
synced 2026-07-29 05:09:10 +00:00
2e0f3e2711
- Reject node_proxy scoped JWT tokens with 403 on host-console and container exec (/ws) upgrades; machine-to-machine credentials must not open interactive shells - Validate stackParam against path.resolve + startsWith(baseDir) to prevent directory traversal on the PTY cwd (Rule 9 pattern) - Strip JWT_SECRET, AUTH_PASSWORD, AUTH_PASSWORD_HASH, DATABASE_URL from the environment passed to node-pty spawned shells
67 lines
2.2 KiB
TypeScript
67 lines
2.2 KiB
TypeScript
import * as os from 'os';
|
|
import * as pty from 'node-pty';
|
|
import { WebSocket } from 'ws';
|
|
import { execSync } from 'child_process';
|
|
|
|
function getUnixShell() {
|
|
try {
|
|
execSync('which bash', { stdio: 'ignore' });
|
|
return 'bash';
|
|
} catch {
|
|
return 'sh';
|
|
}
|
|
}
|
|
|
|
export class HostTerminalService {
|
|
static spawnTerminal(ws: WebSocket, targetDirectory: string) {
|
|
const shell = os.platform() === 'win32' ? 'powershell.exe' : getUnixShell();
|
|
|
|
// Strip sensitive backend secrets from the PTY environment so they are not
|
|
// visible to the console user via `env` / `printenv`.
|
|
const SENSITIVE_KEYS = ['JWT_SECRET', 'AUTH_PASSWORD', 'AUTH_PASSWORD_HASH', 'DATABASE_URL'];
|
|
const safeEnv = Object.fromEntries(
|
|
Object.entries(process.env as Record<string, string>).filter(([k]) => !SENSITIVE_KEYS.includes(k))
|
|
);
|
|
|
|
const ptyProcess = pty.spawn(shell, [], {
|
|
name: 'xterm-color',
|
|
cols: 80,
|
|
rows: 30,
|
|
cwd: targetDirectory,
|
|
env: safeEnv,
|
|
});
|
|
|
|
ptyProcess.onData((data) => {
|
|
if (ws.readyState === WebSocket.OPEN) {
|
|
ws.send(data); // Raw-Down protocol
|
|
}
|
|
});
|
|
|
|
ws.on('message', (message: string) => {
|
|
try {
|
|
const parsed = JSON.parse(message); // JSON-Up protocol
|
|
if (parsed.type === 'input') {
|
|
ptyProcess.write(parsed.payload);
|
|
} else if (parsed.type === 'resize') {
|
|
ptyProcess.resize(parsed.cols, parsed.rows);
|
|
}
|
|
} catch (e) {
|
|
console.error('Failed to parse Host terminal message:', e);
|
|
}
|
|
});
|
|
|
|
ws.on('close', () => {
|
|
console.log('Host terminal WebSocket closed, cleaning up PTY process');
|
|
ptyProcess.kill();
|
|
});
|
|
|
|
// Handle PTY process exit
|
|
ptyProcess.onExit(({ exitCode, signal }) => {
|
|
console.log(`Host terminal PTY process exited with code ${exitCode} and signal ${signal}`);
|
|
if (ws.readyState === WebSocket.OPEN) {
|
|
ws.close();
|
|
}
|
|
});
|
|
}
|
|
}
|