mirror of
https://github.com/Studio-Saelix/sencho.git
synced 2026-08-06 00:47:52 +00:00
SaelixCode
f7471a1a18
- Fix rate limiter to allow 100 attempts in dev mode so E2E tests are not blocked by failed-login attempts during test development - Simplify logout button selector to use Lucide icon class (lucide-log-out) instead of the fragile Tooltip-content locator chain that broke on navigation - Rewrite stacks E2E spec: use waitForFunction to wait for sidebar to load, delete leftover stacks via browser-context fetch before creating, and use page.reload() to get a clean sidebar state - Fix AlertDialogContent: remove asChild+motion.div pattern that triggered a React.Children.only crash — Radix AlertDialog.Content injects a second DescriptionWarning child internally, breaking Slot when asChild=true; replace with CSS keyframe animations (data-[state=open]:animate-in) - Fix final assertion in delete test to use exact text + listbox scope to avoid false positives from similarly-named stacks like e2e-test-stack-* - All 6 E2E tests pass (4 auth + 2 stacks); node tests skip gracefully
84 lines
3.3 KiB
TypeScript
84 lines
3.3 KiB
TypeScript
/**
|
|
* Stack management E2E tests — happy path CRUD.
|
|
*/
|
|
import { test, expect } from '@playwright/test';
|
|
import { loginAs, TEST_USERNAME, TEST_PASSWORD } from './helpers';
|
|
|
|
const TEST_STACK = 'e2e-test-stack';
|
|
|
|
/** Wait for stacks to load in the sidebar (uses /api/stacks via the browser context). */
|
|
async function waitForStacksLoaded(page: import('@playwright/test').Page) {
|
|
// Poll until the stacks API returns data AND the sidebar has at least one item
|
|
await page.waitForFunction(() => {
|
|
const items = document.querySelectorAll('[cmdk-item]');
|
|
return items.length > 0;
|
|
}, { timeout: 15_000 });
|
|
}
|
|
|
|
/** Delete the test stack via the browser's authenticated fetch (so cookies are included). */
|
|
async function deleteTestStackViaApi(page: import('@playwright/test').Page) {
|
|
await page.evaluate(async (name) => {
|
|
await fetch(`/api/stacks/${name}`, { method: 'DELETE', credentials: 'include' }).catch(() => {});
|
|
}, TEST_STACK);
|
|
}
|
|
|
|
test.describe('Stack management', () => {
|
|
test.beforeEach(async ({ page }) => {
|
|
await loginAs(page);
|
|
await waitForStacksLoaded(page);
|
|
});
|
|
|
|
test('create a new stack', async ({ page }) => {
|
|
// Remove leftover from prior runs (using browser context auth)
|
|
await deleteTestStackViaApi(page);
|
|
await page.waitForTimeout(500);
|
|
|
|
// Reload to get a fresh sidebar without the deleted stack
|
|
await page.reload();
|
|
await loginAs(page); // may re-login if cookie expired, otherwise skips to dashboard
|
|
await waitForStacksLoaded(page);
|
|
|
|
await page.getByRole('button', { name: 'Create Stack' }).click();
|
|
await expect(page.getByRole('dialog')).toBeVisible({ timeout: 5_000 });
|
|
|
|
await page.locator('#create-stack-name').fill(TEST_STACK);
|
|
await page.locator('[role="dialog"]').getByRole('button', { name: 'Create' }).click();
|
|
|
|
// Wait for dialog to close (success) or error message to appear (failure)
|
|
await Promise.race([
|
|
page.getByRole('dialog').waitFor({ state: 'hidden', timeout: 8_000 }),
|
|
page.getByText(/already exists/i).waitFor({ state: 'visible', timeout: 8_000 }),
|
|
]).catch(() => {});
|
|
|
|
// The stack should now exist — refresh and verify via the sidebar
|
|
await page.reload();
|
|
await loginAs(page);
|
|
await waitForStacksLoaded(page);
|
|
|
|
await expect(page.getByText(TEST_STACK).first()).toBeVisible({ timeout: 5_000 });
|
|
});
|
|
|
|
test('delete the test stack', async ({ page }) => {
|
|
// Confirm the stack exists in the sidebar
|
|
await expect(page.getByText(TEST_STACK).first()).toBeVisible({ timeout: 5_000 });
|
|
|
|
// Click on the stack to open the editor
|
|
await page.getByText(TEST_STACK).first().click();
|
|
|
|
// The toolbar Delete button has the Lucide Trash2 icon
|
|
const deleteBtn = page.locator('button:has(.lucide-trash-2)');
|
|
await expect(deleteBtn).toBeVisible({ timeout: 10_000 });
|
|
await deleteBtn.click();
|
|
|
|
// AlertDialog confirmation
|
|
await expect(page.getByRole('alertdialog')).toBeVisible({ timeout: 5_000 });
|
|
await page.getByRole('alertdialog').getByRole('button', { name: 'Delete' }).click();
|
|
|
|
// Stack should no longer appear in the sidebar (exact match to avoid false positives from
|
|
// similarly-named stacks; scoped to the CommandList)
|
|
await expect(
|
|
page.locator('[role="listbox"]').getByText(TEST_STACK, { exact: true })
|
|
).not.toBeVisible({ timeout: 8_000 });
|
|
});
|
|
});
|