4 Commits

Author	SHA1	Message	Date
Anso	117f590332	fix(security): gate admin-only scan affordances on isAdmin (#1230) ... * fix(security): gate admin-only scan affordances on isAdmin Backend already required admin for SBOM, SARIF, scan policies, Trivy install/update/uninstall, the auto-update toggle, CVE suppressions, and misconfig acknowledgements. The matching frontend surfaces were gated only on isPaid (or only on isReplica), so non-admin users at the same tier saw buttons that returned 403 on click. Threads isAdmin from useAuth() into SecuritySection, SuppressionsPanel, and MisconfigAckPanel. Updates the scan-result sheet caller in ResourcesView so SBOM and SARIF render only when paid AND admin; passes canManageSuppressions to the stack-misconfig sheet so admins can ack misconfigs from that surface too. Read paths remain visible to non-admins (policy list, suppression list, ack list, scan history) since the GET routes are auth-only on both sides. * fix(security): close 3 remaining scan-sheet parity gaps from review Code review surfaced three sites missed in the first pass: 1. SecurityHistoryView opened the scan sheet with canGenerateSbom set only on isPaid, so Skipper non-admins saw SBOM and SARIF buttons even though the backend requires admin+paid. Now ANDed with isAdmin. 2. ResourcesView passed onRescan unconditionally, and the sheet renders a Re-scan primary action whenever onRescan is defined. Non-admins reaching the sheet via the severity-badge shortcut saw the button; clicking it called POST /security/scan, which the backend requires admin for. onRescan is now undefined for non-admins. 3. ShellOverlays and ResourcesView passed canManageSuppressions=isAdmin without considering the replica gate, so a replica admin saw suppress and ack columns whose backend writes blockIfReplica. The sheet now probes /fleet/role internally and ANDs !isReplica into the effective canManageSuppressions, so the column hides on a replica regardless of how the caller wired the prop. * fix(security): clear isReplica state on every scan-sheet probe The previous probe only flipped the state to true on a replica response and never wrote false on a control, non-OK, or skipped probe. With the sheet kept mounted by ResourcesView, SecurityHistoryView, and ShellOverlays, an admin who first viewed a scan on a replica would keep suppress/ack controls hidden even after switching to a control instance, because the stale true value persisted across re-opens. The effect now resets isReplica to false at the start of every probe and assigns the result of /fleet/role directly. Probe failures and skips leave the state at false, so the UI is permissive and the backend blockIfReplica guard remains the source of truth.	2026-05-25 18:33:04 -04:00
Anso	7c84969b31	fix(editor): harden save-deploy, node-switch, delete, and stats reactivity (#1188) ... * fix(stacks): validate input, bound YAML parses, and reorder delete steps Backend hardening covering three editor-served routes: - `/:stackName/containers` GET adds an explicit `isValidStackName` guard so bad input is rejected at the call site even if the router-level param validator changes in future. - `MAX_COMPOSE_PARSE_BYTES` (1 MiB) bounds the two `YAML.parse` callsites (`resolveAllEnvFilePaths`, `/services`) so a malformed or oversize compose cannot exhaust heap during routine env/service lookups. - `DELETE /:stackName` is reordered to abort before any database cleanup if `FileSystemService.deleteStack` throws, keeping DB and FS in sync. Partial-failure responses now describe the resulting state in human terms instead of returning a generic 500. Adds debug-mode entry-point traces (`[Stacks:debug] ...`) on save / down / restart / delete handlers, all sanitised through `sanitizeForLog`. New vitest covers the containers validator, the YAML size guard, and the small-compose happy path. * fix(editor): gate save-and-deploy on save success, abort stale loads `saveFile` now returns a boolean: true on a successful PUT, false on any failure. `handleSaveAndDeploy` short-circuits when save fails so a backend 500 on the compose write no longer slips through to a deploy with the unsaved in-memory content. The diff-preview confirm path in ShellOverlays applies the same guard. `loadFile` now drives a per-hook `AbortController`. A stack switch, a node switch (via `resetEditorState`), or hook unmount aborts the in-flight GET chain so a late compose / env / containers / backup response from the previous selection never overwrites freshly-loaded state. `hasUnsavedChanges` is exported so EditorLayout can check it during the node-switch lifecycle. New unit tests cover the boolean save contract and the save-fail-blocks-deploy invariant. * fix(editor): prompt on node switch when the editor has unsaved changes Switching the active node previously called `resetEditorState()` without checking the editor's dirty state, silently dropping in-progress edits. The post-auth shell now intercepts the node-change effect: if the editor is dirty, the attempted node is stashed via the existing `pendingUnsavedNode` field, `pendingUnsavedLoad` is set to a sentinel that routes `discardAndLoadPending` to `setActiveNode`, and `activeNode` is reverted to the previous node so the dialog can be resolved without losing content. A re-entrant switch (clicking a third node while the dialog is still open) is now ignored — the second switch reverts silently so the dialog's anchor stays on the first attempt. When the previous node is no longer in the registry and cannot be reverted to, the operator gets a warning toast before the wipe so the loss is at least visible. * fix(editor): split delete and deploy permission gates in the action bar The action bar previously wrapped every affordance — including the Delete menu item — in a single `can('stack:deploy')` check, even though the backend route requires `stack:delete`. A user with `stack:deploy` only saw a Delete button that 403'd, and a user with `stack:delete` only saw no menu at all. Each affordance now renders against its own permission: deploy / stop / restart / update on `stack:deploy`, delete on `stack:delete`, rollback on `canDeploy + isPaid + backupInfo.exists`, scan on `isAdmin + trivy.available`. The overflow menu appears if any of {rollback, scan, delete} is granted, so a delete-only operator still has a way to remove the stack. Adds a Monaco model dispose on EditorView unmount via the existing editor ref, and a compact `Stats unavailable` chip in the CONTAINERS header that lights up when the live-stats WebSocket reports a persistent failure. * fix(editor): make container-stats hook reactive to the active node `useContainerStats` previously read the active node id from `localStorage` on each WebSocket open, with a deps array of `[containers]` only. After a node switch the stats stream stayed pointed at the previous node's `/ws` endpoint until the containers array refreshed. The hook now accepts `activeNodeId` as a second argument, depends on `[containers, activeNodeId]`, and drops the localStorage read. The return shape is `{ stats, error }`: the error field carries a string when the stream fails, surfaced by EditorView as a small chip in the CONTAINERS header. A per-WS `warnedOnce` set ensures a flaky daemon emits at most one console.warn per stream lifetime, never at message rate. Close codes 1000 / 1001 stay silent (normal teardown, navigation). The error reset (`setError(null)`) is split into its own effect keyed on `activeNodeId` so the banner does not flap on every containers-array refresh tick against a persistently-flaky daemon. Tests cover the new shape, the node-id reactivity, and the abnormal-close warn behaviour. * docs(editor): describe new gate split and add troubleshooting entries Updates the editor cockpit page to reflect that the action bar now gates each affordance on its own permission (deploy / delete), and that the bar appears for delete-only users so a stack can still be removed. Adds three troubleshooting accordions covering the new behaviours: a failed save that blocks the subsequent deploy, the unsaved-changes prompt on node switch, and the live-stats chip when the daemon is unreachable. Adds an E2E spec verifying that a forced PUT 500 on the compose write surfaces the failure toast and prevents the deploy POST from firing. * fix(stacks): use printf-style format for compose-down warn `console.warn` treats arg-1 as a printf format string when subsequent args follow. The template literal here interpolated a sanitized but not %-escaped stackName into arg-1 alongside an error argument, so a stackName containing a `%s` placeholder could theoretically swallow the error in the substitution. Switch to the file's established `'... %s ...', value, err` pattern. * test(editor): fix save-deploy spec; click both edit buttons, drop Monaco fill The editor has two edit affordances: a lowercase 'edit' in the Anatomy panel header that swaps the right column to the editor tabs, and a capital 'Edit' in the editor toolbar that flips Monaco from read-only into edit mode. The spec previously matched both with a case-insensitive regex and only fired one click, so Monaco never entered edit mode. It also tried to fill .monaco-editor textarea — that element is Monaco's IME accessibility helper, hard-coded readonly; the real editable surface is a contenteditable div. `saveFile()` does not gate on a dirty buffer, so the spec does not need to modify Monaco at all. Click both edit buttons with case-anchored regexes and drop the fill step. * test(editor): disambiguate Save & Deploy locator from sidebar row The TEST_STACK fixture is named 'e2e-save-deploy-stack'. The sidebar renders each stack into a div with role=button whose accessible name includes the stack slug, so the regex /save.*deploy/i matches both the sidebar row ('e2e-save-deploy-stack') and the editor toolbar's actual Save & Deploy button — strict-mode bails. Anchor the locator to the literal button text with exact:true.	2026-05-24 15:18:47 -04:00
Anso	3ec0a45ff0	feat(frontend): SystemSheet §9.11 — security and scheduled sheets (PR 2/3) (#961) ... * feat(frontend): add SystemSheet primitive and migrate mesh sheets to §9.11 chrome DESIGN.md §9.11 codifies one canonical right-side detail-sheet shell (cyan rail, mono crumb, italic serif name, mono meta, ESC chip + close glyph, fixed three-slot toolbar, cyan-underline tabs, ScrollArea body, footer freshness band). Today the 16 sheet consumers each render their own header chrome with stock shadcn SheetHeader/SheetTitle. Introduce <SystemSheet> + <SheetSection> in frontend/src/components/ui/system-sheet.tsx, composing the existing <Sheet>/<SheetContent> primitive. Add a backward-compatible showClose prop to SheetContent so SystemSheet can render its own ESC chip + close glyph instead of the stock cyan square close. Migrate the four mesh sheets as the first batch: * MeshActivitySheet: crumb Fleet › Mesh › Activity, footer freshness from most-recent event timestamp. * MeshOptInSheet: crumb Fleet › Mesh › {nodeName}, meta of opted-in count, drops the redundant bottom Close button (ESC chip dismisses). * MeshDiagnosticsSheet: removes the icon-prefixed title (forbidden by §9.11), lifts Refresh/Restart buttons from the body into the toolbar band, three SheetSection blocks for sidecar status, streams, cache. * MeshRouteDetailSheet: adds Overview/Events/Raw tabs, lifts Test probe into the toolbar primary slot, footer surfaces last probe latency. * feat(frontend): migrate security and scheduled sheets to §9.11 chrome PR 2 of the System Sheet (§9.11) rollout, stacked on the SystemSheet primitive PR. Migrates six more sheet consumers and merges the Stack alert + auto-heal sheets into a single tabbed sheet per audit §17. Sheets migrated: * NodeUpdatesSheet: crumb Fleet > Updates, Recheck primary, Update-all secondary when applicable. Stat tiles and node rows lose their card-in-sheet wrapping (forbidden by §9.11) for flat dividers. * StackAlertSheet (now the merged stack monitor): tabs Alerts / Auto-heal, crumb Stack > {name} > Monitor. New initialTab prop lets callers open directly to either tab. Auto-heal tab is hidden entirely for Community-tier users (matches the existing tier-gating on the context menu trigger and keyboard shortcut). * StackAutoHealSheet.tsx: deleted. Its body became the Auto-heal tab inside the merged sheet. * VulnerabilityScanSheet: removed the icon-prefixed title (forbidden by §9.11). Re-scan, Compare, CSV, SARIF lifted from body cards into the toolbar band. Tabs Vulnerabilities | Secrets | Misconfigs (counts on the tab labels). SBOM dropdown stays in the body summary section pending a primitive enhancement for dropdown-attached toolbar actions. * ScanComparisonSheet: crumb Security > Scans > Compare, name Diff, meta with the +added/-removed delta. * SecurityHistoryView: the inner sheet only. Crumb Security > Scan history. Compare (paid + 2 selected) and Refresh in toolbar. * ScheduledOperationsView run-history sheet (lines ~847-935 only): crumb Schedules > {taskName} > Runs, Download CSV in toolbar, footer surfaces next-run timestamp. Hook refactor: * useOverlayState replaces three separate state vars (alertSheetOpen, alertSheetStack, autoHealStackName) with one stackMonitor object carrying { stackName, tab }. New helpers openAlertSheet(stackName), openAutoHeal(stackName), closeStackMonitor(). Tests rewritten and pass (11/11). * useSidebarContextMenu and ShellOverlays updated for the new API. The three other call sites (useStackMenuItems, useStackKeyboardShortcuts) already use openAlertSheet/openAutoHeal and need no change.	2026-05-06 23:19:16 -04:00
Anso	1cf996142b	refactor(frontend): EditorLayout final shell (B4-7) (#906) ... * refactor(frontend): extract useOverlayState hook from EditorLayout * refactor(frontend): extract useStackActions hook and wire useOverlayState into EditorLayout * refactor(frontend): fix quality issues in useStackActions post-review * fix(frontend): fix interval leak, RunResult contract, yml hardcode, and loadFile length in useStackActions * refactor(frontend): extract useSidebarContextMenu hook from EditorLayout * refactor(frontend): extract ShellOverlays component from EditorLayout * refactor(frontend): relocate Monaco layout effect and log-viewer event listener out of EditorLayout The Monaco tab-switch layout effect is now self-contained in EditorView, alongside its monacoEditorRef. The SENCHO_OPEN_LOGS_EVENT listener moves into useOverlayState, where openLogViewer lives. EditorLayout is left with the two coordination effects that depend on cross-hook state.	2026-05-04 07:43:02 -04:00