feat(notifications): deep-link bell rows to source stack and container logs (#692)

Add stack_name and container_name columns to notification_history so bell
rows can act as jump points. Producers (AutoHeal, Docker events) pass the
container context through dispatchAlert; the panel renders routable rows
as buttons that load the target stack and, when a container name is
present, open its logs modal. Non-structural notifications stay as
passive display rows.
This commit is contained in:
Anso
2026-04-19 03:56:59 -04:00
committed by GitHub
parent 7c01906e70
commit ed2a16af79
9 changed files with 165 additions and 28 deletions
@@ -121,6 +121,7 @@ describe('DockerEventService - die classification', () => {
'error',
expect.stringContaining('Container Crash Detected'),
undefined,
'web',
);
});
@@ -188,6 +189,7 @@ describe('DockerEventService - die classification', () => {
'error',
expect.stringContaining('OOM Kill'),
undefined,
'hog',
);
});
@@ -220,6 +222,7 @@ describe('DockerEventService - die classification', () => {
'error',
expect.stringContaining('Healthcheck failed'),
undefined,
'api',
);
});
@@ -314,6 +317,7 @@ describe('DockerEventService - malformed payloads', () => {
'error',
expect.stringContaining('Container Crash Detected'),
undefined,
'ok',
);
});
});
@@ -497,6 +501,7 @@ describe('DockerEventService - hardening', () => {
'error',
expect.stringContaining('Container Crash Detected'),
undefined,
'app',
);
});
@@ -550,6 +555,7 @@ describe('DockerEventService - hardening', () => {
'error',
expect.stringContaining('Container Crash Detected'),
undefined,
'ephemeral',
);
});
@@ -214,6 +214,23 @@ describe('NotificationService - routing logic', () => {
level: 'info',
message: 'Should be logged',
timestamp: expect.any(Number),
stack_name: undefined,
container_name: undefined,
});
});
it('persists stackName and containerName context on the history row', async () => {
mockGetEnabledNotificationRoutes.mockReturnValue([]);
mockGetEnabledAgents.mockReturnValue([]);
await svc.dispatchAlert('warning', 'Restarted', 'my-app', 'my-app-web-1');
expect(mockAddNotificationHistory).toHaveBeenCalledWith({
level: 'warning',
message: 'Restarted',
timestamp: expect.any(Number),
stack_name: 'my-app',
container_name: 'my-app-web-1',
});
});
+2
View File
@@ -244,6 +244,7 @@ export class AutoHealService {
'info',
`Auto-Heal: Restarted ${containerName} on stack ${policy.stack_name} after being unhealthy for ${policy.unhealthy_duration_mins} minute(s).`,
policy.stack_name,
containerName,
)
.catch(err => console.error('[AutoHeal] notification dispatch failed:', err));
} catch (err) {
@@ -267,6 +268,7 @@ export class AutoHealService {
'warning',
`Auto-Heal: Failed to restart ${containerName} on stack ${policy.stack_name}. Error: ${errorMsg}`,
policy.stack_name,
containerName,
)
.catch(e => console.error('[AutoHeal] notification dispatch failed:', e));
+30 -3
View File
@@ -199,6 +199,8 @@ export interface NotificationHistory {
timestamp: number;
is_read: boolean;
dispatch_error?: string;
stack_name?: string;
container_name?: string;
}
export interface FleetSnapshot {
@@ -444,6 +446,7 @@ export class DatabaseService {
this.migrateRegistries();
this.migrateRoleAssignments();
this.migrateNotificationRoutes();
this.migrateNotificationHistoryContext();
this.migrateScanPolicyFleetColumns();
this.migrateSecretMisconfigColumns();
}
@@ -1076,6 +1079,18 @@ export class DatabaseService {
try { this.db.prepare('ALTER TABLE notification_history ADD COLUMN dispatch_error TEXT').run(); } catch { /* already exists */ }
}
private migrateNotificationHistoryContext(): void {
const tryAddColumn = (col: string, def: string) => {
try {
this.db.prepare(`ALTER TABLE notification_history ADD COLUMN ${col} ${def}`).run();
} catch {
/* column already present */
}
};
tryAddColumn('stack_name', 'TEXT');
tryAddColumn('container_name', 'TEXT');
}
private migrateScanPolicyFleetColumns(): void {
const tryAddColumn = (table: string, col: string, def: string) => {
try {
@@ -1360,13 +1375,23 @@ export class DatabaseService {
const stmt = this.db.prepare('SELECT * FROM notification_history ORDER BY timestamp DESC LIMIT ?');
return stmt.all(limit).map((row: any) => ({
...row,
is_read: row.is_read === 1
is_read: row.is_read === 1,
stack_name: row.stack_name ?? undefined,
container_name: row.container_name ?? undefined,
}));
}
public addNotificationHistory(notification: Omit<NotificationHistory, 'id' | 'is_read'>): NotificationHistory {
const stmt = this.db.prepare('INSERT INTO notification_history (level, message, timestamp, is_read) VALUES (?, ?, ?, 0)');
const result = stmt.run(notification.level, notification.message, notification.timestamp);
const stmt = this.db.prepare(
'INSERT INTO notification_history (level, message, timestamp, is_read, stack_name, container_name) VALUES (?, ?, ?, 0, ?, ?)'
);
const result = stmt.run(
notification.level,
notification.message,
notification.timestamp,
notification.stack_name ?? null,
notification.container_name ?? null
);
this.db.exec(`
DELETE FROM notification_history
@@ -1381,6 +1406,8 @@ export class DatabaseService {
message: notification.message,
timestamp: notification.timestamp,
is_read: false,
stack_name: notification.stack_name,
container_name: notification.container_name,
};
}
+8 -7
View File
@@ -426,6 +426,7 @@ export class DockerEventService {
void this.emitError(
`Healthcheck failed: ${name} is unhealthy.`,
stackName,
state.name,
);
} else {
state.unhealthySince = undefined;
@@ -535,7 +536,7 @@ export class DockerEventService {
// rate-suppressed alerts don't silently lock out the next real crash.
if (state) state.lastCrashAlertAt = Date.now();
await this.emitError(message, info.stackName);
await this.emitError(message, info.stackName, info.name);
}
private isCrashAlertsEnabled(): boolean {
@@ -641,16 +642,16 @@ export class DockerEventService {
// Notification wrappers (prefix with node name for multi-node clarity)
// ========================================================================
private async emitError(message: string, stackName?: string): Promise<void> {
return this.notifier.dispatchAlert('error', this.prefix(message), stackName);
private async emitError(message: string, stackName?: string, containerName?: string): Promise<void> {
return this.notifier.dispatchAlert('error', this.prefix(message), stackName, containerName);
}
private async emitWarning(message: string, stackName?: string): Promise<void> {
return this.notifier.dispatchAlert('warning', this.prefix(message), stackName);
private async emitWarning(message: string, stackName?: string, containerName?: string): Promise<void> {
return this.notifier.dispatchAlert('warning', this.prefix(message), stackName, containerName);
}
private async emitInfo(message: string, stackName?: string): Promise<void> {
return this.notifier.dispatchAlert('info', this.prefix(message), stackName);
private async emitInfo(message: string, stackName?: string, containerName?: string): Promise<void> {
return this.notifier.dispatchAlert('info', this.prefix(message), stackName, containerName);
}
private prefix(message: string): string {
+9 -2
View File
@@ -39,12 +39,19 @@ export class NotificationService {
* - agents table (all tiers): global fallback channels used when no
* notification_routes match or when no stackName is provided.
*/
public async dispatchAlert(level: 'info' | 'warning' | 'error', message: string, stackName?: string) {
public async dispatchAlert(
level: 'info' | 'warning' | 'error',
message: string,
stackName?: string,
containerName?: string,
) {
// 1. Log to history and get the full inserted record (with id)
const notification = this.dbService.addNotificationHistory({
level,
message,
timestamp: Date.now()
timestamp: Date.now(),
stack_name: stackName,
container_name: containerName,
});
// 2. Push to connected browser clients via WebSocket