gsadmin/sencho
1
0
Fork 0
mirror of https://github.com/Studio-Saelix/sencho.git synced 2026-08-30 12:09:15 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(whats-new): add RBAC entry and a zoomable screenshot lightbox (#1806)

Browse Source 
RBAC is the largest capability change in this release, so it leads the
list. Every entry's screenshot now opens full-viewport on click; the
overlay is portaled to document.body so it isn't capped at the modal's
own frame, dismissible via backdrop click, a close button, or Escape.
This commit is contained in:
Anso
2026-08-09 19:24:23 -04:00
committed by GitHub
parent 88fc5470e8
commit e9901aa24b
4 changed files with 124 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
frontend/src/components/__tests__/WhatsNewModal.test.tsx
+44
View File
@@ -87,4 +87,48 @@ describe('WhatsNewModal', () => {
await userEvent.click(screen.getByRole('button', { name: 'View full changelog' }));
expect(onViewChangelog).toHaveBeenCalledTimes(1);
});
it('clicking a screenshot opens a zoomed overlay with the same image', async () => {
render(<WhatsNewModal open onOpenChange={vi.fn()} onViewChangelog={vi.fn()} />);
await userEvent.click(screen.getByRole('button', { name: 'Zoom in on Second feature screenshot' }));
const zoomed = screen.getByRole('dialog', { name: 'Zoomed screenshot' });
expect(zoomed.querySelector('img')).toHaveAttribute('src', '/whats-new/second.png');
});
it('the close button dismisses only the zoom overlay, leaving the parent modal open', async () => {
const onOpenChange = vi.fn();
render(<WhatsNewModal open onOpenChange={onOpenChange} onViewChangelog={vi.fn()} />);
await userEvent.click(screen.getByRole('button', { name: 'Zoom in on Second feature screenshot' }));
await userEvent.click(screen.getByRole('button', { name: 'Close zoomed screenshot' }));
expect(screen.queryByRole('dialog', { name: 'Zoomed screenshot' })).not.toBeInTheDocument();
// The regression this guards against: an earlier implementation portaled
// the overlay to document.body, outside Radix's Dialog content subtree,
// so Radix treated every zoom-dismiss click as an outside click and also
// closed the parent. If that regressed, onOpenChange(false) fires here.
expect(onOpenChange).not.toHaveBeenCalled();
expect(screen.getByRole('dialog', { name: "What's New" })).toBeInTheDocument();
});
it('clicking the backdrop dismisses only the zoom overlay, leaving the parent modal open', async () => {
const onOpenChange = vi.fn();
render(<WhatsNewModal open onOpenChange={onOpenChange} onViewChangelog={vi.fn()} />);
await userEvent.click(screen.getByRole('button', { name: 'Zoom in on Second feature screenshot' }));
await userEvent.click(screen.getByRole('dialog', { name: 'Zoomed screenshot' }));
expect(screen.queryByRole('dialog', { name: 'Zoomed screenshot' })).not.toBeInTheDocument();
expect(onOpenChange).not.toHaveBeenCalled();
expect(screen.getByRole('dialog', { name: "What's New" })).toBeInTheDocument();
});
it('Escape dismisses only the zoom overlay, leaving the parent modal open', async () => {
const onOpenChange = vi.fn();
render(<WhatsNewModal open onOpenChange={onOpenChange} onViewChangelog={vi.fn()} />);
await userEvent.click(screen.getByRole('button', { name: 'Zoom in on Second feature screenshot' }));
await userEvent.keyboard('{Escape}');
expect(screen.queryByRole('dialog', { name: 'Zoomed screenshot' })).not.toBeInTheDocument();
// Radix's own Escape handling for the parent Dialog is a document-level
// capture listener; without stopPropagation this fires too and also
// requests the parent close.
expect(onOpenChange).not.toHaveBeenCalled();
expect(screen.getByRole('dialog', { name: "What's New" })).toBeInTheDocument();
});
});