gsadmin/sencho
1
0
Fork 0
mirror of https://github.com/Studio-Saelix/sencho.git synced 2026-08-20 23:32:19 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: distinguish failed image-update checks from "up to date" (#1470)

Browse Source 
* fix: distinguish failed image-update checks from "up to date"

The image-update detector collapsed every failure (registry unreachable,
missing auth, rate limit, unresolved local digest) into hasUpdate:false and
dropped the captured reason, so a failed check was indistinguishable from a
current image and never raised a notification, even while a manual stack
update still pulled a newer image.

Detection now records a tri-state per stack (ok / partial / failed) with the
failure reason, exposed via a new GET /api/image-updates/detail (the boolean
GET / is unchanged so fleet aggregation is unaffected). A fully-failed check
preserves the last known has_update, so a transient outage neither erases a
real update nor flaps the notification state. The sidebar shows a muted
"couldn't check" indicator with the reason on hover, and the Update board
lists stacks whose check failed in a "could not be checked" advisory.

Detector hardening: the manifest digest lookup issues HEAD first (falling back
to GET) so it no longer draws down Docker Hub's anonymous pull-rate budget, and
local RepoDigest matching is normalized so official library/* images resolve
their digest instead of falling through to a silent "no update".

* fix: preserve confirmed updates through partial checks; tighten failure surfacing

Address review findings on the tri-state image-update detection:

- A partial check (some images errored) no longer erases a previously
  confirmed update; only a fully-ok check can lower has_update, so a single
  image's registry blip cannot drop the stack's update and re-fire the
  notification on recovery. Adds a regression test.
- The image-level catch stores getErrorMessage(e) rather than raw String(e),
  since that value surfaces verbatim in the sidebar tooltip and readiness
  advisory.
- useImageUpdates and the readiness detail fetch now log unexpected non-ok
  responses instead of silently leaving stale state.
- Remove an unused checkFailedCount derivation (the row indicator is driven by
  the checkStatus prop).
- Reword the recordStackCheckFailure docstring and the HEAD-first comment.
This commit is contained in:
Anso
2026-06-26 16:16:34 -04:00
committed by GitHub
parent e3b3c3b857
commit d9b7911f12
19 changed files with 820 additions and 38 deletions
Download Patch File Download Diff File Expand all files Collapse all files
frontend/src/types/imageUpdates.ts
+19
View File
@@ -23,3 +23,22 @@ export interface ImageUpdateStatus {
/** 5-field cron expression when mode is 'cron', null otherwise. */
cronExpression: string | null;
}
/**
* Per-stack image-update check outcome. 'ok' = every checkable image was
* reached; 'partial' = some checkable images errored; 'failed' = no checkable
* image could be reached, so update status is undeterminable (distinct from a
* confirmed "up to date").
*/
export type CheckStatus = 'ok' | 'partial' | 'failed';
/**
* Rich per-stack update status from `GET /api/image-updates/detail`. `lastError`
* carries the failure reason when `checkStatus` is 'failed' or 'partial'.
*/
export interface StackUpdateInfo {
hasUpdate: boolean;
checkStatus: CheckStatus;
lastError: string | null;
checkedAt: number;
}