fix: explain why a failed pre-deploy scan blocks a deploy (#1477)

When the pre-deploy gate could not scan or evaluate an image (a compose parse
error, a scan failure, an invalid image reference, or an evaluation error), it
pushed a synthetic violation with zero counts and no reason. The block dialog
then showed "0 critical, 0 high" with no explanation and only Close or admin
bypass, so an operator could not tell why the deploy was blocked or what to fix.

The synthetic violation now carries the failure reason in an error field, which
flows through the existing 409 block payload. The block dialog renders that
reason under a "Could not be scanned" label instead of a misleading zero-count
row, and shows a recovery hint pointing at the fix-and-deploy-again path.
This commit is contained in:
Anso
2026-06-26 19:13:47 -04:00
committed by GitHub
parent 000a592388
commit 628400ac19
4 changed files with 116 additions and 13 deletions
+14
View File
@@ -40,6 +40,14 @@ export interface PolicyViolation {
/** Which policy inputs matched (empty when the image could not be scanned). */
reasons: PolicyBlockReason[];
scanId: number;
/**
* Why the block is unactionable by policy: set when the gate blocked because
* the image could not be scanned or evaluated (compose parse error, scan
* failure, evaluation error), not because a policy input matched. Absent for
* a normal policy match. Lets the UI explain the failure instead of showing a
* zero-count block with no reason.
*/
error?: string;
}
export interface PolicyEnforcementOptions {
@@ -304,6 +312,7 @@ export async function enforcePolicyPreDeploy(
fixableCount: 0,
reasons: [],
scanId: 0,
error: `Compose file could not be parsed: ${message}`,
}],
};
}
@@ -356,6 +365,7 @@ export async function enforcePolicyForImageRefs(
fixableCount: 0,
reasons: [],
scanId: 0,
error: 'Invalid image reference; the image could not be scanned',
});
}
continue;
@@ -375,6 +385,7 @@ export async function enforcePolicyForImageRefs(
fixableCount: 0,
reasons: [],
scanId: 0,
error: `Pre-flight scan failed: ${message}`,
});
continue;
}
@@ -416,7 +427,10 @@ export async function enforcePolicyForImageRefs(
kevCount: 0,
fixableCount: 0,
reasons: [],
// The scan completed; only evaluation failed, so the real scan
// id is kept (the other failure sites have no scan and use 0).
scanId: scan.id,
error: `Policy evaluation failed: ${message}`,
});
}
}