From 60de0ddec281187dd9ac6790168551630ebeeb9f Mon Sep 17 00:00:00 2001
From: Anso <dev@saelix.com>
Date: Wed, 1 Jul 2026 02:54:22 -0400
Subject: [PATCH] fix(deploy-modal): hide frozen countdown label in inline
 feedback style (#1534)

In inline deploy feedback style, the auto-close countdown label
("closes in Xs") was visible but permanently frozen. canAutoClose
was already false in inline style (the banner owns the lifecycle),
but showCountdown was driven by !gateHoldsOpen, showing the label
even when no countdown timer could ever start.

Change showCountdown to canAutoClose so the label only appears
when the modal is actually eligible to auto-close (modal style,
succeeded, no observing gate). No gate contracts or modal-style
behavior change.

Adds regression tests: inline succeeded hides the label, modal
succeeded shows it.
---
 frontend/src/components/DeployFeedbackModal.tsx    |  4 ++--
 .../__tests__/DeployFeedbackModal.inline.test.tsx  | 14 ++++++++++++++
 2 files changed, 16 insertions(+), 2 deletions(-)

diff --git a/frontend/src/components/DeployFeedbackModal.tsx b/frontend/src/components/DeployFeedbackModal.tsx
index 225d2997..47e03b86 100644
--- a/frontend/src/components/DeployFeedbackModal.tsx
+++ b/frontend/src/components/DeployFeedbackModal.tsx
@@ -229,7 +229,7 @@ export function DeployFeedbackModal({ isMinimized, onMinimize }: DeployFeedbackM
               rowCount={logRows.length}
               errorMessage={errorMessage}
               countdown={countdown}
-              showCountdown={!gateHoldsOpen}
+              showCountdown={canAutoClose}
               gateStatus={healthGate?.status ?? null}
             />
             <Button
@@ -413,7 +413,7 @@ interface StatusIndicatorProps {
   rowCount: number;
   errorMessage?: string;
   countdown: number;
-  /** False while a health gate is observing or terminal-unhealthy (no auto-close). */
+  /** False when auto-close is not eligible: inline style, or while a gate is observing or terminal-unhealthy. */
   showCountdown: boolean;
   /** Active health gate status, or null when no gate was started. */
   gateStatus: 'observing' | 'passed' | 'failed' | 'unknown' | null;
diff --git a/frontend/src/components/__tests__/DeployFeedbackModal.inline.test.tsx b/frontend/src/components/__tests__/DeployFeedbackModal.inline.test.tsx
index 4b89633e..8d1dfb2c 100644
--- a/frontend/src/components/__tests__/DeployFeedbackModal.inline.test.tsx
+++ b/frontend/src/components/__tests__/DeployFeedbackModal.inline.test.tsx
@@ -78,6 +78,20 @@ describe('DeployFeedbackModal Inline vs Modal style', () => {
         expect(onMinimize).not.toHaveBeenCalled();
     });
 
+    it('inline style: succeeded state shows no auto-close countdown label', () => {
+        mockStyle = 'inline';
+        mockPanelState = panel({ status: 'succeeded' });
+        render(<DeployFeedbackModal isMinimized={false} onMinimize={onMinimize} />);
+        expect(screen.queryByText(/closes in/i)).toBeNull();
+    });
+
+    it('modal style: succeeded state shows auto-close countdown label', () => {
+        mockStyle = 'modal';
+        mockPanelState = panel({ status: 'succeeded' });
+        render(<DeployFeedbackModal isMinimized={false} onMinimize={onMinimize} />);
+        expect(screen.getByText(/closes in/i)).toBeInTheDocument();
+    });
+
     it('modal style owns the live terminal; inline style renders no terminal (single socket)', () => {
         mockStyle = 'modal';
         const view = render(<DeployFeedbackModal isMinimized={false} onMinimize={onMinimize} />);