fix(stacks): require stack:read on file explorer GET routes (#1200)

The four file-explorer GET endpoints (list, content, download,
permissions) previously relied on auth alone. Their write-side siblings
required stack:edit, so the read path was the only file-explorer surface
without an explicit capability check. The shipped roles all carry
stack:read globally so behaviour is unchanged today, but adding the
guard prevents a future role definition from silently inheriting
unrestricted file reads, and it brings the file-explorer reads in line
with gitSources and stackActivity which already gate on stack:read.

The frontend Files tab trigger, panel, and the anatomy-panel "Open
Files" affordance now render only when the user holds stack:read for
the active stack. An effect canonicalises activeTab back to 'compose'
if the user lands on 'files' without permission, so a denied user
cannot end up staring at an empty panel.
This commit is contained in:
Anso
2026-05-24 22:58:28 -04:00
committed by GitHub
parent c67478b50d
commit 4c28b37a59
3 changed files with 56 additions and 8 deletions
@@ -595,4 +595,39 @@ describe('permission gating', () => {
.send({ mode: 0o644 });
expect(res.status).toBe(403);
});
it('viewer with global stack:read can GET /files', async () => {
const res = await request(app)
.get(`/api/stacks/${STACK}/files`)
.set('Cookie', viewerCookie);
expect(res.status).toBe(200);
expect(Array.isArray(res.body)).toBe(true);
});
it('viewer with global stack:read can GET /files/content', async () => {
const res = await request(app)
.get(`/api/stacks/${STACK}/files/content`)
.query({ path: 'compose.yaml' })
.set('Cookie', viewerCookie);
expect(res.status).toBe(200);
expect(typeof res.body.content).toBe('string');
});
it('viewer with global stack:read can GET /files/download', async () => {
const res = await request(app)
.get(`/api/stacks/${STACK}/files/download`)
.query({ path: 'compose.yaml' })
.set('Cookie', viewerCookie);
expect(res.status).toBe(200);
expect(res.headers['content-disposition']).toMatch(/attachment/);
});
it('viewer with global stack:read can GET /files/permissions', async () => {
const res = await request(app)
.get(`/api/stacks/${STACK}/files/permissions`)
.query({ path: 'compose.yaml' })
.set('Cookie', viewerCookie);
expect(res.status).toBe(200);
expect(typeof res.body.octal).toBe('string');
});
});