gsadmin/sencho
1
0
Fork 0
mirror of https://github.com/Studio-Saelix/sencho.git synced 2026-09-03 22:25:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: keep running containers until stack pull/build succeeds (#1657)

Browse Source 
* fix: keep running containers until stack pull/build succeeds

Acquire images before reconcile, capture a recovery generation for
compensation, and only remove classified orphans after handoff.

* fix: address recovery audit blockers for safe stack updates

Retire abandoned and expired recovery artifacts, probe compensated
runtimes before reporting rollback success, preserve local Docker when
deleting a node, validate the exact Compose invocation before capture,
and repair updateStack return-contract fixtures.

* fix: resolve ESLint errors blocking CI on this branch

Unused-import and unused-variable errors left over from the stack
deletion refactor: MeshService in stacks.ts (its opt-out cascade moved
into DeployedStackDeletionService), a redundant pruneVolumes
destructure in deleteDeployedStack (the real one is re-derived from
the same input object inside runDeletionBody), and an unused beforeAll
import in a Docker-integration test stub. Also scopes the webhook
pull-action case body in a block to satisfy no-case-declarations;
purely syntactic, no behavior change.

* fix: harden recovery probe, cleanup retry, and failed-pull Docker test

Reject absent or unhealthy expected replicas before reporting rollback
success, keep cleanup records until artifacts are actually removed, fail
closed when a mesh override cannot be generated, and assert a real
failed pull leaves the original container running.

* fix: verify recovery probe image identity and stack-scoped override paths

Reject recovered runtimes that use the wrong image or leave scale-zero
services running, and confine tombstone override deletion to the intent
stack directory so forged cross-stack paths cannot be swept.

* test: batch notification cap fixtures in a SQLite transaction

Unbatched 1200-row inserts were timing out at the default 30s under
CI load even though the same assertions pass in under 2s when green.
This commit is contained in:
Anso
2026-07-21 12:18:01 -04:00
committed by GitHub
parent b1decbb32a
commit 3f1f15a6f4
41 changed files with 3087 additions and 244 deletions
Download Patch File Download Diff File Expand all files Collapse all files
backend/src/__tests__/update-guard-rollback.test.ts
+5 -4
View File
@@ -96,11 +96,12 @@ describe('buildRollbackItems', () => {
expect(known.detail).toContain('nginx:1.27.1');
});
it('downgrades the previous image to not_covered for a moving tag', () => {
it('treats a moving tag as ready because full-stack updates retain the prior image ID', () => {
const item = itemById(baseInputs({ rollbackTarget: { target: 'nginx:latest', moving: true } }), 'previous_images');
expect(item.state).toBe('not_covered');
expect(item.state).toBe('ready');
expect(item.detail).toContain('moving image tag');
expect(item.detail).toContain('nginx:latest');
expect(item.detail).toContain('recovery window');
});
it('does not mistake an image literally named error for a failed preview', () => {
@@ -139,9 +140,9 @@ describe('aggregateRollbackOverall', () => {
expect(aggregateRollbackOverall(items)).toBe('partial');
});
it('is partial when the rollback target is a moving tag', () => {
it('is ready when the rollback target is a moving tag (image ID capture covers it)', () => {
const items = buildRollbackItems(baseInputs({ rollbackTarget: { target: 'nginx:latest', moving: true } }), NOW);
expect(aggregateRollbackOverall(items)).toBe('partial');
expect(aggregateRollbackOverall(items)).toBe('ready');
});
it('is partial when env coverage is missing', () => {