gsadmin/sencho
1
0
Fork 0
mirror of https://github.com/Studio-Saelix/sencho.git synced 2026-08-29 11:47:01 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(networking): treat host-network services as host-exposed in summaries (#1430)

Browse Source 
The exposure summaries derived a stack's exposure solely from the declared
published-port list, so a service running with network_mode: host (which
publishes every container port on the host but declares no ports:) was
under-reported as less exposed than it actually is.

Capture network_mode in the lightweight dependency parser, add an
isHostNetwork predicate, and treat a host-network service as exposed and
publishing across the Fleet networking summary, the Stack Dossier export, and
the Networking panel, matching how the Compose Doctor already flags host
networking.
This commit is contained in:
Anso
2026-06-24 19:50:45 -04:00
committed by GitHub
parent 2ed01641c8
commit 2eafee3594
11 changed files with 111 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files
frontend/src/lib/networkExposureSummary.test.ts
+13 -1
View File
@@ -31,7 +31,15 @@ describe('buildNetworkExposureSummary', () => {
expect(s).toEqual({
stackIntent: 'internal',
networks: [{ name: 'app_backend', external: false, internal: true }],
services: [{ name: 'web', intent: 'public', ports: ['8080/tcp (all interfaces)', '9000/tcp (loopback)'] }],
services: [{ name: 'web', intent: 'public', ports: ['8080/tcp (all interfaces)', '9000/tcp (loopback)'], hostNetwork: false }],
});
});
it('flags a host-network service as host-exposed even with no published ports', () => {
const s = buildNetworkExposureSummary({ renderable: true, networks: [], services: [{ name: 'app', publishedPorts: [], networkMode: 'host' }] }, []);
expect(s).toEqual({
stackIntent: null,
networks: [],
services: [{ name: 'app', intent: null, ports: [], hostNetwork: true }],
});
});
});
@@ -47,6 +55,10 @@ describe('networkExposureSection', () => {
it('returns null for a null summary', () => {
expect(networkExposureSection(null)).toBeNull();
});
it('renders the host-network phrase for a host-mode service', () => {
const md = networkExposureSection(buildNetworkExposureSummary({ renderable: true, networks: [], services: [{ name: 'app', publishedPorts: [], networkMode: 'host' }] }, [])) ?? '';
expect(md).toContain('host network (all ports exposed on host)');
});
it('never includes a value that lives in an ignored field (no env or label leak)', () => {
// A secret planted in fields the builder does not read must not surface.
const leaky = facts({