gsadmin/sencho
1
0
Fork 0
mirror of https://github.com/Studio-Saelix/sencho.git synced 2026-08-12 11:47:11 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(pilot): let SENCHO_PUBLIC_URL override the request Host in enrollment (#1122)

Browse Source 
The enrollment minter inferred SENCHO_PRIMARY_URL from the request Host
header, which baked loopback or LAN addresses into the compose YAML when
the admin opened Add Node on the central's own machine. Pilots on a
different network (a public cloud VPS, for example) cannot dial that.

SENCHO_PUBLIC_URL on the primary now wins when set and well-formed
(http(s)://, no loopback). Trailing slashes are stripped. Falls back to
the request Host when unset or invalid.
This commit is contained in:
Anso
2026-05-20 03:35:25 -04:00
committed by GitHub
parent b4d92621d4
commit 282ab8d844
4 changed files with 107 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
backend/src/__tests__/pilot-enrollment.test.ts
+65
View File
@@ -134,6 +134,71 @@ describe('POST /api/nodes (pilot_agent mode)', () => {
});
});
describe('SENCHO_PUBLIC_URL override in mintPilotEnrollment', () => {
const ORIGINAL = process.env.SENCHO_PUBLIC_URL;
afterAll(() => {
if (ORIGINAL === undefined) delete process.env.SENCHO_PUBLIC_URL;
else process.env.SENCHO_PUBLIC_URL = ORIGINAL;
});
it('bakes the env-var URL into composeYaml when set and valid', async () => {
process.env.SENCHO_PUBLIC_URL = 'https://sencho.example.com';
const res = await request(app)
.post('/api/nodes')
.set('Cookie', adminCookie)
.send({ name: 'pilot-public-url-set', type: 'remote', mode: 'pilot_agent' });
const parsed = parseYaml(res.body.enrollment.composeYaml) as ComposeFile;
expect(parsed.services.agent.environment.SENCHO_PRIMARY_URL).toBe('https://sencho.example.com');
});
it('strips a trailing slash from the env-var URL', async () => {
process.env.SENCHO_PUBLIC_URL = 'https://sencho.example.com/';
const res = await request(app)
.post('/api/nodes')
.set('Cookie', adminCookie)
.send({ name: 'pilot-public-url-trailing', type: 'remote', mode: 'pilot_agent' });
const parsed = parseYaml(res.body.enrollment.composeYaml) as ComposeFile;
expect(parsed.services.agent.environment.SENCHO_PRIMARY_URL).toBe('https://sencho.example.com');
});
it('falls back to request host when env var is unset', async () => {
delete process.env.SENCHO_PUBLIC_URL;
const res = await request(app)
.post('/api/nodes')
.set('Cookie', adminCookie)
.send({ name: 'pilot-public-url-unset', type: 'remote', mode: 'pilot_agent' });
const parsed = parseYaml(res.body.enrollment.composeYaml) as ComposeFile;
// Supertest sends requests with host = `127.0.0.1:<ephemeral-port>`,
// so the fallback URL must reflect that, not the env-var override.
expect(parsed.services.agent.environment.SENCHO_PRIMARY_URL).toMatch(/^http:\/\/127\.0\.0\.1:\d+$/);
});
it('falls back to request host when env var is malformed', async () => {
process.env.SENCHO_PUBLIC_URL = 'not a url';
const res = await request(app)
.post('/api/nodes')
.set('Cookie', adminCookie)
.send({ name: 'pilot-public-url-bad', type: 'remote', mode: 'pilot_agent' });
const parsed = parseYaml(res.body.enrollment.composeYaml) as ComposeFile;
expect(parsed.services.agent.environment.SENCHO_PRIMARY_URL).toMatch(/^http:\/\/127\.0\.0\.1:\d+$/);
});
it('rejects a loopback URL and falls back to the request host', async () => {
process.env.SENCHO_PUBLIC_URL = 'http://127.0.0.1:1852';
const res = await request(app)
.post('/api/nodes')
.set('Cookie', adminCookie)
.send({ name: 'pilot-public-url-loopback', type: 'remote', mode: 'pilot_agent' });
const parsed = parseYaml(res.body.enrollment.composeYaml) as ComposeFile;
expect(parsed.services.agent.environment.SENCHO_PRIMARY_URL).toMatch(/^http:\/\/127\.0\.0\.1:\d+$/);
});
});
describe('POST /api/nodes/:id/pilot/enroll', () => {
it('regenerates the enrollment for an existing pilot node', async () => {
const create = await request(app)