From dd339ecb5edf635186e41bf92b02345304860d0a Mon Sep 17 00:00:00 2001 From: skolarianer <6286711+skolarianer@users.noreply.github.com> Date: Tue, 20 Oct 2026 17:42:25 +0200 Subject: [PATCH] Avoid duplicate per-blob file ACKs (cherry picked from commit 1c90cb120e4674a41994f49ce11f8b50e905408e) --- static/client.html | 3 --- tests/client-file-stream-ack.mjs | 4 ++-- 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/static/client.html b/static/client.html index bd0e9dc..d6d9de9 100644 --- a/static/client.html +++ b/static/client.html @@ -1521,9 +1521,6 @@ // ── File download handler (server-initiated file transfer) ── client.onfile = function(stream, mimetype, filename) { var reader = new Guacamole.BlobReader(stream, mimetype); - reader.onprogress = function(length) { - stream.sendAck('Received', Guacamole.Status.Code.SUCCESS); - }; reader.onend = function() { var blob = reader.getBlob(); var a = document.createElement('a'); diff --git a/tests/client-file-stream-ack.mjs b/tests/client-file-stream-ack.mjs index b3d125f..b625503 100644 --- a/tests/client-file-stream-ack.mjs +++ b/tests/client-file-stream-ack.mjs @@ -36,6 +36,6 @@ assert.deepEqual(acknowledgements, [ { message: 'OK', code: 0 } ], 'the stream should be accepted once the reader is ready'); -reader.onprogress(); -assert.deepEqual(acknowledgements.at(-1), { message: 'Received', code: 0 }); +assert.equal(reader.onprogress, undefined, + 'BlobReader handles per-blob ACKs without an extra callback'); console.log('client-file-stream-ack: ok');