mirror of
https://github.com/rustfs/rustfs.git
synced 2026-08-30 16:59:52 +00:00
Zhengchao An
f63af3df63
The ecstore/global-state migrations are done (backlog#815, #939, #1052 all closed). Review of every migration-era test/gate measure found three things actually retirable or broken — everything else is a live anti-regression guard and stays. Remove: - scripts/check_metrics_migration_refs.sh — guards a migration that finished: rustfs_metrics:: has zero hits, the metrics crate no longer exists, and the script was never wired into CI or make (only reference was one line in config-model-boundary-adr.md, also removed). - crates/obs init_metrics_collectors — the "backward-compatible alias kept during migration" the removed script was guarding. Zero callers; pure delegate to init_metrics_runtime. Archive (docs/superpowers/plans/, continuing the 2026-07 convention, with the standard archived banner): - startup-timeline.md, scheduler-baseline.md, profiling-numa-capability-inventory.md, kms-development-defaults-inventory.md — one-shot snapshots whose only consumer is the already-archived migration-progress ledger (their same-dir links there start resolving again after the move); zero script pins; fed the closed backlog#660/#665 architecture-review ledger. Fixed the one outbound link (startup-timeline -> readiness-matrix) that the move would have broken — check_doc_paths.sh deliberately does not scan plans/, so nothing else would have caught it. Wire (found orphaned by the same review): - scripts/check_extension_schema_boundaries.sh guards a live contract crate but was never invoked anywhere. Add lint-fmt.mak target, include in pre-commit/pre-pr/dev-check, add ci.yml Quick Checks step (job already installs ripgrep), sync the CONTRIBUTING.md enumerated list, and harden the script against a silently-passing rg probe when src/ is missing. Keep (verified live, documented so the next cleanup pass does not repeat this analysis): - scripts/check_architecture_migration_rules.sh — added a header stating it is a permanent boundary guard, not retirable migration scaffolding; 'migration' in the name is historical. - check_migration_gate_count.sh + floor, delete-marker e2e proof, all pinned docs, compat-cleanup-register sync, remaining inventories (referenced by live docs). Verification: all 7 guard scripts pass, actionlint clean, cargo check --workspace (excl e2e) clean, cargo fmt --check clean. Adversarially reviewed by two independent skeptic passes; their 7 findings (alias left behind, broken outbound link, missing banners, wrong backlog attribution, CONTRIBUTING drift, rg exit-2 hole, missing header rationale) are all folded in.
62 lines
2.0 KiB
Makefile
62 lines
2.0 KiB
Makefile
## —— Code quality and Formatting ------------------------------------------------------------------
|
|
|
|
.NOTPARALLEL: fix
|
|
|
|
.PHONY: fmt
|
|
fmt: core-deps fmt-deps ## Format code
|
|
@echo "🔧 Formatting code..."
|
|
cargo fmt --all
|
|
|
|
.PHONY: fmt-check
|
|
fmt-check: core-deps fmt-deps ## Check code formatting
|
|
@echo "📝 Checking code formatting..."
|
|
cargo fmt --all --check
|
|
|
|
.PHONY: clippy-check
|
|
clippy-check: core-deps ## Run clippy checks
|
|
@echo "🔍 Running clippy checks..."
|
|
cargo clippy --all-targets -- -D warnings
|
|
|
|
.PHONY: clippy-fix
|
|
clippy-fix: core-deps ## Apply clippy fixes
|
|
@echo "🔧 Applying clippy fixes..."
|
|
cargo clippy --fix --allow-dirty
|
|
|
|
.PHONY: fix
|
|
fix: fmt clippy-fix ## Format code and apply clippy fixes
|
|
|
|
.PHONY: quick-check
|
|
quick-check: core-deps ## Run fast workspace compilation check
|
|
@echo "🔨 Running fast compilation check..."
|
|
cargo check --workspace --exclude e2e_test
|
|
|
|
.PHONY: unsafe-code-check
|
|
unsafe-code-check: ## Check unsafe_code allowances have SAFETY comments
|
|
@echo "🔒 Checking unsafe_code allowances..."
|
|
./scripts/check_unsafe_code_allowances.sh
|
|
|
|
.PHONY: architecture-migration-check
|
|
architecture-migration-check: ## Check architecture migration guardrails
|
|
@echo "🏗️ Checking architecture migration guardrails..."
|
|
./scripts/check_architecture_migration_rules.sh
|
|
|
|
.PHONY: logging-guardrails-check
|
|
logging-guardrails-check: ## Check logging guardrails for redaction and noise regressions
|
|
@echo "🪵 Checking logging guardrails..."
|
|
./scripts/check_logging_guardrails.sh
|
|
|
|
.PHONY: tokio-io-uring-check
|
|
tokio-io-uring-check: ## Check tokio io-uring runtime feature stays removed
|
|
@echo "🚫 Checking tokio io-uring feature guard..."
|
|
./scripts/check_no_tokio_io_uring.sh
|
|
|
|
.PHONY: extension-schema-check
|
|
extension-schema-check: ## Check extension-schema stays a lightweight contract crate
|
|
@echo "🧩 Checking extension schema boundaries..."
|
|
./scripts/check_extension_schema_boundaries.sh
|
|
|
|
.PHONY: compilation-check
|
|
compilation-check: core-deps ## Run compilation check
|
|
@echo "🔨 Running compilation check..."
|
|
cargo check --all-targets
|