mirror of
https://github.com/rustfs/rustfs.git
synced 2026-08-06 13:27:43 +00:00
Zhengchao An
afaf8c681a
The UnknownChecksumAlgorithmError message omitted crc64nvme and advertised the deprecated md5. Parsing "md5" also returned a Crc32 algorithm and its into_impl produced a 4-byte CRC32, so a caller asking for MD5 silently got the wrong digest. Enumerate the accepted algorithms (crc32, crc32c, crc64nvme, sha1, sha256) in the error message, remove the unused Md5 enum variant, and make parsing "md5" fail loudly. Add tests covering the message contents and the md5 parse error.
46 lines
1.4 KiB
Rust
46 lines
1.4 KiB
Rust
// Copyright 2024 RustFS Team
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
use std::error::Error;
|
|
use std::fmt;
|
|
|
|
#[derive(Debug)]
|
|
pub struct UnknownChecksumAlgorithmError {
|
|
checksum_algorithm: String,
|
|
}
|
|
|
|
impl UnknownChecksumAlgorithmError {
|
|
pub(crate) fn new(checksum_algorithm: impl Into<String>) -> Self {
|
|
Self {
|
|
checksum_algorithm: checksum_algorithm.into(),
|
|
}
|
|
}
|
|
|
|
pub fn checksum_algorithm(&self) -> &str {
|
|
&self.checksum_algorithm
|
|
}
|
|
}
|
|
|
|
impl fmt::Display for UnknownChecksumAlgorithmError {
|
|
fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
|
|
write!(
|
|
f,
|
|
r#"unknown checksum algorithm "{}", please pass a known algorithm name ("crc32", "crc32c", "crc64nvme", "sha1", "sha256")"#,
|
|
self.checksum_algorithm
|
|
)
|
|
}
|
|
}
|
|
|
|
impl Error for UnknownChecksumAlgorithmError {}
|