mirror of
https://github.com/rustfs/rustfs.git
synced 2026-08-08 22:33:22 +00:00
weisd
ca4793f93e
* fix: preserve S3 listing pagination parity S3 listing responses need stable wire semantics across encoded listings, version markers, and quorum-sensitive metadata reads. This tightens marker handling, response encoding, and version-marker pagination while keeping the changes scoped to listing paths and regression tests. Constraint: Branch, code, commit, and PR text must avoid restricted upstream project naming. Constraint: Verification required Rust 1.95 toolchain path because Homebrew cargo-clippy resolved to 1.94. Rejected: Treat null version-id-marker as no marker | repeats or skips the marker boundary for null-version listings. Rejected: Compare encoded next-marker values directly | encoded output can diverge from raw listing order. Confidence: high Scope-risk: moderate Directive: Do not change listing marker semantics without covering V1, V2, versions, encoded responses, and null-version markers together. Tested: cargo fmt --all --check Tested: cargo clippy --workspace --all-features --all-targets -- -D warnings Tested: make pre-commit with LC_ALL=en_US.UTF-8 and Rust 1.95 PATH Tested: git diff --check Not-tested: live distributed object-store compatibility test against a remote cluster * fix: keep listing echo fields raw S3 compatibility tests expect list response echo fields such as Prefix, Delimiter, StartAfter, and Marker to preserve the request value even when URL encoding is requested. Keep URL encoding scoped to object keys and common prefixes while preserving the next-marker raw comparison fix. Constraint: PR branch was updated with latest main before this fix. Constraint: Do not use restricted upstream project naming in commit text. Rejected: Encode all response string fields | breaks compatibility tests for unreadable prefix values. Confidence: high Scope-risk: narrow Tested: cargo test -p rustfs list_objects --lib Tested: cargo fmt --all --check Tested: cargo clippy --workspace --all-features --all-targets -- -D warnings Tested: make pre-commit Tested: git diff --check Not-tested: live CI s3 compatibility rerun before push * fix: accept empty listing continuation token S3 compatibility tests treat an empty ListObjectsV2 continuation token as an explicit empty echo value, not as an invalid base64 token. Preserve the request echo while skipping decoded-token pagination for the empty string. Constraint: Keep invalid non-empty continuation tokens rejected before store lookup. Rejected: Drop empty continuation tokens from the response | compatibility tests assert the empty echo field is present. Confidence: high Scope-risk: narrow Tested: cargo test -p rustfs list_objects --lib Tested: cargo fmt --all --check Tested: cargo clippy --workspace --all-features --all-targets -- -D warnings Tested: make pre-commit Tested: git diff --check Not-tested: live CI s3 compatibility rerun after this push * fix: delete explicit null object versions S3 compatibility cleanup lists unversioned objects with VersionId=null and then sends that value back through DeleteObjects. The API layer keeps null as an internal sentinel, but the storage delete path must map it back to the stored null version instead of treating it as a real UUID. Constraint: Keep the wire response able to echo null version IDs. Rejected: Treat VersionId=null the same as an absent version id everywhere | versioned and suspended buckets need explicit null version semantics. Confidence: high Scope-risk: moderate Tested: cargo test -p rustfs-ecstore delete_file_info_version_id_maps_explicit_null_version_to_stored_null Tested: cargo test -p rustfs normalize_delete_objects_version_id_preserves_explicit_null_marker --lib Tested: cargo fmt --all --check Tested: cargo clippy --workspace --all-features --all-targets -- -D warnings Tested: make pre-commit Tested: git diff --check Not-tested: live CI s3 compatibility rerun after this push * fix: keep version marker scoped to marker key Version listing cleanup can delete the key returned as the previous page marker before requesting the next page. When the marker key is no longer present, the version marker must not be applied to the first later key, otherwise each cleanup page can skip one null-version object and leave the bucket non-empty. Constraint: Preserve version-marker pagination for marker keys that still exist. Rejected: Drop version markers whenever the marker key was supplied | multi-version marker keys still need intra-key pagination. Confidence: high Scope-risk: narrow Tested: cargo test -p rustfs-ecstore version_marker_is_applied_only_when_key_marker_entry_is_present Tested: cargo test -p rustfs-ecstore delete_file_info_version_id_maps_explicit_null_version_to_stored_null Tested: cargo test -p rustfs normalize_delete_objects_version_id_preserves_explicit_null_marker --lib Tested: cargo fmt --all --check Tested: cargo clippy --workspace --all-features --all-targets -- -D warnings Tested: make pre-commit Tested: git diff --check Not-tested: live CI s3 compatibility rerun after this push --------- Co-authored-by: houseme <housemecn@gmail.com> Co-authored-by: loverustfs <hello@rustfs.com>