mirror of
https://github.com/rustfs/rustfs.git
synced 2026-07-27 08:38:58 +00:00
weisd
a66337bd28
* fix: keep scanner walk timeouts from offlining drives Scanner walk operations can time out on large or slow directory listings without proving the backing drive is faulty. Keep the timeout error local to the scan while preserving failure marking for ordinary disk operations. Constraint: Scanner walk_dir can include listing work that exceeds the drive timeout under slow storage. Rejected: Disable timeout failure marking globally | real stuck disk operations must still affect drive health Confidence: high Scope-risk: narrow Directive: Do not route scanner/listing timeout back into drive offline state without reproducing issue #2651 Tested: cargo test -p rustfs-ecstore timeout Tested: cargo fmt --all --check Tested: cargo clippy --workspace --all-features --all-targets -- -D warnings Tested: make pre-commit with en_US.UTF-8 locale Related: https://github.com/rustfs/rustfs/issues/2651 * fix: keep remote scanner walks from offlining drives Remote walk_dir uses a streaming request that can hit total or stall timeouts during large scans without proving the remote drive is faulty. Route that scanner path through an explicit ignore action while preserving failure marking for ordinary remote operations. Also treat Duration::ZERO as no operation timeout for remote health tracking, matching the existing local disk wrapper contract while still marking network-like errors on default paths. Constraint: Scanner walk_dir streams can be slow because of directory size or consumer backpressure. Rejected: Disable remote timeout failure marking globally | normal remote disk operations still need to evict failed connections and update drive health Confidence: high Scope-risk: narrow Directive: Do not reintroduce remote scanner timeout failure marking without reproducing issue #2651 against remote disks. Tested: cargo test -p rustfs-ecstore execute_with_timeout Tested: cargo test -p rustfs-ecstore timeout Tested: cargo fmt --all --check Tested: cargo clippy --workspace --all-features --all-targets -- -D warnings Tested: make pre-commit with en_US.UTF-8 locale Related: https://github.com/rustfs/rustfs/issues/2651 * test: prove scanner walk backpressure keeps drives online Add a local scanner walk regression test where the output writer never makes progress. The test confirms the walk timeout returns without marking the drive faulty, covering a stall source that is not caused by object count or network transfer speed. Constraint: Scanner walk can block on downstream writer backpressure as well as disk or network IO.\nConfidence: high\nScope-risk: narrow\nTested: cargo test -p rustfs-ecstore walk_dir_writer_backpressure_timeout_does_not_mark_drive_failure\nTested: cargo test -p rustfs-ecstore timeout\nTested: cargo fmt --all --check\nTested: cargo clippy --workspace --all-features --all-targets -- -D warnings\nTested: make pre-commit --------- Co-authored-by: houseme <housemecn@gmail.com>