Files
rustfs/docs/architecture/decommission-compatibility.md
T
overtrue 3cee88f313 feat(ecstore): account for tier free versions in decommission sweep
Tier free versions (xl.meta cleanup records for deleted transitioned
versions) are not migrated as free versions during decommission: the
exact inventory keeps them inline in versions and the migration loop
routes them through the generic delete-marker path, dropping the flag
and remote-tier identity. Reference audit across GET, heal, ILM,
transition, replication, and restore found no cluster-local consumer
that resolves a free version after decommission; on user-facing delete
paths the remote-delete obligation is also carried by a committed
tier-journal entry, leaving only journal-less records (transition
state unknown) exposed to remote orphaning.

- count and log skipped free versions per decommission entry with
  disposition reason tier_free_version_not_migrated instead of
  omitting them silently
- document free-version lifecycle, non-migration invariant, allowed
  physical-delete timing, and the reference-audit result in
  docs/architecture/decommission-compatibility.md
- state the invariant in doc comments at the filemeta free-version
  sites
- guard the accounting with
  decommission_free_version_accounting_reports_skipped_records

Closes rustfs/backlog#1923
2026-08-22 18:37:54 +08:00

12 KiB

Decommission Compatibility Scope

This note records the current RustFS decommission contract for admin/API compatibility reviews.

Current Contract

RustFS supports queued multi-pool decommission start requests on multi-pool deployments.

The admin handler accepts the request shape used by the MinIO-compatible admin API, including comma-separated pool targets. An empty target list is rejected. Single-pool deployments reject decommission because there is no destination pool. On multi-pool deployments, one or more valid target pools are accepted as a single queued operation.

Request Semantics

POST /v3/pools/decommission with comma-separated pool targets is treated as a queue submission:

  • validate all requested pool identifiers before mutating metadata;
  • reject duplicate target pools in the same request;
  • reject active or queued target pools;
  • reject completed decommission targets because completion means the pool can be removed from the deployment configuration;
  • allow failed or canceled targets to be retried;
  • persist queued metadata before starting workers;
  • start only the local-leader prefix of the queue on the receiving node.

The local-leader-prefix rule keeps the active worker on the leader for the pool being moved while still allowing a request to contain later targets whose leaders are different nodes. Later queued targets are recovered or promoted by the leader that owns that target.

Admin start, cancel, and clear requests may arrive on any cluster node. When the target pool first endpoint is remote, RustFS forwards the operation over the authenticated internode RPC channel to that first endpoint. The receiving node still enforces the local-leader rule before mutating decommission state.

Persisted Metadata Shape

The queue is persisted in pool metadata and decoded with the rest of PoolMeta. Each pool entry can distinguish:

  • active: at most one pool currently moving data;
  • queued: validated pools waiting for the active entry to finish;
  • completed: pools finished successfully;
  • failed: pools whose worker reached terminal failure;
  • canceled: pools canceled before or during execution.

Legacy metadata without queue fields decodes as a non-queued decommission entry, preserving restart behavior for already deployed clusters.

Serial Scheduling And Recovery

Only one queued entry may own a decommission worker at a time. Startup recovery:

  • loads pool metadata before rebalance recovery;
  • resumes the first local non-terminal active/queued entry;
  • skips a durably completed prefix and promotes the next queued entry only after successful completion;
  • treats failed or canceled terminal entries as an automatic-promotion barrier, leaving later queued pools visible but stopped until an operator retries, clears, or otherwise resolves the terminal entry;
  • keeps queued pools out of active worker scheduling until promotion, while still making their future state visible in admin status.

Promotion is persisted before worker execution. If cancellation is already requested immediately after promotion, RustFS persists a canceled terminal state instead of leaving the promoted pool active without a worker.

Cancel Semantics

Cancel separates active and queued behavior:

  • canceling the active entry requests worker cancellation and persists terminal metadata;
  • canceling a queued entry marks that entry canceled before it becomes active;
  • failed or canceled terminal entries can be cleared explicitly when the operator chooses to abandon the decommission attempt;
  • peer reload failures during cancel must be surfaced in status and logs.

Cancel requests can be accepted on non-leader nodes as remote cancel intent; the leader observes the pending cancel and applies it to the active worker.

Status Response Shape

GET /v3/pools/list and GET /v3/pools/status?pool=... expose per-pool machine-readable decommission state. The status field can report active, running, queued, complete, failed, or canceled.

When decommission metadata is present, decommissionInfo includes:

  • queue and terminal flags: queued, complete, failed, canceled;
  • progress counters: objectsDecommissioned, objectsDecommissionedFailed, bytesDecommissioned, and bytesDecommissionedFailed;
  • current location: bucket, prefix, and object;
  • queue/history lists: queuedBuckets and decommissionedBuckets;
  • waitingReason, currently queued for queued entries and waiting_for_worker when metadata exists but no worker has started.

This makes queued pools and stalled metadata visible without requiring operators to inspect pool metadata files directly.

MinIO Divergence Decisions

This section records the current product decisions for behavior that is close to MinIO but not always byte-for-byte identical.

Empty Delete Markers

MinIO decommission documentation states that empty delete markers, meaning delete markers with no successor object versions, are not transitioned to another pool.

RustFS follows that behavior for decommission when the bucket has no replication configuration: a lone remaining delete marker is treated as cleanup-only metadata and is skipped. When replication is configured, RustFS intentionally keeps the delete marker eligible for movement so delete-marker replication and purge state are not lost.

RustFS rebalance uses the same predicate as decommission: skip only a lone delete marker without replication. This is intentional even though MinIO's public documentation calls out the decommission case more explicitly than the rebalance case.

Regression guards:

  • should_skip_decommission_delete_marker_characterizes_empty_marker_without_replication
  • should_skip_decommission_delete_marker_characterizes_replication_configured
  • test_should_skip_rebalance_delete_marker_characterizes_empty_marker_without_replication
  • test_should_skip_rebalance_delete_marker_characterizes_replication_configured

Lifecycle-Expired Versions During Cleanup

MinIO decommission ignores versions that are already expired by lifecycle rules. RustFS follows that decommission behavior by allowing safely expired versions to count toward source cleanup completion.

RustFS rebalance is intentionally stricter. Expired versions do not prove that a target pool received an equivalent version, so rebalance cleanup requires actual rebalance completion for the source entry instead of treating lifecycle-expired versions as moved.

Regression guards:

  • test_should_cleanup_decommission_source_entry_accepts_migrated_and_safely_expired_versions
  • test_should_cleanup_decommission_source_entry_accepts_versions_only_safely_expired_by_lifecycle
  • test_should_cleanup_rebalance_source_entry_rejects_versions_only_expired_by_lifecycle

No migration step is required for these decisions because this note documents the current RustFS behavior. Changing either decision later requires an operator compatibility note and updated characterization tests.

Tier Free Versions During Decommission

A tier free version is an internal xl.meta record (rustfs_filemeta::FREE_VERSION, flagged XL_FLAG_FREE_VERSION) shaped like a delete marker. It is created by MetaObject::init_free_version when a version whose remote transition completed is deleted locally: the visible version is removed and the record keeps the remote-tier identity (tier, object name, version id, state, destination id) needed for an idempotent remote delete. Free versions are not user-visible versions; num_versions and all listing/GET paths exclude them.

Lifecycle And Consumers

Creation: any local delete that removes a version whose transition status is complete appends the record via MetaObject::delete_versioninit_free_version (skipped only when skip_tier_free_version is set, as on data-movement copies). The same deletes also persist a durable tier-journal entry on every user-facing path: S3 single deletes (execute_delete_objectdelete_object_with_tier_delete_journal), S3 batch deletes, lifecycle expiry, and lifecycle delete-all all prepare and commit a journal entry around the delete. A journal entry is omitted when the removed version's transition state decodes as TransitionVersionState::Unknown, or on internal journal-less delete paths that never touch transitioned user objects.

Consumption while the record exists: the background recovery loop started by init_background_expiry (spawned by spawn_tier_free_version_recovery_once, enabled by default) scans disks for pending records and re-enqueues them; the usage scanner does the same; the lifecycle worker then deletes the remote tier object idempotently and only afterwards removes the local record. Heal walks include free-version records in metadata healing. Transition planning, replication, restore, GET, listings, and usage aggregation never depend on them.

Decommission Handling

The exact decommission inventory loader (load_file_info_versions_exact via get_all_file_info_versions) keeps free-version records inline in versions; it never populates free_versions, so the source-cleanup preflight comparison of free_versions is vacuous for decommission. The migration loop then routes every record through the generic delete-marker handling:

  • a record that is the only remaining version without replication is skipped by the empty-delete-marker rule and counted as done;
  • any other record is copied to the target pool as an ordinary delete marker with the same version id and mod time.

In both cases the free-version flag and its remote-tier identity are dropped: decommission neither preserves free-version semantics nor performs or reschedules the pending remote-tier delete. Source cleanup then removes the original records together with the source xl.meta.

Allowed physical-delete timing: the source record may be removed once the migration loop has dispositioned it (copied as a plain marker or skipped as lone), which happens regardless of whether its remote-tier delete was ever performed.

Reference-Audit Result

No cluster-local consumer resolves a free version after decommission finishes: GET, listing, transition planning, replication, restore, and heal operate either on user-visible versions or while the record still exists. The remote exposure is bounded:

  • On every user-facing delete path the remote-delete obligation is durably carried by the committed tier-journal entry, which the tier sweeper processes independently of xl.meta; the free-version record is an idempotent second pointer, not the only one. Dropping it during decommission therefore does not orphan the remote object.
  • Residual exposure: for records whose version state decoded as Unknown no journal entry exists, so dropping the unconsumed record loses that cleanup hint and the remote-tier object is orphaned. The same applies to any future internal delete path that removes transitioned versions without a journal entry.

Copying a pending record as an ordinary delete marker also adds a user-visible tombstone to the target pool's version history that the source never exposed.

Because of the residual journal-less case, decommission must account for every free-version record instead of omitting it silently:

  • decommission_free_versions_skipped counts the records per decommission entry;
  • entries with a non-zero count log state = "free_versions_skipped" with reason tier_free_version_not_migrated.

Regression guard:

  • decommission_free_version_accounting_reports_skipped_records

Regression Guard

The queued multi-pool contract is guarded by:

  • test_contextualized_decommission_start_request_allows_multiple_target_pools
  • test_decommission_start_local_leader_allows_remote_queued_pool
  • test_local_decommission_queue_prefix_stops_at_remote_leader
  • test_decommission_peer_target_returns_none_for_local_first_endpoint
  • test_pool_meta_queued_decommission_is_not_suspended_until_promoted
  • test_pool_meta_promoted_queued_decommission_can_be_canceled
  • test_first_resumable_decommission_queue_indices_stops_at_failed_or_canceled_state
  • test_first_resumable_decommission_queue_indices_allows_after_completed_prefix
  • admin_pool_list_item_exposes_queued_decommission_state

These tests live in crates/ecstore/src/core/pools.rs and rustfs/src/app/admin_usecase.rs.