mirror of
https://github.com/rustfs/rustfs.git
synced 2026-07-26 08:18:18 +00:00
3f1acfe8a7
* fix(docker): warn instead of rejecting default or missing credentials The entrypoint hard-reject from #4278 broke the container-first UX and the repo's own scheduled e2e lanes (e2e-s3tests, mint boot rustfs-ci images with default credentials and died at startup). Maintainer decision: ship no baked-in credentials, warn instead of block. - missing credentials: warn and start; wording accounts for the RUSTFS_ROOT_*/MINIO_* alias sources the entrypoint does not inspect - default rustfsadmin via env/CLI/file: warn and start; the warning notes all-default pairs cannot derive an internode RPC secret - malformed config stays fatal: source conflicts, unreadable files, empty or whitespace-only values, flags missing their argument - present-but-empty env vars now hit the empty-value hard failure instead of running the binary with an empty root credential - empty/default checks trim CR and blanks like the binary; files without a trailing newline are no longer falsely rejected as empty - the no-baked-credentials guard covers all four Dockerfiles, and the test harness refuses hosts where /usr/bin/rustfs exists - e2e-s3tests/mint move to non-default credentials (rustfsadmin-ci), which also restores RPC-secret derivation for the multi-node lane GHSA-68cw fail-closed RPC derivation (#4402) is untouched; helm stays fail-closed by design. * chore(docker): reword entrypoint comment flagged by typos check
297 lines
10 KiB
Bash
Executable File
297 lines
10 KiB
Bash
Executable File
#!/bin/sh
|
|
set -e
|
|
|
|
# 1) Normalize command:
|
|
# - No arguments: default to execute rustfs with DATA_VOLUMES
|
|
# - First argument starts with '-': treat as rustfs arguments, auto-prefix rustfs
|
|
# - First argument is 'rustfs': replace with absolute path to avoid PATH interference
|
|
# - Otherwise: treat as full rustfs arguments (e.g., /data paths)
|
|
if [ $# -eq 0 ]; then
|
|
set -- /usr/bin/rustfs
|
|
elif [ "${1#-}" != "$1" ]; then
|
|
set -- /usr/bin/rustfs "$@"
|
|
elif [ "$1" = "rustfs" ]; then
|
|
shift
|
|
set -- /usr/bin/rustfs "$@"
|
|
elif [ "$1" = "/usr/bin/rustfs" ]; then
|
|
: # already normalized
|
|
elif [ "$1" = "cargo" ]; then
|
|
: # Pass through cargo command as-is
|
|
else
|
|
set -- /usr/bin/rustfs "$@"
|
|
fi
|
|
|
|
DEFAULT_ROOT_CREDENTIAL="rustfsadmin"
|
|
|
|
resolve_credential_source() {
|
|
CREDENTIAL_ENV_NAME="$1"
|
|
CREDENTIAL_FILE_ENV_NAME="$2"
|
|
CREDENTIAL_VALUE_OPTION="$3"
|
|
CREDENTIAL_FILE_OPTION="$4"
|
|
shift 4
|
|
|
|
CREDENTIAL_DIRECT_SET=false
|
|
CREDENTIAL_DIRECT_VALUE=""
|
|
CREDENTIAL_FILE_SET=false
|
|
CREDENTIAL_FILE_VALUE=""
|
|
|
|
# ${VAR+x} distinguishes unset from present-but-empty: an env var explicitly
|
|
# set to "" (e.g. an unexpanded compose interpolation) is a malformed value
|
|
# that must hit the empty-value hard failure, not the missing-credential
|
|
# warning — the binary would otherwise run with an empty root credential.
|
|
eval "CREDENTIAL_ENV_PRESENT=\${$CREDENTIAL_ENV_NAME+x}"
|
|
eval "CREDENTIAL_ENV_VALUE=\${$CREDENTIAL_ENV_NAME:-}"
|
|
eval "CREDENTIAL_ENV_FILE_PRESENT=\${$CREDENTIAL_FILE_ENV_NAME+x}"
|
|
eval "CREDENTIAL_ENV_FILE_VALUE=\${$CREDENTIAL_FILE_ENV_NAME:-}"
|
|
|
|
if [ -n "$CREDENTIAL_ENV_PRESENT" ]; then
|
|
CREDENTIAL_DIRECT_SET=true
|
|
CREDENTIAL_DIRECT_VALUE="$CREDENTIAL_ENV_VALUE"
|
|
fi
|
|
|
|
if [ -n "$CREDENTIAL_ENV_FILE_PRESENT" ]; then
|
|
CREDENTIAL_FILE_SET=true
|
|
CREDENTIAL_FILE_VALUE="$CREDENTIAL_ENV_FILE_VALUE"
|
|
fi
|
|
|
|
while [ "$#" -gt 0 ]; do
|
|
arg="$1"
|
|
case "$arg" in
|
|
--)
|
|
break
|
|
;;
|
|
--"$CREDENTIAL_VALUE_OPTION"=*)
|
|
CREDENTIAL_DIRECT_SET=true
|
|
CREDENTIAL_DIRECT_VALUE="${arg#*=}"
|
|
;;
|
|
--"$CREDENTIAL_VALUE_OPTION")
|
|
shift
|
|
if [ "$#" -eq 0 ]; then
|
|
echo "error:--$CREDENTIAL_VALUE_OPTION requires a value."
|
|
return
|
|
fi
|
|
CREDENTIAL_DIRECT_SET=true
|
|
CREDENTIAL_DIRECT_VALUE="$1"
|
|
;;
|
|
--"$CREDENTIAL_FILE_OPTION"=*)
|
|
CREDENTIAL_FILE_SET=true
|
|
CREDENTIAL_FILE_VALUE="${arg#*=}"
|
|
;;
|
|
--"$CREDENTIAL_FILE_OPTION")
|
|
shift
|
|
if [ "$#" -eq 0 ]; then
|
|
echo "error:--$CREDENTIAL_FILE_OPTION requires a value."
|
|
return
|
|
fi
|
|
CREDENTIAL_FILE_SET=true
|
|
CREDENTIAL_FILE_VALUE="$1"
|
|
;;
|
|
esac
|
|
|
|
shift
|
|
done
|
|
|
|
if [ "$CREDENTIAL_DIRECT_SET" = "true" ] && [ "$CREDENTIAL_FILE_SET" = "true" ]; then
|
|
echo "conflict"
|
|
return
|
|
fi
|
|
|
|
if [ "$CREDENTIAL_DIRECT_SET" = "true" ]; then
|
|
echo "value:$CREDENTIAL_DIRECT_VALUE"
|
|
return
|
|
fi
|
|
|
|
if [ "$CREDENTIAL_FILE_SET" = "true" ]; then
|
|
echo "file:$CREDENTIAL_FILE_VALUE"
|
|
return
|
|
fi
|
|
|
|
echo "missing"
|
|
}
|
|
|
|
# Mirrors the binary's .trim() so the empty/default checks below agree with
|
|
# what the server will actually use: strips CR (CRLF-edited files) and
|
|
# surrounding blanks. Comparison only — the value passed to the binary is
|
|
# untouched.
|
|
trim_credential() {
|
|
printf '%s' "$1" | tr -d '\r' | sed 's/^[[:space:]]*//;s/[[:space:]]*$//'
|
|
}
|
|
|
|
# Credential policy: images ship no baked-in credentials, but default or
|
|
# missing credentials only WARN — the container still starts (the binary falls
|
|
# back to its built-in default, and warns when both keys end up default).
|
|
# Hard failures (ERROR, exit 1) are reserved for malformed configuration
|
|
# (conflicting sources, unreadable files, empty values). The binary also accepts credentials via
|
|
# legacy/compat envs (RUSTFS_ROOT_*, MINIO_*) that this script does not
|
|
# inspect, so the missing-credential warning is phrased conditionally.
|
|
validate_credential_source() {
|
|
CREDENTIAL_NAME="$1"
|
|
FILE_NAME="$2"
|
|
ALIAS_HINT="$3"
|
|
CREDENTIAL_SOURCE="$4"
|
|
|
|
case "$CREDENTIAL_SOURCE" in
|
|
error:*)
|
|
echo "ERROR: ${CREDENTIAL_SOURCE#error:}" >&2
|
|
exit 1
|
|
;;
|
|
conflict)
|
|
echo "ERROR: Set either $CREDENTIAL_NAME or $FILE_NAME, not both." >&2
|
|
exit 1
|
|
;;
|
|
missing)
|
|
echo "WARNING: $CREDENTIAL_NAME or $FILE_NAME is not set; unless credentials are provided via another supported source (e.g. $ALIAS_HINT), rustfs falls back to its built-in default credential. Set non-default credentials for production deployments." >&2
|
|
;;
|
|
value:*)
|
|
CREDENTIAL_VALUE=$(trim_credential "${CREDENTIAL_SOURCE#value:}")
|
|
if [ -z "$CREDENTIAL_VALUE" ]; then
|
|
echo "ERROR: $CREDENTIAL_NAME must not be empty." >&2
|
|
exit 1
|
|
fi
|
|
if [ "$CREDENTIAL_VALUE" = "$DEFAULT_ROOT_CREDENTIAL" ]; then
|
|
echo "WARNING: $CREDENTIAL_NAME uses the default $DEFAULT_ROOT_CREDENTIAL credential. Set non-default credentials for production deployments; with an all-default pair, multi-node clusters additionally need RUSTFS_RPC_SECRET to derive internode RPC auth." >&2
|
|
fi
|
|
;;
|
|
file:*)
|
|
CREDENTIAL_FILE="${CREDENTIAL_SOURCE#file:}"
|
|
if [ -z "$CREDENTIAL_FILE" ]; then
|
|
echo "ERROR: $FILE_NAME must not be empty." >&2
|
|
exit 1
|
|
fi
|
|
if [ ! -r "$CREDENTIAL_FILE" ]; then
|
|
echo "ERROR: $FILE_NAME points to an unreadable file." >&2
|
|
exit 1
|
|
fi
|
|
# `read` fails at EOF-without-newline but still fills the variable;
|
|
# keep the partial line so newline-less secret files stay valid.
|
|
IFS= read -r CREDENTIAL_FILE_CONTENT < "$CREDENTIAL_FILE" || :
|
|
CREDENTIAL_FILE_CONTENT=$(trim_credential "$CREDENTIAL_FILE_CONTENT")
|
|
if [ -z "$CREDENTIAL_FILE_CONTENT" ]; then
|
|
echo "ERROR: $FILE_NAME must not be empty." >&2
|
|
exit 1
|
|
fi
|
|
if [ "$CREDENTIAL_FILE_CONTENT" = "$DEFAULT_ROOT_CREDENTIAL" ]; then
|
|
echo "WARNING: $FILE_NAME contains the default $DEFAULT_ROOT_CREDENTIAL credential. Set non-default credentials for production deployments; with an all-default pair, multi-node clusters additionally need RUSTFS_RPC_SECRET to derive internode RPC auth." >&2
|
|
fi
|
|
;;
|
|
esac
|
|
}
|
|
|
|
if [ "$1" = "/usr/bin/rustfs" ]; then
|
|
ACCESS_SOURCE=$(resolve_credential_source "RUSTFS_ACCESS_KEY" "RUSTFS_ACCESS_KEY_FILE" "access-key" "access-key-file" "$@")
|
|
SECRET_SOURCE=$(resolve_credential_source "RUSTFS_SECRET_KEY" "RUSTFS_SECRET_KEY_FILE" "secret-key" "secret-key-file" "$@")
|
|
validate_credential_source "RUSTFS_ACCESS_KEY" "RUSTFS_ACCESS_KEY_FILE" "RUSTFS_ROOT_USER or MINIO_ROOT_USER" "$ACCESS_SOURCE"
|
|
validate_credential_source "RUSTFS_SECRET_KEY" "RUSTFS_SECRET_KEY_FILE" "RUSTFS_ROOT_PASSWORD or MINIO_ROOT_PASSWORD" "$SECRET_SOURCE"
|
|
fi
|
|
|
|
# 2) Process data volumes (separate from log directory)
|
|
DATA_VOLUMES=""
|
|
process_data_volumes() {
|
|
VOLUME_RAW="${RUSTFS_VOLUMES:-/data}"
|
|
# Convert comma/tab to space
|
|
VOLUME_LIST_RAW=$(echo "$VOLUME_RAW" | tr ',\t' ' ')
|
|
|
|
VOLUME_LIST=""
|
|
for vol in $VOLUME_LIST_RAW; do
|
|
# Helper to manually expand {N..M} since sh doesn't support it on variables
|
|
if echo "$vol" | grep -E -q "\{[0-9]+\.\.\.?[0-9]+\}"; then
|
|
PREFIX=${vol%%\{*}
|
|
SUFFIX=${vol##*\}}
|
|
RANGE=${vol#*\{}
|
|
RANGE=${RANGE%\}}
|
|
RANGE=$(echo "$RANGE" | sed 's/\.\.\./../')
|
|
START=${RANGE%%..*}
|
|
END=${RANGE##*..}
|
|
|
|
# Check if START and END are numbers
|
|
if [ "$START" -eq "$START" ] 2>/dev/null && [ "$END" -eq "$END" 2>/dev/null ]; then
|
|
i=$START
|
|
while [ "$i" -le "$END" ]; do
|
|
VOLUME_LIST="$VOLUME_LIST ${PREFIX}${i}${SUFFIX}"
|
|
i=$((i+1))
|
|
done
|
|
else
|
|
# Fallback if not numbers
|
|
VOLUME_LIST="$VOLUME_LIST $vol"
|
|
fi
|
|
else
|
|
VOLUME_LIST="$VOLUME_LIST $vol"
|
|
fi
|
|
done
|
|
|
|
for vol in $VOLUME_LIST; do
|
|
case "$vol" in
|
|
/*) DATA_VOLUMES="$DATA_VOLUMES $vol" ;;
|
|
*) : ;; # skip non-absolute paths (including http(s):// URLs)
|
|
esac
|
|
done
|
|
|
|
echo "Initializing data directories:$DATA_VOLUMES"
|
|
for vol in $DATA_VOLUMES; do
|
|
if [ ! -d "$vol" ]; then
|
|
echo " mkdir -p $vol"
|
|
mkdir -p "$vol"
|
|
# If target user is specified, try to set directory owner to that user (non-recursive to avoid large disk overhead)
|
|
if [ -n "$RUSTFS_UID" ] && [ -n "$RUSTFS_GID" ]; then
|
|
chown "$RUSTFS_UID:$RUSTFS_GID" "$vol" 2>/dev/null || true
|
|
elif [ -n "$RUSTFS_USERNAME" ] && [ -n "$RUSTFS_GROUPNAME" ]; then
|
|
chown "$RUSTFS_USERNAME:$RUSTFS_GROUPNAME" "$vol" 2>/dev/null || true
|
|
fi
|
|
fi
|
|
done
|
|
}
|
|
|
|
# 3) Process log directory (separate from data volumes)
|
|
process_log_directory() {
|
|
# Output logs to stdout
|
|
if [ -z "$RUSTFS_OBS_LOG_DIRECTORY" ]; then
|
|
echo "OBS log directory not configured and logs outputs to stdout"
|
|
return
|
|
fi
|
|
|
|
# Output logs to remote endpoint
|
|
if [ "${RUSTFS_OBS_LOG_DIRECTORY}" != "${RUSTFS_OBS_LOG_DIRECTORY#*://}" ]; then
|
|
echo "Output logs to remote endpoint"
|
|
return
|
|
fi
|
|
|
|
# Outputs logs to local directory
|
|
LOG_DIR="${RUSTFS_OBS_LOG_DIRECTORY}"
|
|
|
|
echo "Initializing log directory: $LOG_DIR"
|
|
if [ ! -d "$LOG_DIR" ]; then
|
|
echo " mkdir -p $LOG_DIR"
|
|
mkdir -p "$LOG_DIR"
|
|
# If target user is specified, try to set directory owner to that user (non-recursive to avoid large disk overhead)
|
|
if [ -n "$RUSTFS_UID" ] && [ -n "$RUSTFS_GID" ]; then
|
|
chown "$RUSTFS_UID:$RUSTFS_GID" "$LOG_DIR" 2>/dev/null || true
|
|
elif [ -n "$RUSTFS_USERNAME" ] && [ -n "$RUSTFS_GROUPNAME" ]; then
|
|
chown "$RUSTFS_USERNAME:$RUSTFS_GROUPNAME" "$LOG_DIR" 2>/dev/null || true
|
|
fi
|
|
fi
|
|
}
|
|
|
|
# Execute the separate processes
|
|
process_data_volumes
|
|
process_log_directory
|
|
|
|
# 5) Append DATA_VOLUMES only if no data paths in arguments
|
|
# Check if any argument looks like a data path (starts with / and not an option)
|
|
HAS_DATA_PATH=false
|
|
for arg in "$@"; do
|
|
case "$arg" in
|
|
/usr/bin/rustfs) continue ;;
|
|
-*) continue ;;
|
|
/*) HAS_DATA_PATH=true; break ;;
|
|
esac
|
|
done
|
|
|
|
if [ "$HAS_DATA_PATH" = "false" ] && [ -n "$DATA_VOLUMES" ]; then
|
|
echo "Starting: $* $DATA_VOLUMES"
|
|
set -- "$@" $DATA_VOLUMES
|
|
else
|
|
echo "Starting: $*"
|
|
fi
|
|
|
|
exec "$@"
|