mirror of
https://github.com/rustfs/rustfs.git
synced 2026-08-01 11:02:14 +00:00
cxymds
1655f3192e
* fix(notify): unify runtime lifecycle coordination * fix(notify): repair lifecycle convergence checks * fix(admin): expose effective notify state (#5097)
95 lines
2.8 KiB
Rust
95 lines
2.8 KiB
Rust
// Copyright 2024 RustFS Team
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
use rustfs_targets::{TargetError, arn::TargetID};
|
|
use std::io;
|
|
use thiserror::Error;
|
|
use tokio::task::JoinError;
|
|
|
|
/// Errors related to the notification system's lifecycle.
|
|
#[derive(Debug, Error)]
|
|
pub enum LifecycleError {
|
|
/// Error indicating the system has already been initialized.
|
|
#[error("System has already been initialized")]
|
|
AlreadyInitialized,
|
|
|
|
/// Error indicating the system has not been initialized yet.
|
|
#[error("System has not been initialized")]
|
|
NotInitialized,
|
|
}
|
|
|
|
/// Error types for the notification system
|
|
#[derive(Debug, Error)]
|
|
pub enum NotificationError {
|
|
#[error("Target error: {0}")]
|
|
Target(#[from] TargetError),
|
|
|
|
#[error("Configuration error: {0}")]
|
|
Configuration(String),
|
|
|
|
#[error("ARN not found: {0}")]
|
|
ARNNotFound(String),
|
|
|
|
#[error("Invalid ARN: {0}")]
|
|
InvalidARN(String),
|
|
|
|
#[error("Bucket notification error: {0}")]
|
|
BucketNotification(String),
|
|
|
|
#[error("Rule configuration error: {0}")]
|
|
RuleConfiguration(String),
|
|
|
|
#[error("System lifecycle error: {0}")]
|
|
Lifecycle(#[from] LifecycleError),
|
|
|
|
#[error("I/O error: {0}")]
|
|
Io(io::Error),
|
|
|
|
#[error("Failed to read configuration: {0}")]
|
|
ReadConfig(String),
|
|
|
|
#[error("Failed to save configuration: {0}")]
|
|
SaveConfig(String),
|
|
|
|
#[error("Target '{0}' not found")]
|
|
TargetNotFound(TargetID),
|
|
|
|
#[error("System initialization error: {0}")]
|
|
Initialization(String),
|
|
|
|
#[error("Storage not available: {0}")]
|
|
StorageNotAvailable(String),
|
|
}
|
|
|
|
pub(crate) fn transition_join_error(error: JoinError) -> NotificationError {
|
|
let reason = if error.is_cancelled() { "cancelled" } else { "panicked" };
|
|
NotificationError::Initialization(format!("Notification lifecycle transition task {reason}"))
|
|
}
|
|
|
|
#[cfg(test)]
|
|
mod tests {
|
|
use super::transition_join_error;
|
|
|
|
#[tokio::test]
|
|
async fn transition_join_error_does_not_expose_panic_payload() {
|
|
let join_error = tokio::spawn(async { panic!("do-not-expose-payload") })
|
|
.await
|
|
.expect_err("test task should panic");
|
|
|
|
let rendered = transition_join_error(join_error).to_string();
|
|
assert!(rendered.contains("panicked"));
|
|
assert!(!rendered.contains("do-not-expose-payload"));
|
|
}
|
|
}
|