mirror of
https://github.com/rustfs/rustfs.git
synced 2026-08-01 19:12:14 +00:00
7354a5663d
The repository has 18 rust-cache families of 1.2-3.1GB each against GitHub's fixed 10GB per-repo quota. Measured usage sat at 9.72GB, 9.96GB and 11.63GB on three samples, so LRU eviction is continuous and the main lanes lose: ci-test and ci-e2e were repeatedly absent from the surviving entries. That is what makes "Setup Rust environment" bimodal — 0.7-3.4 minutes warm against 11.8-20.9 minutes cold. Four changes, all cache-only. No job builds or tests anything different. Collapse ci.yml's nine cache sites into four keys, each with exactly one writer: ci-dev (test-and-lint writes; ILM, debug-binary, e2e-tests and e2e-full read), ci-feat-rio (rio-v2 lint writes, its debug-binary reads), ci-feat-proto (the swift leg writes for both protocol legs), and ci-uring, which stays alone. e2e-full is easy to miss here: it already shared ci-e2e with e2e-tests and both saved, so without an explicit 'false' it would have become a second unnamed writer of ci-dev. rio/swift/sftp are deliberately NOT merged — measured at 2365/2307/1200MB they are not near-identical, and none is a superset of the others. Give each writer a superset warm-up on main. A writer's own steps are not automatically a superset of its readers': clippy emits metadata only, the nextest pass excludes e2e_test, and no lint lane enables e2e-test-hooks, whose different feature resolution yields a different -Cmetadata. Without these builds the readers would restore a cache missing precisely what they need. Guarded to main, so the PR critical path is unaffected. Stop writing tag-scoped caches in build.yml. A cache saved on refs/tags/X can only be restored by a re-run of that same tag, so each release cycle wrote up to 12 unreadable 1-2GB entries that evicted the hot lanes. Tag builds still restore the main-scoped cache. The one real cost is that re-running a failed leg of the same tag now falls back to main's cache. Flip the composite action's cache-save-if default to 'false' and make the input mandatory in practice. audit.yml was relying on the old "true" default: every PR touching Cargo.toml or Cargo.lock saved a second, PR-scoped copy (~843MB measured, job 91048468127) that pushed main-scoped lanes out of the quota. The fail-safe direction is a cold cache, not a stolen quota slice. scripts/security/check_cache_save_if.sh now asserts every call site states it, wired into audit.yml next to the existing pin check. While there, cargo-deny stops pulling the full setup composite. It compiles nothing, so apt, protoc, flatc and nextest were pure overhead — but it does run cargo metadata, and Cargo.toml pins datafusion and s3s as git dependencies that must be materialised into ~/.cargo/git, so the cache itself stays. Refs: rustfs/backlog#1598, rustfs/backlog#1600
148 lines
5.6 KiB
YAML
148 lines
5.6 KiB
YAML
# Copyright 2024 RustFS Team
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License");
|
|
# you may not use this file except in compliance with the License.
|
|
# You may obtain a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS,
|
|
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
# See the License for the specific language governing permissions and
|
|
# limitations under the License.
|
|
|
|
name: Security Audit
|
|
|
|
on:
|
|
push:
|
|
branches: [ main ]
|
|
paths:
|
|
- '**/Cargo.toml'
|
|
- '**/Cargo.lock'
|
|
- 'deny.toml'
|
|
- '.github/actions/**'
|
|
- '.github/workflows/**'
|
|
- 'scripts/release/create_or_update_release.sh'
|
|
- 'scripts/security/check_preview_release_workflow.sh'
|
|
- 'scripts/security/check_workflow_pins.sh'
|
|
pull_request:
|
|
types: [ opened, synchronize, reopened, closed ]
|
|
branches: [ main ]
|
|
paths:
|
|
- '**/Cargo.toml'
|
|
- '**/Cargo.lock'
|
|
- 'deny.toml'
|
|
- '.github/actions/**'
|
|
- '.github/workflows/**'
|
|
- 'scripts/release/create_or_update_release.sh'
|
|
- 'scripts/security/check_preview_release_workflow.sh'
|
|
- 'scripts/security/check_workflow_pins.sh'
|
|
schedule:
|
|
- cron: '0 3 * * 0' # Weekly on Sunday 03:00 UTC (staggered after the midnight ci/build crons)
|
|
workflow_dispatch:
|
|
|
|
permissions:
|
|
contents: read
|
|
|
|
# Event-scoped groups: merges to main must not cancel the weekly scheduled
|
|
# run (same rationale as ci.yml).
|
|
concurrency:
|
|
group: ${{ github.workflow }}-${{ github.event_name }}-${{ github.event.pull_request.number || github.ref }}
|
|
cancel-in-progress: ${{ github.event_name != 'schedule' }}
|
|
|
|
env:
|
|
CARGO_TERM_COLOR: always
|
|
|
|
jobs:
|
|
cancel-closed-pr-runs:
|
|
name: Cancel Closed PR Runs
|
|
if: github.event_name == 'pull_request' && github.event.action == 'closed'
|
|
runs-on: ubuntu-latest
|
|
steps:
|
|
- name: Explain cancellation run
|
|
run: echo "PR closed; this run only cancels older runs in the same concurrency group."
|
|
|
|
# RustSec advisory scanning is covered by the `advisories` check of
|
|
# cargo-deny below; a separate cargo-audit job would duplicate the same
|
|
# database lookup with a second ignore list to maintain.
|
|
cargo-deny:
|
|
name: Cargo Deny
|
|
if: github.event_name != 'pull_request' || github.event.action != 'closed'
|
|
runs-on: ubuntu-latest
|
|
timeout-minutes: 20
|
|
steps:
|
|
- name: Checkout repository
|
|
uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7
|
|
|
|
# cargo-deny compiles nothing, so the full setup composite (apt packages,
|
|
# protoc, flatc, nextest, rustfmt/clippy) was pure overhead here. It does
|
|
# still need a real cargo: `cargo deny check` runs `cargo metadata`, and
|
|
# Cargo.toml pins datafusion and s3s as git dependencies, which must be
|
|
# materialised into ~/.cargo/git — a cold clone is hundreds of MB, so the
|
|
# cache stays.
|
|
- name: Install Rust toolchain
|
|
uses: dtolnay/rust-toolchain@29eef336d9b2848a0b548edc03f92a220660cdb8 # stable
|
|
|
|
# Was relying on the composite's default, which used to be "true": every
|
|
# PR touching Cargo.toml/Cargo.lock saved a second, PR-scoped copy of this
|
|
# cache and pushed the main-scoped lanes out of the 10GB quota. The
|
|
# default is now "false", but state it explicitly — see
|
|
# scripts/security/check_cache_save_if.sh.
|
|
- name: Setup Rust cache
|
|
uses: Swatinem/rust-cache@e18b497796c12c097a38f9edb9d0641fb99eee32 # v2
|
|
with:
|
|
cache-all-crates: true
|
|
cache-on-failure: true
|
|
shared-key: rustfs-cargo-deny
|
|
save-if: ${{ github.ref == 'refs/heads/main' }}
|
|
|
|
- name: Install cargo-deny
|
|
uses: taiki-e/install-action@bffeee26d4db9be238a4ea78d8826604ebcb594d # v2
|
|
with:
|
|
tool: cargo-deny
|
|
|
|
- name: Run cargo-deny
|
|
run: cargo deny check --hide-inclusion-graph advisories sources bans licenses
|
|
|
|
workflow-pin-report:
|
|
name: Workflow Pin Report
|
|
if: github.event_name != 'pull_request' || github.event.action != 'closed'
|
|
runs-on: ubuntu-latest
|
|
timeout-minutes: 5
|
|
steps:
|
|
- name: Checkout repository
|
|
uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7
|
|
|
|
- name: Report unpinned GitHub Actions
|
|
run: ./scripts/security/check_workflow_pins.sh --enforce
|
|
|
|
- name: Check setup cache-save-if is explicit
|
|
run: ./scripts/security/check_cache_save_if.sh
|
|
|
|
- name: Check preview release workflow policy
|
|
run: ./scripts/security/check_preview_release_workflow.sh
|
|
|
|
dependency-review:
|
|
name: Dependency Review
|
|
runs-on: ubuntu-latest
|
|
if: github.event_name == 'pull_request' && github.event.action != 'closed'
|
|
permissions:
|
|
contents: read
|
|
pull-requests: write
|
|
steps:
|
|
- name: Checkout repository
|
|
uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7
|
|
|
|
- name: Dependency Review
|
|
uses: actions/dependency-review-action@a1d282b36b6f3519aa1f3fc636f609c47dddb294 # v5
|
|
with:
|
|
fail-on-severity: moderate
|
|
allow-ghsas: GHSA-2f9f-gq7v-9h6m
|
|
# rustfs-uring is a first-party Apache-2.0 crate, now published on
|
|
# crates.io (backlog#1104) rather than pulled as a git dependency.
|
|
# Scope the allow to the exact pinned version so a version bump forces a
|
|
# conscious re-review of the license/provenance claim (backlog#1181).
|
|
allow-dependencies-licenses: pkg:cargo/rustfs-uring@0.1.0
|
|
comment-summary-in-pr: always
|