mirror of
https://github.com/rustfs/rustfs.git
synced 2026-09-02 02:08:41 +00:00
a80699b6dd
feat(targets): add an opt-in NATS JetStream publish path for the notify and audit targets The NATS notify and audit targets publish through NATS Core, which returns before the server has durably accepted the message. A broker restart or a connection drop between the publish and the flush loses the event, even though the send queue has already cleared it, and no acknowledgement gates that clear. An opt-in JetStream publish path clears a queued event only after the server returns a durable PublishAck, so delivery is at-least-once across a broker restart or a reconnect. It applies to both the notify and audit NATS targets, is off by default, and is byte-identical to the NATS Core path when disabled. The path includes durable store-and-forward, a stable dedup id sent as the Nats-Msg-Id header so a replayed event is collapsed by the stream duplicate window, pre-flight stream validation, and a bounded failed-events store for terminally-failed and retry-exhausted events. Three configuration keys per target select it: JETSTREAM_ENABLE, JETSTREAM_STREAM_NAME, and JETSTREAM_ACK_TIMEOUT_SECS, under the RUSTFS_NOTIFY_NATS_ and RUSTFS_AUDIT_NATS_ prefixes. The on-disk batch filename separator changes from colon to underscore so batch names are valid on Windows filesystems, with transparent read-back of files written under the previous separator. The migration affects the shared queue store for every target type and lands with this feature because the store gains its first Windows-exercised paths here. Co-authored-by: houseme <housemecn@gmail.com>
134 lines
4.6 KiB
Rust
134 lines
4.6 KiB
Rust
// Copyright 2024 RustFS Team
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
#![allow(dead_code)]
|
|
|
|
//! Audit metrics collector.
|
|
//!
|
|
//! Collects audit log metrics including failed messages, queue length,
|
|
//! and total messages per target.
|
|
//!
|
|
//! This collector reuses the metric descriptors defined in `metrics_type::audit`
|
|
//! to avoid duplication of metric names, types, and help text.
|
|
|
|
use crate::metrics::report::PrometheusMetric;
|
|
use crate::metrics::schema::audit::*;
|
|
use std::borrow::Cow;
|
|
|
|
/// Audit target statistics for metrics collection.
|
|
#[derive(Debug, Clone, Default)]
|
|
pub struct AuditTargetStats {
|
|
/// Target identifier
|
|
pub target_id: String,
|
|
/// Number of messages that failed to send
|
|
pub failed_messages: u64,
|
|
/// Number of messages held in the failed-events store
|
|
pub failed_store_length: u64,
|
|
/// Number of unsent messages in queue
|
|
pub queue_length: u64,
|
|
/// Total number of messages sent
|
|
pub total_messages: u64,
|
|
}
|
|
|
|
/// Collects audit metrics from the provided audit target statistics.
|
|
///
|
|
/// Uses the metric descriptors from `metrics_type::audit` module.
|
|
/// Returns a vector of Prometheus metrics for audit statistics.
|
|
pub fn collect_audit_metrics(stats: &[AuditTargetStats]) -> Vec<PrometheusMetric> {
|
|
if stats.is_empty() {
|
|
return Vec::new();
|
|
}
|
|
|
|
let mut metrics = Vec::with_capacity(stats.len() * 4);
|
|
for stat in stats {
|
|
let target_id_label: Cow<'static, str> = Cow::Owned(stat.target_id.clone());
|
|
|
|
metrics.push(
|
|
PrometheusMetric::from_descriptor(&AUDIT_FAILED_MESSAGES_MD, stat.failed_messages as f64)
|
|
.with_label("target_id", target_id_label.clone()),
|
|
);
|
|
metrics.push(
|
|
PrometheusMetric::from_descriptor(&AUDIT_FAILED_STORE_LENGTH_MD, stat.failed_store_length as f64)
|
|
.with_label("target_id", target_id_label.clone()),
|
|
);
|
|
metrics.push(
|
|
PrometheusMetric::from_descriptor(&AUDIT_TARGET_QUEUE_LENGTH_MD, stat.queue_length as f64)
|
|
.with_label("target_id", target_id_label.clone()),
|
|
);
|
|
metrics.push(
|
|
PrometheusMetric::from_descriptor(&AUDIT_TOTAL_MESSAGES_MD, stat.total_messages as f64)
|
|
.with_label("target_id", target_id_label),
|
|
);
|
|
}
|
|
|
|
metrics
|
|
}
|
|
|
|
#[cfg(test)]
|
|
mod tests {
|
|
use super::*;
|
|
use crate::metrics::schema::MetricType;
|
|
|
|
#[test]
|
|
fn test_collect_audit_metrics() {
|
|
let stats = vec![
|
|
AuditTargetStats {
|
|
target_id: "target-1".to_string(),
|
|
failed_messages: 5,
|
|
failed_store_length: 3,
|
|
queue_length: 10,
|
|
total_messages: 1000,
|
|
},
|
|
AuditTargetStats {
|
|
target_id: "target-2".to_string(),
|
|
failed_messages: 2,
|
|
failed_store_length: 1,
|
|
queue_length: 5,
|
|
total_messages: 500,
|
|
},
|
|
];
|
|
|
|
let metrics = collect_audit_metrics(&stats);
|
|
|
|
assert_eq!(metrics.len(), 8); // 2 targets * 4 metrics each
|
|
|
|
let failed = metrics
|
|
.iter()
|
|
.find(|m| m.value == 5.0 && m.labels.iter().any(|(k, v)| *k == "target_id" && v == "target-1"));
|
|
assert!(failed.is_some());
|
|
|
|
let failed_store = metrics.iter().find(|m| {
|
|
m.value == 3.0
|
|
&& m.name == AUDIT_FAILED_STORE_LENGTH_MD.get_full_metric_name()
|
|
&& m.labels.iter().any(|(k, v)| *k == "target_id" && v == "target-1")
|
|
});
|
|
assert!(failed_store.is_some());
|
|
}
|
|
|
|
#[test]
|
|
fn test_collect_audit_metrics_empty() {
|
|
let stats: Vec<AuditTargetStats> = vec![];
|
|
let metrics = collect_audit_metrics(&stats);
|
|
assert!(metrics.is_empty());
|
|
}
|
|
|
|
#[test]
|
|
fn audit_target_totals_are_exported_as_gauges() {
|
|
assert_eq!(AUDIT_FAILED_MESSAGES_MD.metric_type, MetricType::Gauge);
|
|
assert_eq!(AUDIT_FAILED_STORE_LENGTH_MD.metric_type, MetricType::Gauge);
|
|
assert_eq!(AUDIT_TARGET_QUEUE_LENGTH_MD.metric_type, MetricType::Gauge);
|
|
assert_eq!(AUDIT_TOTAL_MESSAGES_MD.metric_type, MetricType::Gauge);
|
|
}
|
|
}
|