mirror of
https://github.com/rustfs/rustfs.git
synced 2026-08-13 08:36:54 +00:00
houseme
2e5874f839
fix(get): give UringBackend the only fd cache for its disk (#1801) #1801 made `StdBackend::new` always build a descriptor cache. `UringBackend` wraps a `StdBackend` (`inner`), so under io_uring a disk ended up with TWO `FdCache`s: the wrapper's and the inner's. `UringBackend::pread_bytes` delegates to `inner.pread_bytes` on four fallback paths (latch-off, O_DIRECT unsupported / error, buffered-read error), which populated `inner.fd_cache` — but `UringBackend`'s invalidation only touches its own cache, so the inner cache was never invalidated. For up to `FD_CACHE_TTL` (5s) after a heal/rename/ delete, a fallback read could serve the pre-mutation inode: exactly the stale-descriptor hazard `FdCache`'s generation guard exists to close (rustfs/backlog#1176). It also double-counted `FD_CACHE_CAPACITY` (512 fds) against `RLIMIT_NOFILE` per disk (backlog#1178). Fix: `UringBackend` now constructs its inner `StdBackend` with the new `StdBackend::new_without_fd_cache`, so the wrapper owns the only cache for the disk. The inner backend opens per read on fallback, leaving nothing unguarded. `StdBackend::new` (standalone default) is unchanged; a private `build(root, build_fd_cache)` holds the shared construction. - Default (non-io_uring) path: byte-for-byte unchanged. - io_uring path: one cache per disk, fully covered by the wrapper's invalidation; halves the per-disk fd budget under `RLIMIT_NOFILE`. - `RUSTFS_IO_URING_FD_CACHE` / `RUSTFS_LOCAL_FD_CACHE` semantics preserved. - Regression test pins `new_without_fd_cache` -> no cache. Found by a post-merge re-review of the Wave 1 GET PRs. cargo check/clippy clean; Linux compile + the io_uring fd-cache suite deferred to CI. Co-authored-by: heihutu <heihutu@gmail.com>
RustFS ECStore - Erasure Coding Storage
High-performance erasure coding storage engine for RustFS distributed object storage
📖 Documentation
· 🐛 Bug Reports
· 💬 Discussions
📖 Overview
RustFS ECStore provides erasure coding storage capabilities for the RustFS distributed object storage system. For the complete RustFS experience, please visit the main RustFS repository.
✨ Features
- Reed-Solomon erasure coding implementation
- Configurable redundancy levels (N+K schemes)
- Automatic data healing and reconstruction
- Multi-drive support with intelligent placement
- Parallel encoding/decoding for performance
- Efficient disk space utilization
📚 Documentation
For comprehensive documentation, examples, and usage guides, please visit the main RustFS repository.
📄 License
This project is licensed under the Apache License 2.0 - see the LICENSE file for details.
Copyright 2024 RustFS Team
Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
RustFS is a trademark of RustFS, Inc.
All other trademarks are the property of their respective owners.
Made with ❤️ by the RustFS Storage Team