* fix(io-metrics): drop the rustfs-common edge by injecting the S3 telemetry observer
dc700d366 (#7775) made the io-metrics leaf crate depend on rustfs-common
to publish typed telemetry trace events from S3HttpRequestGuard, which
breaks the backlog#1834 leaf-crate rule (io-metrics may only depend on
rustfs-s3-ops).
S3HttpRequestGuard now takes an optional fn-pointer completion observer
(operation, latency, 2xx?) and knows nothing about the trace bus. The
server builds guards through rustfs::server::s3_http_request_guard, which
attaches the observer only while a telemetry subscriber exists and owns
the S3Operation -> TelemetryTraceOperation mapping.
* chore(guard): admit #7785 s3s ratchet growth (+1 file, +4 lines)
#7785 landed the gateway key inventory admin handler after the
baselines were verified, leaving check_s3s_footprint.sh red on main
and every branch cut from it (measured 210 files / 1592 lines vs
209/1588 baselines).
The handler follows the house admin convention whose Operation::call
signature is s3s-typed (S3Request/S3Result), so it cannot route
through a non-s3s seam until the s3gate admin migration replaces the
admin router (rustfs/backlog#1677 F1); no local refactor can shed the
file-level import. Record the measured growth with rationale:
files 209 -> 210, s3_error! lines 1588 -> 1592.
* fix
* fix: resolve clippy gate failures in connect and CLI surfaces
- Box the two large CommandResult performance variants and
LicenseRenewalOutcome::Installed (clippy::large_enum_variant)
- Return RelayError instead of () from RelayTransport::deliver and the
test destination (clippy::result_unit_err)
- Drop an unused mut on the protected relay file handle (unused_mut)
- Pass the digest by value to base64 encoding and drop a redundant
result_json clone (clippy::needless_borrows_for_generic_args,
clippy::redundant_clone)
* fix(connect): resolve the remaining site-replication clippy errors
- Group the endpoint credential triple into SiteReplicationCredentials
so SiteReplicationEndpoint::new takes 6 arguments
(clippy::too_many_arguments)
- Take the build-feature validator by &str (clippy::ptr_arg); the
validator closure stays because &String needs the deref coercion
* style: apply rustfmt to the site-replication credential grouping
* fix(connect): keep the CPU profile fixture off the ecstore import scan
#7811 used "rustfs_ecstore::disk::read_object" as the raw-symbol fixture
of the profile redaction test, which the architecture guard counts as a
direct rustfs_ecstore reference outside the compatibility boundaries
(its scan deliberately includes inline test modules). The accumulator
treats symbols opaquely, so use the internal rustfs::storage:: path that
keeps the fixture realistic without matching the import scanner.
* fix
* fix
* fix
* fix
---------
Co-authored-by: Hauser <housemecn@gmail.com>
rustfs-io-metrics
· Home · Docs · Issues · Discussions
Overview
rustfs-io-metrics is the metrics and configuration module for RustFS, a distributed object storage system. It provides:
- Cache Configuration: L1/L2 tiered cache configuration management
- Adaptive TTL: Dynamic TTL adjustment based on access frequency
- Metrics Collection: Unified metrics recording and reporting
- Bandwidth Monitoring: Real-time bandwidth observation and analysis
- Performance Metrics: I/O performance metrics collection
- Exporter Boundary: Emit via
metrics, export viarustfs-obs, no Prometheus HTTP endpoint
Features
Cache Configuration
Tiered cache configuration management:
use rustfs_io_metrics::{CacheConfig, CacheConfigError};
// Create configuration
let config = CacheConfig::new();
// Validate configuration
if let Err(e) = config.validate() {
println!("Invalid configuration: {}", e);
}
// Custom configuration
let config = CacheConfig {
max_capacity: 10_000,
default_ttl_seconds: 300,
max_memory_bytes: 100 * 1024 * 1024, // 100 MB
..Default::default()
};
Adaptive TTL
Dynamic TTL adjustment based on access frequency:
use rustfs_io_metrics::{AdaptiveTTL, AdaptiveTTLStats};
use std::time::Duration;
let config = CacheConfig::new().with_ttl_range(60, 300, 3600);
let ttl = AdaptiveTTL::new(config);
// Cold object (few accesses)
let cold_ttl = ttl.calculate_ttl(Duration::from_secs(60), 1, 0.8);
println!("Cold object TTL: {:?}", cold_ttl);
// Hot object (many accesses)
let hot_ttl = ttl.calculate_ttl(Duration::from_secs(60), 100, 0.8);
println!("Hot object TTL: {:?}", hot_ttl);
Access Tracking
Track cache item access patterns:
use rustfs_io_metrics::{AccessTracker, AccessRecord};
use std::time::Duration;
let mut tracker = AccessTracker::new(1000, Duration::from_secs(300));
// Record accesses
tracker.record_access("object-key-1", 1024);
tracker.record_access("object-key-1", 1024);
tracker.record_access("object-key-2", 2048);
// Get access count
let count = tracker.get_access_count("object-key-1");
println!("Access count: {}", count);
// Detect hot/cold
if tracker.is_hot("object-key-1", 1) {
println!("Hot object");
}
// Get top keys
let top_keys = tracker.top_keys(10);
for (key, count) in top_keys {
println!("{}: {} accesses", key, count);
}
Metrics Recording
Unified metrics recording functions:
use rustfs_io_metrics::{
// I/O scheduler metrics
record_io_scheduler_decision,
record_io_strategy_change,
record_io_load_level,
// Cache metrics
record_cache_size,
// Backpressure metrics
record_backpressure_event,
record_backpressure_state,
// Timeout metrics
record_timeout_event,
record_operation_duration,
};
// Record I/O scheduler decision
record_io_scheduler_decision("sequential", "high_priority");
// Record cache size
record_cache_size("L1", 1024, 1);
// Record backpressure event
record_backpressure_event("warning", 0.85);
// Record operation timeout
record_timeout_event("GetObject", Duration::from_secs(30));
Internode Transport Metrics
Internode metrics are recorded by src/internode_metrics.rs. Aggregate metrics
remain unlabeled for compatibility with existing dashboards:
| Metric | Meaning |
|---|---|
rustfs_system_network_internode_sent_bytes_total |
Total internode bytes sent by this node. |
rustfs_system_network_internode_recv_bytes_total |
Total internode bytes received by this node. |
rustfs_system_network_internode_requests_outgoing_total |
Total outgoing internode requests. |
rustfs_system_network_internode_requests_incoming_total |
Total incoming internode requests. |
rustfs_system_network_internode_errors_total |
Total internode errors. |
rustfs_system_network_internode_dial_errors_total |
Failed internode connection attempts. |
rustfs_system_network_internode_dial_avg_time_nanos |
Average internode dial duration. |
Operation-level metrics use the same low-cardinality label set:
| Metric | Labels | Meaning |
|---|---|---|
rustfs_system_network_internode_operation_sent_bytes_total |
operation, backend |
Bytes sent for an internode operation. |
rustfs_system_network_internode_operation_recv_bytes_total |
operation, backend |
Bytes received for an internode operation. |
rustfs_system_network_internode_operation_requests_outgoing_total |
operation, backend |
Outgoing request attempts for an internode operation. |
rustfs_system_network_internode_operation_requests_incoming_total |
operation, backend |
Incoming request attempts for an internode operation. |
rustfs_system_network_internode_operation_errors_total |
operation, backend |
Failed internode operation attempts. |
rustfs_system_network_internode_operation_classified_errors_total |
operation, backend, classification |
Classified internode transport failures. |
rustfs_system_network_internode_operation_retries_total |
operation, backend, classification |
Retry attempts for retryable internode transport failures. |
rustfs_system_network_internode_operation_retry_successes_total |
operation, backend, classification |
Successful recoveries after retryable internode transport failures. |
rustfs_system_storage_erasure_write_quorum_failures_total |
stage, dominant_error |
Erasure write quorum failures grouped by failure stage and dominant error class. |
Current operation values are read_file_stream, put_file_stream,
walk_dir, grpc_read_all, and grpc_write_all. Current backend values are
tcp-http for the InternodeDataTransport TCP/HTTP path and grpc for the
remaining gRPC byte paths. The compatibility wrapper uses unknown only for
callers that have not been classified yet.
Success/failure is intentionally not a high-cardinality label today. Failures
are represented by rustfs_system_network_internode_operation_errors_total;
successful completions are not emitted as a dedicated result-labeled metric.
Adding completion/result labels is a follow-up once stream completion semantics
are defined consistently for request setup, body transfer, and shutdown.
Current low-cardinality classification values come from the TCP/HTTP internode
path and include:
connect_timeoutconnection_refuseddns_resolution_failedconnection_resetbody_stream_abortedhttp_429http_502http_503http_504http_status_otherunknown
scripts/run_internode_transport_baseline.sh --metrics-url ... records metric
deltas with operation and backend columns, so the TCP baseline can attribute
bytes and request/error counts to tcp-http transport operations.
Module Structure
rustfs-io-metrics/
├── src/
│ ├── lib.rs # Module entry
│ ├── cache_config.rs # Cache configuration
│ ├── adaptive_ttl.rs # Adaptive TTL
│ ├── io_metrics.rs # I/O metrics
│ ├── backpressure_metrics.rs # Backpressure metrics
│ ├── deadlock_metrics.rs # Deadlock metrics
│ ├── lock_metrics.rs # Lock metrics
│ ├── timeout_metrics.rs # Timeout metrics
│ ├── internode_metrics.rs # Internode transport metrics
│ ├── bandwidth.rs # Bandwidth monitoring
│ ├── global_metrics.rs # Global metrics
│ └── performance.rs # Performance metrics
└── Cargo.toml
Testing
# Run all tests
cargo test --package rustfs-io-metrics
# Run specific tests
cargo test --package rustfs-io-metrics --lib adaptive_ttl
# Run benchmarks
cargo bench --package rustfs-io-metrics --bench metrics_pipeline
Documentation
This crate records metrics through the Rust metrics crate and leaves
exporting to rustfs-obs or the application-level observability pipeline. It
does not expose Prometheus-compatible HTTP endpoints such as
/rustfs/v2/metrics/cluster or /rustfs/v2/metrics/node.
API documentation can be generated locally:
cargo doc --package rustfs-io-metrics --no-deps --open
Useful source references:
Related Modules
- rustfs-io-core: Core I/O scheduling
- rustfs: Main storage service
License
Apache License 2.0