Files
rustfs/scripts/run_ecstore_validation_suite.sh
T
Chris 4e16705873 fix(release): backport main fixes and stabilize tier cleanup tests (#7793)
* fix(ecstore): stop pruning at nonempty directories (#7616)

* fix(ecstore): stop pruning at nonempty directories

* test(ecstore): release pruning fixtures before temp cleanup

(cherry picked from commit 8f150d1d8e)

* fix(heal): preserve retryable batch failures during recovery (#7642)

* fix(heal): preserve retryable batch failures during recovery

* test(heal): pin prebuilt hooks binaries in ci

(cherry picked from commit 5cd58319ed)

* fix(s3): reject oversize single PUT early and map body errors to 4xx (#7635)

* fix(s3): reject oversize single PUT early and map body errors to 4xx

A single PutObject above the 5 GiB single-request ceiling was only
rejected after the client had streamed 5 GiB into s3s's read-time body
budget, and the resulting BodySizeLimitExceeded surfaced from the erasure
writer as 500 InternalError. A body whose connection hit EOF before
Content-Length bytes arrived (hyper's IncompleteBody) was also a 500.
SDKs retry 500s, so one oversize upload was resent from offset 0 five
times.

- PutObject and UploadPart reject a declared length above
  MAX_SINGLE_PUT_OBJECT_SIZE with 400 EntityTooLarge before reading the
  body; the constant moves to rustfs_config so the s3s limit and the
  admission check share one value.
- ApiError maps BodySizeLimitExceeded to EntityTooLarge and a hyper body
  EOF to IncompleteBody across both io::Error conversions.

Fixes #7596.

* test(s3): cover UploadPart admission, aws-chunked length, real s3s limit

- Poll-counting test body proves PutObject and UploadPart reject a
  declared size above the ceiling with zero body polls; exact-cap and
  zero-length parts pass admission.
- A STREAMING-* aws-chunked PUT whose framed Content-Length exceeds the
  cap is admitted when the decoded length is within it and rejected when
  the decoded length is over it.
- The display-based BodySizeLimitExceeded matcher is checked against the
  real error produced by the pinned s3s Body budget.

(cherry picked from commit 50b31bc75b)

* fix(ecstore): make directory mtime fixture portable (#7623)

* fix(ecstore): make directory mtime fixture portable

* style(ecstore): format mtime fixture assertion

---------

Co-authored-by: houseme <housemecn@gmail.com>
Co-authored-by: Zhengchao An <anzhengchao@gmail.com>
(cherry picked from commit b1cc286cac)

* fix(storage): prevent readiness after native migration failures (#7652)

* fix(storage): prevent readiness after native migration failures

* fix(storage): skip unsupported IAM records before reading

* fix(storage): use stable typed migration metadata errors

* fix(storage): include migration record in startup errors

* test(storage): cover native migration startup failures

* test(storage): use array chunks in migration fixture

---------

Co-authored-by: RJ Regenold <214054+rjregenold@users.noreply.github.com>
Co-authored-by: cxymds <cxymds@gmail.com>
(cherry picked from commit 0cbc3ffe61)

* fix(admin): expose OIDC account display fields (#7654)

Expose verified OIDC username and email claims as display-only metadata on self-account responses while preserving the virtual parent as the authorization identity.\n\nKeep rustfs-madmin public response structs unchanged by adding the optional wire fields through private handler response wrappers.

(cherry picked from commit f02bc947cd)

* fix(replication): correct peer joins and remote-state reporting (#7650)

* fix(replication): propagate verified peer deployment identities

* fix(replication): report actual remote peer state

* fix(replication): defer initial sync until all peers join

* test(replication): shut down TLS fixtures cleanly

---------

Co-authored-by: houseme <housemecn@gmail.com>
(cherry picked from commit 853ae63b6a)

* fix(s3): bound stalled UploadPart request bodies (#7659)

* fix(s3): bound stalled UploadPart request bodies

* fix(ci): preserve the S3S footprint ratchet

(cherry picked from commit 666dfd9f9f)

* fix(tables): reject reserved warehouse locations (#7671)

Co-authored-by: cxymds <cxymds@gmail.com>
(cherry picked from commit 414176c47f)

* fix(ci): bind nightly lanes to one resolved source (#7688)

(cherry picked from commit 01d8e4347f)

* fix(replication): close the pre-stable convergence gaps from backlog#2367 (#7626)

* fix(replication): total-order rule sort and honor V1 top-level Prefix

Rule matching had two defects from the pre-GA replication audit
(rustfs/backlog#2367 C-1 and C-2):

- The actionable-rule sort compared same-destination rules by priority but
  answered Equal for any other pair, which is not a total order; the
  standard library sort panics on such comparators once a slice exceeds the
  insertion-sort threshold, so an object matching more than 20 enabled rules
  across two or more targets could panic the PUT or DELETE task. Rules now
  sort by priority descending with destination and id as tie-breakers, and
  filter_target_arns preserves that order instead of draining a HashSet.

- A V1 rule written without a <Filter> carries its prefix at the top level;
  that field was never read, so <Prefix>logs/</Prefix> matched every object.
  ReplicationRuleExt::prefix now falls back to it, with a <Filter> keeping
  precedence. The existing prefix fixtures were built this way and had been
  asserting nothing.

* fix(admin): advertise data-usage and listen capabilities to rc

The rc client gated `rc du` and `rc watch` on a pinned contract that
matched server versions by the string prefix `1.0.0-rc.`; a server that
reports `1.0.0` no longer matches, and the dynamic `advertised` list did
not carry either name, so `rc du` against a GA server fails with an
unsupported-capability error (rustfs/backlog#2367 E-2).

Advertise `admin.data-usage` from the admin route inventory like the IAM
entries, and `listen_notification` for the bucket `?events=` extension
route the admin router dispatches. The client merges advertised entries
ahead of its pinned contract, so no version sniffing is needed.

* fix(site-replication): stop notifying the local site on remove and rotate

The pending-remove and pending-rotation notification loops skipped the
local site by endpoint only, while finalization identifies it by
deployment id or endpoint. The reconcile tick resolves the local peer from
the node's own listen address (and a handler from the request Host), so
`remove --all` dialed the site's registered endpoint, waited out the
request timeout against the lifecycle lock it was holding, and answered
`Partial: failed to notify 1 peer(s)` for a removal that had succeeded
(rustfs/backlog#2367 A-4, backlog#2195 item 3).

Both loops now iterate the peers still awaiting notification through one
helper that applies the finalization identity.

* fix(site-replication): promote and settle IAM retries without a tick of slack

Two retry-queue behaviours kept an IAM change from converging for ten to
twenty minutes after a peer came back (rustfs/backlog#2367 A-1 and A-3,
backlog#2305):

- The lightweight 30-second pass filtered its reachability probe to bucket
  ops, so a backed-off IAM or bucket-metadata snapshot waited for the
  600-second tick to notice the peer. It now probes every backed-off class
  and still replays only bounded bucket ops; promotion is a state flip the
  heavyweight tick acts on.

- Backoffs are multiples of the tick interval, so a failure stamped δ
  seconds after a tick was 600 − δ old at the next tick and slipped a whole
  extra interval. The heavyweight drain now evaluates backoff halfway to its
  next tick.

- An IAM entry first created by a non-deletion failure (the add bootstrap's
  snapshot send, the drain's own replay, an import-iam schedule) was never
  stamped `deletions_recorded`, so a later recorded deletion could not
  settle it and it escalated to the marker only `replicate repair` clears.
  Entries created by this binary now start recorded; a row persisted by an
  older binary keeps the escalation semantics.

* fix(site-replication): reload peer node caches after bucket wiring writes

Every S3 bucket-config write ends by asking the other nodes of the cluster
to reload the bucket's metadata; the site-replication writers never did.
On a multi-node site the node that ran the pairing (or applied a peer's
bucket-meta item) rewrote the bucket targets and the derived replication
rules on disk, while every other node kept serving its cached copy for up
to the 15-minute refresh. A `resync start` routed to such a node reported
every freshly wired bucket as `Config not found` and a bucket whose
operator target the pairing had replaced as `recorded remote target no
longer exists` (rustfs/backlog#2367 A-5, backlog#2195 item 2; functional
SITE-105).

Add one best-effort reload helper in the site-replication hooks and call it
after the bucket setup, versioning, peer bucket-meta apply, removed-peer
cleanup, make-with-versioning, and endpoint-refresh writes; the ensure
helpers now report whether they wrote so unchanged passes stay silent. The
resync manifest and start now read the persisted wiring instead of the
node-local cache, matching the target read the start path already did.

The new four-node e2e pairs two clusters and starts a resync through a
non-coordinator node right after pairing; it also covers an IAM user
created on a non-coordinator node converging to the peer site.

* test(e2e): cover delete-marker replication from a multi-node source

The functional suite reported delete markers created on a 3-node source
never reaching the target (rustfs/backlog#2195 item 4, REP-105). The report
was a probe defect, but the shape had no coverage: the existing
delete-marker e2e runs a single-node source. Pin it against a four-node
source replicating to a four-node peer and to a single-node target, with
the write and the delete issued through different nodes.

* ci(e2e): refresh the distributed selection for the new replication cases

Four distributed cases were added (two site-replication, two delete-marker
replication). The linux digest is derived from the last CI listing of the
lane (34 cases, matching the previous pin) plus the four new names; the
darwin digest is the local listing, which selects the same 38 cases.

(cherry picked from commit aeaba86d73)

* fix(e2e): require a verified server binary for every e2e run (#7687)

* fix(ci): share quick checks and lint workflows

* fix(ci): install actionlint from its verified release

* fix(ci): reject dependencies on required quick checks

* feat(test): verify the E2E server build and source identity

* test(e2e): register verified Darwin test membership

* test(e2e): record verified Linux receipt test membership

* test(e2e): record compiled Darwin receipt test membership

* test(e2e): record compiled Linux receipt test membership

* test(e2e): record Darwin e2e-full membership after merging main

* fix(test): route scanner/heal evidence E2E runs through the verified server binary

The evidence runners built rustfs with plain cargo and then ran e2e_test directly, which now fails without a run receipt. They build through scripts/e2e_binary.py and run the e2e_test invocations under e2e_binary.py run; the obsolete rustfs.features stamp is removed.

* docs(e2e): run server-backed e2e commands through the verified binary wrapper

* test(e2e): record Linux e2e-full membership from the branch CI listing

(cherry picked from commit 2909b1bfe1)

* fix(kms): classify KMS/SSE error contracts and SSE-S3 headers (#7697)

* fix(sse): classify bare SSE-KMS writes when no KMS is available

A `aws:kms` request without a key id, on a bucket without a default key,
returned `500 InternalError` whenever no KMS service was running: the
"no KMS key available" branch exited with an untyped storage error before
the availability classification that the keyed form already received.

Route that branch through the same split: `503 ServiceUnavailable` while
a configured KMS is stopped, `400 InvalidRequest` when KMS was never
configured, and `400 InvalidRequest` naming the missing key id when a
running KMS has no default key. `CreateMultipartUpload` shares the path.

Adds a unit test for the bare form and an e2e module that stops KMS
through the admin API, runs a master-key-only node, and runs a Local KMS
without a default key; refreshes the e2e-full selection digests.

(cherry picked from commit c3259dadc3d603a9185a5b0ad9f83dfb884e61c8)

* fix(sse): keep KMS error classes on the encrypted read path

GetObject, CopyObject and UploadPartCopy on an SSE-KMS object whose key
no longer exists answered `500 InternalError` ("KMS key not found") while
PutObject under the same key already answered `400 KMS.NotFoundException`.
The read path carries its classification through ecstore's
`EncryptionResolutionErrorKind`, which had no kind for a missing key, a
denied KMS grant or a missing backend capability, so all three folded
onto `DecryptionFailed` and the S3 layer reported an internal fault.

Add `KeyNotFound`, `AccessDenied` and `NotImplemented` kinds, map them on
both sides of the boundary, and give an envelope the configured backend
cannot unwrap a diagnosable message while keeping its `500`.

Unit tests cover the kind round trip and the reader wrapping; a new e2e
test deletes a key immediately and checks GET/Copy return 400 with
`KMS.NotFoundException` while HEAD stays 200. The e2e-full selection
digests are refreshed from the current listing (the previous digests
predated the delete-authorization tests) and the e2e `create_default_key`
helper is updated to the accepted `EncryptDecrypt` spelling.

(cherry picked from commit 2523a9814e97caea318d4ff1a51bef3a4d4445b2)

* fix(kms): classify key-management errors on the admin routes

`POST /kms/keys`, the legacy `create-key` alias and `generate-data-key`
reported every backend refusal as `500`: a blank key name (which each
backend failed on differently, the Local backend by writing a key file
with an empty stem), a name already taken, an unknown key, a disabled key
and a capability the backend lacks. `delete` and the lifecycle routes
already classified the same errors.

Refuse a blank or whitespace name in `KmsManager::create_key` before any
backend sees it, and share one `KmsError` to status mapping across
create, delete and generate-data-key (400 for validation and key state,
404 for an unknown key, 409 for a taken name, 501 for a missing
capability, 500 only for damaged material). The XML-error routes carry
the same status explicitly since s3s derives none for a custom code.

The read-only Static backend now reports create, delete and
cancel-deletion as `UnsupportedCapability`, matching its rotate and
enable/disable answers, so the admin API returns 501 for all of them.

(cherry picked from commit e33cac5493c4d9d6662e0d2980b58ba2b24a6d1b)

* fix(sse): stop SSE-S3 responses from naming the wrapping KMS key

`x-amz-server-side-encryption-aws-kms-key-id` is defined for `aws:kms`
objects only, but PutObject, CopyObject, CreateMultipartUpload and
GetObject returned it for `AES256` objects too, carrying the KMS key that
wraps the SSE-S3 data key (the service default, or the literal `default`
on a node without KMS). The write paths copied `kms_key_id` from the
encryption material unconditionally, and the single-decrypt GET
classification did the same after resolving the key for authorization.

Add `EncryptionMaterial::response_kms_key_id`, which yields the id only
for SSE-KMS, use it at the four write-response sites, and gate the GET
classification the same way. CompleteMultipartUpload and HeadObject
already omitted the header.

Unit tests pin both directions; a new e2e test covers Put/Get/Head/Copy
and CreateMultipartUpload for AES256 with an aws:kms control. The
e2e-full selection digests are refreshed from the current listing.

(cherry picked from commit 29d793a63352b0b60fd53c565e80fdbede8964bb)

* fix(s3): validate PutBucketEncryption rules before storing them

A default-encryption rule naming an unknown `SSEAlgorithm` (for example
`AES128`), a rule without `ApplyServerSideEncryptionByDefault`, an empty
rule list, or a `KMSMasterKeyID` on an `AES256` rule was stored as
written: the only algorithm check on the route decided whether to fill
in the default KMS key. `GetBucketEncryption` then advertised that
configuration while the write path encrypted header-less writes under
its `AES256` fallback, so the bucket's declared and actual schemes
disagreed. Two comments claimed the route already refused unknown
algorithms.

Validate the configuration before any of it is applied: `MalformedXML`
for a malformed rule set or unknown algorithm, `InvalidArgument` for a
key id on a non-KMS rule, and nothing stored on refusal. Correct the two
comments to describe when the AES256 fallback is still reachable.

Unit tests cover every refusal and the accepted shapes; an e2e test
checks the refusals leave the previous configuration in place. The
e2e-full selection digests are refreshed from the current listing.

(cherry picked from commit 29e4486dce41197ed93f5253cdbabc57d27a4ddb)

* test(e2e): refresh e2e-full selection for the combined KMS/SSE fixes

* test: align two unit tests with the new KMS and bucket-encryption contracts

`scheduled_deletion_carries_a_deadline_and_can_be_cancelled` still
expects the state error (`InvalidOperation`) for cancelling a key that
is not pending deletion; only the Static backend's mutations moved to
`UnsupportedCapability`. The uninitialized-store PutBucketEncryption
test now sends a well-formed AES256 rule so it reaches the store lookup
instead of the new configuration validation.

(cherry picked from commit e2e6a2535a)

* fix(site-replication): keep an operator's bucket-level target to a peer instead of taking it over (#7709)

* fix(site-replication): keep an operator's bucket-level target to a peer instead of taking it over

Site replication wired each bucket by looking for an existing replication
target "to the same peer" and rewriting the first match in place as its own
same-name target. An operator's bucket-level target that happened to point
at that site (different target bucket, operator credentials) was the first
match whenever it pre-dated the join, and the reconciler repeats the pass
every 600s, so the takeover also depended on target order afterwards. The
operator's rule then named an ARN no target backed and their bucket
replication stopped silently, while the inherited bucket-level reset id
made every site resync report the bucket as owned by another resync
(rustfs/backlog#2479, rustfs/backlog#2489).

Follow MinIO's `getRemoteARN` / `getRemoteARNForPeer` shape instead:

- Wiring updates a target in place only under the same ARN, or when it is
  recognisably the site's own under an older ARN shape (same peer,
  same-name target bucket, site replication service account). Anything
  else gets the site target added next to it.
- The site resync manifest takes the target the derived
  `site-repl-<deployment id>` rule names (same-name shape as fallback), so
  an operator target to the peer neither aborts the bucket as "multiple
  remote targets matched peer" nor gets resynced into.
- Peer removal prunes only targets a pruned derived rule names or the
  same-name target bucket; operator targets stamped with the peer's
  deployment id survive together with their rules.

Unit tests cover the three predicates. e2e
`test_site_replication_keeps_operator_bucket_target_to_peer` runs a
bucket-level replication plus `replication-reset` to the future peer, joins
the sites, and requires the operator target untouched, both paths
delivering, the site resync completing against the site target, and the
operator target and rule surviving `replicate remove --all`; without the
fix it fails at the join with the operator target gone. The repl-nightly
selection digest is refreshed for the new case.

* test(site-replication): drop a redundant clone flagged by clippy

The reconcile unit test cloned the remote peer into the state map although
the binding is not used afterwards; workspace clippy (-D warnings) rejects
that as redundant_clone.

(cherry picked from commit ecdc55fa4b)

* fix: enforce S3 permissions for recursive force deletion (#7661)

* fix: enforce S3 authorization for recursive deletion

* fix: satisfy the s3s footprint guard

* fix: restore list versions policy compatibility (#7686)

(cherry picked from commit 3fd1ce414d)

* fix(ci): repair functional defaults and chain regression checks (#7664)

* fix(ci): default functional suites to nightly packages

* test(ci): follow the fault-tolerance chain handoff

(cherry picked from commit 509a0fa90c)

* fix(ci): align security workflow tests with chain (#7679)

(cherry picked from commit d9e47d2813)

* test(ecstore): keep tier cleanup tests stable after immediate receipt queueing

Release PR #7766 made PUT/CopyObject overwrites queue the tier free-version cleanup receipt immediately, which broke two ecstore tests on release CI. In tier_overwrite_put_and_self_copy_recover_persisted_cleanup_owners the restarted store already runs expiry workers from the second iteration on, so they deleted the remote bytes before the test could assert that the commit leaves them in place; the test now fails the first remote DELETE via set_remove_failure(true) so the cleanup owner stays durable and the later restart still has to rediscover it from xl.meta (the failed remove does not bump remove_count, and the test re-enables removes before the recovery wait). In batch_transitioned_delete_post_commit_failures_roll_back_without_free_version_receipt the convergence loop now treats a transient InsufficientReadQuorum as "not yet converged", because cleanup rewrites xl.meta disk by disk and a racing read can briefly miss quorum (seen in the rio-v2 lane); any other error still panics.

* Revert "fix(ci): align security workflow tests with chain (#7679)"

This reverts commit 4544359f6d.

* Revert "fix(ci): repair functional defaults and chain regression checks (#7664)"

This reverts commit 5ba7ec0291.

* fix(ecstore): pass shard integrity to backported ingest-mode test

The stalled-reader test backported with #7659 used main's four-argument encode_with_ingest_mode, but release's signature takes an optional IntegrityBuilder, so pass None to keep the test focused on ingest-mode cleanup.

---------

Co-authored-by: Henry Guo <marshawcoco@gmail.com>
Co-authored-by: 唐小鸭 <tangtang1251@qq.com>
Co-authored-by: houseme <housemecn@gmail.com>
Co-authored-by: RJ Regenold <rregenold@teamraft.com>
Co-authored-by: RJ Regenold <214054+rjregenold@users.noreply.github.com>
Co-authored-by: cxymds <cxymds@gmail.com>
Co-authored-by: GatewayJ <835269233@qq.com>
Co-authored-by: Jason Kossis <jkossis@gmail.com>
2026-09-14 07:51:15 +08:00

599 lines
21 KiB
Bash
Executable File

#!/usr/bin/env bash
set -euo pipefail
PROFILE="quick"
OUT_DIR=""
DRY_RUN=false
SKIP_E2E=false
SKIP_S3_TESTS=false
SKIP_COVERAGE=false
REQUIRE_FIXTURES=false
UNIT_COVERAGE_MIN="95"
UNIT_COVERAGE_TARGET="100"
UNIT_COVERAGE_SCOPE="ec-critical"
# These two tests bootstrap process-wide ECStore state, so each runs in its
# own cargo-test process and is skipped from every aggregate --lib run.
# Single source of truth: the isolated steps, ecstore-lib-all, and
# run_coverage all read these, so a test rename is a one-line update here
# (and a stale name fails loudly via run_filtered_test_step).
readonly ISOLATED_BUCKET_MIGRATION_TEST="bucket::migration::tests::migrates_real_minio_bucket_metadata_end_to_end"
readonly ISOLATED_DELETE_LOCK_GATING_TEST="set_disk::ops::object::delete_objects_lock_gating_tests::delete_objects_blocks_locked_object_and_deletes_the_rest"
usage() {
cat <<'USAGE'
Usage:
scripts/run_ecstore_validation_suite.sh [options]
Profiles:
quick Core EC read/write/recovery checks for PR smoke (default)
full quick + s3-tests subset + fixture tests + coverage
destructive full + cluster/concurrency/destructive recovery checks
fuzz bounded fuzz smoke for malformed storage inputs
Options:
--profile <quick|full|destructive|fuzz>
--out-dir <path> Default: target/ecstore-validation/<timestamp>
--skip-e2e Skip e2e_test commands
--skip-s3-tests Skip scripts/s3-tests/run.sh in full/destructive
--skip-coverage Explicitly skip the mandatory unit coverage gate
--unit-coverage-min <percent>
Minimum rustfs-ecstore unit line coverage (default: 95)
--unit-coverage-scope <ec-critical|crate>
Coverage scope for the hard gate (default: ec-critical)
--require-fixtures Fail when optional EC fixture tests cannot run
--dry-run Print commands and write metadata without executing
-h, --help
Artifacts:
<out-dir>/run-metadata.env
<out-dir>/summary.tsv
<out-dir>/blackbox-matrix.tsv
<out-dir>/logs/*.log
USAGE
}
arg_value() {
local flag="$1"
local value="${2:-}"
if [[ -z "$value" || "$value" == --* ]]; then
echo "ERROR: missing value for $flag" >&2
exit 1
fi
printf '%s\n' "$value"
}
parse_args() {
while [[ $# -gt 0 ]]; do
case "$1" in
--profile) PROFILE="$(arg_value "$1" "${2:-}")"; shift 2 ;;
--out-dir) OUT_DIR="$(arg_value "$1" "${2:-}")"; shift 2 ;;
--skip-e2e) SKIP_E2E=true; shift ;;
--skip-s3-tests) SKIP_S3_TESTS=true; shift ;;
--skip-coverage) SKIP_COVERAGE=true; shift ;;
--unit-coverage-min) UNIT_COVERAGE_MIN="$(arg_value "$1" "${2:-}")"; shift 2 ;;
--unit-coverage-scope) UNIT_COVERAGE_SCOPE="$(arg_value "$1" "${2:-}")"; shift 2 ;;
--require-fixtures) REQUIRE_FIXTURES=true; shift ;;
--dry-run) DRY_RUN=true; shift ;;
-h|--help) usage; exit 0 ;;
*)
echo "ERROR: unknown arg: $1" >&2
usage
exit 1
;;
esac
done
}
validate_args() {
case "$PROFILE" in
quick|full|destructive|fuzz) ;;
*)
echo "ERROR: --profile must be quick, full, destructive, or fuzz" >&2
exit 1
;;
esac
if ! [[ "$UNIT_COVERAGE_MIN" =~ ^([0-9]|[1-9][0-9]|100)(\.[0-9]+)?$ ]]; then
echo "ERROR: --unit-coverage-min must be between 0 and 100" >&2
exit 1
fi
case "$UNIT_COVERAGE_SCOPE" in
ec-critical|crate) ;;
*)
echo "ERROR: --unit-coverage-scope must be ec-critical or crate" >&2
exit 1
;;
esac
}
setup_workspace() {
local root
root="$(git rev-parse --show-toplevel)"
cd "$root"
if [[ -z "$OUT_DIR" ]]; then
OUT_DIR="target/ecstore-validation/$(date -u +%Y%m%dT%H%M%SZ)"
fi
mkdir -p "$OUT_DIR/logs"
SUMMARY="$OUT_DIR/summary.tsv"
BLACKBOX_MATRIX="$OUT_DIR/blackbox-matrix.tsv"
printf 'status\tlabel\tlog\n' >"$SUMMARY"
}
write_metadata() {
{
printf 'profile=%s\n' "$PROFILE"
printf 'started_at=%s\n' "$(date -u +%Y-%m-%dT%H:%M:%SZ)"
printf 'dry_run=%s\n' "$DRY_RUN"
printf 'skip_e2e=%s\n' "$SKIP_E2E"
printf 'skip_s3_tests=%s\n' "$SKIP_S3_TESTS"
printf 'skip_coverage=%s\n' "$SKIP_COVERAGE"
printf 'unit_coverage_min=%s\n' "$UNIT_COVERAGE_MIN"
printf 'unit_coverage_target=%s\n' "$UNIT_COVERAGE_TARGET"
printf 'unit_coverage_scope=%s\n' "$UNIT_COVERAGE_SCOPE"
printf 'require_fixtures=%s\n' "$REQUIRE_FIXTURES"
printf 'git_commit=%s\n' "$(git rev-parse HEAD 2>/dev/null || true)"
printf 'git_branch=%s\n' "$(git branch --show-current 2>/dev/null || true)"
printf 'rustc=%s\n' "$(rustc --version 2>/dev/null || true)"
printf 'cargo=%s\n' "$(cargo --version 2>/dev/null || true)"
} >"$OUT_DIR/run-metadata.env"
}
safe_label() {
printf '%s\n' "$1" | tr -c 'A-Za-z0-9_.-' '_'
}
quote_command() {
local quoted=()
local arg
for arg in "$@"; do
quoted+=("$(printf '%q' "$arg")")
done
printf '%s ' "${quoted[@]}"
}
record_skip() {
local label="$1"
local reason="$2"
local log="$OUT_DIR/logs/$(safe_label "$label").log"
printf 'SKIP: %s\n' "$reason" | tee "$log"
printf 'SKIP\t%s\t%s\n' "$label" "$log" >>"$SUMMARY"
}
run_step() {
local label="$1"
shift
local log="$OUT_DIR/logs/$(safe_label "$label").log"
{
printf 'label=%s\n' "$label"
printf 'command='
quote_command "$@"
printf '\n'
} >"$log"
if [[ "$DRY_RUN" == "true" ]]; then
printf 'DRY-RUN: '
quote_command "$@"
printf '\n'
printf 'DRY_RUN\t%s\t%s\n' "$label" "$log" >>"$SUMMARY"
return 0
fi
printf 'RUN: %s\n' "$label"
if "$@" 2>&1 | tee -a "$log"; then
printf 'PASS\t%s\t%s\n' "$label" "$log" >>"$SUMMARY"
else
local status=$?
printf 'FAIL\t%s\t%s\n' "$label" "$log" >>"$SUMMARY"
return "$status"
fi
}
# cargo test exits 0 when a filter matches nothing ("running 0 tests"), so a
# renamed test would let a filtered gate pass vacuously. Run the command,
# mirror its output (run_step's tee still sees the live stream), and fail
# unless libtest reports at least one matched test ("running 1 test",
# "running 12 tests", ...). If libtest ever rewords that line, this fails
# loudly instead of passing silently — the safe direction.
require_matched_tests() {
local scratch="$1"
shift
local status=0
"$@" 2>&1 | tee "$scratch" || status=$?
if [[ "$status" -ne 0 ]]; then
return "$status"
fi
if ! grep -qE '^running [1-9][0-9]* tests?$' "$scratch"; then
printf 'ERROR: test filter matched 0 tests (test renamed or moved?): '
quote_command "$@"
printf '\n'
return 1
fi
}
run_filtered_test_step() {
local label="$1"
shift
run_step "$label" require_matched_tests "$OUT_DIR/logs/$(safe_label "$label").tests.log" "$@"
}
run_core_unit_steps() {
run_step "filemeta-lib" cargo test -p rustfs-filemeta --lib
run_filtered_test_step "ecstore-erasure-lib" cargo test -p rustfs-ecstore --lib erasure
run_filtered_test_step "ecstore-set-disk-read-lib" cargo test -p rustfs-ecstore --lib set_disk::read
run_filtered_test_step "ecstore-io-primitives-lib" cargo test -p rustfs-ecstore --lib set_disk::core::io_primitives
run_filtered_test_step "ecstore-rename-rollback" \
cargo test -p rustfs-ecstore --lib set_disk::tests::test_rename_data_quorum_failure_rolls_back_destination_object
run_filtered_test_step "ecstore-disk-local-lib" cargo test -p rustfs-ecstore --lib disk::local
run_filtered_test_step "ecstore-global-bucket-migration" \
cargo test -p rustfs-ecstore --lib "$ISOLATED_BUCKET_MIGRATION_TEST" -- --exact
run_filtered_test_step "ecstore-global-delete-lock-gating" \
cargo test -p rustfs-ecstore --lib "$ISOLATED_DELETE_LOCK_GATING_TEST" -- --exact
run_step "ecstore-lib-all" cargo test -p rustfs-ecstore --lib -- --test-threads=1 \
--skip "$ISOLATED_BUCKET_MIGRATION_TEST" \
--skip "$ISOLATED_DELETE_LOCK_GATING_TEST"
}
run_quick_e2e_steps() {
if [[ "$SKIP_E2E" == "true" ]]; then
record_skip "e2e-quick" "--skip-e2e was set"
return
fi
run_step "build-e2e-server" python3 scripts/e2e_binary.py build
run_step "e2e-reliability-disk-fault" python3 scripts/e2e_binary.py run -- cargo test --package e2e_test reliability_disk_fault_test -- --nocapture
run_step "e2e-heal-erasure-disk-rebuild" python3 scripts/e2e_binary.py run -- cargo test --package e2e_test heal_erasure_disk_rebuild_test -- --nocapture
run_step "e2e-namespace-lock-quorum" python3 scripts/e2e_binary.py run -- cargo test --package e2e_test namespace_lock_quorum_test -- --nocapture
}
run_quick_profile() {
run_core_unit_steps
run_quick_e2e_steps
}
fixture_available() {
[[ -n "${RUSTFS_MINIO_FIXTURE_ROOT:-}" && -d "${RUSTFS_MINIO_FIXTURE_ROOT}" && -n "${RUSTFS_MINIO_STATIC_KMS_KEY_B64:-}" ]]
}
legacy_fixture_available() {
local root="${RUSTFS_LEGACY_TEST_ROOT:-$(pwd)}"
local disk="${RUSTFS_LEGACY_TEST_DISK:-}"
if [[ -z "$disk" ]]; then
if [[ -f "$root/test/.minio.sys/format.json" ]]; then
disk="test"
else
disk="test1"
fi
fi
if [[ ! -f "$root/$disk/.rustfs.sys/format.json" && ! -f "$root/$disk/.minio.sys/format.json" ]]; then
return 1
fi
[[ -f "$root/$disk/vvvv/ktvzip.tar.gz/xl.meta" || -f "$root/$disk/vvvv/path_traversal.md/xl.meta" ]]
}
minio_fixture_missing_reason() {
if [[ -z "${RUSTFS_MINIO_FIXTURE_ROOT:-}" ]]; then
printf 'RUSTFS_MINIO_FIXTURE_ROOT is not set\n'
elif [[ ! -d "${RUSTFS_MINIO_FIXTURE_ROOT}" ]]; then
printf 'RUSTFS_MINIO_FIXTURE_ROOT does not exist: %s\n' "$RUSTFS_MINIO_FIXTURE_ROOT"
elif [[ -z "${RUSTFS_MINIO_STATIC_KMS_KEY_B64:-}" ]]; then
printf 'RUSTFS_MINIO_STATIC_KMS_KEY_B64 is not set\n'
else
printf 'unknown MinIO fixture gate failure\n'
fi
}
write_blackbox_matrix() {
local e2e_status="enabled"
local s3_status="enabled"
local destructive_status="enabled"
local legacy_status="missing-optional"
local minio_status="missing-optional"
if [[ "$SKIP_E2E" == "true" ]]; then
e2e_status="disabled"
destructive_status="disabled"
fi
if [[ "$SKIP_S3_TESTS" == "true" ]]; then
s3_status="disabled"
fi
if legacy_fixture_available; then
legacy_status="enabled"
elif [[ "$REQUIRE_FIXTURES" == "true" ]]; then
legacy_status="missing-required"
fi
if fixture_available; then
minio_status="enabled"
elif [[ "$REQUIRE_FIXTURES" == "true" ]]; then
minio_status="missing-required"
fi
{
printf 'profile\tscenario\tgate\tcommand\tfixture_env\tstatus\n'
printf 'quick\tsingle-node disk fault read/write\tblack-box\tpython3 scripts/e2e_binary.py run -- cargo test --package e2e_test reliability_disk_fault_test -- --nocapture\tnone\t%s\n' "$e2e_status"
printf 'quick\theal degraded erasure disk rebuild\tblack-box\tpython3 scripts/e2e_binary.py run -- cargo test --package e2e_test heal_erasure_disk_rebuild_test -- --nocapture\tnone\t%s\n' "$e2e_status"
printf 'quick\tnamespace lock quorum under EC ops\tblack-box\tpython3 scripts/e2e_binary.py run -- cargo test --package e2e_test namespace_lock_quorum_test -- --nocapture\tnone\t%s\n' "$e2e_status"
printf 'full\tlegacy bitrot read fixture restore\tfixture\tcargo test -p rustfs-ecstore --test legacy_bitrot_read_test -- --nocapture\tRUSTFS_LEGACY_TEST_ROOT,RUSTFS_LEGACY_TEST_DISK\t%s\n' "$legacy_status"
printf 'full\tMinIO generated encrypted read and negative restore fixture\tfixture\tcargo test -p rustfs --features rio-v2 storage::minio_generated_read_test --lib -- --ignored --nocapture\tRUSTFS_MINIO_FIXTURE_ROOT,RUSTFS_MINIO_STATIC_KMS_KEY_B64\t%s\n' "$minio_status"
printf 'full\tS3 multipart range versioning delete subset\tblack-box\tenv TESTEXPR=\"multipart or range or versioning or delete\" DEPLOY_MODE=build MAXFAIL=0 ./scripts/s3-tests/run.sh\tnone\t%s\n' "$s3_status"
printf 'destructive\tdistributed cluster concurrency\tblack-box\tpython3 scripts/e2e_binary.py run -- cargo test --package e2e_test cluster_concurrency_test -- --nocapture\tnone\t%s\n' "$destructive_status"
printf 'destructive\tstale multipart cleanup cluster\tblack-box\tpython3 scripts/e2e_binary.py run -- cargo test --package e2e_test stale_multipart_cleanup_cluster_test -- --nocapture\tnone\t%s\n' "$destructive_status"
printf 'destructive\tdelete marker migration semantics\tblack-box\tpython3 scripts/e2e_binary.py run -- cargo test --package e2e_test delete_marker_migration_semantics_test -- --nocapture\tnone\t%s\n' "$destructive_status"
} >"$BLACKBOX_MATRIX"
}
run_fixture_gate() {
local label="ecstore-fixture-gate"
local log="$OUT_DIR/logs/$(safe_label "$label").log"
local legacy_ok=false
local minio_ok=false
if legacy_fixture_available; then
legacy_ok=true
fi
if fixture_available; then
minio_ok=true
fi
{
printf 'label=%s\n' "$label"
printf 'legacy_fixture_available=%s\n' "$legacy_ok"
printf 'minio_fixture_available=%s\n' "$minio_ok"
printf 'require_fixtures=%s\n' "$REQUIRE_FIXTURES"
if [[ "$minio_ok" != "true" ]]; then
printf 'minio_fixture_reason=%s\n' "$(minio_fixture_missing_reason)"
fi
} | tee "$log"
if [[ "$DRY_RUN" == "true" ]]; then
printf 'DRY_RUN\t%s\t%s\n' "$label" "$log" >>"$SUMMARY"
return 0
fi
if [[ "$legacy_ok" == "true" && "$minio_ok" == "true" ]]; then
printf 'PASS\t%s\t%s\n' "$label" "$log" >>"$SUMMARY"
return 0
fi
if [[ "$REQUIRE_FIXTURES" == "true" ]]; then
printf 'FAIL\t%s\t%s\n' "$label" "$log" >>"$SUMMARY"
return 1
fi
printf 'SKIP\t%s\t%s\n' "$label" "$log" >>"$SUMMARY"
}
run_fixture_steps() {
if legacy_fixture_available; then
run_step "ecstore-legacy-bitrot-read-fixture" cargo test -p rustfs-ecstore --test legacy_bitrot_read_test -- --nocapture
elif [[ "$REQUIRE_FIXTURES" == "true" ]]; then
echo "ERROR: RUSTFS_LEGACY_TEST_ROOT/RUSTFS_LEGACY_TEST_DISK is required for legacy bitrot fixture tests" >&2
exit 1
else
record_skip "ecstore-legacy-bitrot-read-fixture" "legacy bitrot fixture is not present"
fi
if fixture_available; then
run_step "ecstore-minio-generated-read-fixture" \
cargo test -p rustfs --features rio-v2 storage::minio_generated_read_test --lib -- --ignored --nocapture
elif [[ "$REQUIRE_FIXTURES" == "true" ]]; then
echo "ERROR: $(minio_fixture_missing_reason)" >&2
exit 1
else
record_skip "ecstore-minio-generated-read-fixture" "$(minio_fixture_missing_reason)"
fi
}
run_s3_subset() {
if [[ "$SKIP_S3_TESTS" == "true" ]]; then
record_skip "s3-tests-ec-subset" "--skip-s3-tests was set"
return
fi
run_step "s3-tests-ec-subset" \
env TESTEXPR="multipart or range or versioning or delete" DEPLOY_MODE=build MAXFAIL=0 ./scripts/s3-tests/run.sh
}
write_coverage_reports() {
local lcov_path="$1"
local coverage_summary="$2"
local coverage_files="$3"
local root="$4"
awk -v root="$root" -v scope="$UNIT_COVERAGE_SCOPE" -v summary="$coverage_summary" -v files="$coverage_files" '
function is_crate_file(f) {
return index(f, root "/crates/ecstore/src/") == 1
}
function is_ec_critical_file(f) {
return index(f, root "/crates/ecstore/src/erasure/") == 1 ||
f == root "/crates/ecstore/src/set_disk/read.rs" ||
f == root "/crates/ecstore/src/set_disk/shard_source.rs" ||
f == root "/crates/ecstore/src/set_disk/metadata.rs" ||
f == root "/crates/ecstore/src/set_disk/ops/object.rs" ||
f == root "/crates/ecstore/src/set_disk/core/io_primitives.rs" ||
f == root "/crates/ecstore/src/disk/local.rs"
}
function is_gate_file(f) {
return scope == "crate" ? is_crate_file(f) : is_ec_critical_file(f)
}
function pct(hit, found) {
return found == 0 ? 0 : (hit / found) * 100
}
function flush() {
if (file == "") {
return
}
if (is_crate_file(file)) {
crate_hit += hit
crate_found += found
}
if (is_ec_critical_file(file)) {
ec_hit += hit
ec_found += found
}
if (is_gate_file(file)) {
gate_hit += hit
gate_found += found
}
if (is_crate_file(file)) {
printf "%s\t%.2f\t%d\t%d\n", file, pct(hit, found), hit, found >> files
}
}
BEGIN {
print "file\tline_coverage\thit\tfound" > files
}
/^SF:/ {
flush()
file = substr($0, 4)
hit = 0
found = 0
next
}
/^LH:/ { hit += substr($0, 4); next }
/^LF:/ { found += substr($0, 4); next }
END {
flush()
if (gate_found == 0) {
exit 2
}
print "metric\tactual\tmin\ttarget\tscope" > summary
printf "gate_line_coverage\t%.2f\t%s\t%s\t%s\n", pct(gate_hit, gate_found), min, target, scope >> summary
printf "ec_critical_line_coverage\t%.2f\t%s\t%s\tec-critical\n", pct(ec_hit, ec_found), min, target >> summary
printf "crate_line_coverage\t%.2f\t%s\t%s\tcrate\n", pct(crate_hit, crate_found), min, target >> summary
}
' min="$UNIT_COVERAGE_MIN" target="$UNIT_COVERAGE_TARGET" "$lcov_path"
}
run_coverage() {
if [[ "$SKIP_COVERAGE" == "true" ]]; then
record_skip "ecstore-coverage" "--skip-coverage was set"
return
fi
local label="ecstore-unit-coverage"
local log="$OUT_DIR/logs/$(safe_label "$label").log"
local coverage_dir="$OUT_DIR/coverage/ecstore"
local lcov_path="$coverage_dir/lcov.info"
local coverage_summary="$coverage_dir/summary.tsv"
local coverage_files="$coverage_dir/files.tsv"
local cmd=(
cargo llvm-cov -p rustfs-ecstore --lib --lcov --output-path "$lcov_path" -- --test-threads=1
--skip "$ISOLATED_BUCKET_MIGRATION_TEST"
--skip "$ISOLATED_DELETE_LOCK_GATING_TEST"
)
local root
root="$(pwd)"
mkdir -p "$coverage_dir"
{
printf 'label=%s\n' "$label"
printf 'unit_coverage_min=%s\n' "$UNIT_COVERAGE_MIN"
printf 'unit_coverage_target=%s\n' "$UNIT_COVERAGE_TARGET"
printf 'unit_coverage_scope=%s\n' "$UNIT_COVERAGE_SCOPE"
printf 'command='
quote_command "${cmd[@]}"
printf '\n'
} >"$log"
if [[ "$DRY_RUN" == "true" ]]; then
printf 'DRY-RUN: '
quote_command "${cmd[@]}"
printf '\n'
printf 'DRY_RUN\t%s\t%s\n' "$label" "$log" >>"$SUMMARY"
return
fi
if ! command -v cargo-llvm-cov >/dev/null 2>&1; then
printf 'ERROR: cargo-llvm-cov is required for the ECStore unit coverage gate\n' | tee -a "$log"
printf 'FAIL\t%s\t%s\n' "$label" "$log" >>"$SUMMARY"
return 127
fi
printf 'RUN: %s\n' "$label"
if "${cmd[@]}" 2>&1 | tee -a "$log"; then
:
else
local status=$?
printf 'FAIL\t%s\t%s\n' "$label" "$log" >>"$SUMMARY"
return "$status"
fi
if ! write_coverage_reports "$lcov_path" "$coverage_summary" "$coverage_files" "$root"; then
printf 'ERROR: unable to compute scoped coverage from %s\n' "$lcov_path" | tee -a "$log"
printf 'FAIL\t%s\t%s\n' "$label" "$log" >>"$SUMMARY"
return 1
fi
local line_coverage
line_coverage="$(awk -F '\t' '$1 == "gate_line_coverage" { print $2 }' "$coverage_summary")"
printf 'gate_line_coverage=%s%% scope=%s min=%s%% target=%s%%\n' \
"$line_coverage" "$UNIT_COVERAGE_SCOPE" "$UNIT_COVERAGE_MIN" "$UNIT_COVERAGE_TARGET" | tee -a "$log"
printf 'coverage_summary=%s\ncoverage_files=%s\n' "$coverage_summary" "$coverage_files" | tee -a "$log"
if awk -v actual="$line_coverage" -v min="$UNIT_COVERAGE_MIN" 'BEGIN { exit !(actual + 0 >= min + 0) }'; then
printf 'PASS\t%s\t%s\n' "$label" "$log" >>"$SUMMARY"
else
printf 'FAIL: %s coverage %s%% is below %s%%\n' "$UNIT_COVERAGE_SCOPE" "$line_coverage" "$UNIT_COVERAGE_MIN" | tee -a "$log"
printf 'FAIL\t%s\t%s\n' "$label" "$log" >>"$SUMMARY"
return 1
fi
}
run_full_profile() {
run_quick_profile
run_fixture_gate
run_fixture_steps
run_s3_subset
run_coverage
}
run_destructive_profile() {
run_full_profile
# Deterministic rename_data crash-consistency harness (rustfs/backlog#935
# HP-14 / test plan rustfs/backlog#896): injects a hard power loss at each
# pre-commit step across strict/relaxed durability and asserts the object
# reopens as old-or-new, never a mixed/corrupt version (rustfs/backlog#878
# hard rule). Unit-level, so it runs even when --skip-e2e drops the cluster
# scenarios below.
run_filtered_test_step "ecstore-crash-consistency" \
cargo test -p rustfs-ecstore --lib disk::local::test::crash_consistency -- --test-threads=1
if [[ "$SKIP_E2E" == "true" ]]; then
record_skip "e2e-destructive" "--skip-e2e was set"
return
fi
run_step "e2e-cluster-concurrency" python3 scripts/e2e_binary.py run -- cargo test --package e2e_test cluster_concurrency_test -- --nocapture
run_step "e2e-stale-multipart-cleanup-cluster" python3 scripts/e2e_binary.py run -- cargo test --package e2e_test stale_multipart_cleanup_cluster_test -- --nocapture
run_step "e2e-delete-marker-migration-semantics" python3 scripts/e2e_binary.py run -- cargo test --package e2e_test delete_marker_migration_semantics_test -- --nocapture
}
run_fuzz_profile() {
local max_total_time="${MAX_TOTAL_TIME:-60}"
run_step "fuzz-storage-inputs" env MAX_TOTAL_TIME="$max_total_time" ./scripts/fuzz/run.sh
}
main() {
parse_args "$@"
validate_args
setup_workspace
write_metadata
write_blackbox_matrix
case "$PROFILE" in
quick) run_quick_profile ;;
full) run_full_profile ;;
destructive) run_destructive_profile ;;
fuzz) run_fuzz_profile ;;
esac
printf 'summary=%s\n' "$SUMMARY"
printf 'artifacts=%s\n' "$OUT_DIR"
}
main "$@"