mirror of
https://github.com/rustfs/rustfs.git
synced 2026-07-26 16:28:15 +00:00
Zhengchao An
73a30178f5
The capacity scan's timeout fallback required the exact prefix (threshold + sample_rate files, default ~200k) to be fully enumerated before any sample existed. Cold-cache HDDs cannot stat that many files inside the 15s budget, so large slow disks — exactly the disks sampling was designed for — always timed out with sampled_count == 0, discarded the accumulated exact-prefix work with a hard error, and re-ran 15s of useless full-disk I/O every 120s (S03). When a sample did exist, the estimate only extrapolated over files the walker had seen, silently under-reporting disks whose tail was never reached (S10). - Enter sampling early: once half the (possibly dynamic) time budget is consumed and the exact prefix hasn't filled, freeze the threshold at the current position so the remaining budget collects samples and the timeout fallback is always reachable. - Compensate the unseen tail: when the scan root is a dedicated mount point (stat st_dev differs from the parent), take the max of the seen-files extrapolation and the filesystem-level used bytes. On shared filesystems (multi-disk dev layouts) statvfs would overcount, so it is not trusted and behavior is unchanged. - sampled_count == 0 at timeout no longer hard-fails when a dedicated mount provides filesystem usage; the exact prefix is kept as a floor. Without any estimator the original error still surfaces. - Extract ScanLimits from env reading so the blocking scanner is parameterizable in tests. Ref: rustfs/backlog#1013 (S03+S10 from audit rustfs/backlog#1010)
53 lines
1.6 KiB
TOML
53 lines
1.6 KiB
TOML
# Copyright 2024 RustFS Team
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License");
|
|
# you may not use this file except in compliance with the License.
|
|
# You may obtain a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS,
|
|
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
# See the License for the specific language governing permissions and
|
|
# limitations under the License.
|
|
|
|
[package]
|
|
name = "rustfs-object-capacity"
|
|
version.workspace = true
|
|
edition.workspace = true
|
|
license.workspace = true
|
|
repository.workspace = true
|
|
rust-version.workspace = true
|
|
homepage.workspace = true
|
|
description = "Capacity scan and refresh core for RustFS."
|
|
keywords = ["capacity", "storage", "rustfs", "scan", "metrics"]
|
|
categories = ["filesystem", "development-tools"]
|
|
|
|
[lib]
|
|
doctest = false
|
|
|
|
[[bench]]
|
|
name = "capacity_scan"
|
|
harness = false
|
|
|
|
[lints]
|
|
workspace = true
|
|
|
|
[dependencies]
|
|
rustfs-config = { workspace = true, features = ["constants"] }
|
|
rustfs-io-metrics = { workspace = true }
|
|
rustfs-utils = { workspace = true, features = ["os"] }
|
|
futures = { workspace = true }
|
|
tokio = { workspace = true, features = ["sync", "time"] }
|
|
tracing = { workspace = true }
|
|
uuid = { workspace = true }
|
|
walkdir = { workspace = true }
|
|
|
|
[dev-dependencies]
|
|
criterion = { workspace = true }
|
|
serial_test = { workspace = true }
|
|
temp-env = { workspace = true, features = ["async_closure"] }
|
|
tempfile = { workspace = true }
|
|
tokio = { workspace = true, features = ["test-util", "macros", "rt"] }
|